Re: Down to 5

2009-10-12 Thread Grant Ingersoll
Yep, working on it now. So, let's call it pencils down. I'll put up one either tonight or tomorrow morning. On Oct 12, 2009, at 5:14 PM, Yonik Seeley wrote: On Fri, Oct 9, 2009 at 11:21 AM, Grant Ingersoll wrote: Realistically speaking, I can do an RC on Monday afternoon. So, how abou

Re: Down to 5

2009-10-12 Thread Yonik Seeley
On Fri, Oct 9, 2009 at 11:21 AM, Grant Ingersoll wrote: > Realistically speaking, I can do an RC on Monday afternoon.  So, how about > we say "Pencils down" at 12 noon EDT on Monday and then I can create an RC > that afternoon. Zero issues... If you have the time today, I think everyone's ready f

Re: Down to 5

2009-10-12 Thread Anders Melchiorsen
A bit of a shame if the HTML stripper in 1.4 will be useless for most real situations. I have added a new version of the patch, with test cases for the stuff that I am fixing. I also think that the new code is a bit easier to follow (no longer reusing existing state variables), so hopefully it wil

Re: Down to 5

2009-10-09 Thread Yonik Seeley
Unfortunately we don't have good unit tests for this, so it's difficult for people to tell if we've avoided regressions while making progress. But since it's a bug fix... it is technically possible for it to be included after the code freeze deadline I think? -Yonik On Fri, Oct 9, 2009 at 5:20 P

Re: Down to 5

2009-10-09 Thread Anders Melchiorsen
Yonik Seeley writes: > One further issue... should we commit the changes to the HTMLStripReader? > https://issues.apache.org/jira/browse/SOLR-1394 As the reporter of that bug, I would obviously like to see a fix included in 1.4. It would be one thing to have the patch declared faulty, but havin

Re: Down to 5

2009-10-09 Thread Grant Ingersoll
Realistically speaking, I can do an RC on Monday afternoon. So, how about we say "Pencils down" at 12 noon EDT on Monday and then I can create an RC that afternoon. -Grant On Oct 9, 2009, at 10:13 AM, Shalin Shekhar Mangar wrote: On Fri, Oct 9, 2009 at 6:08 PM, Koji Sekiguchi wrote:

Re: Down to 5

2009-10-09 Thread Shalin Shekhar Mangar
On Fri, Oct 9, 2009 at 6:08 PM, Koji Sekiguchi wrote: > Hi Shalin, > > > What about FastVectorHighlighter? > > https://issues.apache.org/jira/browse/SOLR-1268 > > If we're targeting RC in this week, I'd like to push it to 1.5 > because there is no patches. But perhaps you think > 13 votes is cons

Re: Down to 5

2009-10-09 Thread Koji Sekiguchi
Hi Shalin, > What about FastVectorHighlighter? > https://issues.apache.org/jira/browse/SOLR-1268 If we're targeting RC in this week, I'd like to push it to 1.5 because there is no patches. But perhaps you think 13 votes is considerable? Koji

Re: Down to 5

2009-10-08 Thread Shalin Shekhar Mangar
On Fri, Oct 9, 2009 at 4:17 AM, Yonik Seeley wrote: > On Sun, Oct 4, 2009 at 6:13 PM, Grant Ingersoll > wrote: > > Coming along: > > > https://issues.apache.org/jira/secure/BrowseVersion.jspa?id=12310230&versionId=12313351&showOpenIssuesOnly=true > > > > If we can finish these up this week, I can

Re: Down to 5

2009-10-08 Thread Jason Rutherglen
I haven't had any time to verify this, we're not currently recording the HTML that failed which I'd use to reproduce with a test case. Though when I do, it should be fairly comprehensive, though I'm not sure I'd be able to fit it all in an actual unit test unless the HTML was in files which probabl

Re: Down to 5

2009-10-08 Thread Yonik Seeley
One further issue... should we commit the changes to the HTMLStripReader? https://issues.apache.org/jira/browse/SOLR-1394 -Yonik http://www.lucidimagination.com On Thu, Oct 8, 2009 at 6:47 PM, Yonik Seeley wrote: > On Sun, Oct 4, 2009 at 6:13 PM, Grant Ingersoll wrote: >> Coming along: >>  http

Re: Down to 5

2009-10-08 Thread Yonik Seeley
On Sun, Oct 4, 2009 at 6:13 PM, Grant Ingersoll wrote: > Coming along: >  https://issues.apache.org/jira/secure/BrowseVersion.jspa?id=12310230&versionId=12313351&showOpenIssuesOnly=true > > If we can finish these up this week, I can generate RCs next week. Down to 4! We're still planning on a co

Re: Down to 5

2009-10-05 Thread Grant Ingersoll
On Oct 4, 2009, at 10:51 PM, Chris Hostetter wrote: : Subject: Down to 5 I reopened SOLR-1448 because it seems perfectly reasonable to me .. looking for a reply. I commented on the issue. I'm also just waiting on someone else to test/review SOLR-1449 ... otherwise it should be push

Re: Down to 5

2009-10-05 Thread Grant Ingersoll
On Oct 5, 2009, at 12:23 AM, Yonik Seeley wrote: On Sun, Oct 4, 2009 at 10:53 PM, Israel Ekpo wrote: Smaller precisionStep values (specified in bits) will lead to more tokens indexed per value, slightly larger index size, and faster range queries It also states that for faster range que

Re: Down to 5

2009-10-04 Thread Yonik Seeley
On Sun, Oct 4, 2009 at 10:53 PM, Israel Ekpo wrote: > Smaller precisionStep values (specified in bits) will lead to more tokens > indexed per value, slightly larger index size, and faster range queries > > It also states that for faster range queries, consider the > tint/tfloat/tlong/tdouble types

Re: Down to 5

2009-10-04 Thread Israel Ekpo
On Sun, Oct 4, 2009 at 9:51 PM, Chris Hostetter wrote: > > : Subject: Down to 5 > > I reopened SOLR-1448 because it seems perfectly reasonable to me .. > looking for a reply. > > I'm also just waiting on someone else to test/review SOLR-1449 ... > otherwi

Re: Down to 5

2009-10-04 Thread Chris Hostetter
: Subject: Down to 5 I reopened SOLR-1448 because it seems perfectly reasonable to me .. looking for a reply. I'm also just waiting on someone else to test/review SOLR-1449 ... otherwise it should be pushed to 1.5. -Hoss

Re: Down to 5

2009-10-04 Thread Koji Sekiguchi
+1. Grant Ingersoll wrote: Coming along: https://issues.apache.org/jira/secure/BrowseVersion.jspa?id=12310230&versionId=12313351&showOpenIssuesOnly=true If we can finish these up this week, I can generate RCs next week. Thoughts? -Grant

Down to 5

2009-10-04 Thread Grant Ingersoll
Coming along: https://issues.apache.org/jira/secure/BrowseVersion.jspa?id=12310230&versionId=12313351&showOpenIssuesOnly=true If we can finish these up this week, I can generate RCs next week. Thoughts? -Grant