[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12790079#action_12790079
]
Noble Paul commented on SOLR-1621:
--
The patch looks fine . I plan to commit it soon
Allow
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12790128#action_12790128
]
Mark Miller commented on SOLR-1621:
---
bq. me too. But this looked like an exception. This
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12790145#action_12790145
]
Mark Miller commented on SOLR-1621:
---
bq. The patch looks fine . I plan to commit it soon
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12790185#action_12790185
]
Noble Paul commented on SOLR-1621:
--
I shall soon give a final patch w/ the removal of
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789926#action_12789926
]
Mark Miller commented on SOLR-1621:
---
bq. The setSolrConfigFilename() did not work for
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789988#action_12789988
]
Noble Paul commented on SOLR-1621:
--
bq.Personally, I'd prefer a form of deprecation first.
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789302#action_12789302
]
Mark Miller commented on SOLR-1621:
---
I'd like to take a quick look - will report back.
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789439#action_12789439
]
Mark Miller commented on SOLR-1621:
---
You've deprecated handleAliasAction, but you have
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789443#action_12789443
]
Mark Miller commented on SOLR-1621:
---
Also, its confusing the way the Alias test is
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789447#action_12789447
]
Mark Miller commented on SOLR-1621:
---
Lastly : there are a couple little unrelated changes
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789675#action_12789675
]
Noble Paul commented on SOLR-1621:
--
bq.You mark setSolrConfigFilename as deprecated, but it
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789689#action_12789689
]
Noble Paul commented on SOLR-1621:
--
I guess deprecating ALIAS can be committed first so
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789116#action_12789116
]
Noble Paul commented on SOLR-1621:
--
hi . If everyone is OK I would just cleanup the patch
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787968#action_12787968
]
Noble Paul commented on SOLR-1621:
--
also deprecated specifying solrconfig from web.xml. We
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787704#action_12787704
]
Hoss Man commented on SOLR-1621:
The nice thing about the *idea* of ALIAS is that you can
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787712#action_12787712
]
Yonik Seeley commented on SOLR-1621:
I'm good with yanking ALIAS for now.
But I think
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787908#action_12787908
]
Noble Paul commented on SOLR-1621:
--
bq.I'm good with yanking ALIAS for now.
I am happy to
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787031#action_12787031
]
Mark Miller commented on SOLR-1621:
---
bq. the index pages are fixed
how are they fixed?
I
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787303#action_12787303
]
Noble Paul commented on SOLR-1621:
--
bq.if they cause too much grief, we always have the
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12786643#action_12786643
]
Mark Miller commented on SOLR-1621:
---
Nice! Essentially the same as my little patch, but I
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1278#action_1278
]
Mark Miller commented on SOLR-1621:
---
We should try and hit SOLR-1626 with this too since
[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12786783#action_12786783
]
Noble Paul commented on SOLR-1621:
--
hi Mark could you update the patch to trunk?
Allow
22 matches
Mail list logo
