[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-13 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789911#action_12789911 ] Noble Paul commented on SOLR-1644: -- bq.While we should make it easy for custom components

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-13 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789917#action_12789917 ] Yonik Seeley commented on SOLR-1644: bq. This one change can keep the ResponseBuilder

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-13 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789919#action_12789919 ] Noble Paul commented on SOLR-1644: -- bq. if

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-13 Thread Uri Boness (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789920#action_12789920 ] Uri Boness commented on SOLR-1644: -- bq. if

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-13 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789925#action_12789925 ] Yonik Seeley commented on SOLR-1644: bq. definitely it looks verbose (ugly) . But the

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-13 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789986#action_12789986 ] Noble Paul commented on SOLR-1644: -- bq.But perhaps we should have gone with the same

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-12 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789745#action_12789745 ] Yonik Seeley commented on SOLR-1644: While we should make it easy for custom components

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-11 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789226#action_12789226 ] Noble Paul commented on SOLR-1644: -- Let us keep a Map in RB so that each component can

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-11 Thread Uri Boness (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789236#action_12789236 ] Uri Boness commented on SOLR-1644: -- Don't you have it already with the

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-11 Thread Uri Boness (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789259#action_12789259 ] Uri Boness commented on SOLR-1644: -- It should also be possible to share objects between

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-11 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789269#action_12789269 ] Noble Paul commented on SOLR-1644: -- bq. Provide a clean way to keep flags and helper

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-11 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789271#action_12789271 ] Noble Paul commented on SOLR-1644: -- bq.I guess this can be supported by publishing the key

[jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

2009-12-11 Thread Uri Boness (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789290#action_12789290 ] Uri Boness commented on SOLR-1644: -- bq. We should not keep it static. public final should