Re: CVS commit: src/lib/libcrypt

2011-12-01 Thread David Laight
On Tue, Nov 29, 2011 at 09:23:20PM +0100, Joerg Sonnenberger wrote: > On Tue, Nov 29, 2011 at 09:09:38PM +0100, Matthias Drochner wrote: > > Anyway, here is a first cut on an "explicit_bzero" function > > which doesn't get optimized away. I've put it to src/common > > because the same thing makes s

Re: CVS commit: src/sys/dev

2011-12-01 Thread David Laight
On Wed, Nov 30, 2011 at 01:13:10PM -0500, Christos Zoulas wrote: > On Nov 30, 12:13pm, bou...@antioche.eu.org (Manuel Bouyer) wrote: ... > Keeps the headers tidy, and it will make it easy in the future to delete > compatibility code. I would also move the compat code somewhere too, > and call a fun

Re: CVS commit: src/sys/dev

2011-12-01 Thread Manuel Bouyer
On Thu, Dec 01, 2011 at 05:50:14PM +, David Laight wrote: > I'd rather the .c file wasn't polluted with #ifdefs. > Probably better to #define fss_compat_ioctl(...) EINVAL somewhere. > > We ought to sort out a way of making the compat code loadable > - in which case this would need to be a real

Re: CVS commit: src/sys/dev

2011-12-01 Thread David Young
On Thu, Dec 01, 2011 at 07:42:49PM +0100, Manuel Bouyer wrote: > On Thu, Dec 01, 2011 at 05:50:14PM +, David Laight wrote: > > I'd rather the .c file wasn't polluted with #ifdefs. > > Probably better to #define fss_compat_ioctl(...) EINVAL somewhere. > > > > We ought to sort out a way of makin

Re: CVS commit: src/sys/dev

2011-12-01 Thread David Laight
On Thu, Dec 01, 2011 at 01:00:22PM -0600, David Young wrote: > > IIRC, our module loader cannot (yet) load a strong alias over a weak > alias and restore the weak alias when the module containing the strong > alias is unloaded. That would have been nice to have when bpf was > modularized. That w

Re: CVS commit: src/sys/dev

2011-12-01 Thread Christos Zoulas
On Dec 1, 5:50pm, da...@l8s.co.uk (David Laight) wrote: -- Subject: Re: CVS commit: src/sys/dev | I'd rather the .c file wasn't polluted with #ifdefs. | Probably better to #define fss_compat_ioctl(...) EINVAL somewhere. | | We ought to sort out a way of making the compat code loadable | - in whi

Re: CVS commit: src/sys/dev

2011-12-01 Thread David Holland
On Thu, Dec 01, 2011 at 05:50:14PM +, David Laight wrote: > I'd rather the .c file wasn't polluted with #ifdefs. > Probably better to #define fss_compat_ioctl(...) EINVAL somewhere. > > We ought to sort out a way of making the compat code loadable > - in which case this would need to be a