Re: CVS commit: src

2012-07-03 Thread YAMAMOTO Takashi
hi, > Module Name: src > Committed By: reinoud > Date: Sat Jun 30 15:03:58 UTC 2012 > > Modified Files: > src/distrib/sets/lists/modules: md.amd64 md.i386 > src/etc/etc.amd64: Makefile.inc > src/etc/etc.i386: Makefile.inc > src/sys/arch/usermode/conf: Makefile.use

Re: CVS commit: src/share/misc

2012-07-03 Thread Christos Zoulas
In article <20120703163503.4334298...@pluto.mumble.net>, Taylor R Campbell wrote: > Date: Sun, 1 Jul 2012 05:49:06 + > From: David Holland > > erm... sys/types.h is supposed to be first. > > and, as sys/param.h includes sys/types.h, normally one should not use > both. > >Well, foo.

Re: CVS commit: src/sys/fs/msdosfs

2012-07-03 Thread David Holland
On Wed, Jul 04, 2012 at 01:45:08AM +0900, Izumi Tsutsui wrote: > > getdisksize() is not complicated; it tries DIOCGPART and then > > DIOCGWEDGEINFO and that's about it. > > Yes, but it is not implementation issue but design issue. > > > I think it's wrong for either of those to be returning

Re: CVS commit: src/sys/fs/msdosfs

2012-07-03 Thread Izumi Tsutsui
dholland@ wrote: > On Tue, Jul 03, 2012 at 08:01:21PM +0900, Izumi Tsutsui wrote: > > > } Add a sanity check if secsize returned from getdisksize() isn't bogus. > > > } This prevent possible panic "panic: buf mem pool index 23" later in > > > } vfs_bio.c:buf_mempoolidx(). > > > } (I'm not sure

Re: CVS commit: src/share/misc

2012-07-03 Thread Taylor R Campbell
Date: Sun, 1 Jul 2012 05:49:06 + From: David Holland erm... sys/types.h is supposed to be first. and, as sys/param.h includes sys/types.h, normally one should not use both. Well, foo. I was just doing what christos suggested. I am generally very leery of relying on transiti

Re: CVS commit: src/sys/fs/msdosfs

2012-07-03 Thread David Holland
On Tue, Jul 03, 2012 at 08:01:21PM +0900, Izumi Tsutsui wrote: > > } Add a sanity check if secsize returned from getdisksize() isn't bogus. > > } This prevent possible panic "panic: buf mem pool index 23" later in > > } vfs_bio.c:buf_mempoolidx(). > > } (I'm not sure if it's okay for getdisksiz

Re: CVS commit: src

2012-07-03 Thread David Brownlee
On 3 July 2012 07:41, David Laight wrote: > On Mon, Jul 02, 2012 at 10:42:18PM +, David Brownlee wrote: >> Module Name: src >> Committed By: abs >> Date: Mon Jul 2 22:42:18 UTC 2012 >> >> Modified Files: >> src/distrib/vax/miniroot: Makefile.inc >> src/sys/arch/vax/includ

Re: CVS commit: src/sys/fs/msdosfs

2012-07-03 Thread Izumi Tsutsui
jnemeth@ wrote: > On Nov 20, 5:37am, "Izumi Tsutsui" wrote: > } > } Module Name:src > } Committed By: tsutsui > } Date: Sat Jun 30 11:01:42 UTC 2012 > } > } Modified Files: > } src/sys/fs/msdosfs: msdosfs_vfsops.c > } > } Log Message: > } Add a sanity check if s