On Sun, 8 Jul 2018, Christos Zoulas wrote:
On Jul 9, 5:56am, p...@whooppee.com (Paul Goyette) wrote:
-- Subject: Re: CVS commit: src/sys/sys
| > Yes, the double evaluation is a show-stopper, please revert.
|
| A quick inspection shows that no additional code is generated, at least
| when
On Jul 9, 5:56am, p...@whooppee.com (Paul Goyette) wrote:
-- Subject: Re: CVS commit: src/sys/sys
| > Yes, the double evaluation is a show-stopper, please revert.
|
| A quick inspection shows that no additional code is generated, at least
| when using gcc. For example:
Not if the value has
On Jul 8, 10:12pm, n...@gmx.com (Kamil Rytarowski) wrote:
-- Subject: Re: CVS commit: src/lib/libpuffs
| How about this patch:
|
| http://netbsd.org/~kamil/patch-00065-mman-MAP_ALIGNED-cast.txt
|
| With an optional additional () around the macro body.
Yes, that's better! since the flags is
On Sun, 8 Jul 2018, Christos Zoulas wrote:
Committed By: pgoyette
Date: Sun Jul 8 06:21:42 UTC 2018
Modified Files:
src/sys/sys: types.h
Log Message:
Use a different, type-insensitive idiom for CLR().
As discussed on IRC and proposed by dholland@, the existing idiom is
On 08.07.2018 18:48, Christos Zoulas wrote:
> Module Name: src
> Committed By: christos
> Date: Sun Jul 8 16:48:47 UTC 2018
>
> Modified Files:
> src/lib/libpuffs: callcontext.c
>
> Log Message:
> correct previous cast.
>
How about this patch:
On 08.07.2018 15:56, Christos Zoulas wrote:
> In article <20180708092413.gb8...@mail.duskware.de>,
> Martin Husemann wrote:
>> On Sun, Jul 08, 2018 at 10:49:53AM +0200, Jaromír Dole?ek wrote:
Module Name:src
Committed By: kamil
Date: Sat Jul 7 23:05:50 UTC 2018
In article <20180708092258.ga13...@britannica.bec.de>,
Joerg Sonnenberger wrote:
>On Sun, Jul 08, 2018 at 06:21:42AM +, Paul Goyette wrote:
>> Module Name: src
>> Committed By:pgoyette
>> Date:Sun Jul 8 06:21:42 UTC 2018
>>
>> Modified Files:
>> src/sys/sys:
On 08.07.2018 10:49, Jaromír Doleček wrote:
> Shouldn't this:
>
> memtop |= (uint16_t)mpbios_page[0x414] << 8;
>
> be actually << 16 to keep the same semantics?
>
No. This is a 2-byte (x86 word) variable. One byte has to be stored with
the 8 bits shift.
If it would be differently it would
In article <20180708092413.gb8...@mail.duskware.de>,
Martin Husemann wrote:
>On Sun, Jul 08, 2018 at 10:49:53AM +0200, Jaromír Dole?ek wrote:
>> > Module Name:src
>> > Committed By: kamil
>> > Date: Sat Jul 7 23:05:50 UTC 2018
>> >
>> > Modified Files:
>> >
On Sun, Jul 08, 2018 at 06:21:42AM +, Paul Goyette wrote:
> Module Name: src
> Committed By: pgoyette
> Date: Sun Jul 8 06:21:42 UTC 2018
>
> Modified Files:
> src/sys/sys: types.h
>
> Log Message:
> Use a different, type-insensitive idiom for CLR().
>
> As discussed on IRC
On Sun, Jul 08, 2018 at 10:49:53AM +0200, Jaromír Dole?ek wrote:
> > Module Name:src
> > Committed By: kamil
> > Date: Sat Jul 7 23:05:50 UTC 2018
> >
> > Modified Files:
> > src/sys/arch/x86/x86: mpbios.c
> >
> > Log Message:
> > Remove unaligned access to mpbios_page[]
>
Shouldn't this:
memtop |= (uint16_t)mpbios_page[0x414] << 8;
be actually << 16 to keep the same semantics?
Jaromir
Le dim. 8 juil. 2018 à 01:05, Kamil Rytarowski a écrit :
>
> Module Name:src
> Committed By: kamil
> Date: Sat Jul 7 23:05:50 UTC 2018
>
> Modified Files:
>
12 matches
Mail list logo
