Re: [Spacewalk-devel] [PATCH] AdvDataSourceTest: do not rely on test execution order

2013-09-06 Thread Grant Gainey
Hi Silvio, - Original Message - > Hi, > I noticed that AdvDataSourceTest relies on method ordering, and this can > sometimes break tests. In fact we noticed that method call ordering is > different in our OpenJDK 7 configuration between the commandline Ant > launcher and the Eclipse launch

Re: [Spacewalk-devel] [PATCH] ChannelTest: do not assume a proxy channel family exists

2013-09-06 Thread Grant Gainey
Hi Silvio, - Original Message - > Hi, > > Here is another simple patch to avoid having a proxy channel family set > up in order to run ChannelTest. Accepted as commit 4fe6deb81b5328af52a7180676a91ccab1dffee1 Thanks for your contribution! Grant > > Regards, > -- > Silvio Moioli > SUSE

Re: [Spacewalk-devel] [PATCH] UserFactoryTest: avoid failure if there are no users

2013-09-06 Thread Grant Gainey
Hey Silvio, - Original Message - > On 08/28/2013 07:42 PM, Grant Gainey wrote: > > Fixing the tests to be more explicit and less reliant on "typical setups" > > is, at least in my opinion, always a good thing. > > I am glad to hear that, as at the moment that's exactly what I am doing! >

Re: [Spacewalk-devel] [PATCH] Avoid a possible concurrency issue on RhnSet update

2013-09-06 Thread Tomas Lestach
Hello Silvio, > I investigated that: we get ConstraintViolationException with Oracle > and > WrappedSQLException in Postgres. That depends on > SqlExceptionTranslator.sqlException(), which can translate > Oracle-specific errors but not Postgres ones. This is not good. We actually shall fix the co

Re: [Spacewalk-devel] [PATCH] Consolidated rhnLib tests into a single place

2013-09-06 Thread Michael Mraka
Flavio Castelli wrote: % Moved the test defined inside of % backend/test/unit/spacewalk/test/common/rhnLib-tests.py % into backend/common/test/unit-test/test_rhnLib.py (which is where all % the rhnLib tests were already defined). Hello Flavio, I've commited your test update. Thanks. -- Michael

Re: [Spacewalk-devel] [PATCH] Avoid a possible concurrency issue on RhnSet update

2013-09-06 Thread Silvio Moioli
On 09/04/2013 12:08 PM, Tomas Lestach wrote: > * We'll accept also your first exception solution, just remove the index > name, please. See attached patch. > Actually I would expect WrappedSQLException gets thrown (not > ConstraintViolationException). > In case you would catch WrappedSQLExcepti