Re: [Spacewalk-devel] On quality of patches

2014-01-30 Thread Innes, Duncan
> -Original Message- > From: spacewalk-devel-boun...@redhat.com > [mailto:spacewalk-devel-boun...@redhat.com] On Behalf Of Stephen Herr > Sent: 30 January 2014 13:33 > To: spacewalk-devel@redhat.com > Subject: Re: [Spacewalk-devel] On quality of patches > > On 01/30/2014 07:32 AM, Duncan

Re: [Spacewalk-devel] On quality of patches

2014-01-30 Thread Paul Robert Marino
There is an other factor here that no one has mentioned. Recently I've found and reported a lot of bugs in the nightly repo. Where they came from is usually some one updates a portion of the code to fix a specific issue but since a portion of that code is called by multiple parts of the web interfa

Re: [Spacewalk-devel] On quality of patches

2014-01-30 Thread Stephen Herr
On 01/30/2014 07:32 AM, Duncan Mac-Vicar P. wrote: I fully agree with you that this is not acceptable. Now, I think your diagnostic is IMHO neither fair or correct. This does not have to do with the "community contributions" but with the setup of the project itself. We sometimes have sent patch

Re: [Spacewalk-devel] On quality of patches

2014-01-30 Thread Duncan Mac-Vicar P.
On 30/01/14 11:57, Matej Kollar wrote: > Hi all. > > We welcome community contributions and we want to maintain some level > of quality. Natural expectation is that every proposed patch is > tested for the functionality. I fully agree with you that this is not acceptable. Now, I think your diagn

[Spacewalk-devel] On quality of patches

2014-01-30 Thread Matej Kollar
Hi all. We welcome community contributions and we want to maintain some level of quality. Natural expectation is that every proposed patch is tested for the functionality. However, recently I came across quite nasty little thing in Spacewalk... Using SSM to schedule reboot one might end up very