Re: [SAtalk] More 2.11 false positives

2002-03-07 Thread Matthew Cline
On Thursday 07 March 2002 09:00 am, Matt Sergeant wrote: > > # 3) Some whitespace > > my $num_lines = scalar grep(/\s/, grep(/^[A-Z]{20,}$/, @lines)); "\s" needs to be added to the stripping regexp and the extraction regexp, or $num_lines will always be 0. That should be: Index: lib/Ma

Re: [SAtalk] More 2.11 false positives

2002-03-07 Thread Matt Sergeant
On Thu, 7 Mar 2002, Geoff Gibbs wrote: > > Meanwhile, try the following diff: > > > > Index: lib/Mail/SpamAssassin/EvalTests.pm > > === > > RCS file: > > /cvsroot/spamassassin/spamassassin/lib/Mail/SpamAssassin/EvalTests.pm,v > > ret

Re: [SAtalk] More 2.11 false positives

2002-03-07 Thread Geoff Gibbs
> Meanwhile, try the following diff: > > Index: lib/Mail/SpamAssassin/EvalTests.pm > === > RCS file: > /cvsroot/spamassassin/spamassassin/lib/Mail/SpamAssassin/EvalTests.pm,v > retrieving revision 1.109 > diff -r1.109 EvalTests.pm >

Re: [SAtalk] More 2.11 false positives

2002-03-07 Thread Matt Sergeant
On Thu, 7 Mar 2002, Geoff Gibbs wrote: > > I think that this is > > more closely related to the false positive, I spotted, from a base-64 > > attachment which also triggered the whole line of shouting. > > Thinking about this a bit more, shouldn't the whole line of shouting test > test for some s

Re: [SAtalk] More 2.11 false positives

2002-03-07 Thread Geoff Gibbs
> I think that this is > more closely related to the false positive, I spotted, from a base-64 > attachment which also triggered the whole line of shouting. Thinking about this a bit more, shouldn't the whole line of shouting test test for some spaces between the words? This would avoid blocks of

Re: [SAtalk] More 2.11 false positives

2002-03-07 Thread Geoff Gibbs
Matt Sergeant replied: > > I seem to be geting more false positives with 2.11 than 2.01. > > The latest was triggered by someone sending the output from > > a gene comparison program. The body contains gene sequences > > which get reported as whole lines of shouting > > There's not really a whol

Re: [SAtalk] More 2.11 false positives

2002-03-07 Thread Geoff Gibbs
Matt Sergeant replied: > > The latest rules seem to pick up an > > empty subject as 'Subject is all capitals'. > > I think this is fixed in CVS. The current SUBJ_ALL_CAPS rule is: > > header SUBJ_ALL_CAPS Subject =~ > /^[^a-z]*([A-Z][^a-z]*){3,}[^a-z]*$/ > describe SUBJ_ALL_CAPS

Re: [SAtalk] More 2.11 false positives

2002-03-07 Thread Matt Sergeant
On Wed, 6 Mar 2002, Geoff Gibbs wrote: > I seem to be geting more false positives with 2.11 than 2.01. > The latest was triggered by someone sending the output from > a gene comparison program. The body contains gene sequences > which get reported as whole lines of shouting There's not really a

[SAtalk] More 2.11 false positives

2002-03-06 Thread Geoff Gibbs
I seem to be geting more false positives with 2.11 than 2.01. The latest was triggered by someone sending the output from a gene comparison program. The body contains gene sequences which get reported as whole lines of shouting, plus this one had an empty subject. The latest rules seem to pick up