Re: [PATCH] spi/imx: remove autodetection

It is reasonable, looks fine to me. :-) Jason. Uwe Kleine-König wrote: > there are no machines in-tree that still use the driver > name as device name. So save a few bytes and remove it. > > Signed-off-by: Uwe Kleine-König > --- > drivers/spi/spi_imx.c | 30 ++ >

Re: [PATCH v5 1/1] OMAP2: Spi: Force CS to be in inactive state after off-mode transition

--- On Wed, 11/24/10, Kevin Hilman wrote: > I'm not SPI-aware enough to ack > this patch or > test it thoroughly. Heh, my excuse is usually "not enough time" or sometimes "no test setup" ... ;) In this case I can at least ack the fix in principle. CS active means an active trransfer, which

Re: [PATCH v5 1/1] OMAP2: Spi: Force CS to be in inactive state after off-mode transition

Gregory CLEMENT writes: > As request by Grant Likely, there is no more cover letter. Full changelog is > following. > I am still reluctant to add this changelog in the patch description, as it > adds no value to > the patch itself: when it was needed I try to updat comments or patch > descript

[SPAM] Fais tes valises, New York t'attend

-- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R

[PATCH v5 1/1] OMAP2: Spi: Force CS to be in inactive state after off-mode transition

As request by Grant Likely, there is no more cover letter. Full changelog is following. I am still reluctant to add this changelog in the patch description, as it adds no value to the patch itself: when it was needed I try to updat comments or patch description. I understand that Grant Likely wo

Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

On Wed, Nov 24, 2010 at 08:30:37AM -0700, Grant Likely wrote: > It would be easy enough to defer cpufreq initialization based on some > platform defined criteria. It's just an initcall. However, I don't Though it'd be much better to fix the thing where cpufreq doesn't have a device anyway. > k

Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

Mark Brown wrote: > On Wed, Nov 24, 2010 at 03:09:25PM +0100, Sebastian Andrzej Siewior wrote: > >> I've been pointed out to this commit but I don't understand _why_. >> The part I don't get is "so it can be used with cpufreq". Is it >> refered to a driver or the subsystem as it? > > We need the

Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

On Wed, Nov 24, 2010 at 7:16 AM, Mark Brown wrote: > On Wed, Nov 24, 2010 at 03:09:25PM +0100, Sebastian Andrzej Siewior wrote: > >> I've been pointed out to this commit but I don't understand _why_. >> The part I don't get is "so it can be used with cpufreq". Is it >> refered to a driver or the s

Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

On Wed, Nov 24, 2010 at 03:09:25PM +0100, Sebastian Andrzej Siewior wrote: > I've been pointed out to this commit but I don't understand _why_. > The part I don't get is "so it can be used with cpufreq". Is it > refered to a driver or the subsystem as it? We need the regulators for the CPU rails

Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

On Wed, Nov 24, 2010 at 10:09 PM, Sebastian Andrzej Siewior wrote: > Haojian Zhuang wrote: >> >> Hi Sebastian, > > Hi Hoajian, > >> Actually it's added for cpufreq usage. We can check the commit in below. >> >>    pxa2xx_spi: register earlier >> >>    Register pxa2xx_spi earlier so it can be used

Re: [PATCH 4/9] arm/pxa2xx: reorgazine SSP and SPI header files

Haojian Zhuang wrote: > On Wed, Nov 24, 2010 at 7:13 PM, Sebastian Andrzej Siewior > wrote: >> diff --git a/arch/arm/plat-pxa/include/plat/ssp.h >> b/include/linux/pxa2xx_ssp.h >> similarity index 98% >> rename from arch/arm/plat-pxa/include/plat/ssp.h >> rename to include/linux/pxa2xx_ssp.h >>

Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

Haojian Zhuang wrote: > Hi Sebastian, Hi Hoajian, > Actually it's added for cpufreq usage. We can check the commit in below. > > pxa2xx_spi: register earlier > > Register pxa2xx_spi earlier so it can be used with cpufreq > > So I think that this modifcation may cause others brokne. I'

Re: [PATCH 4/9] arm/pxa2xx: reorgazine SSP and SPI header files

On Wed, Nov 24, 2010 at 7:13 PM, Sebastian Andrzej Siewior wrote: > The PXA-SPI driver relies on some files / defines which are arm specific > and are within the ARM tree. The CE4100 SoC which is x86 has also the > SPI core. > This patch moves the ssp and spi files from arm/mach-pxa and plat-pxa t

Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

On Wed, Nov 24, 2010 at 7:13 PM, Sebastian Andrzej Siewior wrote: > It is a simple driver and there is no need to call its init function > at the level of a subsystem. > > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Dirk Brandewie > --- >  drivers/spi/pxa2xx_spi.c |    2 +- >  1 fi

[PATCH 8/9] spi/pxa2xx: Modify RX-Tresh instead of busy-loop for the remaining RX bytes.

After all TX bytes are sent, the driver spins while the SPI core is busy and then it spins for a "short" period of time until RX bytes are available. On Sodavile the busy flag disappears pretty quick and after that it takes approx ~130ms (sometimes less but not much) until there are bytes available

[PATCH 7/9] spi/pxa2xx: Add chipselect support for Sodaville

The SPI core on Sodaville supports chip selects. Its configuration moved into the SSSR register at bit 0 and 1. Thus Sodaville can be hooked up with up to 4 devices. This patch ensures that the bits which are otherwiese reserved are only touched on Sodaville and not on any other PXAs. Also it makes

[PATCH 9/9] spi/pxa2xx: pass of_node to spi device and set a parent device

the of_node will auto-publish devices which are added to the device tree. Signed-off-by: Sebastian Andrzej Siewior --- drivers/spi/pxa2xx_spi.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c index 5c8c6e3..6d3cb79 1

[PATCH 5/9] spi/pxa2xx: Add CE4100 support

Sodaville's SPI controller is very much the same as in PXA25x. The difference: - The RX/TX FIFO is only 4 words deep instead of 16 - No DMA support - The SPI controller offers a CS functionality Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Dirk Brandewie --- arch/x86/include/asm/pxa2

[PATCH 4/9] arm/pxa2xx: reorgazine SSP and SPI header files

The PXA-SPI driver relies on some files / defines which are arm specific and are within the ARM tree. The CE4100 SoC which is x86 has also the SPI core. This patch moves the ssp and spi files from arm/mach-pxa and plat-pxa to include/linux where the CE4100 can access them. This move got verified b

[PATCH 6/9] spi/pxa2xx: Consider CE4100's FIFO depth

For PXA the default threshold is FIFO_DEPTH / 2. Adjust this value for CE4100. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Dirk Brandewie --- arch/arm/include/asm/pxa2xx_ssp.h | 15 +++ arch/x86/include/asm/pxa2xx_ssp.h | 15 +++ drivers/spi/pxa2xx_spi.c

[PATCH 3/9] spi/pxa2xx: Use define for SSSR_TFL_MASK instead of plain numbers

Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Dirk Brandewie --- arch/arm/plat-pxa/include/plat/ssp.h |3 ++- drivers/spi/pxa2xx_spi.c |8 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/plat-pxa/include/plat/ssp.h b/arch/arm/plat-p

[PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

It is a simple driver and there is no need to call its init function at the level of a subsystem. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Dirk Brandewie --- drivers/spi/pxa2xx_spi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/pxa2xx_spi.

[PATCH 2/9] spi/pxa2xx: add support for shared IRQ handler

This is required in case the interrupt line is shared with other devices. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Dirk Brandewie --- drivers/spi/pxa2xx_spi.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/drivers/spi/pxa2xx_spi.c b/driver

SPI support for Sodaville

The SPI core inside Sodaville is very much the same as in PXA25x. I Cc the ARM folks because patch 4 reorganizes some files so that they can be accessed from x86 so you see the whole picture. Yes, Sodaville is a x86 SoC :) The SPI device is behind a PCI bus. The PCI probe code simply creates a plat

[PATCH] spi/imx: remove autodetection

there are no machines in-tree that still use the driver name as device name. So save a few bytes and remove it. Signed-off-by: Uwe Kleine-König --- drivers/spi/spi_imx.c | 30 ++ 1 files changed, 2 insertions(+), 28 deletions(-) diff --git a/drivers/spi/spi_imx.c