On Wed, Aug 01, 2012 at 08:45:19AM +0200, Marek Vasut wrote:
> Dear Guenter Roeck,
>
> > On Wed, Aug 01, 2012 at 08:10:37AM +0200, Marek Vasut wrote:
> > > Dear Shawn Guo,
> > >
> > > > On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
> > > > > On Wed, Aug 01, 2012 at 01:58:56PM +08
Dear Guenter Roeck,
> On Wed, Aug 01, 2012 at 08:10:37AM +0200, Marek Vasut wrote:
> > Dear Shawn Guo,
> >
> > > On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
> > > > On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
> > > > > On Tue, Jul 31, 2012 at 10:29:47PM -0700, Gu
Dear Guenter Roeck,
> On Wed, Aug 01, 2012 at 11:16:15AM +0530, Shubhrajyoti Datta wrote:
> > On Wed, Aug 1, 2012 at 10:59 AM, Guenter Roeck wrote:
> > > On Wed, Aug 01, 2012 at 07:00:54AM +0200, Marek Vasut wrote:
> > >> Dear Shawn Guo,
> > >>
> > >> > On Tue, Jul 31, 2012 at 08:35:59PM -0700,
Dear Guenter Roeck,
> On Wed, Aug 01, 2012 at 02:28:40PM +0800, Shawn Guo wrote:
> > On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
> > > On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
> > > > On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
> > > > > Anyo
On Wed, Aug 01, 2012 at 08:10:37AM +0200, Marek Vasut wrote:
> Dear Shawn Guo,
>
> > On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
> > > On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
> > > > On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
> > > > > Anyo
On Wed, Aug 01, 2012 at 11:16:15AM +0530, Shubhrajyoti Datta wrote:
> On Wed, Aug 1, 2012 at 10:59 AM, Guenter Roeck wrote:
> > On Wed, Aug 01, 2012 at 07:00:54AM +0200, Marek Vasut wrote:
> >> Dear Shawn Guo,
> >>
> >> > On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote:
> >> > > I th
On Wed, Aug 01, 2012 at 02:28:40PM +0800, Shawn Guo wrote:
> On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
> > On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
> > > On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
> > > > Anyone up for writing some patches
Dear Marek Vasut,
[...]
> -out_host_free:
> +out_free_dma:
> + dma_release_channel(ssp->dmach);
> clk_disable_unprepare(ssp->clk);
> +out_host_free:
> spi_master_put(host);
> kfree(host);
> +
Please remove this newline.
> return ret;
> }
Missing dma_release_channel
Dear Shawn Guo,
> On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
> > On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
> > > On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
> > > > Anyone up for writing some patches ? If not, I'll do it.
> > >
> > > Go ahea
On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
> On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
> > On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
> > > Anyone up for writing some patches ? If not, I'll do it.
> > >
> > Go ahead.
> >
> Ok, will do. It i
On Wed, Aug 1, 2012 at 10:59 AM, Guenter Roeck wrote:
> On Wed, Aug 01, 2012 at 07:00:54AM +0200, Marek Vasut wrote:
>> Dear Shawn Guo,
>>
>> > On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote:
>> > > I think the call to spi_master_put() triggers the call to
>> > > spi_master_release(
On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
> On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
> > Anyone up for writing some patches ? If not, I'll do it.
> >
> Go ahead.
>
Ok, will do. It isn't that simple, actually, since at least some of the drivers
also call spi_
On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
> Anyone up for writing some patches ? If not, I'll do it.
>
Go ahead.
Regards,
Shawn
--
Live Security Virtual Conference
Exclusive live event will cover al
On Wed, Aug 01, 2012 at 07:00:54AM +0200, Marek Vasut wrote:
> Dear Shawn Guo,
>
> > On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote:
> > > I think the call to spi_master_put() triggers the call to
> > > spi_master_release(). If so, kfree() would not be needed at all, and the
> > > d
Dear Shawn Guo,
> On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote:
> > I think the call to spi_master_put() triggers the call to
> > spi_master_release(). If so, kfree() would not be needed at all, and the
> > documentation is wrong.
>
> Also those drivers calling kfree in probe.
L
Dear Shawn Guo,
> On Wed, Aug 01, 2012 at 04:31:04AM +0200, Marek Vasut wrote:
> > > Couple of reasons for asking: No other SPI master driver calls it in
> > > the remove function (unless I missed it), most drivers don't call it
> > > in the probe function error path, and if I call it in the remov
On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote:
> I think the call to spi_master_put() triggers the call to
> spi_master_release().
> If so, kfree() would not be needed at all, and the documentation is wrong.
>
Also those drivers calling kfree in probe.
Regards,
Shawn
--
On Wed, Aug 01, 2012 at 11:53:36AM +0800, Shawn Guo wrote:
> On Wed, Aug 01, 2012 at 04:31:04AM +0200, Marek Vasut wrote:
> > > Couple of reasons for asking: No other SPI master driver calls it in the
> > > remove function (unless I missed it), most drivers don't call it in the
> > > probe function
Hi Marek,
On Wed, Aug 01, 2012 at 04:31:04AM +0200, Marek Vasut wrote:
> Dear Guenter Roeck,
>
> [...]
>
> > > +static int __devexit mxs_spi_remove(struct platform_device *pdev)
> > > +{
> > > + struct spi_master *host;
> > > + struct mxs_spi *spi;
> > > + struct mxs_ssp *ssp;
> > > +
> > > + ho
On Wed, Aug 01, 2012 at 04:31:04AM +0200, Marek Vasut wrote:
> > Couple of reasons for asking: No other SPI master driver calls it in the
> > remove function (unless I missed it), most drivers don't call it in the
> > probe function error path, and if I call it in the remove function in a
> > SPI m
On Tue, Jul 31, 2012 at 01:53:00PM -0700, Guenter Roeck wrote:
> > + spi_master_put(host);
> > + kfree(host);
> > +
>
> Is the kfree() here and in the probe function really necessary ?
>
The following is how the kerneldoc of spi_alloc_master says.
* The caller is responsible for assigning
Dear Guenter Roeck,
[...]
> > +static int __devexit mxs_spi_remove(struct platform_device *pdev)
> > +{
> > + struct spi_master *host;
> > + struct mxs_spi *spi;
> > + struct mxs_ssp *ssp;
> > +
> > + host = platform_get_drvdata(pdev);
> > + spi = spi_master_get_devdata(host);
> > + s
On Fri, Jul 06, 2012 at 06:17:25AM -, Marek Vasut wrote:
> This is slightly reworked version of the SPI driver.
> Support for DT has been added and it's been converted
> to queued API.
>
> Based on previous attempt by:
> Fabio Estevam
>
> Signed-off-by: Fabio Estevam
> Signed-off-by: Marek
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML
Lien miroir :
http://m10-fr.com/mc10_m/YT04JmI9MTcyNzcmYz0xOTYxNjQxJmQ9MjAxMi0wNy0zMSAxNzoxMDowMSZlPTEmaD0xNzI3NiZmPTE3Mjc3Jmc9MTcyNzc=
Lien de désinscription :
http://m10-fr.com/mc10_unsub/YT04JmI9MTcyNzcmYz0xOTYxNjQxJm
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML
Lien miroir :
http://m10-fr.com/mc10_m/YT0xMyZiPTE3MzMxJmM9NDgzNjEyJmQ9MjAxMi0wNy0zMSAxMTo1MDowMSZlPTEmaD0xNzMzMCZmPTE3MzMxJmc9MTczMzE=
Lien de désinscription :
http://m10-fr.com/mc10_unsub/YT0xMyZiPTE3MzMxJmM9NDgzNjEyJm
25 matches
Mail list logo
