On Thu, Feb 07, 2013 at 02:12:11PM +0100, Andreas Larsson wrote:
> This relies upon of_spi_register_master to find out which gpios to use.
>
> Signed-off-by: Andreas Larsson
> ---
> drivers/spi/spi-fsl-lib.h |1 +
> drivers/spi/spi-fsl-spi.c | 53 +++
ary normally running on SPARC.
The patches look clean and neat, I don't see anything obviously wrong with
them... so,
Acked-by: Anton Vorontsov
Thanks!
Anton
--
Free Next-Gen Firewall Hardware Offer
Buy your Sophos
spi_mpc8xxx_cs *cs = spi->controller_state;
> - __be32 __iomem *mode = &mspi->base->mode;
> + struct fsl_spi_reg *reg_base = (struct fsl_spi_reg *)mspi->reg_base;
No need for these type casts (the same is for the whole patch).
--
Anton Vorontsov
email: cbouatmai
atic const struct of_device_id of_fsl_espi_match[] = {
> + { .compatible = "fsl,mpc8536-espi" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, of_fsl_espi_match);
> +
> +static struct of_platform_driver fsl_espi_driver = {
> + .driver = {
> +
ers don't work, then
> > it is the SPI master driver that is buggy.
>
> By the way, does this fix your problem?
>
> https://patchwork.kernel.org/patch/184752/
It shouldn't. AFAIK, eSPI is PIO-only controller, and the overrun
fix is for the DMA mode.
Thanks,
p.s.
o muram data regions 0x0..0x2000 and
0x9000..0x9100. Note that we actually don't want "data" regions,
and the only reason why that worked is that sysdev/cpm_common.c
maps muram(0)..muram(max).
Thanks,
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
, but even the simple implementation as in mmc_spi
case proves that it is possible to separate OF/ACPI/DMI/whatever
handling from the generic code.
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
-
On Mon, May 17, 2010 at 03:17:10PM +0200, Joakim Tjernlund wrote:
> This fixes a typo were map_tx_dma is used instead of
> map_rx_dma, casing the driver to unmap rx_dma when it
> shouldn't.
>
> Signed-off-by: Joakim Tjernlund
Acked-by: Anton Vorontsov
Thanks!
bits so disable these for now.
>
> Also move the different quirks into its own function to keep
> mpc8xxx_spi_setup_transfer() sane.
>
> Signed-off-by: Joakim Tjernlund
> ---
Looks OK, thanks!
Acked-by: Anton Vorontsov
--
Anton Vorontsov
email: cbouatmai.
On Fri, May 14, 2010 at 11:14:27AM +0200, Joakim Tjernlund wrote:
>
> Signed-off-by: Joakim Tjernlund
Acked-by: Anton Vorontsov
Thanks!
> ---
> Documentation/spi/spidev_test.c |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/Documentatio
On Thu, May 13, 2010 at 05:55:22PM +0200, Joakim Tjernlund wrote:
> Anton Vorontsov wrote on 2010/05/13 11:55:45:
> >
> > On Thu, May 13, 2010 at 11:36:15AM +0200, Joakim Tjernlund wrote:
> > [...]
> > > The new QE mode is so broken :(
> > > Notice how the
ther.
I guess by copying the whole buffer, shifting bytes back and
forth, remapping it, doing transfer, and copying data back.
I think that'll work, but no idea how efficient that will be.
Also, I'd not do that for CPM hardware, I tend to believe
that it's not affected.
--
On Wed, May 12, 2010 at 06:28:51PM +0200, Joakim Tjernlund wrote:
> Anton Vorontsov wrote on 2010/05/12 18:22:31:
> >
> > On Wed, May 12, 2010 at 05:50:50PM +0200, Joakim Tjernlund wrote:
> > > tx_dma/rx_dma are already set to a dummy buffer when no
> > > tx/rx bu
g tx_dma/rx_dma alone.
>
> Do not INIT_TX_RX while controller is enabled, this is bad according
> to the MPC8321 manual.
>
> Signed-off-by: Joakim Tjernlund
Acked-by: Anton Vorontsov
Thanks!
> ---
> drivers/spi/spi_mpc8xxx.c |7 +++
> 1 files changed, 3 in
rant Likely
> Cc: Kumar Gala
> Cc: Anton Vorontsov
> Cc: Andrew Morton
> Cc: spi-devel-general@lists.sourceforge.net
> ---
Acked-by: Anton Vorontsov
Thanks!
--
This SF.Net email is sponsored by the Ver
s is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
> changed the return value of platform_get_irq from 0 to -ENXIO on error.
>
> Signed-off-by: Uwe Kleine-König
> Cc: David Vrabel
> Cc: Greg Kroah-Hartman
> Cc: David Brownell
> Cc: Grant Likely
> Cc: Kumar
ap HWIRQ0 to something that is not VIRQ0.
IRQ0 is invalid for everything that is outside of arch/*.
http://lkml.org/lkml/2005/11/22/159
http://lkml.org/lkml/2005/11/22/213
http://lkml.org/lkml/2005/11/22/227
--
Anton Vorontsov
email: cbouatmai...@gmail.
On Thu, Nov 26, 2009 at 11:50:05AM -0700, Grant Likely wrote:
> On Thu, Nov 26, 2009 at 11:41 AM, Anton Vorontsov
> wrote:
> > On Thu, Nov 26, 2009 at 11:16:34AM -0700, Grant Likely wrote:
> > [...]
> >> The spi-cs-high property is defined in
> >> Documentat
s for non-broken hw/fw.
So I think it should be applied.
Thanks,
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
can't extract that information from the compatible string.
To workaround that we can use 'spi-cs-high', but that's ugly
workaround.
SPI modes (0,1,2,3) is another matter, some devices can work in
several modes, so 'spi-cpol' and 'spi-cpha' are actually usef
efinition of those flags isn't also exposed.
Yep. Though, IIRC Joakim asked to keep the legacy bindings for some
time (until we implement SPI chip-select framework?)... so for now
we'll have to leave we the exposed flags.
Thanks again,
--
Anton
taneously.
>
> Signed-off-by: Wolfram Sang
> Cc: Juergen Beisert
> Cc: David Brownell
> Cc: Jean Delvare
> Cc: Anton Vorontsov
> Cc: Andrew Morton
> ---
Wolfram, thanks for your work on this.
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 2ad01
00_add_driver(&max7300_driver);
> + if (ret)
> + return ret;
> + ret = max7301_add_driver(&max7301_driver);
Nowadays you can use device table matching, as an example see
commit 8cec03eee4a771f949c70cff07775c9bb21d4642 ("hwmon: lm70:
conver
C) 2006 Polycom, Inc.
*
+ * CPM SPI and QE buffer descriptors mode support:
+ * Copyright (c) 2009 MontaVista Software, Inc.
+ * Author: Anton Vorontsov
+ *
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as p
Soon there will be more flags introduced in subsequent patches, so
let's turn qe_mode into flags.
Also introduce mpc8xxx_spi_strmode() and print current SPI mode.
Signed-off-by: Anton Vorontsov
Acked-by: David Brownell
---
drivers/spi/spi_mpc8xxx.c |
The bits are generic to CPM devices, so let's move them to the
common header file, so drivers won't need to privately reintroduce
another bunch of the same bits (as we can't include cpm2.h header
together with cpm1.h).
Signed-off-by: Anton Vorontsov
---
arch/powerpc/include/as
We'll add more steps soon, so get rid of the duplication.
Signed-off-by: Anton Vorontsov
Acked-by: David Brownell
---
drivers/spi/spi_mpc8xxx.c | 56 +++-
1 files changed, 24 insertions(+), 32 deletions(-)
diff --git a/drivers/spi/spi_mpc8xx
This patch fixes the following warning:
CC drivers/spi/spi_mpc8xxx.o
spi_mpc8xxx.c: In function 'of_mpc8xxx_spi_probe':
spi_mpc8xxx.c:681: warning: 'ret' may be used uninitialized in this function
Signed-off-by: Anton Vorontsov
Acked-by: David Brownell
---
drive
When cpm2.h included into spi_mpc8xxx driver, the SPI defines
in the header conflict with defines in the driver.
We don't need them in the header file, so remove them. Plus
remove "struct spi", we'll use a better version in the driver.
Signed-off-by: Anton Vorontsov
---
where we'll place common USB structs that
are used by QE/CPM UDC and QE Host drivers (FHCI).
And as for the structs in qe.h and cpm2.h, just prefix them with qe_
and cpm_.
Signed-off-by: Anton Vorontsov
---
arch/powerpc/include/asm/cpm.h| 22 ++
arch/powerpc/i
This is needed to avoid ugly #ifdefs in drivers. Also update fsl_qe_udc
driver so that now it doesn't define its own versions that cause build
breakage when the generic stubs are used.
Signed-off-by: Anton Vorontsov
Acked-by: Greg Kroah-Hartman
---
arch/powerpc/include/asm/cpm.h |
Hello Kumar,
There are Acks from Greg KH and David Brownell to pass the whole
patchset via PowerPC tree. Can you please apply it?
Thanks,
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
On Fri, Aug 28, 2009 at 12:45:34AM -0500, Kumar Gala wrote:
>
> On Aug 18, 2009, at 5:04 PM, Anton Vorontsov wrote:
>
> >When cpm2.h included into spi_mpc8xxx driver, the SPI defines
> >in the header conflict with defines in the driver.
> >
> >We don't n
On Thu, Aug 27, 2009 at 09:41:59PM -0700, David Brownell wrote:
> On Tuesday 18 August 2009, Anton Vorontsov wrote:
>
> > - Fix build issues in fsl_qe_udc;
> > - Some minor cosmetic changes in "Add support for QE DMA mode and
> > CPM1/CPM2 chips" patch.
>
On Tue, Aug 18, 2009 at 03:27:47PM -0700, Greg KH wrote:
> On Wed, Aug 19, 2009 at 02:04:18AM +0400, Anton Vorontsov wrote:
> > This is needed to avoid ugly #ifdefs in drivers. Also update fsl_qe_udc
> > driver so that now it doesn't define its own versions that cause build
&
We'll add more steps soon, so get rid of the duplication.
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc8xxx.c | 56 +++-
1 files changed, 24 insertions(+), 32 deletions(-)
diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8
+ * CPM SPI and QE buffer descriptors mode support:
+ * Copyright (c) 2009 MontaVista Software, Inc.
+ * Author: Anton Vorontsov
+ *
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
The bits are generic to CPM devices, so let's move them to the
common header file, so drivers won't need to privately reintroduce
another bunch of the same bits (as we can't include cpm2.h header
together with cpm1.h).
Signed-off-by: Anton Vorontsov
---
arch/powerpc/include/as
Soon there will be more flags introduced in subsequent patches, so
let's turn qe_mode into flags.
Also introduce mpc8xxx_spi_strmode() and print current SPI mode.
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc8xxx.c | 30 +++---
include/linux/fsl_devi
When cpm2.h included into spi_mpc8xxx driver, the SPI defines
in the header conflict with defines in the driver.
We don't need them in the header file, so remove them. Plus
remove "struct spi", we'll use a better version in the driver.
Signed-off-by: Anton Vorontsov
---
This is needed to avoid ugly #ifdefs in drivers. Also update fsl_qe_udc
driver so that now it doesn't define its own versions that cause build
breakage when the generic stubs are used.
Signed-off-by: Anton Vorontsov
---
arch/powerpc/include/asm/cpm.h |
This patch fixes the following warning:
CC drivers/spi/spi_mpc8xxx.o
spi_mpc8xxx.c: In function 'of_mpc8xxx_spi_probe':
spi_mpc8xxx.c:681: warning: 'ret' may be used uninitialized in this function
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc8xxx.c |
where we'll place common USB structs that
are used by QE/CPM UDC and QE Host drivers (FHCI).
And as for the structs in qe.h and cpm2.h, just prefix them with qe_
and cpm_.
Signed-off-by: Anton Vorontsov
---
arch/powerpc/include/asm/cpm.h| 22 ++
arch/powerpc/i
bs for
non-QE/CPM builds", so we could merge that patch via powerpc tree?
Thanks!
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
--
Let Crystal Reports handle the reporting - Free Cryst
On Sat, Aug 15, 2009 at 02:25:49AM +0400, Anton Vorontsov wrote:
[]
> +#ifdef CONFIG_CPM
> int cpm_command(u32 command, u8 opcode);
> +#else
> +static inline int cpm_command(u32 command, u8 opcode)
> +{
> + return -ENOSYS;
> +}
> +#endif /* CONFIG_CPM */
It
The bits are generic to CPM devices, so let's move them to the
common header file, so drivers won't need to privately reintroduce
another bunch of the same bits (as we can't include cpm2.h header
together with cpm1.h).
Signed-off-by: Anton Vorontsov
---
arch/powerpc/include/as
+ * CPM SPI and QE buffer descriptors mode support:
+ * Copyright (c) 2009 MontaVista Software, Inc.
+ * Author: Anton Vorontsov
+ *
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
This is needed to avoid ugly #ifdefs in drivers.
QE/CPM UDC and MPC8xxx SPI drivers will benefit from this change.
Signed-off-by: Anton Vorontsov
---
arch/powerpc/include/asm/cpm.h | 44
arch/powerpc/include/asm/qe.h | 11 +-
2 files
Soon there will be more flags introduced in subsequent patches, so
let's turn qe_mode into flags.
Also introduce mpc8xxx_spi_strmode() and print current SPI mode.
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc8xxx.c | 30 +++---
include/linux/fsl_devi
When cpm2.h included into spi_mpc8xxx driver, the SPI defines
in the header conflict with defines in the driver.
We don't need them in the header file, so remove them. Plus
remove "struct spi", we'll use a better version in the driver.
Signed-off-by: Anton Vorontsov
---
27;ll place common USB structs that are used
by QE/CPM UDC and QE Host drivers (FHCI).
And as for the structs in qe.h and cpm2.h, just prefix them with qe_
and cpm_.
Signed-off-by: Anton Vorontsov
---
arch/powerpc/include/asm/cpm.h| 22 ++
arch/powerpc/include/as
We'll add more steps soon, so get rid of the duplication.
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc8xxx.c | 56 +++-
1 files changed, 24 insertions(+), 32 deletions(-)
diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8
This patch fixes the following warning:
CC drivers/spi/spi_mpc8xxx.o
spi_mpc8xxx.c: In function 'of_mpc8xxx_spi_probe':
spi_mpc8xxx.c:681: warning: 'ret' may be used uninitialized in this function
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc8xxx.c |
Hi all,
Here are some patches that add DMA support for spi_mpc8xxx driver,
which means that we now support QE BD mode and SPI on CPM1 and CPM2
chips.
QE BD mode and CPM2 SPI support were tested on real hardware, CPM1
was only compile tested (though I belive it will work :-).
Thanks,
--
Anton
t;can't set output direction for"
> + "gpio #%d: %d\n",
> + i, ret);
There is no space between 'for' and 'gpio' words.
(also the whole dev_err() may fit into two line
On Fri, Jun 19, 2009 at 01:45:46PM +0200, Leon Woestenberg wrote:
> Hello,
>
> On Thu, Jun 18, 2009 at 4:04 PM, Kumar Gala wrote:
> > On Jun 18, 2009, at 8:09 AM, Anton Vorontsov wrote:
> >> On Thu, Jun 18, 2009 at 08:19:44AM +0200, Rini van Zetten wrote:
> &g
w = pinfo->alow_flags[cs];
> + gpio_set_value(gpio, on ^ alow);
Please put an empty line after variable declaration.
Thanks!
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
On Mon, May 04, 2009 at 01:55:04PM -0700, Andrew Morton wrote:
> On Fri, 1 May 2009 03:47:39 +0400
> Anton Vorontsov wrote:
>
> > Here are few patches that are needed to support spi-mmc slot on
> > MPC8610HPCD PowerPC boards:
> >
> > [1/9] spi_mpc83xx: Handles
On Mon, May 04, 2009 at 01:53:27PM -0700, Andrew Morton wrote:
> On Fri, 1 May 2009 03:48:33 +0400
> Anton Vorontsov wrote:
>
> > Since we renamed the file, we might want to rename the file
> > internals too.
> >
> > Though we don't bother with changing
Since we renamed the file, we might want to rename the file
internals too.
Though we don't bother with changing platform driver name and
platform module alias. The stuff is legacy and hopefully we'll
remove it soon.
Suggested-by: Kumar Gala
Signed-off-by: Anton Vorontsov
---
d
The driver handles MPC83xx, MPC85xx and MPC86xx SPI controllers,
so rename the file for clarity.
Suggested-by: Kumar Gala
Signed-off-by: Anton Vorontsov
---
drivers/spi/Makefile |2 +-
drivers/spi/spi_mpc83xx.c | 958 -
drivers/spi
nsfer(spi, t);
WARNING: line over 80 characters
#1392: FILE: drivers/spi/spi_mpc8xxx.c:402:
+ mpc83xx_spi_chipselect(spi,
BITBANG_CS_INACTIVE);
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc83xx.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/sp
This patch adds spi and mmc-spi-slot nodes, plus a gpio-controller
for PIXIS' sdcsr bank that is used for managing SPI chip-select and
for reading card's states.
Signed-off-by: Anton Vorontsov
---
arch/powerpc/boot/dts/mpc8610_hpcd.dts | 32
ar
ely not experimental anymore.
Signed-off-by: Anton Vorontsov
---
drivers/spi/Kconfig | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 83a185d..3c1845c 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfi
This is needed for some underlaying GPIO controllers that may be
a bit slow, or if chip-select signal need some time to stabilize.
For what it's worth, we already have the similar delay for
chip-select de-assertion case.
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc83xx.c |
.
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc83xx.c | 115 +++-
1 files changed, 60 insertions(+), 55 deletions(-)
diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
index 40f7448..50112a5 100644
--- a/drivers/spi/spi_mpc83xx.c
y.
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc83xx.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
index f4573a9..08b49d2 100644
--- a/drivers/spi/spi_mpc83xx.c
+++ b/drivers/spi/spi_mpc83xx.c
@@ -
This patch removes #if 0'ed code, and spi_mpc83xx->busy variable that
is used by that dead snippet only.
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_mpc83xx.c | 16
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/drivers/spi/spi_mpc83xx.c b/dri
ssues
[6/9] spi_mpc83xx: Split mpc83xx_spi_work() into two routines
[7/9] spi_mpc83xx: Remove dead code
[8/9] spi_mpc83xx: Rename spi_83xx.c to spi_8xxx.c
[9/9] spi_mpc8xxx: s/83xx/8xxx/g
Thanks,
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freeno
mpc52xx_psc_spi driver is the last user of the legacy activate_cs
and deactivate_cs callbacks, so convert the driver to the cs_control
hook and remove the legacy callbacks from fsl_spi_platform_data
struct.
Signed-off-by: Anton Vorontsov
---
drivers/spi/mpc52xx_psc_spi.c | 22
Hi Peter,
Sorry for the late response (and don't hesitate to ping me if I
don't answer, some things get lost in my inbox traffic, sorry).
On Wed, Apr 08, 2009 at 11:18:43AM +0200, Peter Korsgaard wrote:
> >>>>> "Anton" == Anton Vorontsov writes:
>
x27;t duplicate platform data callbacks in mpc83xx_spi struct.
Signed-off-by: Anton Vorontsov
---
arch/powerpc/platforms/83xx/mpc832x_rdb.c | 16
arch/powerpc/sysdev/fsl_soc.c | 14 ++
arch/powerpc/sysdev/fsl_soc.h |5 +++--
drivers/sp
different address
spaces)
spi_mpc83xx.c:296:25:expected unsigned int [noderef] [usertype] *reg
spi_mpc83xx.c:296:25:got void *tmp_ptr
spi_mpc83xx.c:486:13: warning: symbol 'mpc83xx_spi_irq' was not declared.
Should it be static?
Signed-off-by: Anton Vorontsov
---
drivers/spi/spi_
The advantages of this:
- Don't encourage legacy support;
- Less external symbols, less code to compile-in for !MPC832x_RDB
platforms.
Signed-off-by: Anton Vorontsov
---
arch/powerpc/platforms/83xx/mpc832x_rdb.c | 107 +
arch/powerpc/sysdev/fsl_
This patch implements full support for OF SPI bindings. Now the driver
can manage its own chip selects without any help from the board files
and/or fsl_soc constructors.
The "legacy" code is well isolated and could be removed as time goes by.
Signed-off-by: Anton Vorontsov
---
d
- Add gpio-controller node to manage QE GPIO Bank D;
- Add mmc-spi node;
- Modify board file so that it won't use legacy SPI support with the new
device trees.
Signed-off-by: Anton Vorontsov
---
arch/powerpc/boot/dts/mpc832x_rdb.dts | 24
arch/powerpc/plat
The bindings describes a case where MMC/SD/SDIO slot directly connected
to a SPI bus. Such setups are widely used on embedded PowerPC boards.
The patch also adds the mmc-spi-slot entry to the OpenFirmware modalias
table.
Signed-off-by: Anton Vorontsov
---
.../powerpc/dts-bindings/mmc-spi
On Tue, Jan 06, 2009 at 10:28:10PM -0600, Kumar Gala wrote:
> On Dec 5, 2008, at 2:09 PM, Anton Vorontsov wrote:
>> Hi all,
>>
>> The patch series are used to support SPI via the OF SPI subsystem
>> (driver/of/of_spi.c). Now the driver is able to manage its own
>&g
ment of_gpio_count()") you can use of_gpio_count() from
linux/of_gpio.h.
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
--
___
spi-devel-genera
On Fri, Dec 05, 2008 at 11:09:36PM +0300, Anton Vorontsov wrote:
> Hi all,
>
> The patch series are used to support SPI via the OF SPI subsystem
> (driver/of/of_spi.c). Now the driver is able to manage its own
> chip selects, and doesn't need any auxiliary support from
This is needed to not bother with ugly #ifdefs in the drivers.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/fsl_soc.h |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_soc.h b/arch/powerpc/sysdev/fsl_soc.h
pport to mpc832x_rdb boards
[6/7] powerpc: Add mmc-spi-slot bindings
[7/7] powerpc/83xx: Add mmc-spi support via the device tree for MPC8323E-RDB
Thanks,
--
Anton Vorontsov
email: [EMAIL PROTECTED]
irc://irc.freenode.net/bd2
--
This patch implements full support for OF SPI bindings. Now the driver
can manage its own chip selects without any help from the board files
and/or fsl_soc constructors.
The "legacy" code is well isolated and could be removed as time goes by.
Signed-off-by: Anton Vorontsov <[EM
x27;t duplicate platform data callbacks in mpc83xx_spi struct.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/83xx/mpc832x_rdb.c | 16
arch/powerpc/sysdev/fsl_soc.c | 14 ++
arch/powerpc/sysdev/fsl_soc.h |
different address
spaces)
spi_mpc83xx.c:296:25:expected unsigned int [noderef] [usertype] *reg
spi_mpc83xx.c:296:25:got void *tmp_ptr
spi_mpc83xx.c:486:13: warning: symbol 'mpc83xx_spi_irq' was not declared.
Should it be static?
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
The bindings describes a case where MMC/SD/SDIO slot directly connected
to a SPI bus. Such setups are widely used on embedded PowerPC boards.
The patch also adds the mmc-spi-slot entry to the OpenFirmware modalias
table.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
.../power
- Add gpio-controller node to manage QE GPIO Bank D;
- Add mmc-spi node;
- Modify board file so that it won't use legacy SPI support with the new
device trees.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc832x_rdb.dts | 24 +++
The advantages of this:
- Don't encourage legacy support;
- Less external symbols, less code to compile-in for !MPC832x_RDB
platforms.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/83xx/mpc832x_rdb.c | 107 +
arch/pow
..]
There is spidev driver to do SPI in userspace. But no, it does not mean
that we can always use UIO. For example, we can't use UIO when we want to
process IRQs (think touchscreen pen-down irq), or better, we anyway will
need to write UI
ACCEL_Y_GAIN(_mode, _show, _store, _addr) \
> + IIO_DEVICE_ATTR(y_gain, _mode, _show, _store, _addr)
> +
> +#define IIO_DEV_ATTR_ACCEL_Z_GAIN(_mode, _show, _store, _addr) \
> + IIO_DEVICE_ATTR(z_gain, _mode, _show, _store, _addr)
> +
Why such a generic subsystem
abs.org/pipermail/linuxppc-dev/2008-June/058253.html
(Chen posted this patch separately to linuxppc-dev and spi lists)
I would be more happy if Chen could explain which boundary conditions
were wrong.
Something like I did once:
commit a44648b057f5331fe6c0e863dc693ed335490e7a
Author: Anton Voro
platform
get_cd hook (oops).
Suggested-by: Marc Pignat <[EMAIL PROTECTED]>
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
On Thu, Jun 05, 2008 at 05:58:59PM +0200, Marc Pignat wrote:
[...]
> > > * get_ro will return:
> > > * 0 for a read/write card
>
On Tue, Jun 03, 2008 at 12:07:49PM +0200, Marc Pignat wrote:
> Hi all!
>
> On Friday 23 May 2008, Anton Vorontsov wrote:
> > get_ro() callback must return values >= 0 for its logical state, and
> ...
> > static void pxamci_set_ios(struct mmc_host *mmc, struct mmc
need take special care when returning platform's values to the mmc core.
2. In case of host instance didn't implement get_ro() callback, it should
really return -ENOSYS and let the mmc core decide what to do about it
(mmc core thinks the same way as the hosts, so it isn't fu
ned-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
drivers/mmc/host/mmc_spi.c | 19 +--
include/linux/spi/mmc_spi.h |9 +
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 3550858..7248
y the hosts that are able to report card-detect status without need to
talk MMC.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
drivers/mmc/core/core.c | 12 +---
include/linux/mmc/host.h |8
2 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/drive
al.
Aha, that's an idea, thanks. Implemented in the updated patches.
p.s.
I think, in case of capabilities, it's users' responsibility to not
issue bogus flags, so mmc_spi doesn't mask anything, it just passes
platform's caps. This also avoids drivers update when (if) new cap
y the hosts that are able to report card-detect status without need to
talk MMC.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
drivers/mmc/core/core.c | 12 +---
include/linux/mmc/host.h |8
2 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/drive
If platform_data lacks init() callback (solely used to request
card-detect interrupt), we mark the host as MMC_CAP_NEEDS_POLL.
get_cd() host operation provided to optimize polling.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
drivers/mmc/host/mmc_spi.c
need take special care when returning platform's values to the mmc core.
2. In case of host instance didn't implement get_ro() callback, it should
really return -ENOSYS and let the mmc core decide what to do about it
(mmc core thinks the same way as the hosts, so it isn't fu
1 - 100 of 145 matches
Mail list logo
