On Mon, May 04, 2009 at 01:53:27PM -0700, Andrew Morton wrote:
> On Fri, 1 May 2009 03:48:33 +0400
> Anton Vorontsov <avoront...@ru.mvista.com> wrote:
>
> > Since we renamed the file, we might want to rename the file
> > internals too.
> >
> > Though we don't bother with changing platform driver name and
> > platform module alias. The stuff is legacy and hopefully we'll
> > remove it soon.
> >
>
> but but but
>
> >
> > -static struct of_platform_driver of_mpc83xx_spi_driver = {
> > - .name = "mpc83xx_spi",
> > - .match_table = of_mpc83xx_spi_match,
> > - .probe = of_mpc83xx_spi_probe,
> > - .remove = __devexit_p(of_mpc83xx_spi_remove),
> > +static struct of_platform_driver of_mpc8xxx_spi_driver = {
> > + .name = "mpc8xxx_spi",
> > + .match_table = of_mpc8xxx_spi_match,
> > + .probe = of_mpc8xxx_spi_probe,
> > + .remove = __devexit_p(of_mpc8xxx_spi_remove),
> > };
>
> It _did_ change the platform driver name, didn't it?
This is an OF platform driver, here it is safe to change
the name. But I didn't change the pure platform driver,
here:
| -static struct platform_driver mpc83xx_spi_driver = {
| - .probe = plat_mpc83xx_spi_probe,
| - .remove = __exit_p(plat_mpc83xx_spi_remove),
| +static struct platform_driver mpc8xxx_spi_driver = {
| + .probe = plat_mpc8xxx_spi_probe,
| + .remove = __exit_p(plat_mpc8xxx_spi_remove),
| .driver = {
| .name = "mpc83xx_spi",
------------------^
> This patch series had quite a lot of conflicts with the already-pending
>
> spi-move-common-spi_setup-functionality-into-core.patch
> spi-move-more-spi_setup-functionality-into-core.patch
>
> which I beleive I successfully fixed up.
Thanks a lot, I'll test it soon.
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations
Conference from O'Reilly Media. Velocity features a full day of
expert-led, hands-on workshops and two days of sessions from industry
leaders in dedicated Performance & Operations tracks. Use code vel09scf
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
