Re: Adding/changing SPI device registrations on the fly via the load of a module

2013-10-28 Thread Grant Likely
Hi Martin, Yes, this is definitely a problem that needs to be solved, and it isn't restricted to SPI devices. I2C, GPIO, etc all have the same problem. Using a device driver with kernel parameters isn't a very good interface though. There is already some conversations going on about allowing devic

[PATCH] MAINTAINERS: Remove Grant Likely

2013-07-11 Thread Grant Likely
SPI are in good hands with Linus and Mark. Rob Herring has a really good grasp on the DT core code, and in the last week there have been several volunteers to create and maintain a DT bindings tree. You can expect to see an email about that hit the list shortly. Signed-off-by: Grant Likely --- MAINT

[git pull] SPI bug fixes

2013-05-03 Thread Grant Likely
11 insertions(+), 8 deletions(-) -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- Get 100% visibility into Java/.NET code with AppDynamics Lite It's a free troubleshooting tool designed for production Get

Re: [PATCH 01/15] spi: altera: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Grant Likely
to manually clear the device driver data to NULL. > > Signed-off-by: Jingoo Han Hi Jingoo, Thanks for doing this. However, there is no need to have a separate patch for each and every spi driver. Can you please squash them all into a single patch and repost? Acked-by: Grant Likely &g

Re: [REPOST PATCH] spi: s3c64xx: let device core setup the default pin configuration

2013-04-16 Thread Grant Likely
On Mon, 15 Apr 2013 20:42:57 -0700, Doug Anderson wrote: > From: Thomas Abraham > > With device core now able to setup the default pin configuration, > the pin configuration code based on the deprecated Samsung specific > gpio bindings is removed. > > Signed-off-by: Thomas Abraham > Signed-off

Re: [PATCH v5 0/5] Patch enables support for m25p64 SPI flash support on da850-EVM.

2013-04-16 Thread Grant Likely
and is something that should > have been merge last merge window itself (when the bindings were > accepted). So, the patches pending on Grant's ack seem very low risk to > me and we are much delayed already to wait further. For both of those patches: Acked-by: Grant Likely ---

Re: [PATCH 02/17] of_spi: add generic binding support to specify cs gpio

2013-04-15 Thread Grant Likely
On Fri, 22 Mar 2013 17:16:54 +0800, Wenyou Yang wrote: > From: Jean-Christophe PLAGNIOL-VILLARD > > This will allow to use gpio for chip select with no modification in the > driver binding > > When use the cs-gpios, the gpio number will be passed via the cs_gpio field > and the number of chip s

Re: Quick questions regarding the SPI interface

2013-04-06 Thread Grant Likely
mple-rate > can get very well controlled getting close to real-time performance with > regards to jitter and more... > > Can you please give me your thoughts on these before I start implementing > the next revision of the DMA enabled driver for the RPI har

Re: [PATCH 4/4] spi: remove unused Tegra platform data header

2013-03-09 Thread Grant Likely
On Sat, Mar 9, 2013 at 1:10 AM, Rhyland Klein wrote: > On 3/2/2013 6:02 PM, Grant Likely wrote: >> >> On Fri, 15 Feb 2013 15:03:50 -0700, Stephen Warren >> wrote: >>> >>> From: Stephen Warren >>> >>> The platform data header is no long

Re: [PATCH] spi: Driver for GPIO controlled SPI multiplexer

2013-03-03 Thread Grant Likely
On Sun, 3 Mar 2013 15:42:39 +0800, Mark Brown wrote: > On Sat, Mar 02, 2013 at 05:32:44PM +0000, Grant Likely wrote: > > > Mark commented on this too, but I disagree with him on one point; it > > will actually be simpler if you finish up the transfer in the callback, >

Re: [PATCH V3] spi: tegra114: add spi driver

2013-03-03 Thread Grant Likely
On Fri, 22 Feb 2013 19:59:11 +0530, Manish Badarkhe wrote: > On Fri, Feb 22, 2013 at 6:07 PM, Laxman Dewangan wrote: > > Add SPI driver for NVIDIA's Tegra114 SPI controller. This controller > > is different than the older SoCs SPI controller in internal design as > > well as register interface.

Re: [PATCH v2 7/7] spi: spi-fsl-spi: Add support for gpio chipselects for GRLIB type cores

2013-03-03 Thread Grant Likely
On Thu, 7 Feb 2013 08:08:21 -0800, Anton Vorontsov wrote: > On Thu, Feb 07, 2013 at 02:12:11PM +0100, Andreas Larsson wrote: > > This relies upon of_spi_register_master to find out which gpios to use. > > > > Signed-off-by: Andreas Larsson > > --- > > drivers/spi/spi-fsl-lib.h |1 + > > dri

Re: [PATCH 4/4] spi: remove unused Tegra platform data header

2013-03-03 Thread Grant Likely
On Fri, 15 Feb 2013 15:03:50 -0700, Stephen Warren wrote: > From: Stephen Warren > > The platform data header is no longer used. Delete it. > > Signed-off-by: Stephen Warren I like the diffstat for this series. Applied! Thanks, g. --

Re: [PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization

2013-03-03 Thread Grant Likely
On Fri, 22 Feb 2013 17:09:18 +0900, Boojin Kim wrote: > This patch adds dma maxburst size initialization. > The maxburst should be set by MODE_CFGn.DMA_TYPE, > because the pl330 dma driver supports burst mode. > > Signed-off-by: Hyeonkook Kim Acked-by: Grant Likely This series

Re: [PATCH v5 01/16] spi/spi-atmel: fix master->num_chipselect wrongly set.

2013-03-03 Thread Grant Likely
On Tue, 26 Feb 2013 14:47:54 +0800, Wenyou Yang wrote: > if the spi property "cs-gpios" is set as below: > > cs-gpios = <0>, <&pioC 11 0>, <0>, <0>; > > the master->num_chipselect will wrongly be set to 0, > and the spi fail to probe. > > Signed-off-by: Wenyou Yang > Cc: spi-devel-genera

Re: [PATCH] spi: spi-xilinx: Use DT information for bits_per_word value

2013-03-03 Thread Grant Likely
On Mon, 11 Feb 2013 17:28:01 +0100, "Jens Renner (EFE)" wrote: > From: Jens Renner > > This patch overrides the default value of bits_per_word with the actual value > of "xlnx,num-transfer-bits" from the DTS file to allow for 16 and 32 bit word > lengths. > > Signed-off-by: Jens Renner > ---

Re: [PATCH 05/12] spi: mxs-spi: move to use generic DMA helper

2013-03-03 Thread Grant Likely
along with the changes, the non-DT > case handling in probe function also gets removed. > > Signed-off-by: Shawn Guo > Cc: Grant Likely > Cc: spi-devel-general@lists.sourceforge.net Acked-by: Grant Likely -

Re: [PATCH] spi: Initialize cs_gpio and cs_gpios with -ENOENT

2013-03-03 Thread Grant Likely
On Wed, 13 Feb 2013 14:20:25 +0100, Andreas Larsson wrote: > The return value from of_get_named_gpio is -ENOENT when the given index > matches a hole in the "cs-gpios" property phandle list. However, the > default value of cs_gpio in struct spi_device and entries of cs_gpios in > struct spi_master

Re: [PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization

2013-03-03 Thread Grant Likely
irection = sdd->tx_dma.direction; > config.fifo = sdd->sfr_start + S3C64XX_SPI_TX_DATA; > config.width = sdd->cur_bpw / 8; > -- > 1.7.5.4 > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in &g

Re: [PATCH] of: spi: Return error from of_spi_register_master on bad "cs-gpios" property

2013-03-03 Thread Grant Likely
< 0) > + return nb; > > cs = devm_kzalloc(&master->dev, > sizeof(int) * master->num_chipselect, > -- > 1.7.0.4 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -

Re: [PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization

2013-03-03 Thread Grant Likely
On Fri, 22 Feb 2013 17:09:18 +0900, Boojin Kim wrote: > This patch adds dma maxburst size initialization. > The maxburst should be set by MODE_CFGn.DMA_TYPE, > because the pl330 dma driver supports burst mode. > > Signed-off-by: Hyeonkook Kim Applied, thanks. g. -

RE: [PATCH 0/4] Enable SPI flash support on da850-evm DT kernel

2013-03-03 Thread Grant Likely
On Wed, 27 Feb 2013 11:32:39 +, "Manjunathappa, Prakash" wrote: > On Wed, Feb 27, 2013 at 14:09:57, Nori, Sekhar wrote: > > On 2/25/2013 4:14 PM, Manjunathappa, Prakash wrote: > > > Patch enables support for m25p80 SPI flash support on > > > da850-EVM. > > > > > > Testing information: > > >

Re: [PATCH V2 2/5] spi: s3c64xx: added support for polling mode

2013-03-03 Thread Grant Likely
On Wed, 13 Feb 2013 12:03:45 -0800, Girish K S wrote: > The 64xx spi driver supports partial polling mode. > Only the last chunk of the transfer length is transferred > or recieved in polling mode. > > Some SoC's that adopt this controller might not have have dma > interface. This patch adds supp

Re: [PATCH v3 0/7] spi: spi-fsl-spi: Make spi-fsl-spi usable in cpu mode outside of FSL SOC environments and add a grlib variant normally running on sparc

2013-03-03 Thread Grant Likely
On Fri, 15 Feb 2013 16:52:20 +0100, Andreas Larsson wrote: > Changes since v3: > - Patches 1-7: Added Acked-by: Anton Vorontsov > - Patch 1: Small style tweak lining up function arguments properly > - Patch 7: Changed a style issue with two variables declared on same line > - Patch 7: Removed usa

Re: [PATCH] spi/atmel: fix speed_hz check in atmel_spi_transfer()

2013-03-03 Thread Grant Likely
On Wed, 20 Feb 2013 08:51:48 +0100, Nicolas Ferre wrote: > On 02/19/2013 10:44 PM, Joachim Eastwood : > > atmel_spi_transfer() would check speed_hz and fail if > > the speed was changed in the transfer. After commit > > "spi: make sure all transfer has proper speed set" > > this would happen on a

Re: [PATCH V2 3/5] spi: s3c64xx: Added provision for non-gpio i/o's

2013-03-03 Thread Grant Likely
On Wed, 13 Feb 2013 12:03:46 -0800, Girish K S wrote: > Currently the drivers supports only the GPIO based i/o pins. > But there are Exynos SoC's that use the same controller with > dedicated i/o pins. > > This patch provides provision to support gpio/dedicated pins. > The decision is made by pa

Re: [PATCH] spi: Driver for GPIO controlled SPI multiplexer

2013-03-02 Thread Grant Likely
On Wed, 27 Feb 2013 14:58:39 +0100, Peter Korsgaard wrote: > From: Dries Van Puymbroeck > > This patch contains a driver for a gpio controlled multiplexer on an > SPI bus. This can be useful if a board requires more SPI devices, > and thus more chip selects, than the SPI controller on the proce

Re: [PATCH] spi: Driver for GPIO controlled SPI multiplexer

2013-03-02 Thread Grant Likely
. An SPI multiplexer on the other hand can be implemented in several different ways. I would still be more specific here. You can be specific to your specific hardware now, and a more generic value can be added later

[GIT PULL] SPI for v3.9

2013-02-19 Thread Grant Likely
p select code spi/ath79: use gpio_request_one spi/ath79: avoid multiple initialization of the SPI controller spi/ath79: add shutdown handler Grant Likely (4): spi/of: Use DT aliases for assigning bus number Merge branch 'broonie/spi-next' of git://git.kern

Re: spi-atmel broken in next

2013-02-17 Thread Grant Likely
On Sun, Feb 17, 2013 at 11:15 AM, Joachim Eastwood wrote: > Hi, > > spi-atmel is now broken for all spi transfers in linux-next. This is > caused by commit "spi: make sure all transfer has proper speed set". > The reason is the following code in atmel_spi_transfer(...) > > 849 /* FIXME implemen

Re: [PATCH v2 5/6] of_spi: Add fetching of of_gpio flags to of_spi_register_master

2013-02-12 Thread Grant Likely
On Tue, 12 Feb 2013 10:39:02 +0100, Andreas Larsson wrote: > On 2013-02-11 01:22, Grant Likely wrote: > > On Tue, 29 Jan 2013 15:53:42 +0100, Andreas Larsson > > wrote: > >> When using a gpio chip select with a OF_GPIO_ACTIVE_LOW flag, this needs > >> to be &g

Re: [PATCH v2 6/6] of_spi: Initialize cs_gpios and cs_gpio with -EEXIST

2013-02-12 Thread Grant Likely
On Tue, 12 Feb 2013 10:46:27 +0100, Andreas Larsson wrote: > On 2013-02-11 01:23, Grant Likely wrote: > > On Tue, 29 Jan 2013 15:53:43 +0100, Andreas Larsson > > wrote: > >> Holes in the cs-gpios DT phandle list is supposed to mark that native > >> chipselects

Re: [PATCH v2] gpio: mcp23s08: convert driver to DT

2013-02-11 Thread Grant Likely
) > + pdata = of_get_mcp23s08_pdata(&spi->dev); > + > + /* if there was no pdata in DT, take it the legacy way */ > + if (!pdata) > + pdata = spi->dev.platform_data; > + > + if ((!pdata || !gpio_is_valid(pdata->base)) && pdata->ba

Re: [PATCH v2 6/6] of_spi: Initialize cs_gpios and cs_gpio with -EEXIST

2013-02-10 Thread Grant Likely
that should be handled natively by the controller driver is > + * set to -EEXIST. > * @cs_gpio_flags: possible array of of_gpio_flags corresponding to cs_gpios > * > * Each SPI master controller can communicate with one or more @spi_device > -- > 1.7.0.4 > -- Grant Likely,

Re: [PATCH v2 5/6] of_spi: Add fetching of of_gpio flags to of_spi_register_master

2013-02-10 Thread Grant Likely
On Tue, 29 Jan 2013 15:53:42 +0100, Andreas Larsson wrote: > When using a gpio chip select with a OF_GPIO_ACTIVE_LOW flag, this needs to be > known to the controller driver. > > Signed-off-by: Andreas Larsson Out of curiosity, what do you need the flags for? Polarity of the CS signal? I think i

Re: [PATCH v2 4/6] of_spi: Document cs_gpios and cs_gpio in kernel-doc

2013-02-10 Thread Grant Likely
ce > * children. These make a small bus, sharing MOSI, MISO and SCK signals > -- > 1.7.0.4 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- Free Next-Gen Firewall Hardware Offer Bu

Re: [PATCH v2 3/6] of_spi: Initialize cs_gpios properly

2013-02-10 Thread Grant Likely
-ENOMEM; > > - memset(cs, -EINVAL, master->num_chipselect); > + for (i = 0; i < master->num_chipselect; i++) > + cs[i] = -EINVAL; > > for (i = 0; i < nb; i++) > cs[i] = of_get_named_gpio(np, "cs-gpios

Re: [PATCH v2 2/6] of: Return -ENXIO from of_parse_phandle_with_args for too large index and return errors from of_gpio_named_count

2013-02-10 Thread Grant Likely
On Tue, 29 Jan 2013 15:53:39 +0100, Andreas Larsson wrote: > This lets of_gpio_named_count return an errno on errors by being able to > distinguish between reaching the end of the phandle list and getting some > other > error from of_parse_phandle_with_args. > > Return error from of_spi_register

Re: [PATCH 2/2] gpio: mcp23s08: convert driver to DT

2013-02-09 Thread Grant Likely
On Wed, 6 Feb 2013 18:01:58 +0100, Lars Poeschel wrote: > From: Lars Poeschel > > This converts the mcp23s08 driver to be able to be used with device > tree. > There is a special "mcp,chips" property, that correspond to the chips > member of the struct mcp23s08_platform_data. It can be used fo

Re: [PATCH 1/2] gpio: mcp23s08: Allow -1 as a legal value for global gpio base

2013-02-09 Thread Grant Likely
On Wed, 6 Feb 2013 18:01:57 +0100, Lars Poeschel wrote: > From: Lars Poeschel > > Explicitly allow -1 as a legal value for the > mcp23s08_platform_data->base. This is the special value lets the > kernel choose a valid global gpio base number. > > Signed-off-by: Lars Poeschel > --- > drivers

Re: [PATCH RFC 1/1] gpio: mcp23s08: convert driver to DT

2013-02-09 Thread Grant Likely
On Wed, 6 Feb 2013 10:31:04 +0100, Lars Poeschel wrote: > On Tuesday 05 February 2013 at 15:29:09, Grant Likely wrote: > > On Thu, 31 Jan 2013 21:51:36 +0100, Linus Walleij > wrote: > > > On Thu, Jan 31, 2013 at 4:58 PM, Lars Poeschel > wrote: > > > > --- /

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-06 Thread Grant Likely
On Wed, Feb 6, 2013 at 8:12 PM, Girish KS wrote: > On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely > wrote: >> On Tue, 5 Feb 2013 15:09:41 -0800, Girish K S >> wrote: >>> The status of the interrupt is available in the status register, >>> so reading the cle

Re: [PATCH v2] spi/ath79: add shutdown handler

2013-02-06 Thread Grant Likely
h79_spi_shutdown(struct platform_device *pdev) > +{ > + ath79_spi_remove(pdev); > +} > + > static struct platform_driver ath79_spi_driver = { > .probe = ath79_spi_probe, > .remove = ath79_spi_remove, > + .shutdown = ath79_spi_shutdown, &g

Re: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-06 Thread Grant Likely
es internal dedicated pins > + */ > + if (sdd->port_conf->quirks & S3C64XX_SPI_QUIRK_GPIO) > + return 0; > + > /* find gpios for mosi, miso and clock lines */ > for (idx = 0; idx < 3; idx++) { > gpio = of_get_gpio(dev

Re: [PATCH 2/4] spi: s3c64xx: added support for polling mode

2013-02-06 Thread Grant Likely
On Tue, 5 Feb 2013 15:09:42 -0800, Girish K S wrote: > The 64xx spi driver supports partial polling mode. > Only the last chunk of the transfer length is transferred > or recieved in polling mode. > > Some SoC's that adopt this controller might not have have dma > interface. This patch adds supp

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-06 Thread Grant Likely
On Tue, 5 Feb 2013 15:09:41 -0800, Girish K S wrote: > The status of the interrupt is available in the status register, > so reading the clear pending register and writing back the same > value will not actually clear the pending interrupts. This patch > modifies the interrupt handler to read the

Re: [PATCH V2 2/2] spi/bcm63xx: work around inability to keep CS up

2013-02-05 Thread Grant Likely
On Tue, 5 Feb 2013 16:00:04 +0100, Jonas Gorski wrote: > On Tue, 05 Feb 2013 14:35:30 + > Grant Likely wrote: > > > On Sun, 3 Feb 2013 15:15:13 +0100, Jonas Gorski wrote: > > > This SPI controller does not support keeping CS asserted after sending > > >

Re: [PATCH v2 2/2] spi: bitbang: convert to using core message queue

2013-02-05 Thread Grant Likely
On Thu, 10 Jan 2013 13:04:37 +0100 (CET), Guennadi Liakhovetski wrote: > On Thu, 10 Jan 2013, Linus Walleij wrote: > > > On Wed, Jan 9, 2013 at 3:44 PM, Guennadi Liakhovetski > > wrote: > > > > > [ 79.968000] mmc0: new SD card on SPI > > > [ 79.976000] mmcblk0: mmc0: SU02G 1.84 GiB > >

Re: Trying to use spidev to send an spi message, result from spidev_test.c "Illegal argument" . (i.mx23, kernel 3.7)

2013-02-05 Thread Grant Likely
On Sun, 30 Dec 2012 18:14:55 +0900, Juha Lumme wrote: > Hi, > > I am having issues communicating with a micro controller connected to > SPI bus, using spidev. > I would like to send messages to my MSP430 from user land, but so far no > luck. > > At least I know that my SPI bus should be ok, si

Re: [PATCH 1/2] SPI: MIPS: lantiq: make use of spi_finalize_current_message

2013-02-05 Thread Grant Likely
On Wed, 30 Jan 2013 21:33:30 +0100, John Crispin wrote: > Rather than calling m->complete() directly we choose the sane way and call > spi_finalize_current_message instead. > > Signed-off-by: Thomas Langer > Signed-off-by: John Crispin Applied, thanks. g. ---

Re: [PATCH RESEND] spi: spi-fsl-spi: Make spi-fsl-spi usable in cpu mode outside of FSL SOC environments and add a grlib variant normally running on sparc

2013-02-05 Thread Grant Likely
On Wed, 30 Jan 2013 13:15:24 +0100, Andreas Larsson wrote: > This makes the cpu mode of the driver available outside of an FSL SOC > and even powerpc environment. This is accomplished by putting things > regarding fsl specific code and to cpm specific code within ifdefs. > > Furthermore, this add

Re: [PATCH V2 0/2] spi/bcm63xx: fix multi transfer messages

2013-02-05 Thread Grant Likely
On Tue, 5 Feb 2013 15:04:41 +, Mark Brown wrote: > On Tue, Feb 05, 2013 at 02:30:40PM +0000, Grant Likely wrote: > > > Another option is to allow longer transfers if a GPIO is used for the CS > > line. A lot of SPI controllers need to do that. > > > That isn

Re: [PATCH] spi: davinci: use request_threaded_irq() to fix deadlock

2013-02-05 Thread Grant Likely
On Wed, 2 Jan 2013 10:19:08 -0500, Murali Karicheri wrote: > On 12/22/2012 05:08 AM, Grant Likely wrote: > > On Fri, 21 Dec 2012 15:13:26 -0500, Murali Karicheri > > wrote: > >> With RT pre-empt patch applied to Linux kernel, the irq handler will be > >> forc

Re: Fixing eSPI controller driver: some queries

2013-02-05 Thread Grant Likely
On Fri, 18 Jan 2013 10:03:28 +0100, Thomas De Schampheleire wrote: > Hi, > > The Freescale eSPI controller driver is broken in several ways. I already > attempted to fix this with a patch many months back. The patch works for > me, but never got feedback from the original author. > (see https://

Re: [PATCH 2/2] SPI: MIPS: lantiq: set SPI_MASTER_HALF_DUPLEX flag

2013-02-05 Thread Grant Likely
On Wed, 30 Jan 2013 21:33:31 +0100, John Crispin wrote: > Due to hardware limitations of the spi/flash frontend of the EBU we need to > set > the SPI_MASTER_HALF_DUPLEX flag. > > Signed-off-by: Thomas Langer > Signed-off-by: John Crispin Applied, thanks. g.

[PATCH V2] spi: Remove erroneous __init, __exit and __exit_p() references in drivers

2013-02-05 Thread Grant Likely
/__devexit purge since they didn't match the pattern. Remove then now to be rid of it. v2: purge __init also Reported-by: Arnd Bergmann [Arnd set a patch cleaning up one, and then I found more] Signed-off-by: Grant Likely --- drivers/spi/spi-atmel.c |2 +- drivers/spi/spi-au1550.c |

Re: [PATCH] spi: orion: Use module_platform_driver()

2013-02-05 Thread Grant Likely
__exit orion_spi_exit(void) > -{ > - platform_driver_unregister(&orion_spi_driver); > -} > -module_exit(orion_spi_exit); > +module_platform_driver(orion_spi_driver); > > MODULE_DESCRIPTION("Orion SPI driver"); > MODULE_AUTHOR("Shadi Ammouri "); >

Re: [PATCH V2 2/2] spi/bcm63xx: work around inability to keep CS up

2013-02-05 Thread Grant Likely
status = -EINVAL; > goto exit; > } > > - /* configure adapter for a new transfer */ > - bcm63xx_spi_setup_transfer(spi, t); > + if (t->cs_change || > + list_is_last(&

Re: [PATCH V2 1/2] spi/bcm63xx: reject transfers unable to transfer

2013-02-05 Thread Grant Likely
On Sun, 3 Feb 2013 15:15:12 +0100, Jonas Gorski wrote: > The hardware does not support keeping CS asserted after sending one > FIFO buffer worth of data, so reject transfers requiring CS being kept > asserted, either between transers or for a certain time after it, > or exceeding the FIFO size. >

Re: [PATCH V2 0/2] spi/bcm63xx: fix multi transfer messages

2013-02-05 Thread Grant Likely
9 > +++------ > 1 file changed, 125 insertions(+), 54 deletions(-) > > -- > 1.7.10.4 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- Free Next-

Re: [PATCH RFC 1/1] gpio: mcp23s08: convert driver to DT

2013-02-05 Thread Grant Likely
On Thu, 31 Jan 2013 21:51:36 +0100, Linus Walleij wrote: > On Thu, Jan 31, 2013 at 4:58 PM, Lars Poeschel > wrote: > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt > > @@ -0,0 +1,27 @@ > > +Microchip MCP2308/MCP23S08/MCP23017/MCP23S17 driver for > > +8-/16

Re: [PATCH 3/5] serial: pl011: use generic DMA slave configuration if possible

2013-02-05 Thread Grant Likely
get all the necessary information from the device tree. > > Like the patch that converts the dw_dma controller, this is completely > untested and is looking for someone to try it out. > > Signed-off-by: Arnd Bergmann > Cc: Grant Likely > Cc: Jiri Slaby > Cc: Greg Kroa

Re: [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible

2013-02-05 Thread Grant Likely
get all the necessary information from the device tree. > > Like the patch that converts the dw_dma controller, this is completely > untested and is looking for someone to try it out. > > Signed-off-by: Arnd Bergmann > Cc: Grant Likely > Cc: Mark Brown > Cc: spi-deve

Re: [PATCH] spi: Ensure memory used for spi_write_then_read() is DMA safe

2013-02-05 Thread Grant Likely
local_buf = kmalloc(max((unsigned)SPI_BUFSIZ, n_tx + n_rx), > + GFP_KERNEL | GFP_DMA); > if (!local_buf) > return -ENOMEM; > } else { &

Re: [PATCH 25/33] spi: Convert to devm_ioremap_resource()

2013-02-05 Thread Grant Likely
icit > error messages can be removed from the failure code paths. > > Signed-off-by: Thierry Reding > Cc: Grant Likely > Cc: spi-devel-general@lists.sourceforge.net Looks fine by me. Go ahead and merge with the rest of the series. Acked-by: Grant Likely > --- > dri

Re: [PATCH 2/2] spi: spi-mpc512x-psc: add support for gpio chip selects

2013-02-05 Thread Grant Likely
ter: > if (mps->psc) > iounmap(mps->psc); > @@ -497,6 +563,7 @@ static int mpc512x_psc_spi_do_remove(struct device *dev) > { > struct spi_master *master = spi_master_get(dev_get_drvdata(dev)); > struct mpc512x_psc_spi *mps = spi_master_get_devdata(mast

Re: [PATCH 1/2] spi: spi-mpc512x-psc: init mode bits supported by the driver

2013-02-05 Thread Grant Likely
master->setup = mpc512x_psc_spi_setup; > master->transfer = mpc512x_psc_spi_transfer; > master->cleanup = mpc512x_psc_spi_cleanup; > -- > 1.7.5.4 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -

Re: [PATCH v2] spi: spi-mpc512x-psc: don't use obsolet cell-index property

2013-02-05 Thread Grant Likely
d = of_alias_get_id(op->dev.of_node, "spi"); > + if (id < 0) { > + dev_err(&op->dev, "no alias id for %s\n", > + op->dev.of_node->full_name); &g

Re: [PATCH 1/3] spi: Add helper functions for setting up transfers

2013-02-05 Thread Grant Likely
On Sun, 27 Jan 2013 03:33:59 +, Mark Brown wrote: > On Wed, Jan 09, 2013 at 06:31:09PM +0100, Lars-Peter Clausen wrote: > > > The second function spi_sync_transfer() takes a SPI device and an array of > > spi_transfers. It will allocate a new spi_message (on the stack) and add all > > transf

[PATCH] spi: Remove erroneous __exit and __exit_p() references in drivers

2013-02-05 Thread Grant Likely
match the pattern. Remove then now to be rid of it. Reported-by: Arnd Bergmann [Arnd set a patch cleaning up one, and then I found more] Signed-off-by: Grant Likely --- drivers/spi/spi-atmel.c |2 +- drivers/spi/spi-au1550.c |4 ++-- drivers/spi/spi-omap-100k.c |4 ++-- dr

Re: [PATCH] driver-core: constify data for class_find_device()

2013-02-05 Thread Grant Likely
> --- > > patch against https://github.com/torvalds/linux.git master Acked-by: Grant Likely for the GPIO and SPI bits. -- Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2

Re: [PATCH 14/19] spi/atmel: remove incorrect __exit_p()

2013-02-05 Thread Grant Likely
On Fri, 25 Jan 2013 14:14:31 +, Arnd Bergmann wrote: > Since we no longer allow building without hotplug, the > atmel_spi_remove function is always present and we should > not use __exit_p() to refer to it. > > Without this patch, building at91_dt_defconfig results in: > > drivers/spi/spi-at

Re: [PATCH] spi: s3c64xx: fix checkpatch warnings and error

2013-02-05 Thread Grant Likely
ret); > + dev_err(&pdev->dev, "failed to get alias id, errno > %d\n", > + ret); > goto err0; > } > sdd->port_id = ret; > @@ -1347,8 +1341,7 @@ static int __init s3c64

Re: [PATCH v2] spi: s3c64xx: Use devm_clk_get() and devm_request_irq()

2013-02-05 Thread Grant Likely
On Thu, 10 Jan 2013 11:04:21 +0900, Jingoo Han wrote: > Use devm_clk_get() and devm_request_irq() rather than clk_get() and > request_irq() to make cleanup paths more simple. > > Signed-off-by: Jingoo Han Applied, thanks. g. ---

Re: [PATCH] spi: spi-imx: Add MODULE_ALIAS()

2013-02-05 Thread Grant Likely
UTHOR("Sascha Hauer, Pengutronix"); > MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:" DRIVER_NAME); > -- > 1.7.9.5 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -

Re: [PATCH 2/2] spi: tegra: remove checks for valid speed

2013-02-05 Thread Grant Likely
speed) { > clk_set_rate(tspi->clk, speed * 4); > tspi->cur_speed = speed; > @@ -841,6 +839,8 @@ static int tegra_slink_setup(struct spi_device *spi) > > BUG_ON(spi->chip_select >= MAX_CHIP_SELECT); > > + /* Set speed to

Re: [PATCH 1/2] spi: make sure all transfer has proper speed set

2013-02-05 Thread Grant Likely
xfer->bits_per_word = spi->bits_per_word; > + if (!xfer->speed_hz) > + xfer->speed_hz = spi->max_speed_hz; > } > > message->spi = spi; > -- > 1.7.1.1 > -- Grant Likely, B.Sc, P.Eng. Secret L

Re: [PATCH 1/2] spi: spi-gpio: Add checks for the dt properties

2013-02-05 Thread Grant Likely
On Tue, 22 Jan 2013 16:50:30 +0100, Maxime Ripard wrote: > On 09/01/2013 09:37, Maxime Ripard wrote: > > On 27/12/2012 22:54, Maxime Ripard wrote: > >> The bindings assumed that the gpios properties were always there, which > >> made the NO_TX and NO_RX mode not usable from device tree. Add extra

Re: [PATCH 6/6] spi/ath79: add shutdown handler

2013-02-05 Thread Grant Likely
On Thu, 27 Dec 2012 10:42:29 +0100, Gabor Juhos wrote: > The SPI controller of the AR7xxx/AR9xxx SoCs > have a special mode which allows the SoC to > directly read data from SPI flash chips. In > this mode, the content of the SPI flash chip > can be accessed via a memory mapped region. > > During

Re: [PATCH 5/6] spi/ath79: avoid multiple initialization of the SPI controller

2013-02-05 Thread Grant Likely
start(&sp->bitbang); > if (ret) > - goto err_clk_disable; > + goto err_disable; > > return 0; > > +err_disable: > + ath79_spi_disable(sp); > err_clk_disable: > clk_disable(sp->clk); > err_clk_put: >

Re: [PATCH 4/6] spi/ath79: use gpio_request_one

2013-02-05 Thread Grant Likely
return status; > - } > + status = gpio_request_one(cdata->gpio, flags, > + dev_name(&spi->dev)); > } > > - return 0; > + return status; > } > > static void ath79_spi_cleanup_cs(struct s

Re: [PATCH 3/6] spi/ath79: remove superfluous chip select code

2013-02-05 Thread Grant Likely
t;ioc_base |= AR71XX_SPI_IOC_CS0; > - else > - sp->ioc_base &= ~AR71XX_SPI_IOC_CS0; > - ath79_spi_wr(sp, AR71XX_SPI_REG_IOC, sp->ioc_base); > } > > return 0; > -- > 1.7.10 > -- Grant Likely, B.Sc, P.E

Re: [PATCH 2/6] spi/ath79: add missing HIGH->LOW SCK transition

2013-02-05 Thread Grant Likely
; ath79_spi_delay(sp, nsecs); > + if (bits == 1) > + ath79_spi_wr(sp, AR71XX_SPI_REG_IOC, out); > > word <<= 1; > } > -- > 1.7.10 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd.

Re: [PATCH 1/6] spi/ath79: add delay between SCK changes

2013-02-05 Thread Grant Likely
On Thu, 27 Dec 2012 10:42:24 +0100, Gabor Juhos wrote: > The driver uses the "as fast as it can" approach > to drive the SCK signal. However this does not > work with certain low speed SPI chips (e.g. the > PCF2123 RTC chip). > > The patch adds per-bit slowdowns in order to be > able to use the d

Re: [PATCH V2] mxs: spi: clear XFER_COUNT in ctrl0 field in DMA descriptor

2013-02-05 Thread Grant Likely
On Wed, 26 Dec 2012 14:48:51 +0900, Juha Lumme wrote: > On MX23 the XFER_COUNT part in ctrl0 field in DMA descriptor was improperly > OR'd during the construction of DMA descriptor chain, instead of being > freshly set. > Because of that too many bytes were being expected from SPI during the last

Re: [PATCH 1/2] spi: sirf: use clk_prepare_enable and clk_disable_unprepare

2013-02-05 Thread Grant Likely
ered office Churchill House, > Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom > More information can be found at www.csr.com. Follow CSR on Twitter at > http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog > >

Re: [PATCH 2/2] spi: sirf: add support for new SiRFmarco SMP SoC

2013-02-05 Thread Grant Likely
n can be found at www.csr.com. Follow CSR on Twitter at > http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists

Re: [PATCH v2 01/10] spi: tegra: Do not use clock name to get clock

2013-01-14 Thread Grant Likely
; this patch needs > to go through the Tegra tree due to dependencies. Acked-by: Grant Likely No problem merging it via the Tegra tree. g. -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MV

Re: [PATCH] spi: erase pointer to drvdata on removal

2013-01-14 Thread Grant Likely
tices this change is buggy, the driver shouldn't > use a drvdata value that it didn't set. I had thought this stuff had > all been removed from I2C and either dropped or factored out into the > driver core... Looks to me like __device_release_driver() in drivers/base/dd.c al

Re: [PATCH] MAINTAINERS: Add myself as a backup maintainer for SPI

2013-01-14 Thread Grant Likely
On Mon, Jan 14, 2013 at 2:32 AM, Mark Brown wrote: > Grant said he would find it helpful for me to continue handling some of > the legwork for SPI so add myself to MAINTAINERS so I get CCed on > patches. > > Signed-off-by: Mark Brown Acked-by: Grant Likely > --- > MAIN

Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

2013-01-11 Thread Grant Likely
On Thu, 3 Jan 2013 19:04:55 +0300, Dan Carpenter wrote: > On Sat, Dec 22, 2012 at 09:56:20AM +0000, Grant Likely wrote: > > On Wed, 19 Dec 2012 19:39:14 +0300, Dan Carpenter > > wrote: > > > On Wed, Dec 19, 2012 at 03:11:54PM +, Grant Likely wrote: > > &g

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2013-01-11 Thread Grant Likely
On Mon, 24 Dec 2012 11:16:52 -0500, Jun Chen wrote: > On Fri, 2012-12-21 at 19:06 +0000, Grant Likely wrote: > > The problem is that I don't understand why this change is necessary. > > spi_devices should always be children of an spi_master, not siblings. > > What is th

Re: [PATCH] spi: davinci: use request_threaded_irq() to fix deadlock

2012-12-22 Thread Grant Likely
ev) > goto unmap_io; > } > > - ret = request_irq(dspi->irq, davinci_spi_irq, 0, dev_name(&pdev->dev), > - dspi); > + ret = request_threaded_irq(dspi->irq, davinci_spi_irq, dummy_thread_fn, > + 0, d

Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

2012-12-22 Thread Grant Likely
On Wed, 19 Dec 2012 19:39:14 +0300, Dan Carpenter wrote: > On Wed, Dec 19, 2012 at 03:11:54PM +0000, Grant Likely wrote: > > On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto > > wrote: > > > > > > Hi > > > > > > > According t

Re: [PATCH RFC] spidev.c: add sysfs attributes for SPI configuration

2012-12-22 Thread Grant Likely
On Thu, 20 Dec 2012 16:30:36 +0100, Federico Vaga wrote: > On Wednesday 19 December 2012 15:09:25 Grant Likely wrote: > > Not a good idea. sysfs is not a good place for operational > > interfaces. Please use the spi character devices for direct > > manipulation of

Re: [PATCH V2] spi: remove check for bits_per_word on transfer from low level driver

2012-12-22 Thread Grant Likely
On Thu, 20 Dec 2012 11:33:47 +0530, Laxman Dewangan wrote: > On Wednesday 19 December 2012 09:54 PM, Grant Likely wrote: > > On Tue, 18 Dec 2012 14:25:43 +0530, Laxman Dewangan > > wrote: > >> The spi core make sure that each transfer structure have the proper > &

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-22 Thread Grant Likely
On Fri, 21 Dec 2012 12:39:52 -0500, Jun Chen wrote: > On Wed, 2012-12-19 at 16:21 +0000, Grant Likely wrote: > > On Wed, 19 Dec 2012 09:04:16 +, Mark Brown > > wrote: > > > On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: > > > > > > >

Re: [PATCH] spi: spi-mpc512x-psc: don't use obsolet cell-index property

2012-12-22 Thread Grant Likely
On Fri, 21 Dec 2012 14:48:38 +, Grant Likely wrote: > On Fri, Dec 21, 2012 at 2:43 PM, Anatolij Gustschin wrote: > > Use unique PSCx register base offset to obtain the > > SPI PSC number used for SPI bus id. > > > > Signed-off-by: Anatolij Gustschin > >

Re: [PATCH] spi: spi-mpc512x-psc: don't use obsolet cell-index property

2012-12-21 Thread Grant Likely
(id > 11) { > + dev_err(&op->dev, "node %s has invalid reg > property\n", > op->dev.of_node->full_name); > return -EINVAL; > } > - id = *psc_nump; > } > >

Re: [GIT PULL] SPI bug fixes for v3.8 merge window

2012-12-19 Thread Grant Likely
[Forgot to cc: lkml] On Thu, Dec 20, 2012 at 12:46 AM, Grant Likely wrote: > Hi Linus, > > And finally, here are the bug fixes I've queued up for SPI. Very > little in the way of excitement other than a device driver feature > that should have been in my first pull req,

  1   2   3   4   5   6   7   8   9   10   >