Re: [PATCH 1/3] dmaengine: add dma_get_slave_sg_limits()

2013-07-18 Thread Russell King - ARM Linux
On Thu, Jul 18, 2013 at 11:46:39AM -0500, Joel Fernandes wrote: > The API is optionally implemented by dmaengine drivers and when > unimplemented will return a NULL pointer. A client driver using > this API provides the required dma channel, address width, and > burst size of the transfer. dma_get_

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-09 Thread Russell King - ARM Linux
On Sat, Feb 09, 2013 at 09:35:53PM +0530, Sekhar Nori wrote: > On 2/1/2013 11:52 PM, Matt Porter wrote: > > + ret = of_address_to_resource(node, 1, &res); > > of_address_to_resource() needs > > > + if (IS_ERR_VALUE(ret)) > > This needs More importantly, is this the correct way to check fo

Re: [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible

2013-02-08 Thread Russell King - ARM Linux
On Thu, Feb 07, 2013 at 10:15:48PM +0100, Arnd Bergmann wrote: > On Thursday 07 February 2013 21:19:04 Linus Walleij wrote: > > On Thu, Feb 7, 2013 at 8:42 PM, Arnd Bergmann wrote: > > > On Thursday 07 February 2013, Linus Walleij wrote: > > > > >> Actually I once read about a feature where the k

Re: [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible

2013-02-08 Thread Russell King - ARM Linux
On Thu, Feb 07, 2013 at 07:29:17PM +0100, Linus Walleij wrote: > Actually I once read about a feature where the kernel provides > a static page full of zeroes or something like this, that would be > ideal to use in cases like this, then all of this dummy page > allocation and freeing can be deleted

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Tue, Feb 05, 2013 at 04:30:45PM +0100, Linus Walleij wrote: > On Mon, Feb 4, 2013 at 10:54 PM, Cyril Chemparathy wrote: > > On 02/04/2013 04:11 PM, Linus Walleij wrote: > > >> Cyril, just stack up the cookies and take a sweep over them to see > >> which ones are baked when the NAPI poll comes

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Tue, Feb 05, 2013 at 04:47:05PM +, Mark Brown wrote: > On Tue, Feb 05, 2013 at 05:21:48PM +0100, Linus Walleij wrote: > > > For IRQ mode, use the completion callback to push each cookie > > to NAPI, and thus let the IRQ drive the traffic. > > The whole purpose of NAPI is to avoid taking in

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 04:54:45PM -0500, Cyril Chemparathy wrote: > You're assuming that cookies complete in order. That is not necessarily > true. Under what circumstances is that not true? -- Free Next-Gen Firewall

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 09:47:38PM +, Arnd Bergmann wrote: > On Monday 04 February 2013, Linus Walleij wrote: > > So I think the above concerns are moot. The callback we can > > set on cookies is entirely optional, and it's even implemented by > > each DMA engine, and some may not even support

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-04 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 06:47:12PM +0200, Felipe Balbi wrote: > Hi, > > On Mon, Feb 04, 2013 at 08:36:38PM +0300, Sergei Shtylyov wrote: > >In my eyes, getting rid of the mess doesn't justify breaking the rules > > that > > Russell formulated above. > > MUSB is no PCI, there is no single, st

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-04 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 05:41:53PM +0200, Felipe Balbi wrote: > Hi, > > On Fri, Feb 01, 2013 at 09:30:03PM +, Russell King - ARM Linux wrote: > > > > > I guess to make the MUSB side simpler we would need musb-dma-engine > > > > > glue > > > &g

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Russell King - ARM Linux
On Sat, Feb 02, 2013 at 08:27:42PM +0400, Sergei Shtylyov wrote: >> There are two people on this thread CC list who were also involved or >> CC'd on the mails from the thread in 2010... Tony and Felipe. >> Unfortunately, the person who agreed to do the work is no longer in the >> land of the livin

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Russell King - ARM Linux
On Fri, Feb 01, 2013 at 10:41:08AM -0800, Tony Lindgren wrote: > * Matt Porter [130201 10:25]: > > Move mach-davinci/dma.c to common/edma.c so it can be used > > by OMAP (specifically AM33xx) as well. > > I think this should rather go to drivers/dma/? Yes, it should, but just like OMAP, there's

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Russell King - ARM Linux
On Fri, Feb 01, 2013 at 01:59:59PM -0500, Matt Porter wrote: > On Fri, Feb 01, 2013 at 07:52:46PM +, Sergei Shtylyov wrote: > > Hello. > > > > On 02/01/2013 09:49 PM, Matt Porter wrote: > > > > >>> Move mach-davinci/dma.c to common/edma.c so it can be used > > >>> by OMAP (specifically AM33xx

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Russell King - ARM Linux
On Sat, Feb 02, 2013 at 10:18:51AM +, Russell King - ARM Linux wrote: > On Sat, Feb 02, 2013 at 06:09:24AM +0400, Sergei Shtylyov wrote: > > Hello. > > > > On 02-02-2013 4:44, Russell King - ARM Linux wrote: > > > >>>>> On Fri, Feb 01, 20

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Russell King - ARM Linux
On Sat, Feb 02, 2013 at 06:09:24AM +0400, Sergei Shtylyov wrote: > Hello. > > On 02-02-2013 4:44, Russell King - ARM Linux wrote: > >>>>> On Fri, Feb 01, 2013 at 11:49:11PM +0300, Sergei Shtylyov wrote: >>>>>>> good point, do you wanna send some

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-01 Thread Russell King - ARM Linux
On Sat, Feb 02, 2013 at 04:07:59AM +0400, Sergei Shtylyov wrote: > Hello. > > On 02-02-2013 1:30, Russell King - ARM Linux wrote: > >>> On Fri, Feb 01, 2013 at 11:49:11PM +0300, Sergei Shtylyov wrote: >>>>> good point, do you wanna send some patches ? > >

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-01 Thread Russell King - ARM Linux
On Fri, Feb 01, 2013 at 10:56:00PM +0200, Felipe Balbi wrote: > hi, > > On Fri, Feb 01, 2013 at 11:49:11PM +0300, Sergei Shtylyov wrote: > > > good point, do you wanna send some patches ? > > > >I have already sent them countless times and even stuck CPPI 4.1 support > > (in > > arch/arm/com

Re: [PATCH] spi: remove check for bits_per_word on transfer

2012-12-17 Thread Russell King - ARM Linux
On Mon, Dec 17, 2012 at 11:21:57PM +0530, Laxman Dewangan wrote: > When spi client does the spi transfer and does not sets > the bits_per_word for each transfer then set it as default > of spi device in spi core before calling low level transfer. Err, sorry? To me, the above doesn't make too much

Re: [PATCH 2/2] Revert "spi/pl022: enable runtime PM"

2012-10-23 Thread Russell King - ARM Linux
On Tue, Oct 23, 2012 at 12:47:23PM +0100, Russell King - ARM Linux wrote: > On Tue, Oct 23, 2012 at 12:41:31PM +0100, Mark Brown wrote: > > On Tue, Oct 23, 2012 at 12:16:56PM +0100, Russell King - ARM Linux wrote: > > > On Tue, Oct 23, 2012 at 12:10:19PM +0100, Mark Brown wro

Re: [PATCH 2/2] Revert "spi/pl022: enable runtime PM"

2012-10-23 Thread Russell King - ARM Linux
On Tue, Oct 23, 2012 at 12:41:31PM +0100, Mark Brown wrote: > On Tue, Oct 23, 2012 at 12:16:56PM +0100, Russell King - ARM Linux wrote: > > On Tue, Oct 23, 2012 at 12:10:19PM +0100, Mark Brown wrote: > > > > I *really* should not need to remind you to: > > > &

Re: [PATCH 2/2] Revert "spi/pl022: enable runtime PM"

2012-10-23 Thread Russell King - ARM Linux
On Tue, Oct 23, 2012 at 12:10:19PM +0100, Mark Brown wrote: > On Tue, Oct 23, 2012 at 12:31:06PM +0200, Ulf Hansson wrote: > > It seems like this patch did not get applied together with: > > [PATCH 1/2] Revert "spi/pl022: fix spi-pl022 pm enable at probe" > > > > The problem was likely my fault, s

Re: [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"

2012-09-30 Thread Russell King - ARM Linux
On Sun, Sep 30, 2012 at 10:44:17AM +0200, Linus Walleij wrote: > On Fri, Sep 28, 2012 at 1:21 PM, Ulf Hansson > wrote: > > > From: Ulf Hansson > > > > This reverts commit 6887237cd7da904184dab2750504040c68f3a080. > > > > Signed-off-by: Ulf Hansson > > Why? > > It was removed in this commit,

Re: [PATCH V2] spi/pl022: Simplify use of runtime pm

2012-09-27 Thread Russell King - ARM Linux
e_disable from the remove function > can be done since it is already handled by the amba bus. > > Signed-off-by: Ulf Hansson What's the bloody point? Here: commit 92b97f0aaccbf9de4a29696e6253bf82e8850d1d Author: Russell King Date: Sun Aug 14 09:13:48 2011 +0100 PM: add

Re: [RFC PATCH 01/13] ARM: davinci: move private EDMA API to arm/common

2012-09-21 Thread Russell King - ARM Linux
On Fri, Sep 21, 2012 at 02:34:46PM -0400, Matt Porter wrote: > On Fri, Sep 21, 2012 at 10:42:05AM +0100, Russell King wrote: > > Here's the pertinant question: "is it platform data?" Looking at the > > file, it appears to be internal data structures and register

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-21 Thread Russell King - ARM Linux
On Fri, Sep 21, 2012 at 10:45:29PM +0530, S, Venkatraman wrote: > On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter wrote: > > The EDMA DMAC has a hardware limitation that prevents supporting > > scatter gather lists with any number of segments. Since the EDMA > > DMA Engine driver sets the maximum seg

Re: [RFC PATCH 01/13] ARM: davinci: move private EDMA API to arm/common

2012-09-21 Thread Russell King - ARM Linux
On Fri, Sep 21, 2012 at 09:33:42AM +, Hebbar, Gururaja wrote: > On Fri, Sep 21, 2012 at 14:59:23, Russell King - ARM Linux wrote: > > On Thu, Sep 20, 2012 at 10:43:34AM -0400, Matt Porter wrote: > > > Move mach-davinci/dma.c to common/edma.c so it can be used > > > b

Re: [RFC PATCH 01/13] ARM: davinci: move private EDMA API to arm/common

2012-09-21 Thread Russell King - ARM Linux
On Thu, Sep 20, 2012 at 10:43:34AM -0400, Matt Porter wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx atm) as well. This just moves > the private EDMA API but does not support OMAP. > > Signed-off-by: Matt Porter > --- > arch/arm/Kconfig

Re: [PATCH 1/3] dmaengine: add TI EDMA DMA engine driver

2012-08-16 Thread Russell King - ARM Linux
On Thu, Aug 16, 2012 at 05:44:29PM -0400, Matt Porter wrote: > Add a DMA engine driver for the TI EDMA controller. This driver > is implemented as a wrapper around the existing DaVinci private > DMA implementation. This approach allows for incremental conversion > of each peripheral driver to the D

Re: [PATCH] SPI: OMAP: fix over-eager devm_xxx() conversion (was: Re: [CFT 07/11] spi: omap2-mcspi: add DMA engine support)

2012-06-16 Thread Russell King - ARM Linux
Okay, I'm going to queue this up in my tree for -rc as no one seems to be listening to any of the emails I've sent on Thursday. On Thu, Jun 14, 2012 at 03:07:12PM +0100, Russell King - ARM Linux wrote: > From: Russell King > Subject: [PATCH] SPI: OMAP: fix over-eager devm_

Re: [CFT 07/11] spi: omap2-mcspi: add DMA engine support

2012-06-14 Thread Russell King - ARM Linux
On Thu, Jun 14, 2012 at 01:08:43PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 14, 2012 at 12:53:35PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 07, 2012 at 12:08:35PM +0100, Russell King wrote: > > > Add DMA engine support to the OMAP SPI driver. Th

[PATCH] SPI: OMAP: fix over-eager devm_xxx() conversion (was: Re: [CFT 07/11] spi: omap2-mcspi: add DMA engine support)

2012-06-14 Thread Russell King - ARM Linux
From: Russell King Subject: [PATCH] SPI: OMAP: fix over-eager devm_xxx() conversion 1a77b127ae (OMAP : SPI : use devm_* functions) converted the SPI device controller state to use devm_kzalloc(). Unfortunately, this is used against an unbound struct device, which results in the following when

Re: [CFT 07/11] spi: omap2-mcspi: add DMA engine support

2012-06-14 Thread Russell King - ARM Linux
On Thu, Jun 14, 2012 at 12:53:35PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 07, 2012 at 12:08:35PM +0100, Russell King wrote: > > Add DMA engine support to the OMAP SPI driver. This supplements the > > private DMA API implementation contained within this driver, and the

Re: [CFT 07/11] spi: omap2-mcspi: add DMA engine support

2012-06-14 Thread Russell King - ARM Linux
On Thu, Jun 07, 2012 at 12:08:35PM +0100, Russell King wrote: > Add DMA engine support to the OMAP SPI driver. This supplements the > private DMA API implementation contained within this driver, and the > driver can be independently switched at build time between using DMA > en

[CFT 07/11] spi: omap2-mcspi: add DMA engine support

2012-06-07 Thread Russell King
Acked-by: Grant Likely Signed-off-by: Russell King --- drivers/spi/spi-omap2-mcspi.c | 183 +--- 1 files changed, 151 insertions(+), 32 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 46ef5fe..ca016df 100644

[CFT 08/11] spi: omap2-mcspi: remove private DMA API implementation

2012-06-07 Thread Russell King
Remove the private DMA API implementation from spi-omap2-mcspi.c, making it use entirely the DMA engine API. Acked-by: Grant Likely Signed-off-by: Russell King --- drivers/spi/spi-omap2-mcspi.c | 104 ++--- 1 files changed, 5 insertions(+), 99 deletions

[PATCH 11/12] spi: omap2-mcspi: remove private DMA API implementation

2012-04-23 Thread Russell King
Remove the private DMA API implementation from spi-omap2-mcspi.c, making it use entirely the DMA engine API. Signed-off-by: Russell King --- drivers/spi/spi-omap2-mcspi.c | 104 ++--- 1 files changed, 5 insertions(+), 99 deletions(-) diff --git a/drivers

[PATCH 10/12] spi: omap2-mcspi: add DMA engine support

2012-04-23 Thread Russell King
Signed-off-by: Russell King --- drivers/spi/spi-omap2-mcspi.c | 184 ++--- 1 files changed, 152 insertions(+), 32 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index bb9274c..b2461d7 100644 --- a/drivers/spi/spi

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-10 Thread Russell King - ARM Linux
On Tue, Apr 10, 2012 at 09:35:43AM +0100, Mark Brown wrote: > On Tue, Apr 10, 2012 at 09:31:30AM +0100, Russell King - ARM Linux wrote: > > On Fri, Apr 06, 2012 at 03:49:45PM +0800, Shawn Guo wrote: > > > I believe this patch fixes the amba probe failure that impacts any > &g

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-10 Thread Russell King - ARM Linux
On Fri, Apr 06, 2012 at 03:49:45PM +0800, Shawn Guo wrote: > I believe this patch fixes the amba probe failure that impacts any > AMBA platform build with CONFIG_REGULATOR enabled. Could you consider > to send the fix for -rc soon? No idea. I don't have Mark's patch in the patch system. > The p

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-02 Thread Russell King - ARM Linux
On Mon, Apr 02, 2012 at 12:34:13PM +0100, Mark Brown wrote: > On Mon, Apr 02, 2012 at 11:43:57AM +0100, Russell King - ARM Linux wrote: > > On Mon, Apr 02, 2012 at 11:14:28AM +0100, Mark Brown wrote: > > > > I was waiting for some pronouncement from Russell - looking at

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-02 Thread Russell King - ARM Linux
On Mon, Apr 02, 2012 at 11:14:28AM +0100, Mark Brown wrote: > On Mon, Apr 02, 2012 at 12:39:11AM +0200, Linus Walleij wrote: > > > Mark: as Rabin says the v1 patch is probably fine, are you pushing this > > to ARM SoC or into Russell's patch tracker? > > I was waiting for some pronouncement from

[SPI] Fix section mismatch in spi-pl022.c

2012-02-13 Thread Russell King - ARM Linux
From: Russell King WARNING: drivers/spi/built-in.o(.devinit.text+0xdb8): Section mismatch in reference from the function pl022_probe() to the function .init.text:pl022_dma_probe() The function __devinit pl022_probe() references a function __init pl022_dma_probe(). If pl022_dma_probe is only

Re: [PATCH v2] spi: QUP based bus driver for Qualcomm MSM chipsets

2012-01-23 Thread Russell King - ARM Linux
Not specific to this patch, but I notice that you have in your headers: In-Reply-To: References: This is rather annoying, because it means that anyone else who has the same lines ends up having their messages attached to your messages as part of the same thread. I think you need to read the do

Re: [PATCH] RFC: spi/sa1100: rewrite the SA1100 SPI driver

2012-01-19 Thread Russell King - ARM Linux
On Thu, Jan 19, 2012 at 06:49:25PM +0100, Linus Walleij wrote: > On Wed, Jan 18, 2012 at 1:30 PM, Russell King - ARM Linux > wrote: > > On Wed, Jan 18, 2012 at 01:13:29PM +0100, Linus Walleij wrote: > > >> We usually merge drivers for microwire, TI, Motorola ... etc into

Re: [PATCH] RFC: spi/sa1100: rewrite the SA1100 SPI driver

2012-01-18 Thread Russell King - ARM Linux
On Wed, Jan 18, 2012 at 12:30:37PM +, Russell King - ARM Linux wrote: > On Wed, Jan 18, 2012 at 01:13:29PM +0100, Linus Walleij wrote: > > On Wed, Jan 18, 2012 at 12:13 AM, Russell King - ARM Linux > > wrote: > > > > > Please don't delete the above def

Re: [PATCH] RFC: spi/sa1100: rewrite the SA1100 SPI driver

2012-01-18 Thread Russell King - ARM Linux
On Wed, Jan 18, 2012 at 01:13:29PM +0100, Linus Walleij wrote: > On Wed, Jan 18, 2012 at 12:13 AM, Russell King - ARM Linux > wrote: > > > Please don't delete the above definitions. > > OK don't want to break anything... > > > The SSP interface is m

Re: [PATCH] RFC: spi/sa1100: rewrite the SA1100 SPI driver

2012-01-17 Thread Russell King - ARM Linux
On Wed, Jan 18, 2012 at 12:00:36AM +0100, Linus Walleij wrote: > diff --git a/arch/arm/mach-sa1100/include/mach/SA-1100.h > b/arch/arm/mach-sa1100/include/mach/SA-1100.h > index bae8296..ed68746 100644 > --- a/arch/arm/mach-sa1100/include/mach/SA-1100.h > +++ b/arch/arm/mach-sa1100/include/mach/SA

Re: [GIT PULL] ARM: amba: Enable module alias autogeneration for AMBA drivers

2011-12-22 Thread Russell King - ARM Linux
On Thu, Dec 22, 2011 at 11:21:25AM +, Dave Martin wrote: > On Mon, Dec 19, 2011 at 09:39:42PM +0000, Russell King - ARM Linux wrote: > > I have pulled it, I just haven't merged it in anywhere yet. > > OK, great -- thanks. > > I wasn't too familiar with the proc

Re: [GIT PULL] ARM: amba: Enable module alias autogeneration for AMBA drivers

2011-12-19 Thread Russell King - ARM Linux
On Mon, Dec 19, 2011 at 01:24:09PM +, Dave Martin wrote: > Hi Russell, > > This one isn't urgent, but I'm not seeing the amba modalias patches > anywhere yet. Did you have any outstanding concerns which need to be > resolved? > > If you can suggest when/if these are likely to merge that woul

Re: [PATCH 1/2 v4] atmel/spi: fix missing probe

2011-11-03 Thread Russell King - ARM Linux
On Fri, Nov 04, 2011 at 01:57:40AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: > Commit 940ab889 "drivercore: Add helper macro for platform_driver boilerplate" > converted this driver to use module_platform_driver, but due to the use > of platform_driver_probe(), this resulted in the call to at

Re: [PATCH v2] atmel/spi: fix missing probe during the switch to module_platform_driver

2011-11-03 Thread Russell King - ARM Linux
On Thu, Nov 03, 2011 at 07:03:38PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:43 Thu 03 Nov , Russell King - ARM Linux wrote: > > On Thu, Nov 03, 2011 at 05:51:13PM +0100, Jean-Christophe PLAGNIOL-VILLARD > > wrote: > > > this is an other fix I do not wa

Re: [PATCH v2] atmel/spi: fix missing probe during the switch to module_platform_driver

2011-11-03 Thread Russell King - ARM Linux
On Thu, Nov 03, 2011 at 05:51:13PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > this is an other fix I do not want to fix 2 issue in one commit and I do care > of mismatch erros I fix them all the time I send patch for some rm9200 few > weeks ago It should not be a separate patch - it's all t

Re: [PATCH v2] atmel/spi: fix missing probe during the switch to module_platform_driver

2011-11-03 Thread Russell King - ARM Linux
On Thu, Nov 03, 2011 at 11:10:42PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: > in commit 940ab889 This kind of commit message is, frankly, utter crap. With all the complaints that have been on this mailing list about raw commit IDs without saying what the commit was, it completely astounds

Re: [PATCH] spi/pl022: Enable clock in probe an use runtime_idle

2011-11-03 Thread Russell King - ARM Linux
On Thu, Nov 03, 2011 at 02:59:53PM +0100, Ulf Hansson wrote: >>> @@ -2342,11 +2350,19 @@ static int pl022_runtime_resume(struct device *dev) >>> return 0; >>> } >>> + >>> +static int pl022_runtime_idle(struct device *dev) >>> +{ >>> + pm_runtime_suspend(dev); >>> + return 0; >>> +} >>> #e

Re: [PATCH] spi/pl022: Enable clock in probe an use runtime_idle

2011-11-02 Thread Russell King - ARM Linux
On Fri, Oct 21, 2011 at 04:08:44PM +0200, Ulf Hansson wrote: > Since we are always runtime resumed when leaving probe > the clock must be enabled. To accomplish that we are able > to be runtime suspended after probe in the case when no > request is going to be recieved, a runtime_idle function > ha

Re: [PATCH] spi/pl022: Enable clock in probe an use runtime_idle

2011-10-24 Thread Russell King - ARM Linux
On Mon, Oct 24, 2011 at 02:03:42PM +0200, Grant Likely wrote: > On Fri, Oct 21, 2011 at 04:08:44PM +0200, Ulf Hansson wrote: > > Since we are always runtime resumed when leaving probe > > the clock must be enabled. To accomplish that we are able > > to be runtime suspended after probe in the case w

Re: [PATCH 3/3] spi/pl022: skip default configuration before suspending

2011-10-18 Thread Russell King - ARM Linux
On Tue, Oct 18, 2011 at 02:43:34PM +0530, Viresh Kumar wrote: > On 10/17/2011 6:42 PM, Linus WALLEIJ wrote: > > From: Virupax Sadashivpetimath > > > > The loading of the default configuration before suspending has > > been in the driver since its inception, but it is not really > > needed. Especi

Re: [PATCH 2/3] spi/pl022: disable the PL022 block when unused

2011-10-18 Thread Russell King - ARM Linux
On Tue, Oct 18, 2011 at 02:43:27PM +0530, Viresh Kumar wrote: > On 10/17/2011 6:42 PM, Linus WALLEIJ wrote: > > From: Virupax Sadashivpetimath > > > > Make sure we clear the enable bit when the block is not used. > > This will save some energy in certain hardware versions. > > > > Signed-off-by:

Re: [PATCH] spi: Fix builderror in spi-pl022.c

2011-09-21 Thread Russell King - ARM Linux
On Tue, Sep 20, 2011 at 10:45:41PM +0200, Linus Walleij wrote: > On Mon, Sep 5, 2011 at 2:45 PM, Linus Walleij > wrote: > > On Sun, Aug 28, 2011 at 9:26 PM, Peter Huewe wrote: > > > >> This patch fixes a build error, introduced by commit (67fc8b9f, "PM: add > >> runtime PM support to core Primec

Re: [PATCH] spi: Fix builderror in spi-pl022.c

2011-08-28 Thread Russell King - ARM Linux
On Sun, Aug 28, 2011 at 09:26:59PM +0200, Peter Huewe wrote: > This patch fixes a build error, introduced by commit (67fc8b9f, "PM: add > runtime PM support to core Primecell driver") which unfortunately was a little > bit incomplete and did contain a typo (11 instead of 22). > I'm not sure how thi

Re: [PATCH V2 6/6] spi/spi-pl022: Request/free DMA channels as and when required.

2011-08-10 Thread Russell King - ARM Linux
On Wed, Aug 10, 2011 at 04:01:13PM +0530, Jassi Brar wrote: > On Wed, Aug 10, 2011 at 3:31 PM, Koul, Vinod wrote: > > On Wed, 2011-08-10 at 14:59 +0530, viresh kumar wrote: > >> On 08/10/2011 02:30 PM, Russell King - ARM Linux wrote: > >> >> > They must be

Re: [PATCH V2 6/6] spi/spi-pl022: Request/free DMA channels as and when required.

2011-08-10 Thread Russell King - ARM Linux
On Wed, Aug 10, 2011 at 03:44:13PM +0530, viresh kumar wrote: > On 08/10/2011 03:31 PM, Koul, Vinod wrote: > > And on your patch, are you able to dynamically assign the channels for > > platform? What is the intended usage? (as Russell articulated it is bad > > to dynamically assign channel for som

Re: [PATCH V2 6/6] spi/spi-pl022: Request/free DMA channels as and when required.

2011-08-10 Thread Russell King - ARM Linux
On Wed, Aug 10, 2011 at 03:39:28PM +0530, Jassi Brar wrote: > On Wed, Aug 10, 2011 at 2:59 PM, viresh kumar wrote: > > On 08/10/2011 02:30 PM, Russell King - ARM Linux wrote: > >>> > They must be allocated when they are required and must be freed after > >>>

Re: [PATCH V2 6/6] spi/spi-pl022: Request/free DMA channels as and when required.

2011-08-10 Thread Russell King - ARM Linux
On Wed, Aug 10, 2011 at 03:31:42PM +0530, Koul, Vinod wrote: > I would agree on both counts :) > > In some cases it does make sense to hold the channel for the lifetime > like uart or where the channel has been tied to an interface by SoC > designer. > But in some cases like dw_dmac it seems you c

Re: [PATCH V2 6/6] spi/spi-pl022: Request/free DMA channels as and when required.

2011-08-10 Thread Russell King - ARM Linux
On Wed, Aug 10, 2011 at 02:20:59PM +0530, Viresh Kumar wrote: > Currently we request DMA channels at probe time and free them at remove. They > are always occupied, irrespective of their usage. > > They must be allocated when they are required and must be freed after we are > done with transfers.

Re: [PATCH V2 3/6] spi/spi-pl022: Don't allocate more sg than required.

2011-08-10 Thread Russell King - ARM Linux
On Wed, Aug 10, 2011 at 02:20:56PM +0530, Viresh Kumar wrote: > In routine configure_dma(), if transfer->len = PAGE_SIZE, then pages is one > more > than required. While leads to one more sg getting allocated. > > This is wrong. Correct this to allocate correct number of sg. > > Signed-off-by: V

Re: [PATCH v3] pxa2xx_spi: fix memory corruption

2011-07-18 Thread Russell King - ARM Linux
On Fri, Jul 15, 2011 at 03:31:06PM -0600, Grant Likely wrote: > ... plus care must be taken not to accidentally reload the line into > cache after it has been pushed out for DMA, which is a risk on > structures with embedded DMA buffers if other non-DMA elements end up > in the same cache line. Th

Re: [PATCH v3] pxa2xx_spi: fix memory corruption

2011-07-15 Thread Russell King - ARM Linux
On Fri, Jul 15, 2011 at 01:50:03PM -0600, Grant Likely wrote: > On Fri, Jul 15, 2011 at 09:12:42AM +0100, Russell King - ARM Linux wrote: > > On Thu, Jul 14, 2011 at 08:53:31PM -0600, Grant Likely wrote: > > > > + u8 null_dma_buf_unaligned[16]; > > > > >

Re: [PATCH v3] pxa2xx_spi: fix memory corruption

2011-07-15 Thread Russell King - ARM Linux
On Thu, Jul 14, 2011 at 08:53:31PM -0600, Grant Likely wrote: > > + u8 null_dma_buf_unaligned[16]; > > Don't dma buffers need to be cache-line aligned? How large is the > actual transfer? Using the __aligned() or __cacheline_aligned > attribute is the correct way to make sure you've got a data

Re: [PATCH] pxa2xx_spi: fix memory corruption

2011-07-09 Thread Russell King - ARM Linux
On Sun, Jul 10, 2011 at 01:05:48AM +0200, Marek Vasut wrote: > On Saturday, July 09, 2011 11:14:58 PM Vasily Khoruzhick wrote: > > pxa2xx_spi_probe allocates struct driver_data and null_dma_buf > > at same time via spi_alloc_master(), but then calculates > > null_dma_buf pointer incorrectly, and it

Re: [PATCH] spi: reorganize drivers

2011-06-06 Thread Russell King - ARM Linux
On Mon, Jun 06, 2011 at 08:39:04AM -0600, Grant Likely wrote: > However, there are a number of bus types that have infrastructure, but > no actual drivers associated with them, like mca, amba and clk. It > might make sense to move those bus types into drivers/base alongside > the platform_bus_type

Re: [PATCH] spi: reorganize drivers

2011-06-06 Thread Russell King - ARM Linux
On Mon, Jun 06, 2011 at 11:00:38AM +0200, Arnd Bergmann wrote: > This leaves out the two most common buses, USB and PCI, mostly because > the directories contain a lot of stuff that is not really bus code > but actual drivers. It does include i2c and spi, which stick out by > being a lot larger tha

Re: [PATCH 1/5] dmaengine: add ep93xx DMA support

2011-05-26 Thread Russell King - ARM Linux
On Thu, May 26, 2011 at 01:48:12PM -0500, H Hartley Sweeten wrote: > I think the biggest hurdle with using the amba-pl022 driver is that the ep93xx > spi peripheral does not have the registers with the pid and cid id's. Without > those I don't think the amba bus driver will be able to match the de

Re: [PATCH resend] spi/amba-pl022: work in polling or interrupt mode if pl022_dma_probe fails

2011-05-16 Thread Russell King - ARM Linux
On Mon, May 16, 2011 at 04:56:59PM +0530, viresh kumar wrote: > On 05/16/2011 04:34 PM, Russell King - ARM Linux wrote: > > On Mon, May 16, 2011 at 09:40:10AM +0530, Viresh Kumar wrote: > >> > If pl022_dma_probe fails, we can try to transfer data in polling or > >>

Re: [PATCH resend] spi/amba-pl022: work in polling or interrupt mode if pl022_dma_probe fails

2011-05-16 Thread Russell King - ARM Linux
On Mon, May 16, 2011 at 09:40:10AM +0530, Viresh Kumar wrote: > If pl022_dma_probe fails, we can try to transfer data in polling or interrupt > mode. Also, set platform_info->enable_dma to 0, so that no other code tries to > use dma. > > Signed-off-by: Viresh Kumar > Acked-by: Linus Walleij Sho

Re: [PATCH] spi: tegra: don't treat NULL clk as an error

2011-01-10 Thread Russell King - ARM Linux
On Mon, Jan 10, 2011 at 04:24:17PM -0700, Grant Likely wrote: > I was actually looking at the implementation of clk_enable() which is > called by the driver and doesn't do any NULL checking. But I suppose > that it then becomes the clock-code's own fault if it returns NULL and > then oopses on a N

Re: [PATCH] spi: tegra: don't treat NULL clk as an error

2011-01-10 Thread Russell King - ARM Linux
On Mon, Jan 10, 2011 at 10:18:02PM +, Russell King - ARM Linux wrote: > On Mon, Jan 10, 2011 at 01:58:12PM -0700, Grant Likely wrote: > > On Mon, Jan 10, 2011 at 4:05 AM, Jamie Iles wrote: > > > Some platforms have been known to return NULL from clk_get() if they > >

Re: [PATCH] spi: tegra: don't treat NULL clk as an error

2011-01-10 Thread Russell King - ARM Linux
On Mon, Jan 10, 2011 at 01:58:12PM -0700, Grant Likely wrote: > On Mon, Jan 10, 2011 at 4:05 AM, Jamie Iles wrote: > > Some platforms have been known to return NULL from clk_get() if they > > support only a single struct clk.  Whilst tegra doesn't do this, make > > the drivers consistent with othe

Re: [sodaville] [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

2010-11-26 Thread Russell King - ARM Linux
On Fri, Nov 26, 2010 at 11:50:28AM +0100, Sebastian Andrzej Siewior wrote: > * Russell King - ARM Linux | 2010-11-25 23:54:15 [+]: > > >Why should the PXA code change when you haven't explained _why_ you want > >to change the SPI driver to conform to your idea? > &

Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

2010-11-26 Thread Russell King - ARM Linux
On Thu, Nov 25, 2010 at 06:14:49PM -0700, Grant Likely wrote: > On Thu, Nov 25, 2010 at 4:54 PM, Russell King - ARM Linux > wrote: > > On Wed, Nov 24, 2010 at 04:39:05PM +0100, Sebastian Andrzej Siewior wrote: > >> Mark Brown wrote: > >>> On Wed, Nov 24, 20

Re: [PATCH 1/9] spi/pxa2xx: don't use subys initcall for driver init

2010-11-25 Thread Russell King - ARM Linux
On Wed, Nov 24, 2010 at 04:39:05PM +0100, Sebastian Andrzej Siewior wrote: > Mark Brown wrote: >> On Wed, Nov 24, 2010 at 03:09:25PM +0100, Sebastian Andrzej Siewior wrote: >> >>> I've been pointed out to this commit but I don't understand _why_. >>> The part I don't get is "so it can be used with

Re: [PATCH v5 01/12] misc: add driver for sequencer serial port

2010-11-16 Thread Russell King - ARM Linux
On Tue, Nov 16, 2010 at 01:35:40PM -0700, Grant Likely wrote: > I'll let Russel make the decision here; but I must admit I'm puzzled. ^ Grr. I'm ambivalent over it, provided that the author realises that the __raw variants have no ordering guarantees other than their accesses bein

Re: [PATCH v3 01/12] misc: add driver for sequencer serial port

2010-10-22 Thread Russell King - ARM Linux
On Fri, Oct 22, 2010 at 03:33:43PM -0400, Cyril Chemparathy wrote: > On 10/22/2010 08:48 AM, Arnd Bergmann wrote: > > On Friday 22 October 2010 14:39:33 Cyril Chemparathy wrote: > +/* Register Access Helpers */ > +static inline u32 ssp_read(struct ti_ssp *ssp, int reg) > +{ > +

Re: [PATCH 04/16] spi/imx: save the spi chip select in config struct, not the gpio to use

2010-09-17 Thread Russell King - ARM Linux
On Fri, Sep 17, 2010 at 01:11:14PM +0200, Lothar Waßmann wrote: > Hi, > > > diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c > > index 60a52d1..23db984 100644 > > --- a/drivers/spi/spi_imx.c > > +++ b/drivers/spi/spi_imx.c > > @@ -56,7 +56,7 @@ struct spi_imx_config { > > unsigned in

Re: [spi-devel-general] [PATCH] spi: add spi_tegra driver

2010-08-12 Thread Russell King - ARM Linux
On Wed, Aug 11, 2010 at 05:31:00PM -0700, Erik Gilling wrote: > >> +       if (!request_mem_region(r->start, (r->end - r->start) + 1, > >> +                       dev_name(&pdev->dev))) { > >> +               ret = -EBUSY; > >> +               goto err0; > >> +       } > > > > I believe the platfor

Re: [spi-devel-general] [PATCH v6 2/2] ep93xx: SPI driver platform support code

2010-05-05 Thread Russell King - ARM Linux
On Tue, May 04, 2010 at 12:21:36PM -0500, H Hartley Sweeten wrote: > That patch is already present in linux-next. If Russell think there might > be an issue you could rebase this patch on the linux-next tree. If this patch depends on 5998/1, then I'll take it via the ep93xx branch (which has 5998

Re: [spi-devel-general] [PATCH] ARM: Add spi controller driver support for NUC900

2009-11-19 Thread Russell King - ARM Linux
On Thu, Nov 19, 2009 at 05:49:22PM +0800, Wan ZongShun wrote: > 2009/11/19 Russell King - ARM Linux : > > On Thu, Nov 19, 2009 at 04:40:50PM +0800, Wan ZongShun wrote: > >> 2009/11/19 Andrew Morton : > >> > I don't know, because I don't know what operation t

Re: [spi-devel-general] [PATCH] ARM: Add spi controller driver support for NUC900

2009-11-19 Thread Russell King - ARM Linux
On Thu, Nov 19, 2009 at 04:40:50PM +0800, Wan ZongShun wrote: > 2009/11/19 Andrew Morton : > > I don't know, because I don't know what operation the hardware needs to > > stop it from generating interrupts.  Perhaps that's clk_disable()? > > The interrupt will be not occur as long as I run clk_dis

Re: [spi-devel-general] [PATCH] U300 SSP/SPI board setup and test

2009-08-13 Thread Russell King - ARM Linux
On Mon, Aug 10, 2009 at 04:27:13PM +0200, Linus Walleij wrote: > This adds a U300 board configuration for the PL022 SSP/SPI > PrimeCell driver recently merged to the 2.6.31-rc series. > Further it adds a dummy loopback SPI chip that can be used > for testing the SPI functionality on a running syste

Re: [spi-devel-general] [PATCH] rename spi device in clock api for w90p910

2009-07-22 Thread Russell King - ARM Linux
On Wed, Jul 22, 2009 at 06:28:11PM +0800, Wan ZongShun wrote: > When programming clock api, I named this spi device > as w90p910-usi, now, I think named it as w90p910-spi better Ok. In terms of patch ordering, I think this patch should be applied before the patch adding the spi device. -

Re: [spi-devel-general] [PATCH] Add spi resource define for w90p910 spi driver

2009-07-22 Thread Russell King - ARM Linux
On Wed, Jul 22, 2009 at 06:25:41PM +0800, Wan ZongShun wrote: > This is a spi resource define patch for w90p910 spi driver. Ok. -- ___ spi-devel-general mailing list spi-devel-g

Re: [spi-devel-general] [PATCH 1/1] ARM PL022 SSP/SPI driver v2

2009-06-01 Thread Russell King - ARM Linux
On Mon, Jun 01, 2009 at 02:02:39PM +0200, Linus Walleij wrote: > +#include Last question from me I think - does it actually require this include? (it's nice to see drivers without any asm/ includes.) -- Register Now for

Re: [spi-devel-general] [RFC] generic iMX-spi driver

2009-04-30 Thread Russell King - ARM Linux
On Thu, Apr 30, 2009 at 11:44:43PM +0200, Guennadi Liakhovetski wrote: > what's the state of this patch? Is a new revision planned soon to go in > for 2.6.31? No idea, as far as I can see after my last comments, it's dead. -

Re: [spi-devel-general] [RFC] generic iMX-spi driver

2009-03-02 Thread Russell King - ARM Linux
On Fri, Feb 27, 2009 at 11:38:40AM +0100, Wolfram Sang wrote: > > What it does do though is want to naturally align structure members, so > > it's a good idea to group u8's together up to the next members natural > > boundary. So: > > All the hot-path variables are u32 as I don't want to do shift

Re: [spi-devel-general] [RFC] generic iMX-spi driver

2009-02-26 Thread Russell King - ARM Linux
On Thu, Feb 26, 2009 at 11:38:44AM +0100, Wolfram Sang wrote: > On Fri, Feb 20, 2009 at 04:41:21PM +0100, Holger Schurig wrote: > > > +struct spi_core_version { > > > + u32 rxdata; > > > + u32 txdata; > > > + u32 ctrl; > > > + u32 int_en; > > > + u32 status; > > > + u32 test; > > > + u32 period; >

Re: [spi-devel-general] [PATCH] jffs2 summary allocation

2008-04-04 Thread Russell King - ARM Linux
On Fri, Apr 04, 2008 at 12:48:12PM -0700, Andrew Morton wrote: > On Fri, 4 Apr 2008 10:23:55 + (GMT) > Michael Trimarchi <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > I apply this patch to fix this oops. > > > > > > Unable to handle kernel NULL pointer dereference at virtual address