Re: [v2,2/2] spi: bitbang: convert to using core message queue

2013-07-17 Thread Uwe Kleine-König
...@gmx.de It works fine for me on an efm32 board communicating with an ks8851. Maybe the mmc problem is to be found in the mmc subsystem? Tested-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH] spi/imx: set the inactive state of the clock according to the clock polarity

2012-09-21 Thread Uwe Kleine-König
___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH] Revert spi/doc: spi_master_put must be followed up by kfree

2012-09-04 Thread Uwe Kleine-König
) { -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- Live Security Virtual Conference Exclusive live event will cover all the ways

Re: [PATCH v2 00/25] make *struct of_device_id.data const

2012-08-05 Thread Uwe Kleine-König
: make data used as *of_device_id.data const Uwe Kleine-König (17): spi/imx: make spi_imx_data.devtype_data member point to const data spi/spi-omap2-mcspi: add a const qualifier serial/imx: make imx_port.devdata member point to const data serial/mpc52xx_uart: add a const

[PATCH 01/25] spi/imx: make spi_imx_data.devtype_data member point to const data

2012-07-23 Thread Uwe Kleine-König
] Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/spi-imx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 47877d6..b09fc77 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -97,7

[PATCH 02/25] spi/spi-omap2-mcspi: add a const qualifier

2012-07-23 Thread Uwe Kleine-König
-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/spi-omap2-mcspi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 0c73dd4..3455769 100644 --- a/drivers/spi/spi-omap2-mcspi.c +++ b/drivers

[PATCH 19/25] of: add const to struct *of_device_id.data

2012-07-23 Thread Uwe Kleine-König
Drivers should never need to modify the data of a device id. So it can be const which in turn allows more consts in the driver. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- include/linux/mod_devicetable.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 00/25] make *struct of_device_id.data const

2012-07-23 Thread Uwe Kleine-König
/mediabay: make data used as *of_device_id.data const can: mpc5xxx_can: make data used as *of_device_id.data const Marc Kleine-Budde (1): can: mpc5xxx_can: make data in mpc5xxx_can_probe const Uwe Kleine-König (18): spi/imx: make spi_imx_data.devtype_data member point to const data spi/spi-omap2

Re: [PATCH 00/11] make struct of_device_id.data const

2012-07-13 Thread Uwe Kleine-König
Hello, On Fri, Jul 13, 2012 at 02:32:02PM +0200, y...@pengutronix.de wrote: This is utter non-sense, it was me who sent these mails (and pressed 'y' when git send-email asked if Uwe Kleine-König u.kleine-koe...@pengutronix.de is the right sender). Please make sure to correct this when replying

Re: [PATCH RFC] spi/gpio: start with CS non-active

2012-07-05 Thread Uwe Kleine-König
On Thu, Feb 09, 2012 at 10:21:45PM +0100, Uwe Kleine-König wrote: The chip select line was configured as output with the initial value being active explicitly. It was later deasserted during spi_bitbang_setup() without any clock activity in between. So it makes no sense to activate the device

Re: [PATCH] spi/imx: make devtype_data member point to const data

2012-06-21 Thread Uwe Kleine-König
Hi Grant, On Mon, May 21, 2012 at 09:49:35PM +0200, Uwe Kleine-König wrote: This is only cosmetic for now. In case that http://mid.gmane.org/1335171381-24869-1-git-send-email-u.kleine-koe...@pengutronix.de will be applied, it fixes a warning drivers/spi/spi-imx.c

[PATCH] spi/imx: make devtype_data member point to const data

2012-05-21 Thread Uwe Kleine-König
discards const qualifier from pointer target type [enabled by default] though. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/spi-imx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 570f220

Re: mc13xxx: add I2C support, V5

2012-04-02 Thread Uwe Kleine-König
. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- This SF email is sponsosred by: Try Windows

[PATCH] spi/imx: mark base member in spi_imx_data as __iomem

2012-03-29 Thread Uwe Kleine-König
-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/spi-imx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 31054e3..373f4ff 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -83,7 +83,7

Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-27 Thread Uwe Kleine-König
Hello Fabio, On Mon, Mar 26, 2012 at 11:19:42PM -0300, Fabio Estevam wrote: On 3/26/2012 5:59 PM, Uwe Kleine-König wrote: In my version of drivers/spi/spi-imx.c struct spi_imx_data is only defined once. I guess you wanted to say forward declaration. Yes, correct. ... Does

Re: [PATCH v2 1/3] mfd: mc13xxx-core: Prepare for separate spi and i2c backends.

2012-03-11 Thread Uwe Kleine-König
these two lines. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- Virtualization Cloud Management

[PATCH] spi: controller drivers don't need to depend on SPI_MASTER explicitly

2012-02-23 Thread Uwe Kleine-König
They are all defined in an if SPI_MASTER ... endif block. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/Kconfig | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 8293658..c1fb568

[PATCH] spi/doc: spi_master_put must be followed up by kfree

2012-02-23 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/spi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index b2ccdea..4be88d7 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -539,7 +539,8

[PATCH RFC] spi/gpio: start with CS non-active

2012-02-09 Thread Uwe Kleine-König
-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- Hello, I'm not sure if an active chip select line without any clock activity can confuse a device. If so, this patch might qualify as fix. But with my limited knowledge about spi it's also possible that I just miss why the active chip

Re: [PATCH 1/3] mc13xxx-core: Prepare for separate spi and i2c backends.

2012-01-19 Thread Uwe Kleine-König
with the patch. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- Keep Your Developer Skills

Re: [PATCH 2/3] mfd: mc13xxx-core: Move spi specific code into separate module.

2012-01-19 Thread Uwe Kleine-König
; +}; + this should go to drivers/mfd/mc13xxx.h, too. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH v2] spi/imx: Fix spi-imx when the hardware SPI chipselects are used

2011-09-15 Thread Uwe Kleine-König
0) continue; - spi_imx-chipselect[i] = cs_gpio; + ret = gpio_request(spi_imx-chipselect[i], DRIVER_NAME); if (ret) { while (i 0) { -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH v2] spi/imx: Fix spi-imx when the hardware SPI chipselects are used

2011-09-15 Thread Uwe Kleine-König
Hello again, On Thu, Sep 15, 2011 at 09:52:43PM +0200, Uwe Kleine-König wrote: diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 8ac6542..fa594d6 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -786,9 +786,11 @@ static int __devinit spi_imx_probe(struct

Re: [PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data

2011-07-11 Thread Uwe Kleine-König
-- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- All of the data generated in your IT infrastructure is seriously valuable

Re: [PATCH v2 2/7] spi/imx: use mx21 to name SPI_IMX_VER_0_0 function and macro

2011-07-11 Thread Uwe Kleine-König
= mx21_trigger, + .rx_available = mx21_rx_available, + .reset = mx21_reset, .fifosize = 8, }, #endif -- 1.7.4.1 -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http

Re: [PATCH v2 4/7] spi/imx: merge type SPI_IMX_VER_0_7 into SPI_IMX_VER_0_4

2011-07-11 Thread Uwe Kleine-König
also get cleaned up. s/useless/unused/? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- All

Re: [PATCH v2 6/7] spi/imx: copy gpio number passed by platform data into driver private data

2011-07-11 Thread Uwe Kleine-König
@linaro.org Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: Sascha Hauer s.ha...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca --- drivers/spi/spi-imx.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers

Re: [PATCH v4 2/4] mc13xxx-core: Kconfig: Config menu driven by specific IC type

2011-02-22 Thread Uwe Kleine-König
the spi and i2c backends to dedicated files. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

[PATCH 1/2] spi/bitbang: check for setup_transfer during initialization

2011-02-08 Thread Uwe Kleine-König
From: Sascha Hauer s.ha...@pengutronix.de setup_transfer is mandatory if spi_bitbang_transfer is used, so check for it during initialization and not each time during runtime. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de

[PATCH 2/2] [RFC] spi/bitbang: Use a kthread worker instead of workqueue

2011-02-08 Thread Uwe Kleine-König
-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/spi_bitbang.c | 17 ++--- include/linux/spi/spi_bitbang.h |7 --- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/spi/spi_bitbang.c b/drivers/spi/spi_bitbang.c index 14a63f6..e2a874a

[PATCH] spi/imx: select master mode for all channels

2011-02-08 Thread Uwe Kleine-König
comment about the race] Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- Hello, maybe one of our friends at Freescale can comment? Best regards Uwe drivers/spi/spi_imx.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi_imx.c b

Re: [PATCHv3 1/4] mc13xxx-core: Consolidate common code to prepare for separate i2c and spi

2010-12-20 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative

Re: [PATCHv3 4/4] mc13xxx: Add i2c and spi drivers to Kconfig and Makefile

2010-12-20 Thread Uwe Kleine-König
obj-$(CONFIG_MFD_CORE) += mfd-core.o Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH] spi/imx: remove autodetection

2010-11-25 Thread Uwe Kleine-König
On Thu, Nov 25, 2010 at 12:03:43PM +0800, Jason Wang wrote: It is reasonable, looks fine to me. :-) Jason. I'll interpret this as an Ack. Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

[PATCH] spi/imx: remove autodetection

2010-11-24 Thread Uwe Kleine-König
there are no machines in-tree that still use the driver name as device name. So save a few bytes and remove it. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/spi_imx.c | 30 ++ 1 files changed, 2 insertions(+), 28 deletions(-) diff

Re: [PATCH 6/6] atmel_spi: fix warning In function 'atmel_spi_dma_map_xfer'

2010-11-20 Thread Uwe Kleine-König
if that's sensible though. And I wonder about gcc that your patch makes a difference. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

[PATCH 7/6] spi/imx: Support different fifo sizes

2010-10-08 Thread Uwe Kleine-König
-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- Hello, this patch depends on patches already acked by Grant Likely and sitting in Sascha Hauer's imx-for-2.6.37 branch. Best regards Uwe drivers/spi/spi_imx.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 0/6] add spi support for i.MX51 in the existing spi_imx driver

2010-09-20 Thread Uwe Kleine-König
series? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- Start uncovering the many advantages

Re: [PATCH 0/6] add spi support for i.MX51 in the existing spi_imx driver

2010-09-17 Thread Uwe Kleine-König
Hello, On Thu, Sep 02, 2010 at 04:39:08PM +0200, Uwe Kleine-König wrote: Hello Jason, Actually I would prefer our patches, but of course I'm biased :-) I don't know how we should handle this. And Sascha is on vacation this and next week. I will investigate if our patches are already

[PATCH 16/16] ARM: mx5/mx51_3ds: add SPI NOR flash in the board init stage

2010-09-17 Thread Uwe Kleine-König
From: Jason Wang jason77.w...@gmail.com A 2M bytes SPI NOR flash(sst25vf016b) is soldered on the mx51_3ds board. So add the corresponding device for it. Signed-off-by: Jason Wang jason77.w...@gmail.com Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/mach-mx5/board

[PATCH 15/16] ARM: mx5/mx51_3ds: add eCSPI2 support on the imx51_3ds board

2010-09-17 Thread Uwe Kleine-König
From: Jason Wang jason77.w...@gmail.com Signed-off-by: Jason Wang jason77.w...@gmail.com Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/mach-mx5/Kconfig |1 + arch/arm/mach-mx5/board-mx51_3ds.c | 20 2 files changed, 21 insertions

[PATCH 05/16] spi/imx: add support for imx51's eCSPI and CSPI

2010-09-17 Thread Uwe Kleine-König
resp.) plus a (now hopefully correct) reimplementation of the clock calculation. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/Kconfig |5 ++- drivers/spi/spi_imx.c | 140 - 2 files changed, 143 insertions(+), 2

[PATCH 06/16] ARM: imx: change the way spi-imx devices are registered

2010-09-17 Thread Uwe Kleine-König
-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/mach-imx/devices-imx21.h |9 ++- arch/arm/mach-imx/devices-imx27.h | 12 ++-- arch/arm/mach-mx25/devices-imx25.h | 12 ++-- arch/arm/mach-mx3/devices-imx31.h | 12 ++-- arch

[PATCH 07/16] ARM: imx: use platform ids for spi_imx devices

2010-09-17 Thread Uwe Kleine-König
The driver recently learned to handle platform ids. Make use of this new feature. The up side is that the driver needs less knowledge about the spi interfaces used on different SoCs. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/mach-imx/clock-imx1.c

[PATCH 04/16] spi/imx: save the spi chip select in config struct, not the gpio to use

2010-09-17 Thread Uwe Kleine-König
This prepares adding support for imx51's eCSPI. This IP has seperate control and config bits for all four supported chip selects, so the config routine needs to know which chip select is being used even if the chipselect is realized by a gpio. Signed-off-by: Uwe Kleine-König u.kleine-koe

[PATCH 10/16] ARM: mx5: add spi_imx device registration

2010-09-17 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/mach-mx5/devices-imx51.h| 18 ++ arch/arm/plat-mxc/devices/platform-spi_imx.c | 12 2 files changed, 30 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-mx5

[PATCH 08/16] ARM: mx51: clean up mx51 header

2010-09-17 Thread Uwe Kleine-König
This makes the header more look like the other ones, i.e. - sort #defines by value - use lowercase hex constants - use a consistently named header guard Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/plat-mxc/include/mach/mx51.h | 608

[PATCH 02/16] spi/imx: convert driver to use platform ids

2010-09-17 Thread Uwe Kleine-König
spi_imx_setupxfer276 280 +4 Later when the platform code is updated to use the platform ids, the autodetection can be removed which will make the driver a bit smaller again. (~60 Bytes in my test.) Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de

[PATCH 03/16] spi/imx: get rid of more ifs depending on the used cpu

2010-09-17 Thread Uwe Kleine-König
Nearly everything that is needed is provided by the version of the SPI IP. Now the only checks left using cpu_is_... are clk divider tuning on mx21/mx27 and autodetection (which will die soon). Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/spi_imx.c | 73

[PATCH 01/16] spi/imx: default to m on platforms that have such devices

2010-09-17 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/spi/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 91c2f4f..30aea6d 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -147,6

[PATCH 11/16] ARM: mx5/clock-mx51: refactor ccgr callbacks to use common code

2010-09-17 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/mach-mx5/clock-mx51.c | 30 -- 1 files changed, 16 insertions(+), 14 deletions(-) diff --git a/arch/arm/mach-mx5/clock-mx51.c b/arch/arm/mach-mx5/clock-mx51.c index 57c10a9..fe658bf 100644

[PATCH 09/16] ARM: mx51: fix naming of spi related defines

2010-09-17 Thread Uwe Kleine-König
The names used now match the processor's reference manual. Also remove MXC from the interrupt defines to match the other imx platforms. Acked-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/plat-mxc/include/mach/mx51.h | 12

Re: [PATCH 2/6] i.MX5/clock: add eCSPI and CSPI clock definitions

2010-09-10 Thread Uwe Kleine-König
-- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- Automate Storage Tiering Simply Optimize IT performance and efficiency through

Re: [PATCH 5/6] spi-imx: Add i.MX51 support

2010-09-09 Thread Uwe Kleine-König
. I'll try to pick the best our of both and come back to you, of course with a nice commit log :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH 0/6] add spi support for i.MX51 in the existing spi_imx driver

2010-09-02 Thread Uwe Kleine-König
this. And Sascha is on vacation this and next week. I will investigate if our patches are already free to be posted. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

[PATCH 6/6] ARM: mx5/mx51_babbage: Add spi support

2010-09-02 Thread Uwe Kleine-König
From: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- arch/arm/mach-mx5/Kconfig |1 + arch/arm/mach-mx5/board-mx51_babbage.c | 31 +++ 2 files changed, 32 insertions(+), 0 deletions(-) diff --git

[PATCH 5/6] spi-imx: Add i.MX51 support

2010-09-02 Thread Uwe Kleine-König
From: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/spi/spi_imx.c | 123 +++- 1 files changed, 120 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c index

[PATCH 2/6] ARM: mx51: fix naming of spi related defines

2010-09-02 Thread Uwe Kleine-König
The names used now match the processor's reference manual. Also remove MXC from the interrupt defines to match the other imx platforms. Acked-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/plat-mxc/include/mach/mx51.h | 12

[PATCH 1/6] ARM: mx51: clean up mx51 header

2010-09-02 Thread Uwe Kleine-König
This makes the header more look like the other ones, i.e. - sort #defines by value - use lowercase hex constants - use a consistently named header guard Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/plat-mxc/include/mach/mx51.h | 608

[PATCH 4/6] ARM: mx51: Add spi clock and spi_imx device registration

2010-09-02 Thread Uwe Kleine-König
From: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- arch/arm/mach-mx5/clock-mx51.c | 42 ++ arch/arm/mach-mx5/devices-imx51.h| 18

Re: [PATCH 2/6] i.MX5/clock: add eCSPI and CSPI clock definitions

2010-09-02 Thread Uwe Kleine-König
Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading

Re: [PATCH 3/6] mx5: add support to dynamically register spi_imx devices (imx51 3ds)

2010-09-02 Thread Uwe Kleine-König
)\ + imx_add_spi_imx(1, MX51_CSPI3_BASE_ADDR, SZ_4K, MX51_MXC_INT_CSPI, pdata) I like my new approach better. See my patch 3. -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH 5/6] mx51_3ds: add eCSPI2 support on the imx51_3ds board

2010-09-02 Thread Uwe Kleine-König
on the board are unusable.\n); -- 1.5.6.5 -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- This SF.net Dev2Dev email

[spi-devel-general] [RESEND PATCH 5/5] spi/mpc8xxx: don't check platform_get_irq's return value against zero

2010-01-13 Thread Uwe Kleine-König
the return value of platform_get_irq from 0 to -ENXIO on error. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: David Vrabel dvra...@arcom.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: David Brownell dbrown...@users.sourceforge.net Cc: Grant Likely grant.lik...@secretlab.ca Cc

[spi-devel-general] [PATCH 6/7] spi/mpc8xxx: don't check platform_get_irq's return value against zero

2009-12-16 Thread Uwe Kleine-König
of platform_get_irq from 0 to -ENXIO on error. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: David Vrabel dvra...@arcom.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: David Brownell dbrown...@users.sourceforge.net Cc: Grant Likely grant.lik...@secretlab.ca Cc: Kumar Gala ga

Re: [spi-devel-general] + spi-imx-correct-check-for-platform_get_irq-failing.patch added to -mm tree

2009-12-09 Thread Uwe Kleine-König
On Wed, Dec 09, 2009 at 08:08:19AM -0700, Grant Likely wrote: (resend because I forgot to cc the mailing list) 2009/12/9 Uwe Kleine-König u.kleine-koe...@pengutronix.de: Hello Grant, On Tue, Dec 08, 2009 at 05:38:57PM -0700, Grant Likely wrote: diff -puN drivers/spi/spi_imx.c~spi

Re: [spi-devel-general] + spi-imx-correct-check-for-platform_get_irq-failing.patch added to -mm tree

2009-12-09 Thread Uwe Kleine-König
On Wed, Dec 09, 2009 at 04:32:41PM +0100, Uwe Kleine-König wrote: On Wed, Dec 09, 2009 at 08:08:19AM -0700, Grant Likely wrote: (resend because I forgot to cc the mailing list) 2009/12/9 Uwe Kleine-König u.kleine-koe...@pengutronix.de: Hello Grant, On Tue, Dec 08, 2009 at 05:38

[spi-devel-general] [PATCH 0/5] spi-imx: some updates

2009-12-08 Thread Uwe Kleine-König
): spi: drain MXC SPI transfer buffer when probing device Sascha Hauer (1): spi-imx: Add mx25 support Uwe Kleine-König (4): spi-imx: use platform_driver_probe as probe lives in .init.text spi-imx: correct check for platform_get_irq failing spi-imx: use positive logic

[spi-devel-general] [PATCH 1/5] spi-imx: use platform_driver_probe as probe lives in .init.text

2009-12-08 Thread Uwe Kleine-König
Using platform_driver_register with a probe function defined using __init is wrong. This fixes an oops after: cd /sys/bus/platform/drivers/spi_imx echo -n spi_imx.0 unbind echo -n spi_imx.0 bind Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: David

[spi-devel-general] [PATCH 3/5] spi-imx: use positive logic to distinguish cpu variants

2009-12-08 Thread Uwe Kleine-König
This is much safer when support for new variants is added. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: David Brownell dbrown...@users.sourceforge.net Cc: Andrew Morton a...@linux-foundation.org Cc: Sascha Hauer s.ha...@pengutronix.de --- drivers/spi/spi_imx.c |2 +- 1

[spi-devel-general] [PATCH 2/5] spi-imx: correct check for platform_get_irq failing

2009-12-08 Thread Uwe Kleine-König
platform_get_irq returns -ENXIO if there is no entry. So don't check return value being nonzero but greater or equal to zero. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: David Brownell dbrown...@users.sourceforge.net Cc: Andrew Morton a...@linux-foundation.org Cc: Sascha

[spi-devel-general] [PATCH 5/5] spi-imx: don't access struct device directly but use dev_get_platdata

2009-12-08 Thread Uwe Kleine-König
Also there is no casting needed to assign a void pointer. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: David Brownell dbrown...@users.sourceforge.net Cc: Andrew Morton a...@linux-foundation.org Cc: Sascha Hauer s.ha...@pengutronix.de --- drivers/spi/spi_imx.c |2 +- 1

[spi-devel-general] [PATCH 32/38] don't use __exit_p to wrap plat_mpc8xxx_spi_remove

2009-11-24 Thread Uwe Kleine-König
The function plat_mpc8xxx_spi_remove is defined using __devexit, so don't use __exit_p but __devexit_p to wrap it. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: Andrew Morton a...@linux-foundation.org Cc: Kumar Gala ga...@kernel.crashing.org Cc: Anton Vorontsov avoront

Re: [spi-devel-general] [PATCH] SPI: drain MXC SPI transfer buffer when probing device

2009-11-19 Thread Uwe Kleine-König
Hello, On Thu, Nov 19, 2009 at 08:01:42PM +0100, Daniel Mack wrote: Hi Uwe, On Thu, Nov 19, 2009 at 07:49:51PM +0100, Uwe Kleine-König wrote: On Thu, Nov 19, 2009 at 11:44:47AM +0100, Daniel Mack wrote: On the MX31litekit, the bootloader seems to communicate with the MC13783 PMIC chip

[spi-devel-general] [PATCH 0/7] Updates for spi-imx

2009-09-30 Thread Uwe Kleine-König
: update state correctly spi-imx: Fix initial chipselect settings spi-imx: setup mode_bits we can handle Uwe Kleine-König (4): spi-imx: rename source file to spi_imx.c spi-imx: no need to assert bits_per_word being initialized spi-imx: initialize complete config struct

[spi-devel-general] [PATCH 5/7] spi-imx: no need to assert bits_per_word being initialized

2009-09-30 Thread Uwe Kleine-König
spi_imx_setup() is only called by spi_setup(). The latter does the initialization already. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Acked-by: Sascha Hauer s.ha...@pengutronix.de Cc: David Brownell dbrown...@users.sourceforge.net Cc: Andrew Morton a...@linux-foundation.org

[spi-devel-general] [PATCH 7/7 RFC] spi-imx: strip down chipselect function to only drive the chipselect

2009-09-30 Thread Uwe Kleine-König
spi_imx_chipselect() made things that should be (and mostly are) done by spi_imx_setupxfer. Only setting the tx and rx functions was missing. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Acked-by: Sascha Hauer s.ha...@pengutronix.de Cc: David Brownell dbrown

[spi-devel-general] [PATCH 6/7] spi-imx: initialize complete config struct

2009-09-30 Thread Uwe Kleine-König
Otherwise the config function uses random data from the stack. This didn't stick out because config is called once more in the chipselect function with correct parameters. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Acked-by: Sascha Hauer s.ha...@pengutronix.de Cc: David

[spi-devel-general] [PATCH 2/7] spi-imx: update state correctly

2009-09-30 Thread Uwe Kleine-König
From: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: David Brownell dbrown...@users.sourceforge.net Cc: Andrew Morton a...@linux-foundation.org Cc: Guennadi Liakhovetski g.liakhovet

[spi-devel-general] [PATCH 4/7] spi-imx: setup mode_bits we can handle

2009-09-30 Thread Uwe Kleine-König
From: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: David Brownell dbrown...@users.sourceforge.net Cc: Andrew Morton a...@linux-foundation.org Cc: Guennadi Liakhovetski g.liakhovet

[spi-devel-general] [PATCH 3/7] spi-imx: Fix initial chipselect settings

2009-09-30 Thread Uwe Kleine-König
From: Sascha Hauer s.ha...@pengutronix.de We can only setup the gpio pins in spi_setup time when we know the SPI_CS_HIGH setting. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: David Brownell dbrown...@users.sourceforge.net

Re: [spi-devel-general] [PATCH 0/7] Updates for spi-imx

2009-09-30 Thread Uwe Kleine-König
-- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions| http://www.pengutronix.de/ | -- Come build with us! The BlackBerryreg; Developer Conference in SF