Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-03 Thread Thomas Petazzoni
Marek, Le Mon, 23 Jul 2012 22:40:48 +0200, Marek Vasut ma...@denx.de a écrit : +static uint32_t mxs_spi_cs_to_reg(unsigned cs) +{ + uint32_t select = 0; + + if (cs 1) + select |= BM_SSP_CTRL0_WAIT_FOR_CMD; + if (cs 2) + select |=

Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-03 Thread Fabio Estevam
On Fri, Aug 3, 2012 at 10:38 AM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: It sounds really strange to manipulate WAIT_FOR_CMD and WAIT_FOR_IRQ bits to adjust the chip select, and when reading the driver, it seemed suspicious to me. After going through the datasheet, indeed

Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-03 Thread Marek Vasut
Dear Fabio Estevam, On Fri, Aug 3, 2012 at 10:38 AM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: It sounds really strange to manipulate WAIT_FOR_CMD and WAIT_FOR_IRQ bits to adjust the chip select, and when reading the driver, it seemed suspicious to me. After going

Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-03 Thread Marek Vasut
Dear Fabio Estevam, On Fri, Aug 3, 2012 at 10:38 AM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: It sounds really strange to manipulate WAIT_FOR_CMD and WAIT_FOR_IRQ bits to adjust the chip select, and when reading the driver, it seemed suspicious to me. After going

Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-02 Thread Marek Vasut
Dear Mark Brown, Thanks for the review! On Mon, Jul 23, 2012 at 10:40:48PM +0200, Marek Vasut wrote: This is slightly reworked version of the SPI driver. Support for DT has been added and it's been converted to queued API. Looks reasonable overall. + bits_per_word =

Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-02 Thread Mark Brown
On Thu, Aug 02, 2012 at 04:58:38PM +0200, Marek Vasut wrote: It'd be nice to only keep the clocks enabled while doing transfers but again totally non-essential. Hm, this is spread across mxs. Shawn, is there any plan for PM implementation for MXS ? Take a look at s3c64xx - I did

Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-02 Thread Marek Vasut
Dear Mark Brown, On Thu, Aug 02, 2012 at 04:58:38PM +0200, Marek Vasut wrote: It'd be nice to only keep the clocks enabled while doing transfers but again totally non-essential. Hm, this is spread across mxs. Shawn, is there any plan for PM implementation for MXS ? Take a look at

Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-02 Thread Shawn Guo
On Thu, Aug 02, 2012 at 04:58:38PM +0200, Marek Vasut wrote: Hm, this is spread across mxs. Shawn, is there any plan for PM implementation for MXS ? Near term, no. Long term, yes. -- Regards, Shawn -- Live

Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-01 Thread Mark Brown
On Mon, Jul 23, 2012 at 10:40:48PM +0200, Marek Vasut wrote: This is slightly reworked version of the SPI driver. Support for DT has been added and it's been converted to queued API. Looks reasonable overall. + bits_per_word = dev-bits_per_word; + if (t t-bits_per_word) +

[PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-07-06 Thread Marek Vasut
This is slightly reworked version of the SPI driver. Support for DT has been added and it's been converted to queued API. Based on previous attempt by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Marek Vasut ma...@denx.de Cc: