Re: [Spice-devel] [PATCH 2/7] red_worker: rename epoll_timeout to event_timeout

2012-02-21 Thread Alon Levy
On Mon, Feb 20, 2012 at 06:11:26PM -0600, Dan McGee wrote: On Mon, Feb 20, 2012 at 6:07 PM, Dan McGee dpmc...@gmail.com wrote: On Fri, Feb 17, 2012 at 2:52 AM, Alon Levy al...@redhat.com wrote: On Thu, Feb 16, 2012 at 11:30:08PM -0600, Dan McGee wrote: With future patches in mind that will

Re: [Spice-devel] [PATCH 0/7] Series of patches to add non-Linux server support

2012-02-21 Thread Alon Levy
On Thu, Feb 16, 2012 at 11:30:06PM -0600, Dan McGee wrote: This is a set of patches to enable building the server library on a non-Linux, non-pure-GNU toolchain platform. The patches range from build system tweaks to code changes. I don't have any further problems with this patch series, and

[Spice-devel] Should we auto-redirect USB devices when we show the USB device selection menu?

2012-02-21 Thread Hans de Goede
Hi, I'm working on some better / prettier error reporting for the usb device widget, and I was wondering should we auto-redirect newly plugged in USB devices when auto-redir is enabled and they get plugged on while showing the USB device selection menu? Currently we do not do this since when

Re: [Spice-devel] Should we auto-redirect USB devices when we show the USB device selection menu?

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 11:09:49AM +0100, Hans de Goede wrote: Hi, I'm working on some better / prettier error reporting for the usb device widget, and I was wondering should we auto-redirect newly plugged in USB devices when auto-redir is enabled and they get plugged on while showing

[Spice-devel] [PATCH] qxl: add 64bit pci bar

2012-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- spice/qxl_dev.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 5e6ce06..a2af017 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -61,6 +61,12 @@ enum {

Re: [Spice-devel] [PATCH] qxl: add 64bit pci bar

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 12:05:33PM +0100, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com ACK. --- spice/qxl_dev.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 5e6ce06..a2af017 100644 ---

[Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
Spice protocol contains only headers. We would like to be able to use a protocol update without having to wait for the release, a git submodule works well for this purpose. --- .gitmodules|3 +++ autogen.sh |3 +++ configure.ac | 12 +++- spice-protocol |1 + 4

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 12:22 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: Spice protocol contains only headers. We would like to be able to use a protocol update without having to wait for the release, a git submodule works well for this purpose. ---  .gitmodules    |    3 +++  

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 12:22:43PM +0100, Marc-André Lureau wrote: Spice protocol contains only headers. We would like to be able to use a protocol update without having to wait for the release, a git submodule works well for this purpose. Looks good to me. I can revert my attempts to get

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 12:25 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: -SUBDIRS = common gtk po python_modules doc data +SUBDIRS = spice-protocol common gtk po python_modules doc data even better is DIST_SUBDIRS = spice-protocol $(SUBDIRS) So it doesn't get installed. (If

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Gerd Hoffmann
diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 000..b628a96 --- /dev/null +++ b/.gitmodules @@ -0,0 +1,3 @@ +[submodule spice-protocol] + path = spice-protocol + url = git://anongit.freedesktop.org/spice/spice-protocol IIRC relative paths work there too and

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
Hi On Tue, Feb 21, 2012 at 2:03 PM, Gerd Hoffmann kra...@redhat.com wrote: +     url = git://anongit.freedesktop.org/spice/spice-protocol IIRC relative paths work there too and 'git submodule init' picks up the path from the parent then.  So committers automagically get a ssh://... url for

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Christophe Fergeau
On Tue, Feb 21, 2012 at 12:22:43PM +0100, Marc-André Lureau wrote: Spice protocol contains only headers. We would like to be able to use a protocol update without having to wait for the release, a git submodule works well for this purpose. Do we still make spice-protocol releases after that?

[Spice-devel] [PATCH spice-gtk 1/6] usbredir: Add device rejected errors

2012-02-21 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/channel-usbredir.c | 84 -- gtk/channel-usbredir.h |4 ++ gtk/spicy.c |2 + gtk/usb-device-manager.c | 37 gtk/usb-device-manager.h |4 ++-

[Spice-devel] [PATCH spice-gtk 2/6] usbredir: Treat the user cancelling the policykit dialog as a cancel

2012-02-21 Thread Hans de Goede
Rather then treating it as any other error. This avoids showing an error dialog after the user pressed cancel in the policykit dialog. Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/spice-client-glib-usb-acl-helper.c |5 + gtk/usb-acl-helper.c | 13

[Spice-devel] [PATCH spice-gtk 3/6] configure: Fix USB redirection support summary on --disable-usbredir

2012-02-21 Thread Hans de Goede
When running ./configure --disable-usbredir the USB redirection support line in the summary at the end of ./configure would be empty after support instead of ending with yes or no. Signed-off-by: Hans de Goede hdego...@redhat.com --- configure.ac |4 ++-- 1 files changed, 2 insertions(+), 2

[Spice-devel] [PATCH spice-gtk 4/6] usb-device-widget: Use an info_bar for error messages

2012-02-21 Thread Hans de Goede
And in general gnome-hig-ify usb-device-widget: * Use spacing instead of padding so that there is no padding at the outside/border of the widget, allowing the user to control the border size. * Use multiple of 6 as spacing / indentation values * Show the label left justified and bold, show the

[Spice-devel] [PATCH spice-gtk 5/6] usbredir: Add a spice_usb_device_manager_can_redirect_device function

2012-02-21 Thread Hans de Goede
Add a spice_usb_device_manager_can_redirect_device function and use this in SpiceUsbDeviceWidget to check if redirection is available. Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/map-file |1 + gtk/usb-device-manager.c | 71 +---

[Spice-devel] [PATCH spice-gtk 6/6] usbredir: Add awareness of host/guest side filtering

2012-02-21 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/channel-usbredir-priv.h |6 ++ gtk/channel-usbredir.c | 19 --- gtk/usb-device-manager.c| 18 +- 3 files changed, 39 insertions(+), 4 deletions(-) diff --git

Re: [Spice-devel] Should we auto-redirect USB devices when we show the USB device selection menu?

2012-02-21 Thread Hans de Goede
Hi, On 02/21/2012 11:35 AM, Alon Levy wrote: On Tue, Feb 21, 2012 at 11:09:49AM +0100, Hans de Goede wrote: Hi, I'm working on some better / prettier error reporting for the usb device widget, and I was wondering should we auto-redirect newly plugged in USB devices when auto-redir is

Re: [Spice-devel] [PATCH 5/7] red_worker: reimplement event loop using poll()

2012-02-21 Thread Dan McGee
On Fri, Feb 17, 2012 at 7:34 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 02/17/2012 02:18 PM, Alon Levy wrote: - guaranteed bitrot in the poll() path :) Yeah, I guess you are right. I'm worried since I don't know the difference in performance between epoll and poll You can assume it

Re: [Spice-devel] [PATCH 0/7] Series of patches to add non-Linux server support

2012-02-21 Thread Dan McGee
On Fri, Feb 17, 2012 at 3:06 AM, Alon Levy al...@redhat.com wrote: On Thu, Feb 16, 2012 at 11:30:06PM -0600, Dan McGee wrote: The title says non-linux, when in fact it's obvious from the rest of what you write that the use case is Solaris. Why not say that? Because these patches should help

Re: [Spice-devel] [PATCH 1/7] Add configure-time check for -Wl, --version-script option

2012-02-21 Thread Dan McGee
On Fri, Feb 17, 2012 at 4:21 AM, Daniel P. Berrange berra...@redhat.com wrote: The Solaris linker does actually support version scripts using the exact same file syntax as the GNU linker. The only thing that is different is the linker command line arg. Yes, using the -M option, I did see that

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Kai Meyer
On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my expectations straight. Should I be able to use spice from inside a VM on my local machine to

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Yonit Halperin
On 02/21/2012 07:49 PM, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my expectations straight. Should I be able to use spice

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 10:49:04AM -0700, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my expectations straight. Should I

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 02:28:06PM +0100, Christophe Fergeau wrote: On Tue, Feb 21, 2012 at 12:22:43PM +0100, Marc-André Lureau wrote: Spice protocol contains only headers. We would like to be able to use a protocol update without having to wait for the release, a git submodule works well

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Kai Meyer
On 02/21/2012 12:34 PM, Yonit Halperin wrote: On 02/21/2012 07:49 PM, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Kai Meyer
On 02/21/2012 10:57 AM, Alon Levy wrote: On Tue, Feb 21, 2012 at 10:49:04AM -0700, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Yonit Halperin
On 02/21/2012 09:56 PM, Kai Meyer wrote: On 02/21/2012 12:34 PM, Yonit Halperin wrote: On 02/21/2012 07:49 PM, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16

[Spice-devel] [RFC v4 0/9] qxl: fix hangs caused by qxl_render_update

2012-02-21 Thread Alon Levy
This is the second attempt to fix this issue, as a lesson from the last time it doesn't try to use an async monitor command. So with this patchset, in qxl mode, a screendump monitor command will complete before the file is written to disk. This is much better then a hang. To fix it does require

[Spice-devel] [RFC v4 1/9] console: don't call console_select unnecessarily

2012-02-21 Thread Alon Levy
From: Gerd Hoffman kra...@redhat.com Tested-by: Alon Levy al...@redhat.com --- console.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/console.c b/console.c index 135394f..cfcc2f7 100644 --- a/console.c +++ b/console.c @@ -181,12 +181,14 @@ void

[Spice-devel] [RFC v4 2/9] sdl: remove NULL check, g_malloc0 can't fail

2012-02-21 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- ui/sdl.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 6f8091c..f6f711c 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -167,10 +167,6 @@ static PixelFormat sdl_to_qemu_pixelformat(SDL_PixelFormat

[Spice-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

2012-02-21 Thread Alon Levy
Using vga-screen_dump results in a number of calls to ppm_save, instead of a single one. Lacking time to test all the possible users of vga-screen_dump, avoid the redundant calls by doing the vga_hw_update+ ppm_save in qxl_hw_screen_dump. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |

[Spice-devel] [RFC v4 7/9] qxl: introduce QXLCookie

2012-02-21 Thread Alon Levy
Will be used in the next patch. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl-render.c|2 +- hw/qxl.c | 58 --- hw/qxl.h |2 +- ui/spice-display.c | 22 +-- ui/spice-display.h | 14

[Spice-devel] [RFC v4 8/9] qxl: make qxl_render_update async

2012-02-21 Thread Alon Levy
RHBZ# 747011 Removes the last user of QXL_SYNC when using update drivers that use the _ASYNC io ports. The last user is qxl_render_update, it is called both by qxl_hw_update which is the vga_hw_update_ptr passed to graphic_console_init, and by qxl_hw_screen_dump. At the same time the QXLRect

[Spice-devel] [RFC v4 9/9] qxl-render: call ppm_save on bh

2012-02-21 Thread Alon Levy
This changes the behavior of the monitor command. After the previous patch, there is no longer an option of deadlock with virt-manager, but ppm_save is called too early, before the update has completed. With this patch it is called at the correct moment, but that means there is a race between the

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 12:58:55PM -0700, Kai Meyer wrote: On 02/21/2012 10:57 AM, Alon Levy wrote: On Tue, Feb 21, 2012 at 10:49:04AM -0700, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit

Re: [Spice-devel] [RFC v4 0/9] qxl: fix hangs caused by qxl_render_update

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 11:39:28PM +0200, Alon Levy wrote: This is the second attempt to fix this issue, as a lesson from the last time it doesn't try to use an async monitor command. So with this patchset, in qxl mode, a screendump monitor command will complete before the file is written

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 6:48 PM, Alon Levy al...@redhat.com wrote: We will still need releases for anyone building from tarballs, which includes all distribution built packages. Not with the submodule autofoo solution I proposed for spice-gtk. -- Marc-André Lureau