Re: [Spice-devel] [PATCH spice-gtk] RFC: always release shm of primary surfaces

2012-03-22 Thread Yonit Halperin
On 03/21/2012 08:53 PM, Marc-André Lureau wrote: Note: I can't reproduce the leak, even after dozen of resolution switch. Always delete shared memory segment of primary surfaces when destroying its canvas. Ack. Tested. Just notice that it is not only for the primary surface, but for every

Re: [Spice-devel] [PATCH 1/2] server/tests/test_display_base: add Command

2012-03-22 Thread Hans de Goede
Looks good, Ack series. On 03/21/2012 11:16 PM, Alon Levy wrote: add parameters to the commands used for display tests. --- server/tests/test_display_base.c | 110 ++ server/tests/test_display_base.h | 36 + 2 files changed, 101

Re: [Spice-devel] [PATCH spice-gtk 1/2] controller: handle SEND_CAD message as a property

2012-03-22 Thread Hans de Goede
Looks good, ACK series. On 03/21/2012 11:07 PM, Marc-André Lureau wrote: --- gtk/controller/controller.vala |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/gtk/controller/controller.vala b/gtk/controller/controller.vala index 12b5b8d..b083f4e 100644 ---

Re: [Spice-devel] [PATCH 0/5] 32 bit fixes

2012-03-22 Thread Hans de Goede
Looks good, ACK series. And thanks for looking into this, it is about time we start supporting 32 bits :) On 03/21/2012 05:00 PM, Alon Levy wrote: With those patches and a single patch to qemu I'll send soon F17-Alpha-i686 boots and loads qxl driver using qemu-system-i386 and spice-server

Re: [Spice-devel] [PATCH spice-gtk] RFC: always release shm of primary surfaces

2012-03-22 Thread Hans de Goede
ACK! On 03/21/2012 07:53 PM, Marc-André Lureau wrote: Note: I can't reproduce the leak, even after dozen of resolution switch. Always delete shared memory segment of primary surfaces when destroying its canvas. --- gtk/channel-display.c |6 +- 1 files changed, 1 insertions(+), 5

Re: [Spice-devel] [PATCH] ui/spice-display: use uintptr_t when casting qxl physical addresses

2012-03-22 Thread Hans de Goede
Good one, ACK. Acked-by: Hans de Goede hdego...@redhat.com On 03/21/2012 05:17 PM, Alon Levy wrote: The current intptr_t casts are a problem when the address's highest bit is 1, and it is cast to a intptr_t and then to uint64_t, such as at: surface.mem= (intptr_t)ssd-buf; This

Re: [Spice-devel] [PATCH 0/5] 32 bit fixes

2012-03-22 Thread Gerd Hoffmann
On 03/21/12 17:00, Alon Levy wrote: With those patches and a single patch to qemu I'll send soon F17-Alpha-i686 boots and loads qxl driver using qemu-system-i386 and spice-server built with -m32. I think this should get spice-server going on arm too, right? Acked-by: Gerd Hoffmann

[Spice-devel] Fail to create a printing channel

2012-03-22 Thread Charles . Tsai-蔡清海-研究發展部
Alon, I am running the following script to create the printing channel based on the virtio device framework. When the VM is launched, it seems to block somewhere in Qemu. If I remove the following two lines, the VM can be launched without any problem.

Re: [Spice-devel] [PATCH spice-gtk] RFC: always release shm of primary surfaces

2012-03-22 Thread Marc-André Lureau
On Thu, Mar 22, 2012 at 8:17 AM, Yonit Halperin yhalp...@redhat.com wrote: Just notice that it is not only for the primary surface, but for every surface. Only if it has the SPICE_SURFACE_FLAGS_PRIMARY, if I read correctly. -- Marc-André Lureau ___

Re: [Spice-devel] [PATCH spice-gtk] build-sys: move codegen proto to spice-common

2012-03-22 Thread Marc-André Lureau
On Thu, Mar 22, 2012 at 6:30 PM, Alon Levy al...@redhat.com wrote: Actually, strike that - sorry for asking, not worth the trouble. yeah, in my opinion, build-system stuff isn't worth splitting... As long as you don't break the sacred rule of make distcheck and the builds with various options

Re: [Spice-devel] [PATCH spice-gtk] build-sys: move codegen proto to spice-common

2012-03-22 Thread Marc-André Lureau
On Thu, Mar 22, 2012 at 7:48 PM, Alon Levy al...@redhat.com wrote: Looks good to me, ACK. Notice that this patch makes use of branch wip2: http://cgit.freedesktop.org/spice/spice-common/log/?h=wip2 Have you also checked it? I guess it should be reviewed too (or re-review for most of the

Re: [Spice-devel] Fail to create a printing channel

2012-03-22 Thread Charles . Tsai-蔡清海-研究發展部
Alon, In Windows, driver name is provided by the device driver. In this case , com.redhat.print.0 is the device visible to application. Because device com.redhat.print.0 is created by the Qemu which is in Linux, how the Linux passes the driver information to Windows So that Windows application