[Spice-devel] Help with solving a thread safety issue

2014-08-22 Thread Jeremy White
I'm hoping to ask for some advice on the spice server. Background: I've hit a bug with Xspice. The current implementation uses a separate thread to grab pcm data from a fifo. That same thread creates and drives the playback channel, and then pushes that data out using spice_server_playback_p

Re: [Spice-devel] [PATCH (try 2)] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Marc-André Lureau
looks good to me, ack On Fri, Aug 22, 2014 at 5:08 PM, Jeremy White wrote: > Also adjust the mode selection to fit, and add a few larger modes. > > Signed-off-by: Jeremy White > --- > examples/spiceqxl.xorg.conf.example | 30 ++ > src/qxl.h |3 +

[Spice-devel] [PATCH (try 2)] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Jeremy White
Also adjust the mode selection to fit, and add a few larger modes. Signed-off-by: Jeremy White --- examples/spiceqxl.xorg.conf.example | 30 ++ src/qxl.h |3 ++ src/qxl_driver.c| 19 --- src/spiceqxl_driver.c

Re: [Spice-devel] [PATCH] [xf86-video-qxl] The display of the RAM size subtracts the frame buffer, but it has already been subtracted in setting the num_pages field.

2014-08-22 Thread Marc-André Lureau
ack - Original Message - > > Signed-off-by: Jeremy White > --- > src/qxl_driver.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/qxl_driver.c b/src/qxl_driver.c > index d9bf447..7436a62 100644 > --- a/src/qxl_driver.c > +++ b/src/qxl_driver.c > @@ -384,

[Spice-devel] [PATCH] [xf86-video-qxl] The display of the RAM size subtracts the frame buffer, but it has already been subtracted in setting the num_pages field.

2014-08-22 Thread Jeremy White
Signed-off-by: Jeremy White --- src/qxl_driver.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index d9bf447..7436a62 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -384,7 +384,7 @@ qxl_map_memory (qxl_screen_t *qxl, int scrnI

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Jeremy White
Actually no excuse for the top post. I see. I like the idea of making sane memory allocation. When I ''fused'' Xspice I took what I thought was was simplest. I think you can replace mspace with malloc. There is no api to disable the address translation we do (i.e. memslots) but it's already eq

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Alon Levy
On August 22, 2014 9:16:31 AM EDT, Jeremy White wrote: >On 08/22/2014 08:07 AM, Alon Levy wrote: >> Sorry for top posting. I was replying to Marc-Andre's assertion. If >the >> subject isnt arbitrary resolution, aka dynamic, continuous, then I >> missed it. If it is, since agent support for Xspic

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Jeremy White
On 08/22/2014 08:07 AM, Alon Levy wrote: Sorry for top posting. I was replying to Marc-Andre's assertion. If the subject isnt arbitrary resolution, aka dynamic, continuous, then I missed it. If it is, since agent support for Xspice this feature works per my memory. Ah, okay. Yes, my patch brok

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Alon Levy
Sorry for top posting. I was replying to Marc-Andre's assertion. If the subject isnt arbitrary resolution, aka dynamic, continuous, then I missed it. If it is, since agent support for Xspice this feature works per my memory. On August 22, 2014 9:04:32 AM EDT, Jeremy White wrote: >On 08/22/2014

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Jeremy White
On 08/22/2014 07:52 AM, Alon Levy wrote: With agent running we do. ?? I'm sorry, I don't follow. Can you explain what you mean? Cheers, Jeremy On August 22, 2014 7:55:19 AM EDT, "Marc-André Lureau" wrote: Hi Jeremy I wish we could have dynamic allocation for Xspice, avoiding t

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Alon Levy
With agent running we do. On August 22, 2014 7:55:19 AM EDT, "Marc-André Lureau" wrote: >Hi Jeremy > >I wish we could have dynamic allocation for Xspice, avoiding those >parameters, but this could be improved later. > >Few remarks below: > >- Original Message - >> Also adjust the mode s

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Jeremy White
On 08/22/2014 06:55 AM, Marc-André Lureau wrote: Hi Jeremy I wish we could have dynamic allocation for Xspice, avoiding those parameters, but this could be improved later. Yes; I looked into that, and am willing to do that work. For example, I considered simply replacing qxl_mem.c with an X

Re: [Spice-devel] problems with intermediate certificates

2014-08-22 Thread Dietmar Maurer
> I think you must be able to "openssl verify" your file without specifying the > CAfile, if you want Spice ssl checks to pass. Sorry, but how should that work? For example: # cat server.pem intermediate_certificate.pem ca.pem >mix.pem So the file contains all needed certificates, but: # openss

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Marc-André Lureau
Hi Jeremy I wish we could have dynamic allocation for Xspice, avoiding those parameters, but this could be improved later. Few remarks below: - Original Message - > Also adjust the mode selection to fit, and add a few larger modes. > > Signed-off-by: Jeremy White > --- > examples/sp

Re: [Spice-devel] problems with intermediate certificates

2014-08-22 Thread Marc-André Lureau
Hi Dietmar - Original Message - > I use the following certificate files: > > # openssl verify -CAfile /etc/pve/pve-root-ca.pem /etc/pve/local/pve-ssl.pem > /etc/pve/local/pve-ssl.pem: OK > > I pass the content of /etc/pve/pve-root-ca.pem to virt-viewer: > [virt-viewer] > ca=-BEGIN CE

Re: [Spice-devel] [PATCH] [xf86-video-qxl] Skip modes more precisely.

2014-08-22 Thread Marc-André Lureau
ack - Original Message - > > Signed-off-by: Jeremy White > --- > src/qxl_ums_mode.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/qxl_ums_mode.c b/src/qxl_ums_mode.c > index 8959242..e4a7edc 100644 > --- a/src/qxl_ums_mode.c > +++ b/src/qxl_ums_mod

[Spice-devel] problems with intermediate certificates

2014-08-22 Thread Dietmar Maurer
I use the following certificate files: # openssl verify -CAfile /etc/pve/pve-root-ca.pem /etc/pve/local/pve-ssl.pem /etc/pve/local/pve-ssl.pem: OK I pass the content of /etc/pve/pve-root-ca.pem to virt-viewer: [virt-viewer] ca=-BEGIN CERTIFICATE-\nXX/Q=\n-END CERTIFICATE-\