[Spice-devel] [PATCH spice-gtk v2] keymap: Add missing keys for XF86 and X11

It was missing the "shift" variants of many keys, like: !,@,#,$,%,^,&,*,(,),... making BRODWAY backend usage very limited. This change allow us to use it at least with the en_us keyboard layout in the guest. Keys were taken from `xmodmap -pk`. To reproduce the issue: brodwayd

[Spice-devel] [PATCH spice v2] Avoid a 'missing braces around initializer' warning.

Static variables don't need initializers to be 0. Signed-off-by: Jeremy White --- v2: Simply remove the initializer; the whole structure, if static, should be zero. --- server/tests/replay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

Hey, On Fri, Jan 13, 2017 at 05:47:13AM -0500, Frediano Ziglio wrote: > You are right. Surprisingly if the network queue was full the old code > just ignored the request not sending/setting any command. > After your code you don't schedule a send any volume/mute changes. > Maybe nothing change as

Re: [Spice-devel] [PATCH spice] Avoid a 'missing braces around initializer' warning.

> > On Mon, 2017-01-16 at 13:15 -0200, Eduardo Lima (Etrunko) wrote: > > On 12/01/17 18:25, Jeremy White wrote: > > > Signed-off-by: Jeremy White > > > --- > > >  server/tests/replay.c | 2 +- > > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git

Re: [Spice-devel] [PATCH spice] Avoid a 'missing braces around initializer' warning.

On Mon, 2017-01-16 at 13:15 -0200, Eduardo Lima (Etrunko) wrote: > On 12/01/17 18:25, Jeremy White wrote: > > Signed-off-by: Jeremy White > > --- > >  server/tests/replay.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [Spice-devel] [PATCH spice-gtk] keymap: Add missing keys for XF86 and X11

On 16/01/17 11:33, Christophe Fergeau wrote: > On Mon, Jan 16, 2017 at 01:31:26PM +0100, Pavel Grunt wrote: >>> but looks like there are lot of shift >>> keys which are supposed to be layout bound. >>> Why without all these shift codes keyboard was working? >> >> It wasn't working, keycodes were

Re: [Spice-devel] [PATCH spice] Avoid a 'missing braces around initializer' warning.

On 12/01/17 18:25, Jeremy White wrote: > Signed-off-by: Jeremy White > --- > server/tests/replay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/tests/replay.c b/server/tests/replay.c > index 8ec65d6..1f3ebb1 100644 > ---

Re: [Spice-devel] [PATCH spice-gtk] keymap: Add missing keys for XF86 and X11

On Mon, Jan 16, 2017 at 01:31:26PM +0100, Pavel Grunt wrote: > > but looks like there are lot of shift > > keys which are supposed to be layout bound. > > Why without all these shift codes keyboard was working? > > It wasn't working, keycodes were missing. One can check for instance > using

Re: [Spice-devel] [PATCH spice-gtk] keymap: Add missing keys for XF86 and X11

On Mon, 2017-01-16 at 07:25 -0500, Frediano Ziglio wrote: > > > > Resolves: > > https://bugs.freedesktop.org/show_bug.cgi?id=99407 > > --- > >  src/keymaps.csv | 29 + > >  1 file changed, 25 insertions(+), 4 deletions(-) > > > > diff --git a/src/keymaps.csv

Re: [Spice-devel] [PATCH spice-gtk] keymap: Add missing keys for XF86 and X11

> > Resolves: > https://bugs.freedesktop.org/show_bug.cgi?id=99407 > --- > src/keymaps.csv | 29 + > 1 file changed, 25 insertions(+), 4 deletions(-) > > diff --git a/src/keymaps.csv b/src/keymaps.csv > index 9052e3b..08af269 100644 > --- a/src/keymaps.csv > +++

Re: [Spice-devel] [PATCH 2/3] autotools: compile gst-test only if gstreamer is available

On Sun, Jan 15, 2017 at 06:12:21PM +0200, Snir Sheriber wrote: > Needed in order to avoid compilation error when gstreamer is > unavailable > --- > server/tests/Makefile.am | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/server/tests/Makefile.am

Re: [Spice-devel] [PATCH 3/3] Update ifdefs for gstreamer availability

On Sun, Jan 15, 2017 at 06:12:22PM +0200, Snir Sheriber wrote: > Using ifdefs with the recently defined conditional for having > gstreamer_0_10 or gstreamer_1_0 > --- > server/Makefile.am | 8 +--- > server/reds.c | 4 ++-- >

[Spice-devel] [PATCH spice-gtk] keymap: Add missing keys for XF86 and X11

Resolves: https://bugs.freedesktop.org/show_bug.cgi?id=99407 --- src/keymaps.csv | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/src/keymaps.csv b/src/keymaps.csv index 9052e3b..08af269 100644 --- a/src/keymaps.csv +++ b/src/keymaps.csv @@ -2,17