From: Marc-André Lureau
Not strictly required, but slightly more clear and consistent with the
rest of the code.
Signed-off-by: Marc-André Lureau
---
src/channel-display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/channel-display.c b/src/channel-display.c
index 14296d3..e5e5f56
From: Marc-André Lureau
The passed argument is already a SpiceChannel.
Signed-off-by: Marc-André Lureau
---
src/channel-display.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/channel-display.c b/src/channel-display.c
index 7c663cb..14296d3
Hi,
Thanks for taking a look!
On Sun, Dec 30, 2018 at 10:23:02PM +0100, Jakub Janku wrote:
> Hi,
>
> On Wed, Dec 19, 2018 at 3:30 PM Victor Toso wrote:
> >
> > From: Victor Toso
> >
> > If SpiceGtkSession is holding the keyboard, that's huge indication
> > that we should not be requesting
Hi,
Have you tried with migration?
On Wed, Jan 02, 2019 at 03:30:15PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Simple command line tools simply connect all channels, however
> usbredir channels require that the manager was previously
> initialized. Currently,
Hi,
On Wed, Jan 02, 2019 at 05:41:52PM +0200, Snir Sheriber wrote:
> Signed-off-by: Snir Sheriber
Acked-by: Victor Toso
> ---
> src/channel-display-gst.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
>
On Wed, Jan 02, 2019 at 09:39:46AM -0500, Frediano Ziglio wrote:
> >
> > Hey,
> >
> > On Wed, Dec 26, 2018 at 01:03:38PM +0100, Niccolò Belli wrote:
> > > I just noticed that the problem looks limited to special characters.
> > > For example if I set "Password" as password it works, while if I
[spice-gtk]
On 1/2/19 5:41 PM, Snir Sheriber wrote:
Signed-off-by: Snir Sheriber
---
src/channel-display-gst.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 2c07f35..bd2a9ff 100644
---
Signed-off-by: Snir Sheriber
---
src/channel-display-gst.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 2c07f35..bd2a9ff 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
@@ -548,11
Windows needs some specific setting to use network.
Signed-off-by: Frediano Ziglio
---
configure.ac | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
Changes since v1:
- all changes in configure.ac
diff --git a/configure.ac b/configure.ac
index 96e4e66c..afe0017d
Formatting string should be compatible with GLib.
GLib uses formatting types compatible with GNU.
For Linux this is not an issue as both systems (like a printf) and
GLib one uses the same formatting type. However on Windows they
differs potentially causing issues.
This is also make worse as GLib
>
> Hey,
>
> On Wed, Dec 26, 2018 at 01:03:38PM +0100, Niccolò Belli wrote:
> > I just noticed that the problem looks limited to special characters.
> > For example if I set "Password" as password it works, while if I set
> > "Password%%" it doesn't. It's weird because both my server and my
On Wed, Jan 02, 2019 at 03:07:06PM +0100, Christophe Fergeau wrote:
> Hey,
>
> On Wed, Dec 26, 2018 at 01:03:38PM +0100, Niccolò Belli wrote:
> > I just noticed that the problem looks limited to special characters.
> > For example if I set "Password" as password it works, while if I set
> >
Hey,
On Tue, Dec 25, 2018 at 06:20:03PM +0800, 陈炤 wrote:
> Hi,
>
>
> Does SPICE have a solution to capture video stream, and pass-through it to
> the client?
> I want this feature for these reasons:
> 1. Currently SPICE render video on server side, which would consume CPU of
> the server. If
Hey,
On Wed, Dec 26, 2018 at 01:03:38PM +0100, Niccolò Belli wrote:
> I just noticed that the problem looks limited to special characters.
> For example if I set "Password" as password it works, while if I set
> "Password%%" it doesn't. It's weird because both my server and my desktop
> client
Fine with me,
Acked-by: Christophe Fergeau
On Wed, Jan 02, 2019 at 01:02:26PM +, Frediano Ziglio wrote:
> SPICE_ATTR_PRINTF uses __printf__ format attribute.
> spice_log internally uses g_string_append_vprintf which uses
> G_GNUC_PRINTF attribute.
> G_GNUC_PRINTF can be __printf__ or
On Wed, Jan 02, 2019 at 08:07:22AM -0500, Frediano Ziglio wrote:
> >
> > On Sat, Dec 22, 2018 at 09:56:38AM -0500, Frediano Ziglio wrote:
> > >
> > > > Hi
> > > >
> > > > On Fri, Dec 21, 2018 at 4:03 PM Frediano Ziglio
> > > > wrote:
> > > > >
> > > > > Windows needs some specific setting to
>
> Hi
>
> On Wed, Jan 2, 2019 at 4:01 PM Frediano Ziglio wrote:
> >
> > >
> > > From: Marc-André Lureau
> > >
> > > Split lib dependencies in 3 groups: glib, gtk, and acl.
> > >
> > > Fixes:
> > > https://gitlab.freedesktop.org/spice/spice-gtk/issues/77
> > >
> > > Signed-off-by: Marc-André
Hi
On Wed, Jan 2, 2019 at 4:01 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > Split lib dependencies in 3 groups: glib, gtk, and acl.
> >
> > Fixes:
> > https://gitlab.freedesktop.org/spice/spice-gtk/issues/77
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> >
>
> On Sat, Dec 22, 2018 at 09:56:38AM -0500, Frediano Ziglio wrote:
> >
> > > Hi
> > >
> > > On Fri, Dec 21, 2018 at 4:03 PM Frediano Ziglio
> > > wrote:
> > > >
> > > > Windows needs some specific setting to use network.
> > > >
> > > > Signed-off-by: Frediano Ziglio
> > >
> > > with neat
SPICE_ATTR_PRINTF uses __printf__ format attribute.
spice_log internally uses g_string_append_vprintf which uses
G_GNUC_PRINTF attribute.
G_GNUC_PRINTF can be __printf__ or gnu_printf format which in
some systems (currently Windows) can be different.
GLib 2.58 changed G_GNUC_PRINTF on Windows from
On Sat, Dec 22, 2018 at 09:56:38AM -0500, Frediano Ziglio wrote:
>
> > Hi
> >
> > On Fri, Dec 21, 2018 at 4:03 PM Frediano Ziglio wrote:
> > >
> > > Windows needs some specific setting to use network.
> > >
> > > Signed-off-by: Frediano Ziglio
> >
> > with neat below
> > Reviewed-by:
>
> On Sat, Dec 22, 2018 at 06:53:25PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Use widget properties instead, as recommended in the documentation.
> > The UI doesn't seem to have changed after these modifications.
>
> I did not run with these changes, but
On Sat, Dec 22, 2018 at 10:02:36AM -0500, Frediano Ziglio wrote:
> >
> > On Fri, Dec 21, 2018 at 4:03 PM Frediano Ziglio wrote:
> > >
> > > These constants are meant to be used in format string for size_t
> > > types. Use them for portability.
> >
> > PRI*PTR is for [u]intptr_t.
> >
> > There
On Wed, Jan 02, 2019 at 06:30:50AM -0500, Frediano Ziglio wrote:
> > On Sat, Dec 22, 2018 at 06:53:24PM +0400, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
> > > Fixes
> > > WARNING: Use the 'pie' kwarg instead of passing '-fpie' manually to
> > >
>
> From: Marc-André Lureau
>
> Split lib dependencies in 3 groups: glib, gtk, and acl.
>
> Fixes:
> https://gitlab.freedesktop.org/spice/spice-gtk/issues/77
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 46 ++
> src/meson.build |
From: Marc-André Lureau
Simple command line tools simply connect all channels, however
usbredir channels require that the manager was previously
initialized. Currently, running spicy-stats on a VM with usbredir
channels prints:
(lt-spicy-stats:25224): GSpice-CRITICAL **: 14:30:54.724:
> On Sat, Dec 22, 2018 at 06:53:24PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Fixes
> > WARNING: Use the 'pie' kwarg instead of passing '-fpie' manually to
> > 'spice-client-glib-usb-acl-helper'
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> >
Signed-off-by: Frediano Ziglio
---
server/inputs-channel.c | 8
server/reds.c | 36 +++-
server/reds.h | 2 +-
3 files changed, 24 insertions(+), 22 deletions(-)
diff --git a/server/inputs-channel.c b/server/inputs-channel.c
index
On Sat, Dec 22, 2018 at 06:53:24PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Fixes
> WARNING: Use the 'pie' kwarg instead of passing '-fpie' manually to
> 'spice-client-glib-usb-acl-helper'
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 2 +-
>
On Sat, Dec 22, 2018 at 06:53:25PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Use widget properties instead, as recommended in the documentation.
> The UI doesn't seem to have changed after these modifications.
I did not run with these changes, but patch looks good
>
> Hi
>
> On Sat, Dec 22, 2018 at 7:06 PM Frediano Ziglio wrote:
> >
> > >
> > > From: Marc-André Lureau
> > >
> > > Fixes
> > > WARNING: Use the 'pie' kwarg instead of passing '-fpie' manually to
> > > 'spice-client-glib-usb-acl-helper'
> > >
> > > Signed-off-by: Marc-André Lureau
> >
> >
Hi,
On 12/21/18 4:00 PM, Frediano Ziglio wrote:
This file was used by the old client to hold return error codes.
Signed-off-by: Frediano Ziglio
---
spice/Makefile.am | 1 -
spice/error_codes.h | 51 -
spice/meson.build | 1 -
3 files
ping
On Sat, Dec 22, 2018 at 6:53 PM wrote:
>
> From: Marc-André Lureau
>
> Use widget properties instead, as recommended in the documentation.
> The UI doesn't seem to have changed after these modifications.
>
> Signed-off-by: Marc-André Lureau
> ---
> src/usb-device-widget.c | 23
ping
On Sat, Dec 22, 2018 at 6:53 PM wrote:
>
> From: Marc-André Lureau
>
> Split lib dependencies in 3 groups: glib, gtk, and acl.
>
> Fixes:
> https://gitlab.freedesktop.org/spice/spice-gtk/issues/77
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 46
Hi
On Sat, Dec 22, 2018 at 7:06 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > Fixes
> > WARNING: Use the 'pie' kwarg instead of passing '-fpie' manually to
> > 'spice-client-glib-usb-acl-helper'
> >
> > Signed-off-by: Marc-André Lureau
>
> Patch looks good.
> Technically
35 matches
Mail list logo
