On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote:
> This is a preparatory patch for GTK+ vdagent redesign.
>
> Since most of the vdagent code still uses X11 lib,
> force GDK to use X11 backend by calling
> gdk_set_allowed_backends("x11").
What happens if the agent tries to use gtk+, an
nt_send_item() (did not check there is no
other ref), so we don't signal "item sent" much earlier than before.
Apart from the log,
Acked-by: Christophe Fergeau
Christophe
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel-client.c | 30 +++
On Wed, Nov 29, 2017 at 06:34:52AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Nov 28, 2017 at 10:43:33AM +, Frediano Ziglio wrote:
> > > Most of the documentation is extracted from notes in spice-server
> > > code and comments.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > s
uint32 num_frames;
> +// the part of the above frames that was dropped by the client due
> +// to late arrival time
"that were dropped"
Acked-by: Christophe Fergeau
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Sure,
Acked-by: Christophe Fergeau
On Tue, Nov 28, 2017 at 11:25:09AM +, Frediano Ziglio wrote:
> unexected -> unexpected
> esitimation -> estimation
>
> Signed-off-by: Frediano Ziglio
> ---
> server/mjpeg-encoder.c | 6 +++---
> 1 file changed, 3 insertions(+
On Thu, Nov 23, 2017 at 11:06:23PM +0100, Stefan Pietsch wrote:
> Dear list,
>
> I tried to install the latest Spice guest tools in Windows 2016, but the
> installer says: "Unsupported Windows version".
>
> This is the file I was trying to install:
> https://www.spice-space.org/download/binaries/
On Wed, Nov 22, 2017 at 06:19:34PM +0100, Christophe Fergeau wrote:
> On Wed, Nov 22, 2017 at 04:33:23PM +0100, Christophe de Dinechin wrote:
> > From: Christophe de Dinechin
> >
> > The C++ One Definition Rule (ODR) states that all translation units
> > must see t
On Wed, Nov 22, 2017 at 04:33:23PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> The C++ One Definition Rule (ODR) states that all translation units
> must see the same definitions. In the current code, when we call
> Agent::PluginVersionIsCompatible from the plugin, it
On Wed, Nov 22, 2017 at 11:35:06AM -0500, Frediano Ziglio wrote:
> >
> > >
> > > On Wed, Nov 22, 2017 at 12:11:33PM +, Frediano Ziglio wrote:
> > > > Allows to specify abstract Unix sockets addresses.
> > > > These Unix sockets are supported on Linux and allows to not
> > > > have file system
On Wed, Nov 22, 2017 at 11:17:52AM -0500, Frediano Ziglio wrote:
> >
> > I'd expect a few lines in the commit log.
> >
> > Acked-by: Christophe Fergeau
> >
> > Christophe
> >
>
> What about:
>
> "Current code does not free all
I'd expect a few lines in the commit log.
Acked-by: Christophe Fergeau
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
067,10 @@ static void reds_handle_ticket(void *opaque)
> goto error;
> }
>
> +//todo: use monotonic time
> +time(<ime);
> +expired = reds->config->taTicket.expiration_time < ltime;
> +
You can drop the extra white
On Wed, Nov 22, 2017 at 12:11:33PM +, Frediano Ziglio wrote:
> Allows to specify abstract Unix sockets addresses.
> These Unix sockets are supported on Linux and allows to not
> have file system names.
What would be the use-case? Just cleaner not to have a dummy path in the
FS? Or does it brin
Acked-by: Christophe Fergeau
On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote:
> Allows a better encapsulation in the future
>
> Signed-off-by: Frediano Ziglio
> ---
> src/spice-streaming-agent.cpp | 28 +---
> 1 file changed, 17
On Tue, Nov 21, 2017 at 12:28:59PM +, Frediano Ziglio wrote:
> diff --git a/server/stream-channel.c b/server/stream-channel.c
> index c7ca0206..da3f3a4f 100644
> --- a/server/stream-channel.c
> +++ b/server/stream-channel.c
> @@ -203,6 +203,13 @@ stream_channel_send_item(RedChannelClient *rcc,
On Thu, Nov 16, 2017 at 10:17:28AM -0500, Frediano Ziglio wrote:
> > 4. It delegates usage information to the plugins, so that each plugin
> >can document its specific options in a consistent way.
> >
> > 5. It cleans up some confusing or surprising aspects of the interace,
> >notably null
One side effect of this patch is that it makes enums.h fairly
unreadable, which is not so good as it's exposed as public API.
Do you expect to use this that often? I agree it's convenient, but on
the other hand, it's going to make it fairly easy to make "broken"
builds if this is used a lot in the
// this message should not be read
> +p = add_stream_hdr(p, STREAM_TYPE_INVALID, 0);
> +*message_sizes_end++ = p - message;
> +
> +vmc_instance.base.sif = &vmc_interface.base;
> +spice_server_add_interface(test->server, &vmc_instance.base);
> +
> +/
On Tue, Nov 21, 2017 at 03:35:55AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Nov 21, 2017 at 03:25:35AM -0500, Frediano Ziglio wrote:
> > > >
> > > > On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote:
> > > > > Allows a better encapsulation in the future
> > > > >
> > > > > Sig
Acked-by: Christophe Fergeau
On Mon, Nov 20, 2017 at 03:52:27PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel-client.h | 17 +---
> server/red-channel.h| 19 ++---
> server/red-client.h | 13 +-
&
On Tue, Nov 21, 2017 at 03:25:35AM -0500, Frediano Ziglio wrote:
> >
> > On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote:
> > > Allows a better encapsulation in the future
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > src/spice-streaming-agent.cpp | 28 +
On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote:
> Allows a better encapsulation in the future
>
> Signed-off-by: Frediano Ziglio
> ---
> src/spice-streaming-agent.cpp | 28 +---
> 1 file changed, 17 insertions(+), 11 deletions(-)
>
> diff --git a/src/spi
On Mon, Nov 20, 2017 at 04:14:01PM +, Frediano Ziglio wrote:
> common/mem.h contains mainly memory allocation functions.
> As we decided to move to Glib calls directly avoid to include
> function declaration we should not use anymore.
Sure,
Acked-by: Christophe Fergeau
>
>
On Thu, Nov 16, 2017 at 07:12:17AM -0500, Frediano Ziglio wrote:
> >
> > Hey,
> >
> > Some concrete examples of what you are going to do with it would be
> > useful ;)
> >
> > Christophe
> >
> > On Mon, Nov 13, 2017 at 01:16:32PM +, Frediano Ziglio wrote:
> > > An identity macro in C is a m
Hey,
Some concrete examples of what you are going to do with it would be
useful ;)
Christophe
On Mon, Nov 13, 2017 at 01:16:32PM +, Frediano Ziglio wrote:
> An identity macro in C is a macro defined as
>
> #define SOME_NAME SOME_NAME
>
> They are often used to make possible to use prepro
On Mon, Nov 13, 2017 at 03:47:43PM +, Frediano Ziglio wrote:
> This give an hint to client which can optimise rendering.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/stream-channel.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/server/stream-channel.c b/server/stream-
Acked-by: Christophe Fergeau
On Wed, Nov 15, 2017 at 09:44:35AM +, Frediano Ziglio wrote:
> Follow up due to read_command declaration change.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/spice-streaming-agent.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 dele
On Thu, Nov 09, 2017 at 06:48:08PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> This lets us get rid of C-style 'goto done' in do_capture.
>
> Signed-off-by: Christophe de Dinechin
> ---
> src/spice-streaming-agent.cpp | 34 --
> 1 fil
On Thu, Nov 09, 2017 at 04:48:37PM +0100, Christophe de Dinechin wrote:
> >
> > I consider a downside, if I have for instance 2 C open calls and want
> > to define 2 defers I cannot.
>
> You can. You just need to put a surrounding block to make the lifetime of
> each of your cleanups more explici
On Thu, Nov 09, 2017 at 07:25:20AM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Nov 08, 2017 at 03:02:35PM +, Frediano Ziglio wrote:
> > > This better integrate with exceptions.
> > > Also don't leak resources using a return in the middle of the
> > > code.
> > >
> > > Signed-off-by: Fredian
This script currently expects the reference file and the generated file
to both be in the same directory, which is not the case when doing a
build with builddir != srcdir (or when running make distcheck)
Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
---
src/unittests/hexdump.sh
On Thu, Nov 09, 2017 at 06:12:29AM -0500, Frediano Ziglio wrote:
>
> this however prevents the user to just call ./hexdump.sh
> as SRCDIR and BUILDDIR are not defined.
>
> Maybe adding some lines like
>
> SRCDIR="${SRCDIR:-.}"
>
> to support the normal case.
Yes, actually just SRCDIR=`basename
On Wed, Nov 08, 2017 at 03:02:35PM +, Frediano Ziglio wrote:
> This better integrate with exceptions.
> Also don't leak resources using a return in the middle of the
> code.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/Makefile.am | 1 +
> src/defer.hpp | 16
automake does not support this,
see https://www.gnu.org/software/automake/manual/html_node/Wildcards.html
and this was causing weird failures when running make distcheck
(automake looking for *.in files in $builddir rather than $srcdir, and
then an unwanted hexdump\*.out file created in $builddir,
This script currently expects the reference file and the generated file
to both be in the same directory, which is not the case when doing a
build with builddir != srcdir (or when running make distcheck)
---
src/unittests/Makefile.am | 1 +
src/unittests/hexdump.sh | 13 +++--
2 files ch
for the series,
Acked-by: Christophe Fergeau
On Wed, Nov 08, 2017 at 02:18:52PM +, Frediano Ziglio wrote:
> Frediano Ziglio (6):
> Make the compiler work out better way to write unaligned memory
> test-marshallers: Use unaligned structure
> test-marsh
Acked-by: Frediano Ziglio
---
configure.ac | 2 +-
spice-streaming-agent.spec.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index a21832b..1d86200 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7,7 +7,7 @@ AM_CONFIG_HEADER
For once, the default automake behaviour is better than the one this
macro adds... See
https://blogs.gnome.org/desrt/2011/09/08/am_maintainer_mode-is-not-cool/
for details:
« what this macro means is that changes to your Makefile.am will not
automatically result in the Makefile being regenerated un
Acked-by: Frediano Ziglio
---
README | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/README b/README
index d07c014..7e9a3c7 100644
--- a/README
+++ b/README
@@ -2,9 +2,11 @@ Introduction
The SPICE Streaming Agent is a guest-side daemon whi
This is more consistent with how other RPM macros are used (%{release},
%{version}, ...)
---
Changes since v1:
- more details in the commit log
spice-streaming-agent.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/spice-streaming-agent.spec.in b/spice-streaming
The .pc file defines a plugin installation location, which will be arch
dependent, so the .pc file belongs in this arch ${libdir}, not in the
'noarch' ${sharedir}
Acked-by: Frediano Ziglio
---
Makefile.am | 2 +-
spice-streaming-agent.spec.in | 2 +-
2 files changed, 2 insertio
It needs pkg-config to be installed since it installs a .pc file.
---
Changes since v1:
- only add pkgconfig Requires
spice-streaming-agent.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
index e8c6d54..99b1f52 100644
-
On Wed, Nov 08, 2017 at 07:25:21AM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Nov 08, 2017 at 10:31:38AM +0100, Christophe Fergeau wrote:
> > > Hey,
> > >
> > > On Wed, Nov 08, 2017 at 08:20:12AM +, Frediano Ziglio wrote:
> > > > Mis
On Wed, Nov 08, 2017 at 07:44:38AM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Nov 08, 2017 at 07:15:21AM -0500, Frediano Ziglio wrote:
> > > >
> > > > This makes patch applying easier, no need to duplicate the information
> > > > in 2 places, a PatchN entry is enough.
> > > > ---
> > > > spic
On Wed, Nov 08, 2017 at 07:07:59AM -0500, Frediano Ziglio wrote:
> Why this is better ?
I'll add this to the commit log, but I find it more obvious this way
that this is an RPM variable, as opposed to something set by the shell.
>
> >
> > ---
> > spice-streaming-agent.spec.in | 6 +++---
> >
On Wed, Nov 08, 2017 at 07:09:11AM -0500, Frediano Ziglio wrote:
> >
> > The .pc file defines a plugin installation location, which will be arch
> > dependent, so the .pc file belongs in this arch ${libdir}, not in the
> > 'noarch' ${sharedir}
> > ---
> > Makefile.am | 2 +-
> >
On Wed, Nov 08, 2017 at 07:15:21AM -0500, Frediano Ziglio wrote:
> >
> > This makes patch applying easier, no need to duplicate the information
> > in 2 places, a PatchN entry is enough.
> > ---
> > spice-streaming-agent.spec.in | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >
This makes patch applying easier, no need to duplicate the information
in 2 places, a PatchN entry is enough.
---
spice-streaming-agent.spec.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
index 91e6b88..e384951
---
spice-streaming-agent.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
index e384951..8c4f26e 100644
--- a/spice-streaming-agent.spec.in
+++ b/spice-streaming-agent.spec.in
@@ -34,9 +34,9 @@ agent pl
---
README | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/README b/README
index d07c014..7e9a3c7 100644
--- a/README
+++ b/README
@@ -2,9 +2,11 @@ Introduction
The SPICE Streaming Agent is a guest-side daemon which captures the
-guest X.Or
For once, the default automake behaviour is better than the one this
macro adds... See
https://blogs.gnome.org/desrt/2011/09/08/am_maintainer_mode-is-not-cool/
for details:
« what this macro means is that changes to your Makefile.am will not
automatically result in the Makefile being regenerated un
It needs the corresponding library to be installed, as well as
pkg-config since it installs a .pc file.
---
Since the plugins are going to be dlopened, and since the main package
does not ship a .so we need to link to, I'm unsure about the first
Requires this patch adds.
Christophe
spice-stream
---
configure.ac | 2 +-
spice-streaming-agent.spec.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index a21832b..1d86200 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7,7 +7,7 @@ AM_CONFIG_HEADER([config.h])
AC_CONFIG_MAC
The .pc file defines a plugin installation location, which will be arch
dependent, so the .pc file belongs in this arch ${libdir}, not in the
'noarch' ${sharedir}
---
Makefile.am | 2 +-
spice-streaming-agent.spec.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
On Wed, Nov 08, 2017 at 10:31:38AM +0100, Christophe Fergeau wrote:
> Hey,
>
> On Wed, Nov 08, 2017 at 08:20:12AM +, Frediano Ziglio wrote:
> > Missing some names cause some debugging messages to be
> > generated and some of our tests to fail.
>
> Something I wan
Acked-by: Christophe Fergeau
On Wed, Nov 08, 2017 at 06:04:53AM -0500, Frediano Ziglio wrote:
> ping
>
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > COPYING | 203
> > +-
>
lly.
Christophe
>
> This patch was written by Christophe Fergeau.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/utils.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Tested with Gitlab, see https://gitlab.com/freddy77/spice/-/jobs/39471945
>
> diff --git a
On Tue, Nov 07, 2017 at 03:17:31PM +, Frediano Ziglio wrote:
> Fedora 26 removed dependency from python-pyparsing/python-six
> to python but we require the executable to run some scripts
I'd much prefer that this explicitly installs python3-pyparsing/python3-six
(python3 being the future ;). T
On Mon, Oct 30, 2017 at 10:22:40PM +0800, Matthew J. Francis wrote:
> On 30/10/2017 17:28, Frediano Ziglio wrote:
> > This patch changes ABI so would need a version bump and a Qemu patch.
> > Did you send a patch to Qemu too?
>
> As mentioned in the patch overview, I haven't touched qemu yet - if
On Fri, Nov 03, 2017 at 02:47:17PM +0800, Matthew J. Francis wrote:
> Following up to myself:
> I got at least two things wrong in the above analysis.
>
> Firstly, in the Xspice case, we control both ends of the fake uinput
> connection (written to by vdagentd, read from by the "xspice pointer"
>
On Wed, Oct 25, 2017 at 04:26:32PM +0200, Sandro Bonazzola wrote:
> 2017-10-25 16:12 GMT+02:00 Christophe Fergeau :
>
> > Hey,
> >
> > On Tue, Oct 24, 2017 at 07:21:02PM +0200, Sandro Bonazzola wrote:
> > > Any link to release notes?
> >
> > The c
Hey,
On Tue, Oct 24, 2017 at 07:21:02PM +0200, Sandro Bonazzola wrote:
> Any link to release notes?
The closest that we have to release notes would be
https://cgit.freedesktop.org/spice/spice/tree/NEWS
Is that good enough or are you expecting something different for release
notes?
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hey,
On Tue, Oct 24, 2017 at 05:31:08PM +0800, 王杰东 wrote:
> I download virt-viewer-x64-5.0.msi and UsbDk_1.0.7_x64.msi , then install
> them on my Windows 10 ,
> when i connect to a vm via remote-viewer.exe "full screen", then i click
> button "USB devices selection" on toolbar , there is no USB
On Fri, Oct 20, 2017 at 06:05:27AM -0400, Frediano Ziglio wrote:
> > diff --git a/server/reds.c b/server/reds.c
> > index 4af804065..de5f4461c 100644
> > --- a/server/reds.c
> > +++ b/server/reds.c
> > @@ -3983,32 +3983,23 @@ SPICE_GNUC_VISIBLE int
> > spice_server_set_zlib_glz_compression(SpiceSer
This commit adds red_channel_{debug,warning,printerr}() helpers which
will prepend the log message with "channel-name:id (%p)". It also
changes various locations which were doing this manually.
---
Changes since v3:
- Removed useless do {} while
- Added () around parameter name in macro
- Use consi
spice_server_set_channel_security() is already mostly doing that. We can
make its code more generic, and introduce a red_channel_get_name()
method. This method will then be used to make debug messages more
readable by showing the actual channel name rather than its type as
an int.
---
Changes since
Hey,
On Mon, Oct 23, 2017 at 09:51:51AM +0200, Javier Celaya wrote:
> Hello list,
>
> Recently, we updated the Qemu version being used by flexVDI. We were
> using a pre-3.3 QXL device, so it did not provide the
> client_monitors_config callback and that message was getting through to
> the VDAgen
On Mon, Oct 23, 2017 at 06:30:14PM +0800, Matthew J. Francis wrote:
> On 21/10/2017 22:50, Real wrote:
> > I'm a beginner，I do not know how to build spice-gtk on mac os x. Can
> > you help me? thank you
>
> I recently attempted this.
> Basic build instructions can be found at
>
> https://www.spic
Hey,
On Wed, Oct 18, 2017 at 07:40:47AM -0400, Frediano Ziglio wrote:
> About g_warning and g_debug I remember there's still a pending discussion
> on calling these directly. I would stick to spice_debug/spice_warning until
> the discussion is closed.
I did not change this in v3 (but there can al
This commit adds red_channel_{debug,warning,printerr}() helpers which
will prepend the log message with "channel-name:id (%p)". It also
changes various locations which were doing this manually.
---
Changes since v2:
- added red_channel_log_generic macro to limit the amount of copy and
paste
- onl
spice_server_set_channel_security() is already mostly doing that. We can
make its code more generic, and introduce a red_channel_get_name()
method. This method will then be used to make debug messages more
readable by showing the actual channel name rather than its type as
an int.
---
No changes si
spice_server_set_channel_security() is already mostly doing that. We can
make its code more generic, and introduce a red_channel_get_name()
method. This method will then be used to make debug messages more
readable by showing the actual channel name rather than its type as
an int.
---
Changes since
This commit adds red_channel_{debug,warning,printerr}() helpers which
will prepend the log message with "channel-name:id (%p)". It also
changes various locations which were doing this manually.
---
server/red-channel-client.c | 34 ++
server/red-channel.c| 1
On Wed, Oct 18, 2017 at 06:00:00AM -0400, Frediano Ziglio wrote:
> >
> > On Wed, Oct 18, 2017 at 04:08:50AM -0400, Frediano Ziglio wrote:
> > > >
> > > > On Tue, Oct 17, 2017 at 05:15:22PM -0400, Frediano Ziglio wrote:
> > > > > > +static const char *const channel_names[] = {
> > > > > > +[ S
On Wed, Oct 18, 2017 at 09:51:56AM +0300, Yedidyah Bar David wrote:
>
> Filed for this, so that we do not forget it:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1503441
Thanks!
>
> It's still not a replacement for oVirt's needs - so please
> consider/review/ack also current patch. Thanks.
On Wed, Oct 18, 2017 at 04:08:50AM -0400, Frediano Ziglio wrote:
> >
> > On Tue, Oct 17, 2017 at 05:15:22PM -0400, Frediano Ziglio wrote:
> > > > +static const char *const channel_names[] = {
> > > > +[ SPICE_CHANNEL_MAIN ] = "main",
> > > > +[ SPICE_CHANNEL_DISPLAY ] = "display",
> >
On Wed, Oct 18, 2017 at 04:31:17AM -0400, Frediano Ziglio wrote:
> Why don't we have a schema like Unix ioctl (where constants are mostly
> uniques) and implement some gdb macros?
> For instance we could pretty print the entire channel queue.
In my case, it really is something I wanted to pass to
On Tue, Oct 17, 2017 at 05:15:22PM -0400, Frediano Ziglio wrote:
> > +static const char *const channel_names[] = {
> > +[ SPICE_CHANNEL_MAIN ] = "main",
> > +[ SPICE_CHANNEL_DISPLAY ] = "display",
> > +[ SPICE_CHANNEL_INPUTS ] = "inputs",
> > +[ SPICE_CHANNEL_CURSOR ] = "cu
On Tue, Oct 17, 2017 at 03:34:14PM -0500, Jonathon Jongsma wrote:
> To be honest, to me it feels like the benefit from this change is not
> worth the added complexity of generating GEnums and modifying the
> channel clients, etc. Do you have plans to use this somewhere? Or do
> you just call it fro
On Mon, Oct 16, 2017 at 05:01:14PM +0300, Yedidyah Bar David wrote:
> On Mon, Oct 16, 2017 at 4:16 PM, Yedidyah Bar David wrote:
> > On Mon, Oct 16, 2017 at 4:07 PM, Christophe Fergeau
> > wrote:
> >> My understanding is that the short log really should be saying "
On Mon, Oct 16, 2017 at 10:53:43AM -0400, Frediano Ziglio wrote:
> > -
> > -n = select(nfds, &readfds, &writefds, NULL, NULL);
> > -if (n == -1) {
> > -if (errno == EINTR)
> > -continue;
> > -syslog(LOG_ERR, "Fatal error select: %s", strerror(
My understanding is that the short log really should be saying "oVirt CI
support" rather than "standard CI support".
Has gitlab built-in CI been considered for this work? In other words,
why use oVirt for CI rather than something more "standard"?
Where would the error messages go if CI fails? Are
If these paths are unquoted, and the path contains spaces (C:\Program
Files (x86)\...), this could be exploited by putting a binary with a
crafted name (C:\Program.exe), leading to priviledge escalation as this
is a service that is being started.
https://www.commonexploits.com/unquoted-service-pat
On Fri, Oct 13, 2017 at 12:20:02PM -0400, Frediano Ziglio wrote:
> >
> > For the series,
> > Acked-by: Christophe Fergeau
> > though I would put the test after the fix, or squash both.
> >
> > Christophe
> >
>
> Some TDD methodologies suggest
For the series,
Acked-by: Christophe Fergeau
though I would put the test after the fix, or squash both.
Christophe
On Thu, Oct 12, 2017 at 03:56:16PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/test-leaks.c | 36
On Thu, Oct 12, 2017 at 11:06:02AM -0400, Frediano Ziglio wrote:
> >
> > On Fri, Oct 06, 2017 at 11:58:32AM +0100, Frediano Ziglio wrote:
> > > This function does not make much sense anymore.
> > > Is called by RedVmcChannel which doesn't use RedChannelClient ACKs
> > > so the variable changed are
u", size);
> +return FALSE;
> +}
> +
I would say this is a good candidate for using red_channel_warning()
which I sent a series for ;)
If the header is invalid, spice_error() is used, better to use
spice_error() here too for consistency? (or the opposite).
make sense, especially as I'm not convinced
smartcard.c/spicevmc.c should call
red_channel_client_ack_zero_messages_window() as they don't handle acks.
Looks good to me,
Acked-by: Christophe Fergeau
Christophe
signature.asc
Description: PGP signature
___
Hey,
On Wed, Oct 11, 2017 at 02:33:00AM +1100, ge...@hostfission.com wrote:
> I just spent the last hour searching for the header that contains "RedInit"
> according to the Spice protocol specification, frustratingly not finding it.
>
> After digging through the client source I finally discovered
On Thu, Oct 12, 2017 at 05:21:37PM +0800, 一位大叔 wrote:
> My host is centos7, with virt-manager installed a windows7, the host
> installed spice-server, windows7 started the vdagent service, in the
> host using the remote viewer connection, reported socket I / O error,
> How can i deal with it?
I
The typename is unused, and glib-mkenums would try to generate a type with the
same name when parsing red-channel-client.h
---
server/red-channel-client.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red-channel-client.h b/server/red-channel-client.h
index 56503c4
---
server/Makefile.am| 21 ++---
server/common-graphics-channel.h | 4 ++--
server/cursor-channel-client.h| 4 ++--
server/display-channel-private.h | 4 ++--
server/inputs-channel-client.h| 4 ++--
server/main-channel-client.h | 4 ++--
server/red-
Given a RedPipeItem, this returns a string corresponding to its type,
which is useful while debugging to get a better feel of what's going on.
This is achieved by introducing a new
RedChannelClientClass::red_pipe_item_type member, which is then used
together with the enum data generated by glib-mk
Hey,
While looking at that migration bug, these helpers proved quite helpful
to get human-readable logs out of spice-server.
Beginning of the patch series adds RedChannel helpers so that logs show a
human-readable channel name.
Second half of the patch series uses glib enum introspection in order
spice_server_set_channel_security() is already mostly doing that. We can
make its code more generic, and introduce a red_channel_get_name()
method. This method will then be used to make debug messages more
readable by showing the actual channel name rather than its type as
an int.
---
server/red-c
This commit adds red_channel_{debug,warning,printerr}() helpers which
will prepend the log message with "channel-name:id (%p)". It also
changes various locations which were doing this manually.
---
server/red-channel-client.c | 34 ++
server/red-channel.c| 1
On Wed, Oct 11, 2017 at 07:46:29AM -0400, Frediano Ziglio wrote:
> >
> > On Wed, Oct 11, 2017 at 11:30:38AM +0100, Frediano Ziglio wrote:
> > > Some release of ImageMagick contains a bug in compare
> > > utility which uses uninitialized data.
> > > This currently happens on Fedora 25 and 26.
> >
On Wed, Oct 11, 2017 at 11:30:38AM +0100, Frediano Ziglio wrote:
> Some release of ImageMagick contains a bug in compare
> utility which uses uninitialized data.
> This currently happens on Fedora 25 and 26.
nack, this happens to fix it on a specific scenario, there is absolutely
no guarantee this
---
NEWS | 9 +
configure.ac | 2 +-
2 files changed, 10 insertions(+), 1 deletion(-)
Going to push this shortly, and make the release ;)
Christophe
diff --git a/NEWS b/NEWS
index 3f715d2f6..51bb4a2e6 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,12 @@
+Major Changes in 0.14.0:
+=
1101 - 1200 of 6964 matches
Mail list logo
