Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-28 Thread Gerd Hoffmann
Hi, > Well, so instead of tagging messages the protocol is tagging single fields, > something like the difference between a plain text and XML (although there's > no hierarchy in evdev schema). Is possible but this suggestion is more about > base protocol change. Yes. If we have to add Mouse*V

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-28 Thread Frediano Ziglio
> > On Mon, Aug 27, 2018 at 12:13:47PM -0400, Frediano Ziglio wrote: > > > > > > Hi, > > > > > > > +typedef struct SpiceMsgcMousePositionV2 { > > > > +uint32_t x; > > > > +uint32_t y; > > > > +uint32_t buttons_state; > > > > +uint32_t channel_id; > > > > +uint32_t monitor_id;

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-27 Thread Gerd Hoffmann
On Mon, Aug 27, 2018 at 12:13:47PM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > > +typedef struct SpiceMsgcMousePositionV2 { > > > +uint32_t x; > > > +uint32_t y; > > > +uint32_t buttons_state; > > > +uint32_t channel_id; > > > +uint32_t monitor_id; > > > +} SpiceMsgcMous

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-27 Thread Frediano Ziglio
> > Hi, > > > +typedef struct SpiceMsgcMousePositionV2 { > > +uint32_t x; > > +uint32_t y; > > +uint32_t buttons_state; > > +uint32_t channel_id; > > +uint32_t monitor_id; > > +} SpiceMsgcMousePositionV2; > > When touching the mouse messages anyway I'd suggest to design it mo

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-27 Thread Gerd Hoffmann
Hi, > +typedef struct SpiceMsgcMousePositionV2 { > +uint32_t x; > +uint32_t y; > +uint32_t buttons_state; > +uint32_t channel_id; > +uint32_t monitor_id; > +} SpiceMsgcMousePositionV2; When touching the mouse messages anyway I'd suggest to design it more like the linux input

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Gerd Hoffmann
Hi, > Note also that under Linux currently all these protocol limitations allows > to support only a single device with multiple output, which is a problem for > vGPU. Under Windows we support multiple devices but all devices are limited > to one monitor. Extending Linux using the same limitatio

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Marc-André Lureau
Hi On Thu, Aug 23, 2018 at 2:15 PM Lukáš Hrázký wrote: > > On Thu, 2018-08-23 at 03:51 -0400, Frediano Ziglio wrote: > > > > > > Hi > > > > > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > > > wrote: > > > > > > > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > > > > The vers

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Lukáš Hrázký
On Thu, 2018-08-23 at 03:51 -0400, Frediano Ziglio wrote: > > > > Hi > > > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > > wrote: > > > > > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > > > The version 2 is using a (channel_id, monitor_id) pair to uniquely > > > > identif

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Lukáš Hrázký
On Wed, 2018-08-22 at 16:11 -0500, Jonathon Jongsma wrote: > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > The version 2 is using a (channel_id, monitor_id) pair to uniquely > > identify the display on which the event occured, instead of the > > ambiguous display_id. > > > > Signed-of

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Marc-André Lureau
Hi On Thu, Aug 23, 2018 at 11:53 AM Frediano Ziglio wrote: > > > > > Hi > > On Thu, Aug 23, 2018 at 9:51 AM Frediano Ziglio wrote: > > > > > > > > > > > Hi > > > > > > > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > > > > wrote: > > > > > > > > > > On Thu, 2018-08-16 at 18:26 +0200, Luká

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Frediano Ziglio
> > Hi > On Thu, Aug 23, 2018 at 9:51 AM Frediano Ziglio wrote: > > > > > > > > Hi > > > > > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > > > wrote: > > > > > > > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > > > > The version 2 is using a (channel_id, monitor_id) pair to

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Marc-André Lureau
Hi On Thu, Aug 23, 2018 at 9:51 AM Frediano Ziglio wrote: > > > > > Hi > > > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > > wrote: > > > > > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > > > The version 2 is using a (channel_id, monitor_id) pair to uniquely > > > > identif

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Frediano Ziglio
> > Hi > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > wrote: > > > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > > The version 2 is using a (channel_id, monitor_id) pair to uniquely > > > identify the display on which the event occured, instead of the > > > ambiguous disp

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-22 Thread Marc-André Lureau
Hi On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma wrote: > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > The version 2 is using a (channel_id, monitor_id) pair to uniquely > > identify the display on which the event occured, instead of the > > ambiguous display_id. > > > > Signe

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-22 Thread Jonathon Jongsma
On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > The version 2 is using a (channel_id, monitor_id) pair to uniquely > identify the display on which the event occured, instead of the > ambiguous display_id. > > Signed-off-by: Lukáš Hrázký > --- > common/messages.h | 8 > spice.pr

[Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-16 Thread Lukáš Hrázký
The version 2 is using a (channel_id, monitor_id) pair to uniquely identify the display on which the event occured, instead of the ambiguous display_id. Signed-off-by: Lukáš Hrázký --- common/messages.h | 8 spice.proto | 8 2 files changed, 16 insertions(+) diff --git a