Re: [Spice-devel] [vdagent-linux v2] systemd: Remove unneded virtio-port dependencies

2018-12-20 Thread Frediano Ziglio
> On Wed, Dec 19, 2018 at 09:52:57AM -0500, Frediano Ziglio wrote: > > The "Requisite" still prevents the socket to be activated with a > > "systemctl enable spice-vdagentd.socket" launched manually. > > You can obviously complaint that users should not do that but > > I don't think that if the

Re: [Spice-devel] [vdagent-linux v2] systemd: Remove unneded virtio-port dependencies

2018-12-19 Thread Christophe Fergeau
On Wed, Dec 19, 2018 at 09:52:57AM -0500, Frediano Ziglio wrote: > The "Requisite" still prevents the socket to be activated with a > "systemctl enable spice-vdagentd.socket" launched manually. > You can obviously complaint that users should not do that but > I don't think that if the system says

Re: [Spice-devel] [vdagent-linux v2] systemd: Remove unneded virtio-port dependencies

2018-12-19 Thread Frediano Ziglio
> On Wed, Dec 19, 2018 at 04:11:09AM -0500, Frediano Ziglio wrote: > > > > > > On Tue, Dec 18, 2018 at 12:15:09PM -0500, Frediano Ziglio wrote: > > > > > > > > > > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket > > > > > to the relevant virtio devices, which automatically adds >

Re: [Spice-devel] [vdagent-linux v2] systemd: Remove unneded virtio-port dependencies

2018-12-19 Thread Christophe Fergeau
On Wed, Dec 19, 2018 at 04:11:09AM -0500, Frediano Ziglio wrote: > > > > On Tue, Dec 18, 2018 at 12:15:09PM -0500, Frediano Ziglio wrote: > > > > > > > > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket > > > > to the relevant virtio devices, which automatically adds

Re: [Spice-devel] [vdagent-linux v2] systemd: Remove unneded virtio-port dependencies

2018-12-19 Thread Frediano Ziglio
> > On Tue, Dec 18, 2018 at 12:15:09PM -0500, Frediano Ziglio wrote: > > > > > > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket > > > to the relevant virtio devices, which automatically adds Wants=${device} > > > to spice-vdagentd.socket (see 'systemctl show

Re: [Spice-devel] [vdagent-linux v2] systemd: Remove unneded virtio-port dependencies

2018-12-18 Thread Christophe Fergeau
On Tue, Dec 18, 2018 at 12:15:09PM -0500, Frediano Ziglio wrote: > > > > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket > > to the relevant virtio devices, which automatically adds Wants=${device} > > to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket'). > >

Re: [Spice-devel] [vdagent-linux v2] systemd: Remove unneded virtio-port dependencies

2018-12-18 Thread Frediano Ziglio
> > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket > to the relevant virtio devices, which automatically adds Wants=${device} > to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket'). > Adding a Requisite/After for these ports is at best redundant, and most > likely