Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

Hi, On Wed, Jun 14, 2017 at 04:24:17PM +, Marc-André Lureau wrote: > On Thu, Jun 8, 2017 at 12:59 PM Christophe Fergeau > wrote: > > > On Thu, Jun 08, 2017 at 04:41:55AM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > On Thu, Jun 08, 2017 at 04:31:20

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

On Wed, Jun 14, 2017 at 04:24:17PM +, Marc-André Lureau wrote: > On Thu, Jun 8, 2017 at 12:59 PM Christophe Fergeau > wrote: > > As I said, we are not going to agree there :) "If it's used > > consistently, it does not cause confusion", does not mean that's a good > > thing :) This just makes

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

On Thu, Jun 8, 2017 at 12:59 PM Christophe Fergeau wrote: > On Thu, Jun 08, 2017 at 04:41:55AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Thu, Jun 08, 2017 at 04:31:20AM -0400, Marc-André Lureau wrote: > > > > Hi > > > > > > > > - Original Message ---

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

On Thu, Jun 08, 2017 at 04:41:55AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Thu, Jun 08, 2017 at 04:31:20AM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > On Thu, Jun 08, 2017 at 12:55:38AM +0400, marcandre.lur...@redh

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

Hi - Original Message - > On Thu, Jun 08, 2017 at 04:31:20AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Thu, Jun 08, 2017 at 12:55:38AM +0400, marcandre.lur...@redhat.com > > > wrote: > > > > From: Marc-André Lureau > > > > > > > > Use shorter l

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

On Thu, Jun 08, 2017 at 04:31:20AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Thu, Jun 08, 2017 at 12:55:38AM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Use shorter line, use the common "d" variable for private data acces

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

Hi - Original Message - > On Thu, Jun 08, 2017 at 12:55:38AM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Use shorter line, use the common "d" variable for private data access, > > add brackets to ease reading the inner block vs the condition, remove > >

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

On Thu, Jun 08, 2017 at 12:55:38AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Use shorter line, use the common "d" variable for private data access, > add brackets to ease reading the inner block vs the condition, remove > needless != NULL. I'd lean towards NACK for

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

On Thu, 2017-06-08 at 03:54 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Thu, 2017-06-08 at 00:55 +0400, marcandre.lur...@redhat.com > > wrote: > > > From: Marc-André Lureau > > > > > > Use shorter line, use the common "d" variable for private data > > > access, >

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

Hi - Original Message - > On Thu, 2017-06-08 at 00:55 +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Use shorter line, use the common "d" variable for private data > > access, > just to make the line shorter? > > > add brackets to ease reading the inner bl

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: minor code style improvements

On Thu, 2017-06-08 at 00:55 +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Use shorter line, use the common "d" variable for private data > access, just to make the line shorter? > add brackets to ease reading the inner block vs the condition, > remove > needless != NULL