Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-12 Thread Yonit Halperin
Hi, On 03/13/2012 08:40 AM, Gerd Hoffmann wrote: On 03/12/12 19:45, Yonit Halperin wrote: Hi, On 03/12/2012 03:50 PM, Gerd Hoffmann wrote: Hi, Can you explain/exemplify, why sending data as a blob (either by (a) or (b)), that is verified only by the two ends that actually use it, is a

[Spice-devel] log file for spice-gtk

2012-03-15 Thread Yonit Halperin
Hi, Are there any plans to have a log file for spice-gtk? I think that it is very important to have logging with configurable debug level via a configuration file. It will be helpful for live debugging of user problems that are hard to reproduce. I also saw there was some discussion about .sp

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Yonit Halperin
On 03/15/2012 01:25 PM, Marc-André Lureau wrote: On Thu, Mar 15, 2012 at 11:39 AM, Alon Levy wrote: OK, so I think there is place to make remote-viewer produce a log file by default. The caller of virt-viewer/spice-gtk can redirect logging to files. By experience, I'd say this is the right so

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Yonit Halperin
On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4 components. So why make it more complicated if you can avoid it. Especially since there is no functional reason for making the qemu/client capabilities/ve

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Yonit Halperin
Hi, On 03/15/2012 02:36 PM, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4 components. So why make it more complicated if you can

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-18 Thread Yonit Halperin
Hi, On 03/15/2012 04:23 PM, Hans de Goede wrote: Hi, On 03/15/2012 03:07 PM, Yonit Halperin wrote: Hi, On 03/15/2012 02:36 PM, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-18 Thread Yonit Halperin
Hi, On 03/15/2012 04:07 PM, Yonit Halperin wrote: Hi, On 03/15/2012 02:36 PM, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-18 Thread Yonit Halperin
Hi, On 03/15/2012 04:23 PM, Hans de Goede wrote: Hi, On 03/15/2012 03:07 PM, Yonit Halperin wrote: Hi, On 03/15/2012 02:36 PM, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components

Re: [Spice-devel] [bug spice-gtk] spice-gtk memory leak

2012-03-19 Thread Yonit Halperin
On 03/16/2012 08:13 PM, Marc-André Lureau wrote: - Mensaje original - Also, running spicy under valgrind leak check tool shows quite clearly that there is nothing being leaked directly from spice-gtk, it seems. As I told you off-line, It happened to me that remote-viewer (spice-gtk cl

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-20 Thread Yonit Halperin
Hi, On 03/20/2012 03:58 PM, Gerd Hoffmann wrote: Hi, We can either store and migrate the cache, or choose to reset it. In the extinct spice seamless migration solution, the cache was reset. Hmm, this makes me wonder what the main advantage of seamless migration used to be? image cache was

Re: [Spice-devel] [PATCH spice-gtk] RFC: always release shm of primary surfaces

2012-03-22 Thread Yonit Halperin
On 03/21/2012 08:53 PM, Marc-André Lureau wrote: Note: I can't reproduce the leak, even after dozen of resolution switch. Always delete shared memory segment of primary surfaces when destroying its canvas. Ack. Tested. Just notice that it is not only for the primary surface, but for every sur

Re: [Spice-devel] [PATCH spice-gtk] RFC: always release shm of primary surfaces

2012-03-22 Thread Yonit Halperin
On 03/22/2012 02:02 PM, Marc-André Lureau wrote: On Thu, Mar 22, 2012 at 8:17 AM, Yonit Halperin wrote: Just notice that it is not only for the primary surface, but for every surface. Only if it has the SPICE_SURFACE_FLAGS_PRIMARY, if I read correctly. sorry, missed that

Re: [Spice-devel] SPICE_CHANNEL_TUNNEL

2012-03-25 Thread Yonit Halperin
Hi, On 03/23/2012 11:59 AM, Charles.Tsai-蔡清海-研究發展部 wrote: Alon, I read the spice code and found a spice tunnel channel there. What is the purpose of the tunnel channel? Is it for network tunneling? What is the use case for tunnel channel in spice? The tunnel was intended for red

[Spice-devel] [PATCH spice-protocol] controller: add COLOR_DEPTH and DISABLE_EFFECTS messages

2012-04-02 Thread Yonit Halperin
rhbz #787447 Signed-off-by: Yonit Halperin --- spice/controller_prot.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/spice/controller_prot.h b/spice/controller_prot.h index a60b122..f7b1f26 100644 --- a/spice/controller_prot.h +++ b/spice/controller_prot.h @@ -75,6

[Spice-devel] [PATCH spice-common] updated submodule spice-protocol

2012-04-02 Thread Yonit Halperin
added the disable-effects and color-depth options to the controller Signed-off-by: Yonit Halperin --- spice-protocol |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/spice-protocol b/spice-protocol index 32da251..8cf92f0 16 --- a/spice-protocol +++ b/spice-protocol

[Spice-devel] [PATCH spice-gtk] controller: add support for DISABLE_EFFECTS and COLOR_DEPTH

2012-04-02 Thread Yonit Halperin
rhbz #787449 Signed-off-by: Yonit Halperin --- data/spice-protocol.vapi |3 +++ gtk/controller/controller.vala |9 + spice-common |2 +- 3 files changed, 13 insertions(+), 1 deletions(-) diff --git a/data/spice-protocol.vapi b/data/spice

[Spice-devel] [PATCH spice-xpi] add support for DisableEffects and ColorDepth

2012-04-02 Thread Yonit Halperin
rhbz #747313 Signed-off-by: Yonit Halperin --- SpiceXPI/src/plugin/nsISpicec.idl|2 ++ SpiceXPI/src/plugin/nsScriptablePeer.cpp | 16 +++- SpiceXPI/src/plugin/nsScriptablePeer.h |2 ++ SpiceXPI/src/plugin/plugin.cpp | 26

[Spice-devel] [PATCH virt-viewer] spice/controller: add support for the properties disable-effects & color-depth

2012-04-02 Thread Yonit Halperin
rhbz #808986 Signed-off-by: Yonit Halperin --- src/remote-viewer.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-viewer.c index 7dda7fe..5f7685f 100644 --- a/src/remote-viewer.c +++ b/src/remote-viewer.c @@ -583,7 +583,9

Re: [Spice-devel] [PATCH 25/30] Replace custom region implementation with pixman_region32_t

2010-02-22 Thread Yonit Halperin
On 02/18/2010 10:58 PM, Alexander Larsson wrote: +int region_test(const QRegion *rgn, const QRegion *other_rgn, int query) { } The new implementation is not efficient comparing to the previous implementation. The previous one returns immediately once the requested query is satisfied (e.

[Spice-devel] An overview of Network redirection in Spice

2010-03-02 Thread Yonit Halperin
Hi, I’ve previously worked on the network redirection feature, which part of it is already in the upstream. Here, I present an overview of this feature and its status. Motivation -- In many scenarios, the network that the Spice client resides in is not accessible from the virtual machine.

Re: [Spice-devel] autoconf for slirp

2010-03-27 Thread Yonit Halperin
On 03/26/2010 11:45 AM, Alexander Larsson wrote: On Fri, 2010-03-26 at 10:25 +1000, Dave Airlie wrote: this is quick and dirty, and not completely tested yet, but it makes my life a little bit easier, since I don't install stuff in /usr ever. I took this, cleaned it up and made it pass distche

[Spice-devel] [PATCH] client: handling SPICE_MSG_MAIN_MIGRATE_SWITCH_HOST

2010-03-28 Thread Yonit Halperin
disconnecting from the current host and connecting to the target host. --- client/application.cpp | 42 +- client/application.h | 15 +++ client/red_client.cpp | 33 ++--- client/red_client.h|3 +++ 4

Re: [Spice-devel] autoconf for slirp

2010-03-30 Thread Yonit Halperin
On 03/28/2010 02:30 PM, Alexander Larsson wrote: On Sun, 2010-03-28 at 09:03 +0300, Yonit Halperin wrote: On 03/26/2010 11:45 AM, Alexander Larsson wrote: On Fri, 2010-03-26 at 10:25 +1000, Dave Airlie wrote: this is quick and dirty, and not completely tested yet, but it makes my life a

Re: [Spice-devel] [PATCH] client: handling SPICE_MSG_MAIN_MIGRATE_SWITCH_HOST

2010-03-31 Thread Yonit Halperin
On 03/31/2010 03:42 PM, Alexander Larsson wrote: On Sun, 2010-03-28 at 18:21 +0300, Yonit Halperin wrote: disconnecting from the current host and connecting to the target host. +SpiceMsgMainMigrationSwitchHost* migrate = (SpiceMsgMainMigrationSwitchHost*)message->data(); +char* h

[Spice-devel] [PATCH] client: handling SPICE_MSG_MAIN_MIGRATE_SWITCH_HOST

2010-03-31 Thread Yonit Halperin
disconnecting from the current host and connecting to the target host. --- client/application.cpp | 42 +- client/application.h | 15 +++ client/red_client.cpp | 42 +++--- client/red_client.h|

[Spice-devel] [PATCH] client: x11: fix a crash caused by a call to a destroyed window.

2010-04-01 Thread Yonit Halperin
Happens when a focused window is destroyed without a focus out event, and a focus-in event occurs on another window. --- client/x11/red_window.cpp | 12 +--- client/x11/red_window_p.h |2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/client/x11/red_window.cpp b/c

[Spice-devel] [PATCH] server configuration: make network redirection support optional

2010-04-06 Thread Yonit Halperin
By default it is disabled. To enable: configure --enable-tunnel. When active, requires libslirp. --- configure.ac | 20 server/Makefile.am | 12 ++-- server/reds.c |8 +++- 3 files changed, 33 insertions(+), 7 deletions(-) diff --git a/configure

Re: [Spice-devel] [Spice-commits] 2 commits - server/reds.c server/red_worker.c

2010-04-07 Thread Yonit Halperin
+static void red_clear_surface_glz_drawables(RedWorker *worker, int surface_id) +{ +RingItem *ring_item; + +if (!worker->display_channel) { +return; +} + + pthread_mutex_lock(&worker->display_channel->glz_drawables_inst_to_free_lock); + +while ((ring_item = ring_get

Re: [Spice-devel] [Spice-commits] client/windows

2010-04-11 Thread Yonit Halperin
On 04/08/2010 10:31 AM, Alexander Larsson wrote: client/windows/redc.sln|4 ++-- client/windows/redc.vcproj | 13 ++--- 2 files changed, 8 insertions(+), 9 deletions(-) New commits: commit ed568302ad62db7eb8cc52961484c227a401f14e Author: Alexander Larsson Date: Thu Apr 8

[Spice-devel] [PATCH] DrvSetPointerShape: handle surface which is not bitmap

2010-04-13 Thread Yonit Halperin
--- display/res.c | 99 +++- display/rop.c |2 +- display/rop.h |3 ++ 3 files changed, 87 insertions(+), 17 deletions(-) diff --git a/display/res.c b/display/res.c index 318ea9c..2ea9565 100644 --- a/display/res.c +++ b/display/res.c

Re: [Spice-devel] [PATCH] DrvSetPointerShape: handle surface which is not bitmap

2010-04-13 Thread Yonit Halperin
, Yonit Halperin wrote: --- display/res.c | 99 +++- display/rop.c |2 +- display/rop.h |3 ++ 3 files changed, 87 insertions(+), 17 deletions(-) diff --git a/display/res.c b/display/res.c index 318ea9c..2ea9565 100644 --- a

Re: [Spice-devel] spice server is stuck when playing video

2010-04-22 Thread Yonit Halperin
On 04/22/2010 10:26 AM, Coolper Chen wrote: Hi, I build the spice from git, and do some test. I find one issue when I playing video in windows xp(sp2), here's the steps to reproduce: 1.use KMPlayer to play a video,wait for some time,the spice server will be stuck; 2.use "top" command to watch qe

[Spice-devel] reminder

2010-04-25 Thread Yonit Halperin
Hi, When committing code, please use the pre-commit git hook http://spice-space.org/download/spice-pre-commit Yonit ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH] server: fix invalid self loop in surfaces dependencies.

2010-04-28 Thread Yonit Halperin
Cyclic dependencies between surfaces mustn't occur. They can cause invalid rendering - recent drawables might be rendered before older ones. --- server/red_worker.c | 27 ++- 1 files changed, 22 insertions(+), 5 deletions(-) diff --git a/server/red_worker.c b/server/red

[Spice-devel] Jpeg support

2010-06-01 Thread Yonit Halperin
This patch introduces Jpeg encoding/decoding support, for improving Spice WAN experience. Jpeg encoding is enabled when the connection is a low bandwidth one (and the compression method is AUTO_GLZ). Only images that are identified as picture-like are encoded by Jpeg. When a qxl command componen

[Spice-devel] [PATCH 1/9] JPEG support: introducing jpeg encoding for spice bitmaps.

2010-06-01 Thread Yonit Halperin
--- client/Makefile.am |2 + client/canvas.cpp |1 + client/canvas.h|4 + client/jpeg_decoder.cpp| 147 + client/jpeg_decoder.h | 91 + client/red_gdi_canvas.cpp |3 +- client/red_gl_canvas.cpp |3 +- c

[Spice-devel] [PATCH 2/9] support for lossy images in the pixmap cache and fill bits

2010-06-01 Thread Yonit Halperin
1) add an option to determine if a bitmap can be sent lossy to the client 2) when required, replacing lossy cache items with their correspending lossless bitmaps --- client/canvas.cpp|1 + client/canvas.h | 23 ++- client/shared_cache.hpp

[Spice-devel] [PATCH 3/9] lossy surface regions in the client: infrastructure for tracking and updating

2010-06-01 Thread Yonit Halperin
--- server/red_worker.c | 160 +++ 1 files changed, 160 insertions(+), 0 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 55d181d..357c6e8 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -657,6 +657,7 @@ struc

[Spice-devel] [PATCH 4/9] introducing lossy and lz compression in red_send_image

2010-06-01 Thread Yonit Halperin
--- server/red_worker.c | 55 +- 1 files changed, 53 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 357c6e8..a787751 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -405,6 +405,7 @@ typedef

[Spice-devel] [PATCH 5/9] infrastructure routines for resending to the client part of surfaces that have been sent lossy.

2010-06-01 Thread Yonit Halperin
The code also handles cases in which the server doesn't hold anymore these surfaces parts, i.e., when it holds a more updated version of them. This scenario is handled by replacing commands that were rendered, with images. --- server/red_worker.c | 334 ++

[Spice-devel] [PATCH 6/9] send qxl commands to client: support for resending lossy components when jpeg compression is enabled

2010-06-01 Thread Yonit Halperin
--- server/red_worker.c | 655 +-- 1 files changed, 639 insertions(+), 16 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index feb8c8a..35139ef 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -6705,10 +6705,19 @@

[Spice-devel] [PATCH 7/9] not using jpeg when sending a surface to the client (the whole surface)

2010-06-01 Thread Yonit Halperin
When a surface is sent to the client using red_send_surface_image, operations were already performed on it. Thus it may combine, especially if it is a primary surface, both "picture-like" areas and areas that are more "artificial". In order to avoid noticeable artifacts, such surface will be sen

[Spice-devel] [PATCH 8/9] enabling jpeg on low bandwidth connection

2010-06-01 Thread Yonit Halperin
--- server/red_worker.c | 33 + 1 files changed, 17 insertions(+), 16 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 0b651ed..3b62311 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -710,6 +710,8 @@ struct DisplayChannel {

[Spice-devel] [PATCH 9/9] init/destroy lossy surface region

2010-06-01 Thread Yonit Halperin
--- server/red_worker.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 3b62311..b2f514a 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -8965,6 +8965,7 @@ static void red_send_surface_create(DisplayChannel *d

[Spice-devel] [PATCH] server: fix bitmap flags assignment in red_send_image

2010-06-02 Thread Yonit Halperin
SPICE_IMAGE_FLAGS_HIGH_BITS_SET was assigned to the wrong field --- server/red_worker.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index b2f514a..b1fb642 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -8662,1

[Spice-devel] [PATCH] server: optimize red_pipe_replace_rendered_drawables_with_images (lossy bitmaps support related)

2010-06-03 Thread Yonit Halperin
--- server/red_worker.c | 96 +++--- 1 files changed, 90 insertions(+), 6 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index b1fb642..efdfebc 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -7110,6 +7110,64 @@ stat

Re: [Spice-devel] Using 6 monitors with spice

2010-06-05 Thread Yonit Halperin
Hi, the bitmaps cache is shared by the monitors. In red_worker.c MAX_CACHE_CLIENTS = 4. You can try to change it. Yonit. On 06/03/2010 05:11 PM, roman_laza...@troika.ru wrote: Howdy! Some time ago, Izik said the following: >Spice currently support only 4 monitors, however it is just a mat

[Spice-devel] jpeg support in spice-protocol

2010-06-09 Thread Yonit Halperin
Forgot to add the protocol patches when sending the jpeg support patches for spice. Cheers, Yonit. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH 1/2] add image type for jpeg

2010-06-09 Thread Yonit Halperin
--- spice/draw.h |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/spice/draw.h b/spice/draw.h index 3c373b7..91391c6 100644 --- a/spice/draw.h +++ b/spice/draw.h @@ -167,6 +167,7 @@ enum { SPICE_IMAGE_TYPE_GLZ_RGB, SPICE_IMAGE_TYPE_FROM_CACHE, SPICE_IM

[Spice-devel] [PATCH 2/2] cache support for replacing images that were compressed using jpeg with lossless images

2010-06-09 Thread Yonit Halperin
--- spice/draw.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/spice/draw.h b/spice/draw.h index 91391c6..1cf59c8 100644 --- a/spice/draw.h +++ b/spice/draw.h @@ -168,11 +168,13 @@ enum { SPICE_IMAGE_TYPE_FROM_CACHE, SPICE_IMAGE_TYPE_SURFACE, SPICE_IMAGE_

[Spice-devel] [PATCH] fix for not reseting client palette caches on migration

2010-06-09 Thread Yonit Halperin
--- server/red_worker.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index efdfebc..89c4a26 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -9978,6 +9978,8 @@ static int display_channel_handle_migrate_data(Displa

[Spice-devel] zlib over GLZ on WAN

2010-06-13 Thread Yonit Halperin
This patch applies zlib compression over our glz compression on low bandwidth connections (reminder: glz compression is applied over images that are classified as artificial/textual). It improves the compression size, though it consumes more cpu on the server side (hence, it is more suitable for

[Spice-devel] [PATCH] applying zlib compression over glz on WAN connection

2010-06-13 Thread Yonit Halperin
--- client/Makefile.am |2 + client/canvas.cpp |1 + client/canvas.h|3 + client/red_gdi_canvas.cpp |3 +- client/red_gl_canvas.cpp |3 +- client/red_sw_canvas.cpp |6 +- client/windows/redc.vcproj | 12 +++- client/x11/Makefile.am |

[Spice-devel] [PATCH] add image type for images that are compressed by zlib after they have been compressed by glz

2010-06-13 Thread Yonit Halperin
--- spice/draw.h | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/spice/draw.h b/spice/draw.h index 1cf59c8..596a376 100644 --- a/spice/draw.h +++ b/spice/draw.h @@ -169,6 +169,7 @@ enum { SPICE_IMAGE_TYPE_SURFACE, SPICE_IMAGE_TYPE_JPEG, SPICE_IMA

Re: [Spice-devel] [PATCH] applying zlib compression over glz on WAN connection

2010-06-14 Thread Yonit Halperin
On 06/15/2010 08:31 AM, Alon Levy wrote: [snip] +sizeof(zlib_data->data.bufs_head->buf)); + +// the compressed buffer is bigger than the original data +if (zlib_size>= glz_size) { Does this actually happen in practice? Yes, if the compression doesn't work w

[Spice-devel] protocol changes for ZLIB over GLZ

2010-06-20 Thread Yonit Halperin
rebasing ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH] add image type for images that are compressed by zlib after they have been compressed by glz

2010-06-20 Thread Yonit Halperin
--- spice/draw.h | 11 +++ spice/enums.h |1 + 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/spice/draw.h b/spice/draw.h index ff70e7b..874681d 100644 --- a/spice/draw.h +++ b/spice/draw.h @@ -182,6 +182,17 @@ typedef struct SPICE_ATTR_PACKED SpiceJPEGImage {

[Spice-devel] ZLIB over GLZ

2010-06-20 Thread Yonit Halperin
rebased ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH] applying zlib compression over glz on WAN connection

2010-06-20 Thread Yonit Halperin
--- client/Makefile.am |2 + client/canvas.h|3 + client/red_gdi_canvas.cpp |3 +- client/red_gl_canvas.cpp |3 +- client/red_sw_canvas.cpp |6 +- client/windows/redc.vcproj | 12 +++- client/x11/Makefile.am |3 + client/zlib_decoder.cpp|

[Spice-devel] [PATCH] add image type for RGBA bitmaps that were compressed by a combination of JPEG (RGB) and LZ (alpha channel).

2010-06-20 Thread Yonit Halperin
--- spice/draw.h | 12 spice/enums.h |5 + 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/spice/draw.h b/spice/draw.h index 874681d..e6fab5c 100644 --- a/spice/draw.h +++ b/spice/draw.h @@ -193,6 +193,18 @@ typedef struct SPICE_ATTR_PACKED SpiceZlibGlzRGBIm

[Spice-devel] [PATCH] Lossy compression of RGBA images (on WAN connection)

2010-06-20 Thread Yonit Halperin
The RGB channels are compressed using JPEG. The alpha channel is compressed using LZ. --- common/canvas_base.c | 92 +++- common/lz.c | 12 common/lz_common.h |9 ++-- server/red_worker.c | 144 -

[Spice-devel] [PATCH] windows client: add --include "common.h"-- for generated demarshallers

2010-06-23 Thread Yonit Halperin
--- client/windows/generate.bat |2 +- client/windows/generate1.bat |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/windows/generate.bat b/client/windows/generate.bat index 1bb62b4..6bd06d7 100644 --- a/client/windows/generate.bat +++ b/client/windows/generate

[Spice-devel] [PATCH] fix for not clearing the cursor ring when the primary surface is destroyed

2010-06-23 Thread Yonit Halperin
fixes a crash in qxl_soft_reset --- server/red_worker.c | 85 ++ 1 files changed, 71 insertions(+), 14 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index b9ada15..9bd551c 100644 --- a/server/red_worker.c +++ b/server/red_wor

Re: [Spice-devel] [PATCH] fix for not clearing the cursor ring when the primary surface is destroyed

2010-06-23 Thread Yonit Halperin
On 06/23/2010 04:57 PM, Gerd Hoffmann wrote: -static int red_process_cursor(RedWorker *worker, uint32_t max_pipe_size) +static int red_process_cursor(RedWorker *worker, uint32_t max_pipe_size, int *ring_is_empty) { QXLCommandExt ext_cmd; int n = 0; + *ring_is_empty = FALSE; while (!worker->curso

Re: [Spice-devel] [PATCH] windows client: add --include "common.h"-- for generated demarshallers

2010-06-23 Thread Yonit Halperin
On 06/23/2010 05:53 PM, Alexander Larsson wrote: On Wed, 2010-06-23 at 14:29 +0300, Yonit Halperin wrote: --- client/windows/generate.bat |2 +- client/windows/generate1.bat |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/windows/generate.bat b/client

[Spice-devel] [PATCH 1/3] remove unnecessary send of SPICE_MSG_DISPLAY_RESET

2010-06-27 Thread Yonit Halperin
when SPICE_MSG_DISPLAY_RESET was sent, SPICE_MSG_DISPLAY_SURFACE_DESTROY had already been sent for all surfaces. It also caused a client crash since DisplayChannel::handle_reset assumes that screen exists. --- server/red_worker.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff

[Spice-devel] [PATCH 2/3] detaching the screen when the primary surface is destoryed and closing the window if the primary surface is not recreated (the monitor has been detached).

2010-06-27 Thread Yonit Halperin
--- client/display_channel.cpp | 25 +++-- client/display_channel.h |1 + 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/client/display_channel.cpp b/client/display_channel.cpp index 95840b5..1bf0744 100644 --- a/client/display_channel.cpp +++ b/client

[Spice-devel] [PATCH 3/3] fixed unhandled destroy screen in Application:restore_screens_size

2010-06-27 Thread Yonit Halperin
--- client/application.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index f32943e..6b1ce65 100644 --- a/client/application.cpp +++ b/client/application.cpp @@ -1450,7 +1450,7 @@ void Application::enter_full_screen()

[Spice-devel] [PATCH] client: add --include "common.h" for generated marshallers

2010-06-29 Thread Yonit Halperin
--- client/Makefile.am |4 ++-- client/windows/generate.bat |2 +- client/windows/generate1.bat |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client/Makefile.am b/client/Makefile.am index 7a7420a..d5602b5 100644 --- a/client/Makefile.am +++ b/client/M

Re: [Spice-devel] Status of 0.6 release

2010-07-05 Thread Yonit Halperin
On 07/05/2010 12:44 PM, Alexander Larsson wrote: * Improved support for WAN We have landed support for lossy compression (jpeg) and lz compression of glz images, for low bandwidth mode. We need to add some command line arguments to allow this to be enabled/tuned. This is a good basis for wan su

Re: [Spice-devel] Available resolutions

2010-07-07 Thread Yonit Halperin
On 07/08/2010 01:22 AM, Frédéric Grelot wrote: Hi all, I've set up a spice server (unstable version), and few clients : as you may remember from my previous mails, it works quite well in windows, but still not with fedora (i gave up with this, after trying all the drivers I found on the net..

[Spice-devel] QXL fixes

2010-07-12 Thread Yonit Halperin
These patches fix several BSODs and panics. They are coupled with additions to spice-protocol and qemu/hw/qxl.c. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH 1/3] Fix global resources cleanup

2010-07-12 Thread Yonit Halperin
--- display/res.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/display/res.c b/display/res.c index 05bc9e6..c769aeb 100644 --- a/display/res.c +++ b/display/res.c @@ -322,7 +322,7 @@ void CleanGlobalRes() { UINT32 i; -if (!global_res) { +if (global_res)

[Spice-devel] [PATCH 2/3] Fix memory leak: deleting primary surface device bitmap when it is disabled.

2010-07-12 Thread Yonit Halperin
The bug caused BSOD: SESSION_HAS_VALID_POOL_ON_EXIT on switching users/log off (after the driver is disabled and enabled back again, while the miniport is not restarted). --- display/driver.c | 10 +- display/qxldd.h |3 --- 2 files changed, 1 insertions(+), 12 deletions(-) diff -

[Spice-devel] [PATCH 3/3] Fix corrupted ram data (e.g., release_ring), and unsynchronized worker, after driver is disabled and re-enabled.

2010-07-12 Thread Yonit Halperin
On logoff in Win7 guest, and on switch user and login into Winxp guest, the driver is disabled and re-enabled (while the miniport in not reset). However, before the fix, all the draw objects, e.g., surfaces, were still alive in the worker and the release ring still contained objects, while all the

[Spice-devel] [PATCH] add QXL_IO_RESET_RAM_DRAW_DATA

2010-07-12 Thread Yonit Halperin
--- spice/qxl_dev.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 7a121ad..fa43dc1 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -80,6 +80,7 @@ enum { QXL_IO_DESTROY_PRIMARY, QXL_IO_DESTROY_SURFACE_WAIT, QXL_

[Spice-devel] [PATCH] qxl: add support for QXL_IO_RESET_RAM_DRAW_DATA

2010-07-12 Thread Yonit Halperin
--- hw/qxl.c | 54 ++ 1 files changed, 42 insertions(+), 12 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index ab1587a..2501b39 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -179,22 +179,29 @@ static void init_qxl_rom(PCIQXLDevice *d) d->modes

[Spice-devel] [PATCH] server: enabling/disabling jpeg and zlib-over-glz via spice command line args

2010-07-12 Thread Yonit Halperin
--- server/red_dispatcher.c |4 server/red_worker.c | 27 --- server/red_worker.h |2 ++ server/reds.c | 26 ++ server/spice.h | 10 ++ 5 files changed, 66 insertions(+), 3 deletions(-) diff --gi

[Spice-devel] [PATCH] spice: enabling/disabling jpeg and zlib-over-glz via spice command line args

2010-07-12 Thread Yonit Halperin
--- qemu-config.c |6 ++ spice.c | 29 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index 8c2abf2..ca56a97 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -374,6 +374,12 @@ QemuOptsList qemu_spice_opts

Re: [Spice-devel] [PATCH 3/3] Fix corrupted ram data (e.g., release_ring), and unsynchronized worker, after driver is disabled and re-enabled.

2010-07-12 Thread Yonit Halperin
On 07/12/2010 12:43 PM, Gerd Hoffmann wrote: On 07/12/10 11:15, Yonit Halperin wrote: On logoff in Win7 guest, and on switch user and login into Winxp guest, the driver is disabled and re-enabled (while the miniport in not reset). However, before the fix, all the draw objects, e.g., surfaces

[Spice-devel] QXL fixes - version 2

2010-07-12 Thread Yonit Halperin
These patches fix several BSODs and panics. Version 2: no change in qemu and spic-protocol. The old reset method is performed on each device when the driver is disabled. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freede

[Spice-devel] [PATCH 1/3] Fix global resources cleanup

2010-07-12 Thread Yonit Halperin
--- display/res.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/display/res.c b/display/res.c index 05bc9e6..c769aeb 100644 --- a/display/res.c +++ b/display/res.c @@ -322,7 +322,7 @@ void CleanGlobalRes() { UINT32 i; -if (!global_res) { +if (global_res)

[Spice-devel] [PATCH 2/3] Fix memory leak: deleting primary surface device bitmap when it is disabled.

2010-07-12 Thread Yonit Halperin
The bug caused BSOD: SESSION_HAS_VALID_POOL_ON_EXIT on switching users/log off (after the driver is disabled and enabled back again, while the miniport is not restarted). --- display/driver.c | 10 +- display/qxldd.h |3 --- 2 files changed, 1 insertions(+), 12 deletions(-) diff -

[Spice-devel] [PATCH 3/3] Fix corrupted ram data (e.g., release_ring), and unsynchronized worker, after driver is disabled and re-enabled.

2010-07-12 Thread Yonit Halperin
On logoff, in Win7 guest, and on switch user and login into a Winxp guest, the driver is disabled and re-enabled (while the miniport in not reset). However, before the fix, all the draw objects, e.g., surfaces, were still alive in the worker and the release ring still contained objects, while all

[Spice-devel] [PATCH] server: Consider the surface id when identifying video streams, and draw the stream on the proper surface, #28088

2010-07-25 Thread Yonit Halperin
--- server/red_worker.c | 21 + 1 files changed, 17 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index cbfe405..1c32a26 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -427,6 +427,7 @@ struct Stream { int width;

[Spice-devel] [PATCH] client: fix - exit on bad display-effect argument

2010-08-08 Thread Yonit Halperin
--- client/application.cpp |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index 3dafbc6..490cd8c 100644 --- a/client/application.cpp +++ b/client/application.cpp @@ -1926,6 +1926,8 @@ bool Application::set_disabled_display

[Spice-devel] vdagent patch for controlling guest display setting

2010-08-10 Thread Yonit Halperin
The patch can be applied over Arnon last vdagent patches. cheers, Yonit. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH] Controlling Windows display settings (e.g., wallpaper, UI effects and font smoothing)

2010-08-10 Thread Yonit Halperin
The configuration is received from Spice client. The main usage of this option is for disabling display features in order to accelerate Spice performance over limited network connections. --- common/vdcommon.h |2 + vdagent/desktop_layout.h|1 + vdagent/display_setting.cpp |

[Spice-devel] [PATCH] server: remove unnecessary dependency between surfaces and Glz drawables

2010-08-11 Thread Yonit Halperin
Fixes freedesktop bug #28568 --- server/red_worker.c | 38 -- 1 files changed, 4 insertions(+), 34 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 1c32a26..87f5582 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -595,11

[Spice-devel] [PATCH] client: Fix for clipboard sending; It wasn't thread safe.

2010-08-15 Thread Yonit Halperin
--- client/red_client.cpp | 23 +++ client/red_client.h |9 - 2 files changed, 27 insertions(+), 5 deletions(-) diff --git a/client/red_client.cpp b/client/red_client.cpp index 9a8078e..b6a412e 100644 --- a/client/red_client.cpp +++ b/client/red_client.cpp @@ -

[Spice-devel] Modify Qxl surfaces allocation method

2010-08-17 Thread Yonit Halperin
This patch replaces the DirectDraw dependent surfaces allocation with mspace malloc. (bugzilla #29254). Future work on this issue can include: 1) Tuning mspace for surfaces. 2) Separating the deallocations of DEVRAM resources from those of surfaces. Currently, there is only one release_ring. 3)

[Spice-devel] [Qxl PATCH] Change surfaces allocation method.

2010-08-17 Thread Yonit Halperin
The driver no longer claims to support DirectDraw. It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. This fixes freedesktop bug #29254. --- display/driver.c | 18 ++- display/qxldd.h | 19 +-- display/res.c| 158 +++---

Re: [Spice-devel] [Qxl PATCH] Change surfaces allocation method.

2010-08-18 Thread Yonit Halperin
On 08/17/2010 05:36 PM, Alexander Larsson wrote: On Tue, 2010-08-17 at 14:26 +0300, Yonit Halperin wrote: The driver no longer claims to support DirectDraw. It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. This fixes freedesktop bug #29254. Ack (although you should git rm

[Spice-devel] [Qxl PATCH] Change surfaces allocation method.

2010-08-18 Thread Yonit Halperin
The driver no longer claims to support DirectDraw. It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. This fixes freedesktop bug #29254. --- display/dd.c | 122 - display/dd.h | 15 - display/driver.c | 18 ++- display/q

[Spice-devel] [Qxl PATCH] aligning surfaces stride to 4

2010-08-18 Thread Yonit Halperin
--- display/res.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/display/res.c b/display/res.c index 3fe5fe6..6be006e 100644 --- a/display/res.c +++ b/display/res.c @@ -600,15 +600,17 @@ _inline void GetSurfaceMemory(PDev *pdev, UINT32 x, UINT32 y, UINT32 depth,

[Spice-devel] [PATCH] Limiting video streaming to the primary surface. freedesktop bug #28088.

2010-08-19 Thread Yonit Halperin
--- server/red_worker.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index cbfe405..6fd01d5 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1516,7 +1516,10 @@ static inline void red_destroy_surface(Re

Re: [Spice-devel] [PATCH] Limiting video streaming to the primary surface. freedesktop bug #28088.

2010-08-19 Thread Yonit Halperin
Please ignore the patch. I forgot to add something to it. I will resend it later. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] video streaming with primary surface

2010-08-21 Thread Yonit Halperin
This patch fixes bugs in handling video streaming, mainly related to dependencies among surfaces and streaming on off-screen surfaces. The patch limits the support for video streaming to the primary surface. Support for streaming on off-screen surfaces is currently not essential since it is not

[Spice-devel] [PATCH] Limiting video streaming to the primary surface. freedesktop bug #28088.

2010-08-21 Thread Yonit Halperin
--- server/red_worker.c | 47 --- 1 files changed, 40 insertions(+), 7 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index cbfe405..ef9aa53 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1516,7 +1516,10 @@ static

Re: [Spice-devel] [PATCH 1/8] Move SurfaceInfo structure

2010-08-22 Thread Yonit Halperin
On 08/20/2010 09:54 PM, al...@redhat.com wrote: From: Alexander Larsson This is in preparation for using it in DevRes Ack ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

<    1   2   3   4   5   6   7   8   9   10   >