Re: [Spice-devel] [PATCH spice-common 7/9] codegen: Remove support for --ptrsize

2019-03-08 Thread Frediano Ziglio
> > On Thu, Mar 07, 2019 at 04:01:02PM -0500, Frediano Ziglio wrote: > > > > > > Acked-by: Christophe Fergeau > > > > > > > Thanks, looking at reply to 9/9 however I think one thing is not clear from > > what I wrote in the commit message. > > The reason is not only that was used in protocol

Re: [Spice-devel] [PATCH spice-common 7/9] codegen: Remove support for --ptrsize

2019-03-08 Thread Christophe Fergeau
On Thu, Mar 07, 2019 at 04:01:02PM -0500, Frediano Ziglio wrote: > > > > Acked-by: Christophe Fergeau > > > > Thanks, looking at reply to 9/9 however I think one thing is not clear from > what I wrote in the commit message. > The reason is not only that was used in protocol 1 only and now is

Re: [Spice-devel] [PATCH spice-common 7/9] codegen: Remove support for --ptrsize

2019-03-07 Thread Frediano Ziglio
> > Acked-by: Christophe Fergeau > Thanks, looking at reply to 9/9 however I think one thing is not clear from what I wrote in the commit message. The reason is not only that was used in protocol 1 only and now is not used but also that it was wrong from the beginning and useless. I would keep

Re: [Spice-devel] [PATCH spice-common 7/9] codegen: Remove support for --ptrsize

2019-03-07 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Sun, Mar 03, 2019 at 07:10:28PM +, Frediano Ziglio wrote: > This option was used in protocol 1 to generate 64 bit pointers. > A pointer in the protocol is an offset in the current message. > This allows the possibility to have messages with pointers with >

[Spice-devel] [PATCH spice-common 7/9] codegen: Remove support for --ptrsize

2019-03-03 Thread Frediano Ziglio
This option was used in protocol 1 to generate 64 bit pointers. A pointer in the protocol is an offset in the current message. This allows the possibility to have messages with pointers with more than 4GB. This feature was removed and not used in protocol 2. The reason is that messages more than