[sqlalchemy] Re: Integrating the ORM with Trellis

2008-03-06 Thread jason kirtland
Michael Bayer wrote: On Feb 27, 2008, at 12:19 PM, jason kirtland wrote: Michael Bayer wrote: You also get a hook that receives the collection_class argument in the case of a collection-based attribute and you get to return your own class, in which case all the collections API stuff can

[sqlalchemy] Re: Integrating the ORM with Trellis

2008-03-05 Thread Michael Bayer
On Mar 4, 2008, at 7:27 PM, Phillip J. Eby wrote: Okay, so I did a matching uninstrument_attribute and pre_uninstrument_attribute, which look like really dumb names at this point. I propose the following name changes (in addition to the ones in my previous patch):

[sqlalchemy] Re: Integrating the ORM with Trellis

2008-03-04 Thread Phillip J. Eby
At 02:04 PM 3/3/2008 -0500, Michael Bayer wrote: the bug is that unregister_attribute() is not working, which the test suite is using to remove and re-register new instrumentation: class Foo(object): pass attributes.register_attribute(Foo, collection,

[sqlalchemy] Re: Integrating the ORM with Trellis

2008-03-03 Thread Phillip J. Eby
At 04:04 PM 2/27/2008 -0500, Michael Bayer wrote: do you have any interest in committing changes to the branch yourself ? as long as the unit tests keep running whatever you'd want is most likely fine with meotherwise I will at least experiment with doing away with __mro__ searching and

[sqlalchemy] Re: Integrating the ORM with Trellis

2008-03-03 Thread Michael Bayer
the bug is that unregister_attribute() is not working, which the test suite is using to remove and re-register new instrumentation: class Foo(object): pass attributes.register_attribute(Foo, collection, uselist=True, typecallable=set, useobject=True)