Re: Re: Re: Re: Re: Integrate PyHive and Alembic

2020-03-02 Thread Ke Zhu - k...@us.ibm.com
Mike, Thanks for merging my change on Alembic! On Thu, 2020-02-27 at 15:38 -0500, Mike Bayer wrote: > > > On Thu, Feb 27, 2020, at 2:49 PM, Ke Zhu - k...@us.ibm.com wrote: > > On Wed, 2020-02-26 at 11:07 -0500, Mike Bayer wrote: > > > oh, that issue is talking about rowcount. Alembic does not

Re: Re: Re: Re: Integrate PyHive and Alembic

2020-02-27 Thread Mike Bayer
On Thu, Feb 27, 2020, at 2:49 PM, Ke Zhu - k...@us.ibm.com wrote: > On Wed, 2020-02-26 at 11:07 -0500, Mike Bayer wrote: >> oh, that issue is talking about rowcount. Alembic does not need rowcount to >> function correctly. I see that Alembic is doing this now, however there is a >> dialect-leve

Re: Re: Re: Re: Integrate PyHive and Alembic

2020-02-27 Thread Ke Zhu - k...@us.ibm.com
On Wed, 2020-02-26 at 11:07 -0500, Mike Bayer wrote: oh, that issue is talking about rowcount. Alembic does not need rowcount to function correctly.I see that Alembic is doing this now, however there is a dialect-level flag called "supports_sane_rowcount", if this were False, Alembic should