Re: Re: Re: Re: Re: Integrate PyHive and Alembic

2020-03-02 Thread Ke Zhu - k...@us.ibm.com
Mike, Thanks for merging my change on Alembic! On Thu, 2020-02-27 at 15:38 -0500, Mike Bayer wrote: > > > On Thu, Feb 27, 2020, at 2:49 PM, Ke Zhu - k...@us.ibm.com wrote: > > On Wed, 2020-02-26 at 11:07 -0500, Mike Bayer wrote: > > > oh, that issue is talking about rowcount. Alembic does not

Re: Re: Re: Re: Integrate PyHive and Alembic

2020-02-27 Thread Mike Bayer
On Thu, Feb 27, 2020, at 2:49 PM, Ke Zhu - k...@us.ibm.com wrote: > On Wed, 2020-02-26 at 11:07 -0500, Mike Bayer wrote: >> oh, that issue is talking about rowcount. Alembic does not need rowcount to >> function correctly. I see that Alembic is doing this now, however there is a >> dialect-leve

Re: Re: Re: Re: Integrate PyHive and Alembic

2020-02-27 Thread Ke Zhu - k...@us.ibm.com
On Wed, 2020-02-26 at 11:07 -0500, Mike Bayer wrote: oh, that issue is talking about rowcount. Alembic does not need rowcount to function correctly.I see that Alembic is doing this now, however there is a dialect-level flag called "supports_sane_rowcount", if this were False, Alembic should

Re: Re: Re: Integrate PyHive and Alembic

2020-02-26 Thread Mike Bayer
On Tue, Feb 25, 2020, at 11:06 AM, Ke Zhu - k...@us.ibm.com wrote: > According to Apache Hive, Update/Delete can only be performed on tables that > supports ACID. see > https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DML#LanguageManualDML-Update > > > this is a database that c

Re: Re: Re: Integrate PyHive and Alembic

2020-02-25 Thread Ke Zhu - k...@us.ibm.com
According to Apache Hive, Update/Delete can only be performed on tables that supports ACID. see https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DML#LanguageManualDML-Update > this is a database that can change schema structures but not > insert/update/delete rows? is there some

Re: Re: Integrate PyHive and Alembic

2020-02-24 Thread Mike Bayer
On Mon, Feb 24, 2020, at 3:44 PM, Ke Zhu - k...@us.ibm.com wrote: > Mike, > > Thanks for the pointers. I've figured out the programming part and discovers > more things when integrating PyHive: > > 1. It requires the table alembic_version to be transactional so that it can > do Update/Delete

Re: Re: Integrate PyHive and Alembic

2020-02-24 Thread Ke Zhu - k...@us.ibm.com
Mike, Thanks for the pointers. I've figured out the programming part and discovers more things when integrating PyHive: 1. It requires the table alembic_version to be transactional so that it can do Update/Delete when upgrade/downgrade. which is challege for Hive3 which has limited ACID support. Si