Re: [sqlite] DB triggers: Initial patch

2011-05-19 Thread Stephan Beal
On Wed, May 18, 2011 at 11:24 PM, Nico Williams wrote: > - setup Fossil clones that folks can pull from (this means getting my > hosting provider to add support for Fossil, so it won't happen soon > enough) > If your hoster supports CGI, that's all you need to host fossil repos (and it can be se

Re: [sqlite] DB triggers: Initial patch

2011-05-18 Thread Nico Williams
On Wed, May 18, 2011 at 4:14 PM, Petite Abeille wrote: > Very nice, thanks for sharing :) > > Wish such a functionality was part of the stock SQLite :)) Thanks for the kind words! I will do my best to make it palatable and hopefully desirable for the core dev team to integrate my patches. I don

Re: [sqlite] DB triggers: Initial patch

2011-05-18 Thread Petite Abeille
On May 16, 2011, at 7:30 PM, Nico Williams wrote: > In my next post I'll post a [681 line, 28KB unified diff, or 504 line > regular diff] patch implements the following DB triggers: > > - AFTER DATABASE CONNECT > - AFTER TRANSACTION BEGIN > - BEFORE TRANSACTION COMMIT Very nice, thanks for shar

Re: [sqlite] DB triggers: Initial patch

2011-05-16 Thread Nico Williams
A few more comments: - The patch adds just 8KB to libsqlite3.a and the shell, and this is true regardless of whether the before and after compilations use -g or not, -O0 vs. -O2, and -DSQLITE_DEBUG=1 or not. - I've tried to keep the SQLite3 C style as best I could. - My earlier characterizati

Re: [sqlite] DB triggers: Initial patch

2011-05-16 Thread Nico Williams
And here's the patch. I should have been using Fossil all this time. I'll switch to Fossil soon. For now the patch is to sqlite\-src\-3070602. A few more notes on the patch besides the ones I posted earlier: - DB triggers are omitted by defining SQLITE_OMIT_TRIGGER - DB triggers are implement

[sqlite] DB triggers: Initial patch

2011-05-16 Thread Nico Williams
In my next post I'll post a [681 line, 28KB unified diff, or 504 line regular diff] patch implements the following DB triggers: - AFTER DATABASE CONNECT - AFTER TRANSACTION BEGIN - BEFORE TRANSACTION COMMIT These triggers do exactly what I want, and nothing more. If anyone wants to test this