On 08/25/2016 10:26 AM, Amos Jeffries wrote:
> About
> the only further optimization we can do there is make the
> "CharacterSet::SP" that it outputs in the sensitive path be a local
> static *within* DelimiterCharacters() itself and return a reference to
> that instead of constructing a new Charat
On 08/25/2016 10:26 AM, Amos Jeffries wrote:
> 2016-08-23 17:50 GMT+03:00 Alex Rousskov:
>> I wonder whether we should make this variable static to avoid repeated
>> function calls on a performance-sensitive code path.
> The output of DelimiterCharacters() cannot be stored in a static because
> i
On 08/25/2016 08:18 AM, Eduard Bagdasaryan wrote:
> 2016-08-24 18:20 GMT+03:00 Amos Jeffries :
>
>> in src/LogTags.cc:
>> * instead of adding new enum entry please extend LogTags with a new bool
>> flag and the c_str() to append the "IGNORED" when that flag is true.
> Added a new LogTags::ignored
On 26/08/2016 3:52 a.m., Alex Rousskov wrote:
> On 08/25/2016 04:04 AM, Eduard Bagdasaryan wrote:
>
>> Therefore, we could use the timestamp if Last-Modified is unavailable.
>
> I do not understand why the patch hides the lastmod field behind a basic
> getter. If we assert that a timestamp-based
On 25/08/2016 11:31 a.m., Eduard Bagdasaryan wrote:
> 2016-08-23 17:50 GMT+03:00 Alex Rousskov:
>
>> s/request-line/request-line: URI/ for consistency and clarity sake.
>
>> I wonder whether we should make this variable static to avoid repeated
>> function calls on a performance-sensitive code pa
On 08/25/2016 04:04 AM, Eduard Bagdasaryan wrote:
> Therefore, we could use the timestamp if Last-Modified is unavailable.
I do not understand why the patch hides the lastmod field behind a basic
getter. If we assert that a timestamp-based last modification value
should be used in many cases, the
2016-08-24 18:20 GMT+03:00 Amos Jeffries :
> in src/LogTags.cc:
> * instead of adding new enum entry please extend LogTags with a new bool
> flag and the c_str() to append the "IGNORED" when that flag is true.
> - TCP_REFRESH should be set when refresh was started.
> - whoever merges this patch
2016-08-21 15:58 GMT+03:00 Amos Jeffries :
> please dont move the StoreEntry 'lastmod' member variable which exists
> between the "ON-DISK STORE_META_STD TLV field" marker comments.
> A delta should be the actual difference value -N < 0 < +N.
> please take the opportunity to cleanup any touched
