Re: isspace etc and (int) typecast

2007-03-27 Thread Guido Serassio
Hi Henrik, At 02.56 27/03/2007, Henrik Nordstrom wrote: Reviewing Squid-2.HEAD changes and sorting/grouping them a bit I stumbled over your change to add casts in various isspace() calls which looks a bit odd. http://www.squid-cache.org/Versions/v2/HEAD/changesets/11290.patch -for (; i

Re: isspace etc and (int) typecast

2007-03-27 Thread Henrik Nordstrom
tis 2007-03-27 klockan 13:16 +0200 skrev Guido Serassio: What was the warnings you fixed with these casts? I suspect you only silenced a valid warning here without fixing the cause.. Exactly these: http://www.squid-cache.org/mail-archive/squid-dev/200702/0128.html Ok, what I thought..

Re: isspace etc and (int) typecast

2007-03-27 Thread Guido Serassio
Hi Henrik, At 21.18 27/03/2007, Henrik Nordstrom wrote: tis 2007-03-27 klockan 13:16 +0200 skrev Guido Serassio: What was the warnings you fixed with these casts? I suspect you only silenced a valid warning here without fixing the cause.. Exactly these:

Re: isspace etc and (int) typecast

2007-03-27 Thread Henrik Nordstrom
tis 2007-03-27 klockan 22:09 +0200 skrev Guido Serassio: It's almost clear, but I'm just a little confused on the logical side of the things: use an int argument to check for an unsigned char. Really a confusing prototype . The acceptable range is an unsigned char or EOF. EOF is a value