Re: src/Makefile.am:200: Libtool library used but `LIBTOOL' is undefined error,squid3

2008-01-07 Thread Arthur Tumanyan
Arthur Tumanyan wrote: Hi,I'm currently working above mysql logging feature for squid3(cleanly,not a plugin like previous version for squid.2.6). And the trouble is the message in subject when i do ./bootstrap.sh. I don't think it's a result of incorrect code. Any ideas what's the

fixing 4k reply header store reads

2008-01-07 Thread Adrian Chadd
I've been thinking about how to fix that particular issue whilst hacking on the s27_adri branch. The main requirement is modifying the store to allow arbitrary sized pages rather than just 4k pages, and then find a way to read the header data into that first page in store memory. Once its read

Re: astyle

2008-01-07 Thread Alex Rousskov
On Sat, 2008-01-05 at 13:05 +0200, Tsantilas Christos wrote: I spend some time to run the astyle-1.21 on squid3 code. I tried to run it with the following parameters: --mode=c -s4 -O --break-blocks -l I am only seeing the following two problems: 1) The --break-blocks and -l option.

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-07 Thread Alex Rousskov
On Mon, 2008-01-07 at 00:51 +0100, Henrik Nordström wrote: sön 2008-01-06 klockan 12:27 +0200 skrev Tsantilas Christos: It is not a cbdata problem. Are you sure? cbdata exists to help invalidate callbacks when they are no longer meaningful. A callback being made to something no longer

Re: src/Makefile.am:200: Libtool library used but `LIBTOOL' is undefined error,squid3

2008-01-07 Thread Alex Rousskov
On Mon, 2008-01-07 at 02:30 -0800, Arthur Tumanyan wrote: Arthur Tumanyan wrote: Hi,I'm currently working above mysql logging feature for squid3(cleanly,not a plugin like previous version for squid.2.6). And the trouble is the message in subject when i do ./bootstrap.sh. I don't

Re: Windows STABLE branches on squid-cache.org

2008-01-07 Thread Alex Rousskov
On Wed, 2007-12-26 at 23:18 +0100, Guido Serassio wrote: As some Squid developer already know, there is a Squid 2.6 STABLE Windows branch in the squid-cache.org CVS repository, SQUID_NT_2_6, based on SQUID_2_6. This allow to easily maintain the native Windows port based on MS Visual

Re: bzr VCS feedback

2008-01-07 Thread Gonzalo Arana
Tsantilas, Thank you very much for the pointer. I was able to 'branch' squid3-bzr. About bzr, here are two things that I've noticed: * debian etch (stable) has an old version of bzr (0.11-1.1), which does not recognize squid-bzr repository: $ bzr branch

Re: Windows STABLE branches on squid-cache.org

2008-01-07 Thread Guido Serassio
Hi Alex, At 19:07 07/01/2008, Alex Rousskov wrote: On Wed, 2007-12-26 at 23:18 +0100, Guido Serassio wrote: As some Squid developer already know, there is a Squid 2.6 STABLE Windows branch in the squid-cache.org CVS repository, SQUID_NT_2_6, based on SQUID_2_6. This allow to easily

Re: bzr VCS feedback

2008-01-07 Thread Robert Collins
On Mon, 2008-01-07 at 16:50 -0200, Gonzalo Arana wrote: Tsantilas, Thank you very much for the pointer. I was able to 'branch' squid3-bzr. About bzr, here are two things that I've noticed: * debian etch (stable) has an old version of bzr (0.11-1.1), which does not recognize squid-bzr

Re: astyle

2008-01-07 Thread Tsantilas Christos
Alex Rousskov wrote: On Sat, 2008-01-05 at 13:05 +0200, Tsantilas Christos wrote: ... I suggest removing break-blocks both because of the above bug and because it is trying to detect unrelated blocks, classes, etc. which smells too much like AI to me. The --brackets=linux (-l) option is

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-07 Thread Tsantilas Christos
The problem was different: With classic comm code of squid3 when the comm_close for a fd called then: 1) fd marked as closing, read and write handlers called with COMM_ERR_CLOSING 2) comm_close handlers called 3) the fd closed and the fdc_table[fd] initialized. Using async calls (current

Re: Windows STABLE branches on squid-cache.org

2008-01-07 Thread Alex Rousskov
On Mon, 2008-01-07 at 20:56 +0100, Guido Serassio wrote: At 19:07 07/01/2008, Alex Rousskov wrote: On Wed, 2007-12-26 at 23:18 +0100, Guido Serassio wrote: As some Squid developer already know, there is a Squid 2.6 STABLE Windows branch in the squid-cache.org CVS repository,

Re: astyle

2008-01-07 Thread Alex Rousskov
On Mon, 2008-01-07 at 23:55 +0200, Tsantilas Christos wrote: Alex Rousskov wrote: On Sat, 2008-01-05 at 13:05 +0200, Tsantilas Christos wrote: ... I suggest removing break-blocks both because of the above bug and because it is trying to detect unrelated blocks, classes, etc. which

Re: bzr VCS feedback

2008-01-07 Thread Tsantilas Christos
Gonzalo Arana wrote: CVS used only 4K, while bzr used more than 80M (it devastated my workstation). It was not so bad But in the other hand 80M are not huge amount in these days .. Since I am not a core squid developer, I know that I don't have a vote on this, but I have to say

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Mark Nottingham
+1, and in 2.7 ASAP; I've already implemented this in my own hacky way (external to squid); would be nice to have 'real' includes. On 08/01/2008, at 2:47 AM, Adrian Chadd wrote: I gave in and coded up a very, very simplistic and naive implementation for include. You can now include

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-07 Thread Adrian Chadd
On Mon, Jan 07, 2008, Alex Rousskov wrote: We should be able to improve that by redesigning onclose API or comm internals. I think that should be discussed after async calls are fully working though. The fundamental AsyncCall design idea is that modules like comm should not call other code

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-07 Thread Adrian Chadd
On Mon, Jan 07, 2008, Tsantilas Christos wrote: And after some time: - read/write handlers called with COMM_ERR_CLOSING - comm_close handlers called - The fd closed and fdc_table[fd] initialized. If the fd closed before the comm_close handlers executed bad thinks happens. Right.

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Adrian Chadd
On Tue, Jan 08, 2008, Mark Nottingham wrote: +1, and in 2.7 ASAP; I've already implemented this in my own hacky way (external to squid); would be nice to have 'real' includes. Well, test it out, make sure broken things like ACL lines give the right source file and line number, and let me know

Squid-3 and large response headers

2008-01-07 Thread Henrik Nordström
Squid-3 has lots of problems with response headers 4KB. (Bug #2001) 3.0.STABLE hangs and stops reading the response. Cleared by abort or timeout only. 3.HEAD at least grows it's header receive buffer and continues to read the data and feed the response down the chain, but this then triggers

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-07 Thread Amos Jeffries
Tsantilas Christos wrote: The problem was different: With classic comm code of squid3 when the comm_close for a fd called then: 1) fd marked as closing, read and write handlers called with COMM_ERR_CLOSING 2) comm_close handlers called 3) the fd closed and the fdc_table[fd] initialized.

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Amos Jeffries
Adrian Chadd wrote: On Tue, Jan 08, 2008, Mark Nottingham wrote: +1, and in 2.7 ASAP; I've already implemented this in my own hacky way (external to squid); would be nice to have 'real' includes. Well, test it out, make sure broken things like ACL lines give the right source file and line

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Adrian Chadd
On Tue, Jan 08, 2008, Amos Jeffries wrote: I looked at this for 3.1, but the config parser there confused me with its multiple meanings of 'file'. I'd definately like to see how you are doing it in 2 for a side-port. Well, its in the tree. :) FWIW; I believe we should with 3.1 and 2.7 be

Re: astyle

2008-01-07 Thread Amos Jeffries
Alex Rousskov wrote: On Mon, 2008-01-07 at 23:55 +0200, Tsantilas Christos wrote: Alex Rousskov wrote: On Sat, 2008-01-05 at 13:05 +0200, Tsantilas Christos wrote: ... I suggest removing break-blocks both because of the above bug and because it is trying to detect unrelated blocks, classes,

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-07 Thread Alex Rousskov
On Tue, 2008-01-08 at 10:43 +0900, Adrian Chadd wrote: Can you explain the SMP and the profiling advantages a bit better please? I hate having a nested mess of callbacks, but it at least lets me profile the callback chains a lot easier by grouping profiling info by specific call stacks

Re: astyle

2008-01-07 Thread Alex Rousskov
On Tue, 2008-01-08 at 16:45 +1300, Amos Jeffries wrote: On the bit-field problem, I have a similar mind. Even though the wrap is extremely ugly the suggested fix makes code almost unreadable. The fix (pre- and post-processing) is invisible to the programmer. It would be auto-performed before

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-07 Thread Adrian Chadd
On Mon, Jan 07, 2008, Alex Rousskov wrote: Finally, I can't see how async callbacks will make SMP much easier to implement. Could someone give me some insight into this? The AsyncCall API can be used to call threads or processes without changing the caller or the callee code. Selected

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Robert Collins
On Tue, 2008-01-08 at 16:33 +1300, Amos Jeffries wrote: Adrian Chadd wrote: On Tue, Jan 08, 2008, Mark Nottingham wrote: +1, and in 2.7 ASAP; I've already implemented this in my own hacky way (external to squid); would be nice to have 'real' includes. Well, test it out, make sure

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Adrian Chadd
On Tue, Jan 08, 2008, Robert Collins wrote: I looked at this for 3.1, but the config parser there confused me with its multiple meanings of 'file'. I'd definately like to see how you are doing it in 2 for a side-port. I implemented one about 5 years back. Now where did I put it

Re: src/Makefile.am:200: Libtool library used but `LIBTOOL' is undefined error,squid3

2008-01-07 Thread Henrik Nordström
mån 2008-01-07 klockan 02:30 -0800 skrev Arthur Tumanyan: Arthur Tumanyan wrote: Hi,I'm currently working above mysql logging feature for squid3(cleanly,not a plugin like previous version for squid.2.6). And the trouble is the message in subject when i do ./bootstrap.sh. I don't

Re: astyle

2008-01-07 Thread Amos Jeffries
Alex Rousskov wrote: On Tue, 2008-01-08 at 16:45 +1300, Amos Jeffries wrote: On the bit-field problem, I have a similar mind. Even though the wrap is extremely ugly the suggested fix makes code almost unreadable. The fix (pre- and post-processing) is invisible to the programmer. It would be

Re: bzr VCS feedback

2008-01-07 Thread Amos Jeffries
Working my way through the wiki instructions with bzr 1.0 I find a problem with the bind and update commands: # the environ setup differing from wiki... export TRUNKURL=/home/opensrc/bzr/ ## seems to work, or at least produces no messages. bzr bind $TRUNKURL ### fails with the following error

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-07 Thread Alex Rousskov
On Tue, 2008-01-08 at 13:21 +0900, Adrian Chadd wrote: On Mon, Jan 07, 2008, Alex Rousskov wrote: Finally, I can't see how async callbacks will make SMP much easier to implement. Could someone give me some insight into this? The AsyncCall API can be used to call threads or