comm_connect_addr broke in squid3/trunk?

2008-03-31 Thread Alex Rousskov
Hello, I am getting the following Invalid argument error on any connect(2) after updating my trunk copy: 00:16:24.833| commConnectStart: FD 10, cb 0x8b60780*1, 10.0.0.104:1344 00:16:24.833| comm_add_close_handler: FD 10, handler=1, data=0x8c64010 00:16:24.833| cbdataLock: 0x8c64010=1

Re: comm_connect_addr broke in squid3/trunk?

2008-03-31 Thread Amos Jeffries
Alex Rousskov wrote: Hello, I am getting the following Invalid argument error on any connect(2) after updating my trunk copy: 00:16:24.833| commConnectStart: FD 10, cb 0x8b60780*1, 10.0.0.104:1344 00:16:24.833| comm_add_close_handler: FD 10, handler=1, data=0x8c64010 00:16:24.833|

TPROXY support in Squid 3

2008-03-31 Thread Amos Jeffries
Between Balabit and TreeNet we have come up with a working TPROXY 4+ patch. It'll be sent to trunk soon. The merge It would be a whole lot cleaner and actually less change overall if we could drop the TPROXY version 2 support from Squid-3. I know we will likely need to keep the old support

Re: TPROXY support in Squid 3

2008-03-31 Thread Adrian Chadd
On Tue, Apr 01, 2008, Amos Jeffries wrote: Between Balabit and TreeNet we have come up with a working TPROXY 4+ patch. It'll be sent to trunk soon. The merge It would be a whole lot cleaner and actually less change overall if we could drop the TPROXY version 2 support from Squid-3. I

Re: comm_connect_addr broke in squid3/trunk?

2008-03-31 Thread Alex Rousskov
On Tue, 2008-04-01 at 00:08 +1300, Amos Jeffries wrote: Probably a muckup by me in the code setting the sockaddr_storage content. Can you get a trace with output of the sas variable fields? I have abort()ed Squid after a negative connect() return value is detected. Here is the backtrace and

Re: TPROXY support in Squid 3

2008-03-31 Thread Alex Rousskov
On Tue, 2008-04-01 at 00:18 +1300, Amos Jeffries wrote: Between Balabit and TreeNet we have come up with a working TPROXY 4+ patch. It'll be sent to trunk soon. The merge It would be a whole lot cleaner and actually less change overall if we could drop the TPROXY version 2 support from

Re: follow_xff-2_6.patch

2008-03-31 Thread Henrik Nordstrom
tor 2008-03-27 klockan 08:40 +0100 skrev Micalizzi Filippo: I've dowloaded your patch in order to get working the acl in squid as parent proxy with Dansguardian, but this patch doesn't work with any version of 2.6..Is it possibile to get a new updateted one working on 2.6-Stable14 ? The

Re: Trying to start using bzr

2008-03-31 Thread Henrik Nordstrom
sön 2008-03-30 klockan 16:37 -0600 skrev Alex Rousskov: My understanding is that no CVS branches other than trunk and squid3-ecap have been ported or moved to bzr. The decision to move is up to the branch maintainer. Everything in the main squid3 CVS repository has been migrated to bzr,

Re: TPROXY support in Squid 3

2008-03-31 Thread Henrik Nordstrom
tis 2008-04-01 klockan 00:18 +1300 skrev Amos Jeffries: The merge It would be a whole lot cleaner and actually less change overall if we could drop the TPROXY version 2 support from Squid-3. +1 Regards Henrik

Re: TPROXY support in Squid 3

2008-03-31 Thread Henrik Nordstrom
mån 2008-03-31 klockan 08:26 -0600 skrev Alex Rousskov: We may be able to provide better comments when we see the current code. It does not have to be polished and ready for commit. I see no reason to continue supporting now obsolete and no longer supported TPROXY versions in new versions of

Re: Delay pools work: delayed pool assignment ACL; statistics

2008-03-31 Thread Henrik Nordstrom
mån 2008-03-31 klockan 00:11 +0800 skrev Adrian Chadd: I'll commit this work to 2.HEAD, 2.7 and 2.6 in a week or so. 2.HEAD ok. as always for anything reasonably sane in shape. 2.7 not sure. Would delay 2.7.STABLE even further. 2.6 no, feature frozen. Regards Henrik

Re: TPROXY support in Squid 3

2008-03-31 Thread Alex Rousskov
On Mon, 2008-03-31 at 20:28 +0200, Henrik Nordstrom wrote: mån 2008-03-31 klockan 08:26 -0600 skrev Alex Rousskov: We may be able to provide better comments when we see the current code. It does not have to be polished and ready for commit. I see no reason to continue supporting now

Re: mkrelease.sh in 3.0

2008-03-31 Thread Henrik Nordstrom
mån 2008-03-31 klockan 18:40 +1300 skrev Amos Jeffries: bzr: ERROR: Not a branch: /bzr/squid3/tags/SQUID_3_0_STABLE3/. Have you created the tags/SQUID_3_0_STABLE3 release tag in bzr? Can't find any SQUID_3_0_STABLE3 tag, neither in tags or branches.. Regards Henrik

Re: TPROXY support in Squid 3

2008-03-31 Thread Henrik Nordstrom
mån 2008-03-31 klockan 13:31 -0600 skrev Alex Rousskov: What about Adrian plans (if I understood them correctly) to add TPROXY-like support to FreeBSD but not for TPROXY4-like API? Is that a good enough reason to continue supporting unsupported TPROXY versions? FreeBSD and TPROXY4 uses pretty

Re: Trying to start using bzr

2008-03-31 Thread Robert Collins
On Mon, 2008-03-31 at 20:43 +0200, Henrik Nordstrom wrote: But I have to ask Robert how we best continue the merge process on that branch.. I suspect it would actually be best to recreate the branch as a new bzr branch from trunk, if it's kept at all... We can manually sync it up quite

Re: Trying to start using bzr

2008-03-31 Thread Henrik Nordstrom
tis 2008-04-01 klockan 09:23 +1100 skrev Robert Collins: On Mon, 2008-03-31 at 20:43 +0200, Henrik Nordstrom wrote: But I have to ask Robert how we best continue the merge process on that branch.. I suspect it would actually be best to recreate the branch as a new bzr branch from

Re: mkrelease.sh in 3.0

2008-03-31 Thread Amos Jeffries
mån 2008-03-31 klockan 18:40 +1300 skrev Amos Jeffries: bzr: ERROR: Not a branch: /bzr/squid3/tags/SQUID_3_0_STABLE3/. Have you created the tags/SQUID_3_0_STABLE3 release tag in bzr? Can't find any SQUID_3_0_STABLE3 tag, neither in tags or branches.. Regards Henrik Hmm. I debugged my

Re: [MERGE] http_port tproxy options MUST imply transparent.

2008-03-31 Thread Bundle Buggy
Bundle Buggy has detected this merge request. For details, see: http://squid-cache.org/bundlebuggy//request/%3C20080401003609.E3A02E7262%40treenet.co.nz%3E

[MERGE] http_port tproxy options MUST imply transparent.

2008-03-31 Thread Amos Jeffries
Initial hack at TPROXY v4 support in Squid-3 This patch removes the --enable-linux-tproxy configure option and replaces it with two alternatives --enable-linux-tproxy2 and --enable-linux-tproxy4 *-tproxy2 performs the original tproxy behaviour of squid. *-tproxy4 adds and uses the new

Re: comm_connect_addr broke in squid3/trunk?

2008-03-31 Thread Amos Jeffries
On Tue, 2008-04-01 at 00:08 +1300, Amos Jeffries wrote: Probably a muckup by me in the code setting the sockaddr_storage content. Can you get a trace with output of the sas variable fields? I have abort()ed Squid after a negative connect() return value is detected. Here is the backtrace

Re: Delay pools work: delayed pool assignment ACL; statistics

2008-03-31 Thread Adrian Chadd
On Mon, Mar 31, 2008, Henrik Nordstrom wrote: m??n 2008-03-31 klockan 00:11 +0800 skrev Adrian Chadd: I'll commit this work to 2.HEAD, 2.7 and 2.6 in a week or so. 2.HEAD ok. as always for anything reasonably sane in shape. 2.7 not sure. Would delay 2.7.STABLE even further. 2.6 no,

Re: Trying to start using bzr

2008-03-31 Thread Amos Jeffries
tis 2008-04-01 klockan 09:23 +1100 skrev Robert Collins: On Mon, 2008-03-31 at 20:43 +0200, Henrik Nordstrom wrote: But I have to ask Robert how we best continue the merge process on that branch.. I suspect it would actually be best to recreate the branch as a new bzr branch from

bzr issues

2008-03-31 Thread Amos Jeffries
I'm getting annoyed by bzr's method of handling bzr send emails. As you may have noticed it adds the subject of the last commit to the email. regardless of the message thats asked for manually during the send process. It would be good if bzr pulled its email subject from that new message. We

Re: bzr issues

2008-03-31 Thread Robert Collins
On Tue, 2008-04-01 at 15:18 +1300, Amos Jeffries wrote: I'm getting annoyed by bzr's method of handling bzr send emails. As you may have noticed it adds the subject of the last commit to the email. regardless of the message thats asked for manually during the send process. It would be good

Re: bzr issues

2008-03-31 Thread Amos Jeffries
On Tue, 2008-04-01 at 15:18 +1300, Amos Jeffries wrote: I'm getting annoyed by bzr's method of handling bzr send emails. As you may have noticed it adds the subject of the last commit to the email. regardless of the message thats asked for manually during the send process. It would be

Re: bzr issues

2008-03-31 Thread Robert Collins
On Tue, 2008-04-01 at 15:41 +1300, Amos Jeffries wrote: No. I'm just using: bzr send --mailto=squid-dev.squid-cache.org and entering the message when it asks for one. Is it popping up a gui client, or a text editor? Does it have a field for setting a subject? -Rob -- GPG key

Re: bzr issues

2008-03-31 Thread Amos Jeffries
On Tue, 2008-04-01 at 15:41 +1300, Amos Jeffries wrote: No. I'm just using: bzr send --mailto=squid-dev.squid-cache.org and entering the message when it asks for one. Is it popping up a gui client, or a text editor? Does it have a field for setting a subject? Just a text editor (nano