Re: Lessons learned from string-fix and consequences on StringNg design

2009-02-13 Thread Amos Jeffries
Kinkie wrote: On Fri, Feb 13, 2009 at 11:36 AM, Henrik Nordstrom wrote: tor 2009-02-12 klockan 17:19 +0100 skrev Kinkie: It would IMHO make sense to: 1. introduce StringNg::size_type, which should be a _signed_ 32-bit integer 2. introduce a static const StringNg::npos = -1 to be used in place

Re: Squid 3.1.0.5 uses memory without bounds

2009-02-13 Thread Alex Rousskov
On 02/13/2009 01:40 PM, Steinar H. Gunderson wrote: > On Fri, Feb 13, 2009 at 11:55:28AM +0100, Steinar H. Gunderson wrote: > >> Here's a new run. I only let it run for a few minutes, though, so the numbers >> are pretty small (and their relative sizes may not be representable for a >> long-runn

Re: votes..

2009-02-13 Thread Henrik Nordstrom
fre 2009-02-13 klockan 10:25 -0700 skrev Alex Rousskov: > Your recollection is correct. I think it is even documented on the > Squid3 submission instructions wiki page. Indeed it is. http://wiki.squid-cache.org/MergeProcedure#head-3c69e15b207172e0eeb128fef209554218c60eda A little more complicat

Re: Squid 3.1.0.5 uses memory without bounds

2009-02-13 Thread Steinar H. Gunderson
On Fri, Feb 13, 2009 at 11:55:28AM +0100, Steinar H. Gunderson wrote: > Here's a new run. I only let it run for a few minutes, though, so the numbers > are pretty small (and their relative sizes may not be representable for a > long-running Squid): ...and here's a pprof graph: http://home.samfu

Re: [MERGE] libsquid-compat shuffling pt 1

2009-02-13 Thread Alex Rousskov
On 02/06/2009 08:02 PM, Amos Jeffries wrote: > Alex Rousskov wrote: >> s/libsquid-compat/compat/g >> >> I think we should be including headers as compat/foo/... and not just >> foo/... -I directives need to be adjusted for that to happen. This >> will help with future moves of the compat directory

Re: Lessons learned from string-fix and consequences on StringNg design

2009-02-13 Thread Alex Rousskov
On 02/13/2009 10:31 AM, Kinkie wrote: >> As for overflow checks, I would throw in grow() or equivalent if the >> size gets too big. Adding debugging when the size exceeds some large >> threshold is probably not needed because we can grep for that without an >> explicit debug statement. Or did you w

Re: [MERGE] SourceLayout: squid compat library

2009-02-13 Thread Alex Rousskov
Alex Rousskov has voted tweak. Status is now: Conditionally approved Comment: s/squid-compat/compat/g Why do you insist on the "squid-" prefix in that directory name? I still think we should always be including headers as compat/foo/... and not just foo/... I believe you have fixed a few places,

Re: Lessons learned from string-fix and consequences on StringNg design

2009-02-13 Thread Kinkie
On Fri, Feb 13, 2009 at 5:51 PM, Alex Rousskov wrote: > On 02/12/2009 09:19 AM, Kinkie wrote: >> Hi all, >>the work on string-fix is nearing completion, and it yielded some >> interesting insight on an issue also affecting the StringNg design, >> I'd like to have some input on: storage size an

Re: votes..

2009-02-13 Thread Alex Rousskov
On 02/11/2009 03:17 PM, Henrik Nordstrom wrote: > tor 2009-02-12 klockan 08:25 +1100 skrev Robert Collins: > >> On Wed, 2009-02-11 at 23:20 +0200, Tsantilas Christos wrote: >> >>> May I ask, about the votes, which is the procedure? Who is giving access >>> to bundlebuggy? Or it is somethin

Re: Lessons learned from string-fix and consequences on StringNg design

2009-02-13 Thread Alex Rousskov
On 02/12/2009 09:19 AM, Kinkie wrote: > Hi all, >the work on string-fix is nearing completion, and it yielded some > interesting insight on an issue also affecting the StringNg design, > I'd like to have some input on: storage size and API > > StringNg uses currently size_t as its storage size,

Squid Developer? (fwd)

2009-02-13 Thread Duane Wessels
Duane: I'm a second year student at the Harvard Business School. Prior to coming back to school for my MBA I was the co-founder of something called Project Honey Pot (www.projecthoneypot.org). Project Honey Pot tracks malicious behavior online. We work with law enforcement agencies worldwide and h

Re: Memory leak in ICAPXaction

2009-02-13 Thread Alex Rousskov
On 02/11/2009 06:06 PM, Amos Jeffries wrote: >> Amos Jeffries wrote: >> >>> This is also popping out, and very confusing since ICAPXaction global is >>> only created once right? >>> >> it is the "new PconnPool" line. It is create only once. It says its >> reachable because the time of

Re: Squid 3.1.0.5 uses memory without bounds

2009-02-13 Thread Alex Rousskov
On 02/13/2009 03:55 AM, Steinar H. Gunderson wrote: > On Fri, Feb 13, 2009 at 09:01:35PM +1300, Amos Jeffries wrote: > >> A few things are still a little hidden due to the compiler optimizations >> and valgrind behavior, would it be possible that you rebuild squid with >> --disable-optimizat

Re: Lessons learned from string-fix and consequences on StringNg design

2009-02-13 Thread Kinkie
On Fri, Feb 13, 2009 at 11:36 AM, Henrik Nordstrom wrote: > tor 2009-02-12 klockan 17:19 +0100 skrev Kinkie: >> It would IMHO make sense to: >> 1. introduce StringNg::size_type, which should be a _signed_ 32-bit integer >> 2. introduce a static const StringNg::npos = -1 to be used in place of >> s

Re: Squid 3.1.0.5 uses memory without bounds

2009-02-13 Thread Steinar H. Gunderson
On Fri, Feb 13, 2009 at 09:01:35PM +1300, Amos Jeffries wrote: > A few things are still a little hidden due to the compiler optimizations > and valgrind behavior, would it be possible that you rebuild squid with > --disable-optimizations and also make sure that --enable-valgrind is > used. Th

Re: Lessons learned from string-fix and consequences on StringNg design

2009-02-13 Thread Henrik Nordstrom
tor 2009-02-12 klockan 17:19 +0100 skrev Kinkie: > It would IMHO make sense to: > 1. introduce StringNg::size_type, which should be a _signed_ 32-bit integer > 2. introduce a static const StringNg::npos = -1 to be used in place of > std::string::npos Or use size_t in the API while using a smaler t

Re: Squid 3.1.0.5 uses memory without bounds

2009-02-13 Thread Amos Jeffries
Steinar H. Gunderson wrote: On Sun, Feb 08, 2009 at 12:38:42AM +0100, Steinar H. Gunderson wrote: I'm using Squid 3.1.0.5 on my amd64 system (Debian unstable), and I'm having problems that it seems to use RAM without bounds (about 1GB/week) even though my cache_mem is only 128MB. I ran it throug