special chars in URI.

2014-05-13 Thread Eliezer Croitoru
I am not sure but am almost sure I asked this before. I have a google url that came into my external_acl helper and could not be parsed by the URI library. the issue is that in the query there are symbols such as "|" aka pipe. Now the client indeed sent it for sure. I am not sure if in the logs

Re: [MERGE] Squid Patch (revision 10487)

2014-05-13 Thread Michael Pye
On 2014-05-13 11:53, Amos Jeffries wrote: On 13/05/2014 10:52 p.m., Amos Jeffries wrote: On 13/05/2014 4:56 a.m., Michael Pye wrote: On 2014-05-12 16:52, Amos Jeffries wrote: Here is the guts of the original patch as should be relevant to Squid-3.5 (or 3.4). http://master.squid-cache.org/~amos

Re: [PATCH] experiment in private caching

2014-05-13 Thread Alex Rousskov
On 05/13/2014 04:39 AM, Amos Jeffries wrote: > On 13/05/2014 9:04 a.m., Alex Rousskov wrote: >> Performance concerns: To determine whether the requested object is in >> the cache, SMP Store requires semi-expensive lookups (one for each SMP >> cache_dir and one for the shared cache_mem). AFAICT, thi

Re: Squid Won't Cache private

2014-05-13 Thread Amos Jeffries
On 13/05/2014 11:05 p.m., Julius Thomas wrote: > Hi Amos, > > thanks for your answer. > This are the full reply headers. > Okay. For caching the server needs to produce at least a Date: header with current timestamp of when its responding. And a Last-Modified header with timestamp the object was

Re: [MERGE] Squid Patch (revision 10487)

2014-05-13 Thread Michael Pye
On 2014-05-13 11:53, Amos Jeffries wrote: On 13/05/2014 10:52 p.m., Amos Jeffries wrote: On 13/05/2014 4:56 a.m., Michael Pye wrote: On 2014-05-12 16:52, Amos Jeffries wrote: Here is the guts of the original patch as should be relevant to Squid-3.5 (or 3.4). http://master.squid-cache.org/~amos

Re: [PATCH] Fix for Squid 3.4.5 segfault

2014-05-13 Thread Alex Rousskov
On 05/13/2014 02:45 AM, Steve Hill wrote: > On 12.05.14 18:20, Alex Rousskov wrote: >> The Token class in v3.4 uses an ugly union (instead of "struct") for the >> data member. Thus, data.timespec should be identical to data.string. The >> fact that changing .timespec to .string makes a difference i

Re: [PATCH] Use SBuf for tunnel.cc I/O

2014-05-13 Thread Alex Rousskov
On 05/13/2014 04:03 AM, Amos Jeffries wrote: > On 13/05/2014 10:46 a.m., Alex Rousskov wrote: >> On 05/11/2014 11:16 AM, Amos Jeffries wrote: >>> Unlike the char* API the buffer can be appended to before write(2) is >>> completed and the appended bytes will be handled as part of the original >>> wr

Jenkins build is back to normal : 3.HEAD-x64-debian-unstable #595

2014-05-13 Thread noc
See

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-10-clang #78

2014-05-13 Thread noc
See Changes: [Amos Jeffries] Regression: segfault logging with %tg format specifier In trunk rev.13387 Token class data member was converted from union to struct without adding initializer for the timespec field. timesp

Re: Squid Won't Cache private

2014-05-13 Thread Julius Thomas
Hi Amos, thanks for your answer. This are the full reply headers. Squid is acting as an reverse proxy. i cant change the reply headers from the origin server. cache_peer *.*.*.* parent 80 0 sourcehash no-digest name=test1 weight=3 cache_peer *.*.*.* parent 80 0 sourcehash no-digest name=test2 w

Re: Squid Won't Cache private

2014-05-13 Thread Amos Jeffries
On 13/05/2014 7:35 a.m., Julius Thomas wrote: >> Dear Squid Developers, >> > >> > we are using squid 3.4.2.'--enable-http-violations' >> > I can't cache a xml file with this headers: >> > Cache-Control |no-cache| >> > Connection |Keep-Alive| >> > Content-Length |168| >> > Content-

Re: [MERGE] Squid Patch (revision 10487)

2014-05-13 Thread Amos Jeffries
On 13/05/2014 10:52 p.m., Amos Jeffries wrote: > On 13/05/2014 4:56 a.m., Michael Pye wrote: >> On 2014-05-12 16:52, Amos Jeffries wrote: >>> Here is the guts of the original patch as should be relevant to >>> Squid-3.5 (or 3.4). >>> http://master.squid-cache.org/~amosjeffries/patches/Pye_s35.patch

Re: [MERGE] Squid Patch (revision 10487)

2014-05-13 Thread Amos Jeffries
On 13/05/2014 4:56 a.m., Michael Pye wrote: > On 2014-05-12 16:52, Amos Jeffries wrote: >> Here is the guts of the original patch as should be relevant to >> Squid-3.5 (or 3.4). >> http://master.squid-cache.org/~amosjeffries/patches/Pye_s35.patch > > Many thanks Amos, I've just tried this and it d

Re: [PATCH] Fix for Squid 3.4.5 segfault

2014-05-13 Thread Amos Jeffries
On 13/05/2014 8:45 p.m., Steve Hill wrote: > On 12.05.14 18:20, Alex Rousskov wrote: > >> The Token class in v3.4 uses an ugly union (instead of "struct") for the >> data member. Thus, data.timespec should be identical to data.string. The >> fact that changing .timespec to .string makes a differen

Re: [PATCH] experiment in private caching

2014-05-13 Thread Amos Jeffries
On 13/05/2014 9:04 a.m., Alex Rousskov wrote: > On 05/11/2014 05:29 AM, Amos Jeffries wrote: >> This patch seeks to reduce the constant MISS situation we have from >> false failures doing Host: header verify. > > General comments: > > FWIW, I have a general feeling we are going to regret the prop

Re: [PATCH] Use SBuf for tunnel.cc I/O

2014-05-13 Thread Amos Jeffries
On 13/05/2014 10:46 a.m., Alex Rousskov wrote: > On 05/11/2014 11:16 AM, Amos Jeffries wrote: > >> This patch adds a Comm::Write API for accepting SBuf output buffers. > > >> Unlike the char* API the buffer can be appended to before write(2) is >> completed and the appended bytes will be handled

Re: [PATCH] Fix for Squid 3.4.5 segfault

2014-05-13 Thread Steve Hill
On 12.05.14 18:20, Alex Rousskov wrote: The Token class in v3.4 uses an ugly union (instead of "struct") for the data member. Thus, data.timespec should be identical to data.string. The fact that changing .timespec to .string makes a difference indicates that something else is probably broken.