On 07/31/2010 04:27 PM, Andrew Beverley wrote:
I'd like to propose the attached patch, to rename the build option
--enable-linux-netfilter to --enable-nf-transparent. This is for 2
reasons:
1. It is consistent with the remainder of the transparent proxy options
(ifpw-transparent,
I'm not sure its fully worth doing this.
* the transparent options are all due for a naming upgrade or
removal in the next major release anyway.
Okay, I'm happy to leave as is. However, I would still suggest a review
of the naming in the upgrade (see below).
* linux-netfilter in fact
I'd like to propose the attached patch, to rename the build option
--enable-linux-netfilter to --enable-nf-transparent. This is for 2
reasons:
1. It is consistent with the remainder of the transparent proxy options
(ifpw-transparent, ipf-transparent, pf-transparent).
2. It causes less confusion
Andrew Beverley wrote:
I'd like to propose the attached patch, to rename the build option
--enable-linux-netfilter to --enable-nf-transparent. This is for 2
reasons:
1. It is consistent with the remainder of the transparent proxy options
(ifpw-transparent, ipf-transparent, pf-transparent).
2.
Also, would you mind waiting until autoconf-refactor lands to trunk?
It is a largish change, and changing trunk now would make merging
harder. If all goes right, I'll submit a merge candidate on Friday for
review, and if there's no issues I hope to merge next Sunday..
Thanks!
On 8/1/10, Amos
