Re: [PATCH] Fix for Squid 3.4.5 segfault

2014-05-13 Thread Alex Rousskov
On 05/13/2014 02:45 AM, Steve Hill wrote: > On 12.05.14 18:20, Alex Rousskov wrote: >> The Token class in v3.4 uses an ugly union (instead of "struct") for the >> data member. Thus, data.timespec should be identical to data.string. The >> fact that changing .timespec to .string makes a difference i

Re: [PATCH] Fix for Squid 3.4.5 segfault

2014-05-13 Thread Amos Jeffries
On 13/05/2014 8:45 p.m., Steve Hill wrote: > On 12.05.14 18:20, Alex Rousskov wrote: > >> The Token class in v3.4 uses an ugly union (instead of "struct") for the >> data member. Thus, data.timespec should be identical to data.string. The >> fact that changing .timespec to .string makes a differen

Re: [PATCH] Fix for Squid 3.4.5 segfault

2014-05-13 Thread Steve Hill
On 12.05.14 18:20, Alex Rousskov wrote: The Token class in v3.4 uses an ugly union (instead of "struct") for the data member. Thus, data.timespec should be identical to data.string. The fact that changing .timespec to .string makes a difference indicates that something else is probably broken.

Re: [PATCH] Fix for Squid 3.4.5 segfault

2014-05-12 Thread Alex Rousskov
On 05/12/2014 10:47 AM, Steve Hill wrote: > Squid 3.4.5 segfaults when formatting log lines for me. It looks like > this is down to fmt->data.timespec being uninitialised, and affects the > %tg format specifier. > > As far as I can tell, fmt->data.timespec is never set anywhere, and we > should

[PATCH] Fix for Squid 3.4.5 segfault

2014-05-12 Thread Steve Hill
Squid 3.4.5 segfaults when formatting log lines for me. It looks like this is down to fmt->data.timespec being uninitialised, and affects the %tg format specifier. As far as I can tell, fmt->data.timespec is never set anywhere, and we should probably be using fmt->data.string instead. The