Re: [PATCH] meta_header option

2012-10-15 Thread Alex Rousskov
On 10/12/2012 11:21 PM, Amos Jeffries wrote: > The sensitive ones are cert, group, user and password. And we are > constantly being asked how to pass those to ICAP anyway - so I think > allowing them to be passed is a wanted thing and if done safely will not > be a problem. Agreed. Just keep in mi

Re: [PATCH] meta_header option

2012-10-12 Thread Amos Jeffries
On 13/10/2012 5:21 p.m., Alex Rousskov wrote: On 10/12/2012 08:25 PM, Amos Jeffries wrote: meta_note hi "Hello world" external_acl_type ... %note{hi} ... acl world note foo "Ehlo" logformat ... %note{hi} %note{foo} (where the helper recieves "... hi=\"Hello world\" ...")

Re: [PATCH] meta_header option

2012-10-12 Thread Alex Rousskov
On 10/12/2012 08:25 PM, Amos Jeffries wrote: > meta_note hi "Hello world" > >external_acl_type ... %note{hi} ... > >acl world note foo "Ehlo" > >logformat ... %note{hi} %note{foo} > > (where the helper recieves "... hi=\"Hello world\" ...") and responds > "OK foo="Ehlo") Are

Re: [PATCH] meta_header option

2012-10-12 Thread Amos Jeffries
On 13/10/2012 5:00 a.m., Alex Rousskov wrote: On 10/12/2012 01:06 AM, Amos Jeffries wrote: I got a request to implement stacked tags in external ACL the other day. It would seem they are suited well for combining with this feature. How about "tag" or "meta_tag" ? I assume stacked tags are key:v

Re: [PATCH] meta_header option

2012-10-12 Thread Tsantilas Christos
On 10/12/2012 07:00 PM, Alex Rousskov wrote: > OK, so here is the summary of the required changes for the proposed > meta_header patch: > > 1. Rename proposed "meta_header" directive to "note". > 2. Rename proposed "%meta_header" logformat code to "%note". > 3. Enforce restrictions on charac

Re: [PATCH] meta_header option

2012-10-12 Thread Alex Rousskov
On 10/12/2012 01:06 AM, Amos Jeffries wrote: >>> I got a request to implement stacked tags in external ACL the other day. >>> It would seem they are suited well for combining with this feature. How >>> about "tag" or "meta_tag" ? >> I assume stacked tags are key:value pairs. Today, tags are essenti

Re: [PATCH] meta_header option

2012-10-12 Thread Amos Jeffries
On 12/10/2012 5:10 p.m., Alex Rousskov wrote: On 10/11/2012 07:32 PM, Amos Jeffries wrote: On 12/10/2012 4:05 a.m., Alex Rousskov wrote: On 10/11/2012 05:21 AM, Amos Jeffries wrote: If you can avoid calling the list of key:pair entries *headers* it would be less confusing. Here are a few othe

Re: [PATCH] meta_header option

2012-10-11 Thread Alex Rousskov
On 10/11/2012 07:32 PM, Amos Jeffries wrote: > On 12/10/2012 4:05 a.m., Alex Rousskov wrote: >> On 10/11/2012 05:21 AM, Amos Jeffries wrote: >>> If you can avoid calling the >>> list of key:pair entries *headers* it would be less confusing. >> Here are a few other naming options to consider, from

Re: [PATCH] meta_header option

2012-10-11 Thread Amos Jeffries
On 12/10/2012 4:05 a.m., Alex Rousskov wrote: On 10/11/2012 05:21 AM, Amos Jeffries wrote: On 11/10/2012 9:39 p.m., Tsantilas Christos wrote: If there is not any objection I will commit this patch to trunk On 09/19/2012 06:46 PM, Tsantilas Christos wrote: Hi all, This patch adds meta_header

Re: [PATCH] meta_header option

2012-10-11 Thread Alex Rousskov
On 10/11/2012 05:21 AM, Amos Jeffries wrote: > On 11/10/2012 9:39 p.m., Tsantilas Christos wrote: >> If there is not any objection I will commit this patch to trunk >> >> >> On 09/19/2012 06:46 PM, Tsantilas Christos wrote: >>> Hi all, >>> >>> This patch adds meta_header option to squid.conf. It is

Re: [PATCH] meta_header option

2012-10-11 Thread Amos Jeffries
On 11/10/2012 9:39 p.m., Tsantilas Christos wrote: If there is not any objection I will commit this patch to trunk On 09/19/2012 06:46 PM, Tsantilas Christos wrote: Hi all, This patch adds meta_header option to squid.conf. It is similar to adaptation_meta but is applied after all adaptation a

Re: [PATCH] meta_header option

2012-10-11 Thread Tsantilas Christos
If there is not any objection I will commit this patch to trunk On 09/19/2012 06:46 PM, Tsantilas Christos wrote: > Hi all, > > This patch adds meta_header option to squid.conf. It is similar to > adaptation_meta but is applied after all adaptation and before logging. > Values of named meta head

Re: [PATCH] meta_header option

2012-09-21 Thread Tsantilas Christos
Hi Amos, On 09/21/2012 12:31 PM, Amos Jeffries wrote: > On 21/09/2012 4:56 a.m., Tsantilas Christos wrote: >> On 09/20/2012 08:56 AM, Amos Jeffries wrote: >> >>> * also, how can theVirginRep.raw().header be cast to both Request and >>> Reply without one being wrong? surely the second should be

Re: [PATCH] meta_header option

2012-09-21 Thread Amos Jeffries
On 21/09/2012 4:56 a.m., Tsantilas Christos wrote: On 09/20/2012 08:56 AM, Amos Jeffries wrote: This documentation leaves a lot to be desired in terminology clarity. Critique below... On 20/09/2012 3:46 a.m., Tsantilas Christos wrote: Hi all, This patch adds meta_header option to squid.conf.

Re: [PATCH] meta_header option

2012-09-20 Thread Tsantilas Christos
On 09/20/2012 08:56 AM, Amos Jeffries wrote: > This documentation leaves a lot to be desired in terminology clarity. > Critique below... > > > On 20/09/2012 3:46 a.m., Tsantilas Christos wrote: >> Hi all, >> >> This patch adds meta_header option to squid.conf. It is similar to >> adaptation_meta

Re: [PATCH] meta_header option

2012-09-19 Thread Amos Jeffries
This documentation leaves a lot to be desired in terminology clarity. Critique below... On 20/09/2012 3:46 a.m., Tsantilas Christos wrote: Hi all, This patch adds meta_header option to squid.conf. It is similar to adaptation_meta but is applied after all adaptation and before logging. Values