Re: [PATCH]proposal for a fake_strore_url helper wrapping.

2012-09-11 Thread Eliezer Croitoru
On 09/11/2012 01:52 AM, Amos Jeffries wrote: If by this you mean the helper/ section fake helper. The helper/url_rewrite/fake should be sufficient. url-rewrite, store-url, and location-rewrite (also not ported) all have the same API limitations and format so the helpers can all be in helper/

Re: [PATCH]proposal for a fake_strore_url helper wrapping.

2012-09-10 Thread Amos Jeffries
On 11.09.2012 04:16, Eliezer Croitoru wrote: On 09/10/2012 05:39 PM, Alex Rousskov wrote: On 09/09/2012 04:08 AM, Eliezer Croitoru wrote: I took the url_rewrite helper and used what ever seems needed to create a url_store_rewrite helper. I also added the needed variables for the next step and

Re: [PATCH]proposal for a fake_strore_url helper wrapping.

2012-09-10 Thread Eliezer Croitoru
On 9/10/2012 7:44 PM, Alex Rousskov wrote: To be clear, I think we should not push dummy code (e.g., code after step #1 or #2) into Squid trunk. Others may overrule me, of course, but I do not recommend counting on that or fighting over it. I'm with youy on it. I just noticed that I didnt got y

Re: [PATCH]proposal for a fake_strore_url helper wrapping.

2012-09-10 Thread Alex Rousskov
On 09/10/2012 10:16 AM, Eliezer Croitoru wrote: > On 09/10/2012 05:39 PM, Alex Rousskov wrote: >> When you think these changes are ready for commit, please include a >> proposed commit message. It is a good idea to do that even before the >> last stage, of course -- it tells us what the patch is s

Re: [PATCH]proposal for a fake_strore_url helper wrapping.

2012-09-10 Thread Eliezer Croitoru
On 09/10/2012 05:39 PM, Alex Rousskov wrote: On 09/09/2012 04:08 AM, Eliezer Croitoru wrote: I took the url_rewrite helper and used what ever seems needed to create a url_store_rewrite helper. I also added the needed variables for the next step and freeing them where and if needed. this is a mor

Re: [PATCH]proposal for a fake_strore_url helper wrapping.

2012-09-10 Thread Alex Rousskov
On 09/09/2012 04:08 AM, Eliezer Croitoru wrote: > I took the url_rewrite helper and used what ever seems needed to create > a url_store_rewrite helper. > I also added the needed variables for the next step and freeing them > where and if needed. > this is a more of a basic sketch. Please do not ma

Re: [PATCH]proposal for a fake_strore_url helper wrapping. +fixes

2012-09-09 Thread Amos Jeffries
On 10.09.2012 01:12, Eliezer Croitoru wrote: On 9/9/2012 2:54 PM, Amos Jeffries wrote: ++ It is questionable whether the store-URL should also be below the no_cache_done bits as well. Since requests with"cache deny" are not going to be loaded from cache, but maybe they will be stored later

Re: [PATCH]proposal for a fake_strore_url helper wrapping. +fixes

2012-09-09 Thread Eliezer Croitoru
On 9/9/2012 2:54 PM, Amos Jeffries wrote: On 9/09/2012 10:08 p.m., Eliezer Croitoru wrote: I took the url_rewrite helper and used what ever seems needed to create a url_store_rewrite helper. I also added the needed variables for the next step and freeing them where and if needed. this is a more

Re: [PATCH]proposal for a fake_strore_url helper wrapping.

2012-09-09 Thread Amos Jeffries
On 9/09/2012 10:08 p.m., Eliezer Croitoru wrote: I took the url_rewrite helper and used what ever seems needed to create a url_store_rewrite helper. I also added the needed variables for the next step and freeing them where and if needed. this is a more of a basic sketch. Eliezer You dont n

[PATCH]proposal for a fake_strore_url helper wrapping.

2012-09-09 Thread Eliezer Croitoru
I took the url_rewrite helper and used what ever seems needed to create a url_store_rewrite helper. I also added the needed variables for the next step and freeing them where and if needed. this is a more of a basic sketch. Eliezer === modified file 'src/ClientRequestContext.h' --- src/ClientR