Re: Bug review request

2006-08-15 Thread Henrik Nordstrom
tis 2006-08-15 klockan 22:46 +0200 skrev Guido Serassio: > In client_side.c at line 3932, 3943, 4073 and 4285 (not used code) I > can't see any err->request assignment. All of these is before the request has been parsed, so there is no request... > So like this ? > > err->auth_user_request = r

Re: Bug review request

2006-08-15 Thread Guido Serassio
Hi Henrik, At 10.22 15/08/2006, Henrik Nordstrom wrote: On Mon, 2006-08-14 at 10:32 +0200, Guido Serassio wrote: > err->request = requestLink(request); > > But not always err->request is linked to a request, it could be a problem ? You have found places where err->request is assigned without

Re: Bug review request

2006-08-15 Thread Henrik Nordstrom
On Mon, 2006-08-14 at 10:32 +0200, Guido Serassio wrote: > err->request = requestLink(request); > > But not always err->request is linked to a request, it could be a problem ? You have found places where err->request is assigned without a link? > > ->src_addr > > Some confusion here, sometim

Re: Bug review request

2006-08-14 Thread Guido Serassio
Hi Henrik, At 05.57 14/08/2006, Henrik Nordstrom wrote: sön 2006-08-13 klockan 22:37 +0200 skrev Guido Serassio: > Hi, > > I'm trying to close the Bug #212. > Someone could review the proposed patch ? > > It' should be incomplete, some errors still need to be verified. Looked at it and my gut

Re: Bug review request

2006-08-13 Thread Henrik Nordstrom
sön 2006-08-13 klockan 22:37 +0200 skrev Guido Serassio: > Hi, > > I'm trying to close the Bug #212. > Someone could review the proposed patch ? > > It' should be incomplete, some errors still need to be verified. Looked at it and my gut feeling is that errorCon should be extended with a request

Bug review request

2006-08-13 Thread Guido Serassio
Hi, I'm trying to close the Bug #212. Someone could review the proposed patch ? It' should be incomplete, some errors still need to be verified. Thanks for any comment. Regards Guido - Guido Serassio Acme Consulting S.r.l. - Microsof