[sr-dev] Re: [kamailio/kamailio] userloc: change data type of id field to BIGINT (PR #3407)

2023-03-30 Thread Henning Westerholt
Closed #3407. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3407#event-8891454447 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing L

[sr-dev] Re: [kamailio/kamailio] userloc: change data type of id field to BIGINT (PR #3407)

2023-03-30 Thread Henning Westerholt
Close this one - I will make a dedicated commit moving the p_usrloc.sql to the XML schema directory. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3407#issuecomment-1490885121 You are receiving this because you are subscribed to this thread. Mes

[sr-dev] Re: [kamailio/kamailio] core: fix a seg while t_continue with nats module (PR #3396)

2023-03-30 Thread Daniel-Constantin Mierla
Closing this one. @seven1240: if you want to add some extra logging, make a new PR. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3396#issuecomment-1490833634 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] core: fix a seg while t_continue with nats module (PR #3396)

2023-03-30 Thread Daniel-Constantin Mierla
Closed #3396. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3396#event-8891188176 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing L

[sr-dev] Re: [kamailio/kamailio] tm: memory leak in case dropping messages in local-request event route (PR #3403)

2023-03-30 Thread Daniel-Constantin Mierla
I think that `cbp` is expected to be freed out tm, by the code component that knows its structure. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3403#issuecomment-1490832625 You are receiving this because you are subscribed to this thread. Messa

[sr-dev] Re: [kamailio/kamailio] core: add socket timestamp of received packets and keep track of receive delay (PR #3404)

2023-03-30 Thread Daniel-Constantin Mierla
I can't have an opinion right away for merging, the changes are on a critical part of the core code and I am not sure it is portable for bsd/macos/*unix. I think it needs further analysis, it is also only for udp. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio

[sr-dev] Re: [kamailio/kamailio] tcpops: added tcp_get_conid() for kemi (PR #3402)

2023-03-30 Thread Daniel-Constantin Mierla
Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3402#issuecomment-1490792215 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:ea30efdb: tcpops: added tcp_get_conid() for kemi

2023-03-30 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: ea30efdbae2b33988e6157ba5e17aba16db156d4 URL: https://github.com/kamailio/kamailio/commit/ea30efdbae2b33988e6157ba5e17aba16db156d4 Author: Muhammad Shahzad Shafi Committer: Daniel-Constantin Mierla Date: 2023-03-30T21:07:19+02:00 tcpops: added tcp_get_co

[sr-dev] Re: [kamailio/kamailio] tcpops: added tcp_get_conid() for kemi (PR #3402)

2023-03-30 Thread Daniel-Constantin Mierla
Merged #3402 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3402#event-8890955009 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developme

[sr-dev] Re: [kamailio/kamailio] tm:t_lookup_callid use only trans Call-ID header value to match with … (PR #3393)

2023-03-30 Thread Daniel-Constantin Mierla
The exiting code seems inflexible indeed, but also the PR does not feel clean. I will think about if there would be a better way to update. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3393#issuecomment-1490788250 You are receiving this because

[sr-dev] git:master:6f8c1bf9: modules: readme files regenerated - acc ... [skip ci]

2023-03-30 Thread Kamailio Dev
Module: kamailio Branch: master Commit: 6f8c1bf967ca3d101a70631df8d77cc7855b3a72 URL: https://github.com/kamailio/kamailio/commit/6f8c1bf967ca3d101a70631df8d77cc7855b3a72 Author: Kamailio Dev Committer: Kamailio Dev Date: 2023-03-30T19:31:38+02:00 modules: readme files regenerated - acc ... [s

[sr-dev] Re: [kamailio/kamailio] Typos (PR #3375)

2023-03-30 Thread Daniel-Constantin Mierla
Merged #3375 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3375#event-8890089881 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developme

[sr-dev] git: new commits in branch master

2023-03-30 Thread Daniel-Constantin Mierla
- URL: https://github.com/kamailio/kamailio/commit/d394cc62e48fe4636d4c9b2cf9ca8d54e0f1cfbd Author: Date: 2023-03-30T19:23:29+02:00 acc: typo - URL: https://github.com/kamailio/kamailio/commit/f5cfafa396c5925b8b4694c3e962564706fd4e12 A

[sr-dev] Re: HTTPS for xHTTP module

2023-03-30 Thread luca . nardin
Thanks, clear! kind regards, Luca ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] uac_redirect: Module fails to load [regression] (Issue #3188)

2023-03-30 Thread Daniel-Constantin Mierla
Discuss first on sr-users mailing list providing further details, such as modparams, logs with debug=3, and if it proves to be some code error, a new issue can be created. But not before. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3188#issu

[sr-dev] Re: [kamailio/kamailio] uac_redirect: Module fails to load [regression] (Issue #3188)

2023-03-30 Thread ynasida
Can we re-open this issue please ? Or I should create new one ? Mar 30 10:35:26 kam1 kamailio[12610]: ERROR: uac_redirect [../../modules/acc/acc_api.h:191]: acc_load_api(): cannot find bind_acc Mar 30 10:35:26 kam1 kamailio[12610]: ERROR: uac_redirect [uac_redirect.c:259]: redirect_init(): canno

[sr-dev] Re: [kamailio/kamailio] uac_redirect: Module fails to load [regression] (Issue #3188)

2023-03-30 Thread ynasida
Hello, I still have same issue. kamailio 5.6.4. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3188#issuecomment-1490429875 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] Re: Debian SBOM for kamailio

2023-03-30 Thread Henning Westerholt
Hi Olle, sure. What some people are doing is to list the common licence (e.g., GPLv2 or later) prominently like in the help output etc.., and then provide a pointer to a file that includes all the details, like the Debian copyright file discussed earlier. This is the description about that info

[sr-dev] Re: [kamailio/kamailio] core:tcp allow to handle TCP connections with tcp_accept_haproxy=yes flag even message does not contain PROXY protocol header (#2206)

2023-03-30 Thread ovoshlook
Hi I think, I just forgot to update this part of the doc. It should be working fine for any connection type and yes. It should be only a debug-level message But feel free to test it and let us know if something is wrong. -- Reply to this email directly or view it on GitHub: https://github.com

[sr-dev] Re: [kamailio/kamailio] tls: get san entries by index (PR #3408)

2023-03-30 Thread Marcus Orchard
@marcus-orchard commented on this pull request. > @@ -1718,3 +1894,7 @@ sr_kemi_xval_t* ki_tls_cget_attr(sip_msg_t* msg, str > *aname) sr_kemi_xval_null(&_ksr_kemi_tls_xval, SR_KEMI_XVAL_NULL_EMPTY); return &_ksr_kemi_tls_xval; } + Correct, also removed :) -- Reply to this e

[sr-dev] Re: [kamailio/kamailio] tls: get san entries by index (PR #3408)

2023-03-30 Thread Marcus Orchard
@marcus-orchard commented on this pull request. > @@ -318,7 +318,7 @@ static int get_version(str* res, sip_msg_t* msg) res->s = buf; res->len = version.len; tcpconn_put(c); -return 0; + return 0; Yes, removed. -- Reply to this email directly or vi

[sr-dev] Re: [kamailio/kamailio] tls: get san entries by index (PR #3408)

2023-03-30 Thread Marcus Orchard
@marcus-orchard pushed 1 commit. b5ea213bdd08040aa02b734c4eb441fe42b30d93 tls: fix formatting in tls_select.c -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3408/files/f9edbc32efb5dbdb93c6849c732f4af5f78fa8ce..b5ea213bdd08040aa02b734c4eb441fe42b30d93 You are receiving this beca

[sr-dev] Re: Debian SBOM for kamailio

2023-03-30 Thread Olle E. Johansson
> On 30 Mar 2023, at 12:51, Henning Westerholt wrote: > > Hi Olle, > > a compiler does not magically change the licence just by processing the > source code and producing binary code. > That would be an easy solution to many licencing issues. 😉 No but when it combines a lot of source code and

[sr-dev] git:5.5:31e116cc: ndb_redis: break on finding a server via sentinel

2023-03-30 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.5 Commit: 31e116ccf0ad444cef81d47f123a73038453667a URL: https://github.com/kamailio/kamailio/commit/31e116ccf0ad444cef81d47f123a73038453667a Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2023-03-30T12:54:21+02:00 ndb_redis: break on findi

[sr-dev] git:5.5:bbb40895: ndb_redis: fix index on parsing sentinel address

2023-03-30 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.5 Commit: bbb40895bc74810b37df2760bee309025fca27af URL: https://github.com/kamailio/kamailio/commit/bbb40895bc74810b37df2760bee309025fca27af Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2023-03-30T12:54:26+02:00 ndb_redis: fix index on p

[sr-dev] git:5.6:d4ff1550: ndb_redis: fix index on parsing sentinel address

2023-03-30 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.6 Commit: d4ff1550a7c7f9647236f03559dc2fc3106a2b8d URL: https://github.com/kamailio/kamailio/commit/d4ff1550a7c7f9647236f03559dc2fc3106a2b8d Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2023-03-30T12:53:27+02:00 ndb_redis: fix index on p

[sr-dev] git:5.6:21fc0e01: ndb_redis: break on finding a server via sentinel

2023-03-30 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.6 Commit: 21fc0e010ef97d86093d7673b5038b2e65f839cb URL: https://github.com/kamailio/kamailio/commit/21fc0e010ef97d86093d7673b5038b2e65f839cb Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2023-03-30T12:53:12+02:00 ndb_redis: break on findi

[sr-dev] Re: Debian SBOM for kamailio

2023-03-30 Thread Henning Westerholt
Hi Olle, a compiler does not magically change the licence just by processing the source code and producing binary code. That would be an easy solution to many licencing issues. 😉 Its like e.g., a translation of a book. You can not claim that you own the copyright of a book by simple translating

[sr-dev] git:master:5c8eed0c: ndb_redis: fix index on parsing sentinel address

2023-03-30 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 5c8eed0ce78d029f28a1819262516940b7dd749e URL: https://github.com/kamailio/kamailio/commit/5c8eed0ce78d029f28a1819262516940b7dd749e Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2023-03-30T12:49:27+02:00 ndb_redis: fix index o

[sr-dev] Re: HTTPS for xHTTP module

2023-03-30 Thread Olle E. Johansson
> On 30 Mar 2023, at 10:03, luca.nar...@kontron.com wrote: > > Hello, > > we need to use kamailio to handle some HTTP(S) GET requests coming from > another REST client and we are considering to use the xHTTP module of > kamailio. It seems this module only supports HTTP and not HTTPS connectio

[sr-dev] Re: Debian SBOM for kamailio

2023-03-30 Thread Olle E. Johansson
> On 30 Mar 2023, at 11:00, Henning Westerholt wrote: > > Hello Olle, > > IMHO the Debian way is correct. This is also the way companies are doing it, > some examples: > https://www.mbvans.com/en/legal-notices/foss-disclosure > https://oss.bosch-cm.com/gm.html (click at one of the links for t

[sr-dev] Re: Debian SBOM for kamailio

2023-03-30 Thread Henning Westerholt
Hello Olle, IMHO the Debian way is correct. This is also the way companies are doing it, some examples: https://www.mbvans.com/en/legal-notices/foss-disclosure https://oss.bosch-cm.com/gm.html (click at one of the links for the licence terms for a huge PDF) The only way to "fix" this would be t

[sr-dev] Re: [kamailio/kamailio] core:tcp allow to handle TCP connections with tcp_accept_haproxy=yes flag even message does not contain PROXY protocol header (#2206)

2023-03-30 Thread Jukka Väisänen
Documentation still states in the core cookbook: > Please note that enabling this option will reject any inbound TCP connection > that does not conform to the PROXY-protocol spec. So I started looking at making this a per-listen socket option.. And then ran into this commit. Apparently all conn

[sr-dev] Re: [kamailio/kamailio] tls: get san entries by index (PR #3408)

2023-03-30 Thread Olle E. Johansson
@oej commented on this pull request. > @@ -1718,3 +1894,7 @@ sr_kemi_xval_t* ki_tls_cget_attr(sip_msg_t* msg, str > *aname) sr_kemi_xval_null(&_ksr_kemi_tls_xval, SR_KEMI_XVAL_NULL_EMPTY); return &_ksr_kemi_tls_xval; } + Many empty lines here... :-) -- Reply to this email di

[sr-dev] Re: [kamailio/kamailio] tls: get san entries by index (PR #3408)

2023-03-30 Thread Olle E. Johansson
@oej commented on this pull request. > @@ -318,7 +318,7 @@ static int get_version(str* res, sip_msg_t* msg) res->s = buf; res->len = version.len; tcpconn_put(c); -return 0; + return 0; Bad whitespace? -- Reply to this email directly or view it on

[sr-dev] Re: Debian SBOM for kamailio

2023-03-30 Thread Olle E. Johansson
> On 29 Mar 2023, at 16:48, Victor Seva > wrote: > > Signed PGP part > Hi! > > On 28/3/23 16:36, Olle E. Johansson wrote: >> Hi! >> Using the “syft” tool from Anchore I created an SBOM for a server with >> Kamailio installed from Debian. >> The result is quite interesting. Some notes: >> - F

[sr-dev] Re: HTTPS for xHTTP module

2023-03-30 Thread Daniel-Constantin Mierla
Hello, xhttp is independent of the transport protocol, it can be used over tcp (so its http) or over tls (so it is https). You just have to configure kamailio with tls and connect from client to tls socket. Cheers, Daniel On 30.03.23 10:03, luca.nar...@kontron.com wrote: > Hello, > > we need to

[sr-dev] HTTPS for xHTTP module

2023-03-30 Thread luca . nardin
Hello, we need to use kamailio to handle some HTTP(S) GET requests coming from another REST client and we are considering to use the xHTTP module of kamailio. It seems this module only supports HTTP and not HTTPS connections, is that correct? Kind regards, Luca Nardin Kontron Transportation __