[sr-dev] Re: [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-02 Thread Richard Fuchs via sr-dev
Merged #3899 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3899#event-13365138400 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-02 Thread Richard Fuchs via sr-dev
LGTM, thanks -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3899#issuecomment-2203018343 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

[sr-dev] Re: [kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)

2024-07-01 Thread Richard Fuchs via sr-dev
You should be able to just run `clang-format` over your edited code and that should reformat it to make the format checker happy. There are some function calls (`close()` for example) between testing the `errno` value and printing out the log line. These functions might reset `errno` to

[sr-dev] Re: [kamailio/kamailio] The RPC `rtpengine.show` API result has the field `disabled` type change on different values. (Issue #3896)

2024-06-30 Thread Richard Fuchs via sr-dev
Thank you -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3896#issuecomment-2198617071 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

[sr-dev] Re: [kamailio/kamailio] The RPC `rtpengine.show` API result has the field `disabled` type change on different values. (Issue #3896)

2024-06-30 Thread Richard Fuchs via sr-dev
Closed #3896 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3896#event-13342563166 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] add "active" field to rtpengine.show as alternate of "disabled" (PR #3898)

2024-06-30 Thread Richard Fuchs via sr-dev
Merged #3898 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3898#event-13342561791 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] The RPC `rtpengine.show` API result has the field `disabled` type change on different values. (Issue #3896)

2024-06-28 Thread Richard Fuchs via sr-dev
> Then how about: > > * `disabled`: `boolean` - set to `true` if the RTPEngine was disabled by an > RPC call > * `active`: `boolean` - set to `true` if the module is actively using this > RTPEngine (i.e. the internal `rn_disabled` flag is set to 0). This will be > always set to `false` if

[sr-dev] Re: [kamailio/kamailio] The RPC `rtpengine.show` API result has the field `disabled` type change on different values. (Issue #3896)

2024-06-27 Thread Richard Fuchs via sr-dev
FWIW this is legacy from when the RPC code was converted from the old mi interface to the new one. Looks like `recheck_ticks` is also affected by this. If you feel like taking a stab at improving then, feel free. I don't mind a patch that changes the output to something more sensible (although

[sr-dev] Re: [kamailio/kamailio] rtpengine: multipart content dropped when used read_sdp_pv (Issue #3854)

2024-06-03 Thread Richard Fuchs via sr-dev
Closed #3854 as completed via 48317d3180e8ec67d24862ebcbbb80ab887ff5bd. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3854#event-13026141618 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] git:master:48317d31: rtpengine: use extract_body with read_sdp_pv

2024-06-03 Thread Richard Fuchs via sr-dev
Module: kamailio Branch: master Commit: 48317d3180e8ec67d24862ebcbbb80ab887ff5bd URL: https://github.com/kamailio/kamailio/commit/48317d3180e8ec67d24862ebcbbb80ab887ff5bd Author: Richard Fuchs Committer: Richard Fuchs Date: 2024-06-03T15:49:12-04:00 rtpengine: use extract_body

[sr-dev] git:master:5b0e9e8c: rtpengine: format files in clang format

2024-03-21 Thread Richard Fuchs via sr-dev
Module: kamailio Branch: master Commit: 5b0e9e8cb818e1de0c88f9b505a5813147629499 URL: https://github.com/kamailio/kamailio/commit/5b0e9e8cb818e1de0c88f9b505a5813147629499 Author: Donat Zenichev Committer: Richard Fuchs Date: 2024-03-21T11:40:39-04:00 rtpengine: format files in clang format

[sr-dev] git:master:779654d3: rtpengine: fix doc typos

2024-03-21 Thread Richard Fuchs via sr-dev
Module: kamailio Branch: master Commit: 779654d3654586dc1b2ac64b9ea6e7ce1dae75c8 URL: https://github.com/kamailio/kamailio/commit/779654d3654586dc1b2ac64b9ea6e7ce1dae75c8 Author: Donat Zenichev Committer: Richard Fuchs Date: 2024-03-21T11:40:39-04:00 rtpengine: fix doc typos Fix doc typos

[sr-dev] Re: [kamailio/kamailio] rtpengine: add flags processing on the daemon side (PR #3788)

2024-03-21 Thread Richard Fuchs via sr-dev
Closed #3788. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3788#event-12202438232 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] rtpengine: add flags processing on the daemon side (PR #3788)

2024-03-21 Thread Richard Fuchs via sr-dev
Merged as 5cd02f56 and c6fff3a531 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3788#issuecomment-2012561785 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio

[sr-dev] git:master:c6fff3a5: rtpengine: update documentation in regards of flags processing

2024-03-21 Thread Richard Fuchs via sr-dev
Module: kamailio Branch: master Commit: c6fff3a531740e648615a6e6223088693ecdccb9 URL: https://github.com/kamailio/kamailio/commit/c6fff3a531740e648615a6e6223088693ecdccb9 Author: Donat Zenichev Committer: Richard Fuchs Date: 2024-03-21T11:04:53-04:00 rtpengine: update documentation in regards

[sr-dev] git:master:5cd02f56: rtpengine: add flags processing on the daemon side

2024-03-21 Thread Richard Fuchs via sr-dev
Module: kamailio Branch: master Commit: 5cd02f5653e9b9f523a62a0dae78b801f962ce8e URL: https://github.com/kamailio/kamailio/commit/5cd02f5653e9b9f523a62a0dae78b801f962ce8e Author: Donat Zenichev Committer: Richard Fuchs Date: 2024-03-21T11:04:53-04:00 rtpengine: add flags processing

[sr-dev] Re: [kamailio/kamailio] rtpengine: add flags processing on the daemon side (PR #3788)

2024-03-21 Thread Richard Fuchs via sr-dev
I'll merge this if there are no objections @miconda -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3788#issuecomment-2012106700 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)

2024-01-11 Thread Richard Fuchs via sr-dev
> Unfortunately it does not seems to work at least with "codec-accept=XXX": > kam02 rtpengine[570041]: WARNING: [jKOBctrRd-]: [core] Unknown dictionary key > encountered: 'codec-accept' Right, you have to use `codec-flag-...` (dash instead of equals) for this to work. -- Reply to this email

[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)

2024-01-11 Thread Richard Fuchs via sr-dev
These flags should work without this patch, as they would just be put into the `flags` list of strings and rtpengine does parse them out of there. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887531455 You are receiving this

[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)

2024-01-11 Thread Richard Fuchs via sr-dev
LGTM -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887427690 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: rtpengine_manage - Rewrite SDP body

2023-08-18 Thread Richard Fuchs
On 15/08/2023 19.54, [EXT] Richard Fuchs wrote: On 02/08/2023 03.43, [EXT] Scherney Theodor wrote: Hello, The Problem is that SDP body is rewritten, but Content-Length isn’t updated. ... Content length of SDP body isn’t updated. It should be 242. I'll have a fix for this soon(ish

[sr-dev] git:master:1599dd82: rtpengine: set MIME Content-Length

2023-08-18 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 1599dd829e98cb610ca54903e8564d00fe9e07a0 URL: https://github.com/kamailio/kamailio/commit/1599dd829e98cb610ca54903e8564d00fe9e07a0 Author: Richard Fuchs Committer: Richard Fuchs Date: 2023-08-18T08:12:18-04:00 rtpengine: set MIME Content-Length

[sr-dev] Re: rtpengine_manage - Rewrite SDP body

2023-08-15 Thread Richard Fuchs
On 02/08/2023 03.43, [EXT] Scherney Theodor wrote: Hello, The Problem is that SDP body is rewritten, but Content-Length isn’t updated. ... Content length of SDP body isn’t updated. It should be 242. I'll have a fix for this soon(ish). Cheers

[sr-dev] Re: [kamailio/kamailio] [rtpengine] Support syntax for new "sdp-attr" manipulations (Issue #3509)

2023-07-26 Thread Richard Fuchs
FTR this is now available in rtpengine master. Syntax is described in the docs. For example `sdp-attr-add-audio-ptime:20` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3509#issuecomment-1651885239 You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] rtpengine: increase buf size to print mos llint range (PR #3517)

2023-07-20 Thread Richard Fuchs
LGTM. (FTR, `long long` is identical to `long long int`) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3517#issuecomment-1643819138 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] [rtpengine] Support syntax for new "sdp-attr" manipulations (Issue #3509)

2023-07-11 Thread Richard Fuchs
There's supposed to be a compatibility layer in rtpengine to make it possible to add these attributes to the signalling from Kamailio without requiring explicit support from the control module, but that's not implemented yet. It should be coming soon. Stay tuned. As for adding explicit support

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-14 Thread Richard Fuchs
LGTM now -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3473#issuecomment-1591099003 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-13 Thread Richard Fuchs
@rfuchs commented on this pull request. > + + fmsg = faked_msg_next(); + rtb = get_route_type(); + set_route_type(REQUEST_ROUTE); + init_run_actions_ctx(); + run_top_route(event_rt.rlist[dtmf_event_rt], fmsg, ); + set_route_type(rtb); + if(ctx.run_flags

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Richard Fuchs
@rfuchs commented on this pull request. > + s_port.len = rtpengine_dtmf_event_sock.s + > rtpengine_dtmf_event_sock.len - s_port.s; + + if (s_port.len <= 0 || str2int(_port, ) < 0 || port > 65535) { + LM_ERR("failed to initialize dtmf event listener because port is

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-09 Thread Richard Fuchs
@rfuchs commented on this pull request. A bit unsure about how this is supposed to work, maybe I'm just dense? > -static int fixup_set_id(void **param, int param_no) +static void rtpengine_dtmf_events_loop(int rank) The `rank` argument seems unused? > @@ -2147,6 +2401,9 @@ static int

[sr-dev] Re: [kamailio/kamailio] rtpengine: google sanitizer aligment warning (Issue #3058)

2023-05-09 Thread Richard Fuchs
> May be related. #3445 Yes, almost certainly exactly the same issue -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3058#issuecomment-1540401829 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] 5.7 crash due to rtpengine module bencode, on aarch64 (raspberry pi) (Issue #3444)

2023-05-09 Thread Richard Fuchs
> hi, I see that commit is already included in latest sipwise rtpengine > upstream master, from: > > ``` > ade8100d3 (Richard Fuchs2021-03-29 12:48:13 -0400 17) #define > BENCODE_ALLOC_ALIGN 8 > ``` Yes, I'm saying to apply it to the Kamailio sources (rtpengi

[sr-dev] Re: Building with clang

2023-05-01 Thread Richard Fuchs
On 30/04/2023 03.31, [EXT] Ivan Ribakov wrote: Richard, you are right about the problem with the void pointer casting. I'm aware of it and already had to patch a few headers. However my question above is not about void pointers at all. If you check the compiler error message, you will see

[sr-dev] Re: Building with clang

2023-04-29 Thread Richard Fuchs
On 28/04/2023 18.56, [EXT] Ivan Ribakov wrote: Hi all, I looked at Kamailio 5.6.3 makefiles and saw mention of clang being supported. Yet when I try to build it with clang (more precisely, I build a C++ module using clang that includes some Kamailio C headers via "extern C") I get following

[sr-dev] Re: [kamailio/kamailio] Inactive video stream: can't find media IP in the message (Issue #3406)

2023-03-27 Thread Richard Fuchs
This should be addresses in rtpengine, BUT https://datatracker.ietf.org/doc/html/rfc8866#name-connection-information-c A session description MUST contain either at least one "c=" line in each media description or a single "c=" line at the session level. It MAY contain a single session-level

[sr-dev] Re: [kamailio/kamailio] nat_transversal: fix warning introduced at f301ca9cdcc044dd05e9d82139e1db368be6dc5c (6e03201)

2023-03-14 Thread Richard Fuchs
Eh, these are arch dependent. "long int" on 32-bit platforms is only 32 bits. Either use %llu and cast to "long long" or use the PRIu64 macro. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] rtpengine: doc add codec-accept with an example (PR #3381)

2023-02-27 Thread Richard Fuchs
LGTM -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3381#issuecomment-1446819955 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] rtpengine: queried_nodes_limit incorrectly applies to delete commands which can cause all processes to be blocked (Issue #3370)

2023-02-15 Thread Richard Fuchs
Closed #3370 as completed via bd0ce126109f40f5217053f20e687b93b2268164. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3370#event-8526261443 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] git:master:bd0ce126: rtpengine: avoid repeated queries to same node

2023-02-15 Thread Richard Fuchs
Module: kamailio Branch: master Commit: bd0ce126109f40f5217053f20e687b93b2268164 URL: https://github.com/kamailio/kamailio/commit/bd0ce126109f40f5217053f20e687b93b2268164 Author: Richard Fuchs Committer: Richard Fuchs Date: 2023-02-15T08:49:01-05:00 rtpengine: avoid repeated queries to same

[sr-dev] Re: [kamailio/kamailio] rtpengine: queried_nodes_limit incorrectly applies to delete commands which can cause all processes to be blocked (Issue #3370)

2023-02-14 Thread Richard Fuchs
@shaneqld are you able to retest your scenario with 3da4029 applied? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3370#issuecomment-1430309577 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] rtpengine: queried_nodes_limit incorrectly applies to delete commands which can cause all processes to be blocked (Issue #3370)

2023-02-13 Thread Richard Fuchs
@smititelu I would suggest to take the test against `queried_nodes_ptr` also into account in the `select_rtpp_node_old` code path, so that it doesn't keep returning the same node again. Ack? -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] rtpengine: queried_nodes_limit incorrectly applies to delete commands which can cause all processes to be blocked (Issue #3370)

2023-02-13 Thread Richard Fuchs
Much of the load-balancing code in the module isn't mine, but it sure looks like a bug to me. From a quick glance it looks like there's a break condition missing. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3370#issuecomment-1427977518 You

Re: [sr-dev] Make some commands in kamailio rtpengine module asynchronous

2022-11-28 Thread Richard Fuchs
On 28/11/2022 04.14, [EXT] Aditya Gupta wrote: We have 2 rtpengines in production and thousands of calls coming in. Few of them get timed out because they don't get processed in time by rtpengine. Simply by making 3 commands; offer, answer and delete. It can help us a lot with this. I think

Re: [sr-dev] [kamailio/kamailio] rtpengine: fixed set id value in log lines (PR #3265)

2022-10-14 Thread Richard Fuchs
Merged #3265 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3265#event-7592537467 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] rtpengine: fixed set id value in log lines (PR #3265)

2022-10-14 Thread Richard Fuchs
LGTM, thanks -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3265#issuecomment-1279321441 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

[sr-dev] git:master:9a41fb54: rtpengine: allow to-tag usage for all commands

2022-09-28 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 9a41fb5403a6bc4fd5ccee239ccdf725fe6f91df URL: https://github.com/kamailio/kamailio/commit/9a41fb5403a6bc4fd5ccee239ccdf725fe6f91df Author: Richard Fuchs Committer: Richard Fuchs Date: 2022-09-28T09:33:56-04:00 rtpengine: allow to-tag usage for all

Re: [sr-dev] [kamailio/kamailio] rtpengine: Don't recheck node if disabled permanently (PR #2886)

2021-10-18 Thread Richard Fuchs
LGTM. I guess this is for the allow_op=1 use case? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2886#issuecomment-945724564___ Kamailio

Re: [sr-dev] [kamailio/kamailio] Ability to use Publish/subscribe mechanism for N-to-N media forwarding using kamailio (#2874)

2021-10-07 Thread Richard Fuchs
It's not available in Kamailio as these methods (AFAICT) aren't really well suited to be used in a SIP proxy. A better use case would be from a UA. Do you have a vision of how these methods could be used in a SIP proxy? -- You are receiving this because you are subscribed to this thread. Reply

Re: [sr-dev] [kamailio/kamailio] rtpengine -> send_rtpp_command(): mismatched cookie in websocket response (#2862)

2021-09-27 Thread Richard Fuchs
Looking at the code, I think this might be a bug in the `lwsc` module, triggered by more data coming in over the websocket than is being consumed by the lwsc receiver. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:12470055: rtpengine: add un/silence_media() methods

2021-07-23 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 12470055fddc1dd93e2295fcfb5119cf5340d722 URL: https://github.com/kamailio/kamailio/commit/12470055fddc1dd93e2295fcfb5119cf5340d722 Author: Richard Fuchs Committer: Richard Fuchs Date: 2021-07-23T13:34:33-04:00 rtpengine: add un/silence_media() methods

Re: [sr-dev] [kamailio/kamailio] rtpengine: rtpengine_allow_op return node logic (#2800)

2021-07-13 Thread Richard Fuchs
LGTM overall, except that the debug log message ("return it") now doesn't necessarily reflect what it actually does :laughing: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] rtpengine: ignore mos 0 when selecting min-mos (#2771)

2021-06-10 Thread Richard Fuchs
Merged #2771 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2771#event-4870937904___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] rtpengine: ignore mos 0 when selecting min-mos (#2771)

2021-06-10 Thread Richard Fuchs
Fine with me, merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2771#issuecomment-858561628___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/deb: add lwsc module (f892b9a)

2021-04-01 Thread Richard Fuchs
@linuxmaniac for your consideration -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:d37b84be: rtpengine: add support for websocket protocol

2021-03-25 Thread Richard Fuchs
Module: kamailio Branch: master Commit: d37b84be468f24b2cf015b4fc5d9abe97cc930bb URL: https://github.com/kamailio/kamailio/commit/d37b84be468f24b2cf015b4fc5d9abe97cc930bb Author: Richard Fuchs Committer: Richard Fuchs Date: 2021-03-25T16:02:14-04:00 rtpengine: add support for websocket

[sr-dev] git:master:5cc888f0: rtpengine: fix typo in docs

2021-03-24 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 5cc888f0e9e305734621c0db1f63a47f2f0c381a URL: https://github.com/kamailio/kamailio/commit/5cc888f0e9e305734621c0db1f63a47f2f0c381a Author: Richard Fuchs Committer: Richard Fuchs Date: 2021-03-24T16:12:13-04:00 rtpengine: fix typo in docs --- Modified

Re: [sr-dev] [kamailio/kamailio] rtpengine: remove square brackets from IPv6 address for getaddrinfo (#2685)

2021-03-22 Thread Richard Fuchs
> @Den4t: have you checked that setting 0 in place of `]` is not having other > side effects? I didn't notice any restore. > > @rfuchs: any opinion on this patch? Looks good to me -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [sr-dev] RTPEngine - No support for kernel packet forwarding available

2021-03-02 Thread Richard Fuchs
On 01/03/2021 05.02, Suresh Talasaniya wrote: Hello folks, RTPEngine - No support for kernel packet forwarding available, please find the below information/logs. Mar  1 01:46:45 sp201 rtpengine[14973]: INFO: [9ca2e714-95d0-9662-82e9-e89659024d66]: [control] Received command 'offer' from

Re: [sr-dev] [kamailio/kamailio] rtpengine: rebuild sockets if any skipped nodes (#2633)

2021-02-16 Thread Richard Fuchs
> @rfuchs - any comments on this PR? LGTM  -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2633#issuecomment-779932045___ Kamailio (SER)

Re: [sr-dev] rtpengine_allow_op usage doubt

2021-02-05 Thread Richard Fuchs
On 05/02/2021 04.46, David Escartin wrote: sorry i edit the previous message since version 4.4 we are using this parameter to 1 to allow that ongoing calls process their messages through a particular rtpengine when disabling it manually from database. But we see that enabling it also

Re: [sr-dev] [kamailio/kamailio] rtpengine : add node fallback if node ran out of ports (#2621)

2021-02-04 Thread Richard Fuchs
> I haven't looked at the source code or the protocol, is there a > response/error code that can be used instead of the text? Well, it would have to be added :) We don't currently return error codes, but ideally something like that should be used instead of the text. But as we don't have that

Re: [sr-dev] [kamailio/kamailio] rtpengine : add node fallback if node ran out of ports (#2621)

2021-02-04 Thread Richard Fuchs
> @rfuchs - any opinion on this PR? Personally I wouldn't want to rely on a textual error message to control behaviour, but it's already been done before. So fine with me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:5.2:1138bb1e: tmrec: fix typos in docs

2021-01-25 Thread Richard Fuchs
Module: kamailio Branch: 5.2 Commit: 1138bb1e81659e4e07502e4353aa8faee1dda877 URL: https://github.com/kamailio/kamailio/commit/1138bb1e81659e4e07502e4353aa8faee1dda877 Author: Richard Fuchs Committer: Richard Fuchs Date: 2021-01-25T08:44:52-05:00 tmrec: fix typos in docs (cherry picked from

[sr-dev] git:5.3:1134ea5c: tmrec: fix typos in docs

2021-01-25 Thread Richard Fuchs
Module: kamailio Branch: 5.3 Commit: 1134ea5c0562ca66d09c1e5a9f3288b77dd19387 URL: https://github.com/kamailio/kamailio/commit/1134ea5c0562ca66d09c1e5a9f3288b77dd19387 Author: Richard Fuchs Committer: Richard Fuchs Date: 2021-01-25T08:43:55-05:00 tmrec: fix typos in docs (cherry picked from

[sr-dev] git:5.4:4e2c049d: tmrec: fix typos in docs

2021-01-25 Thread Richard Fuchs
Module: kamailio Branch: 5.4 Commit: 4e2c049d27594c30069d1e29caca4f4521d6fe43 URL: https://github.com/kamailio/kamailio/commit/4e2c049d27594c30069d1e29caca4f4521d6fe43 Author: Richard Fuchs Committer: Richard Fuchs Date: 2021-01-25T08:42:53-05:00 tmrec: fix typos in docs (cherry picked from

[sr-dev] git:master:8be74b2f: tmrec: fix typos in docs

2021-01-25 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 8be74b2fe0f59a9cef472b781feeae4cf3357bea URL: https://github.com/kamailio/kamailio/commit/8be74b2fe0f59a9cef472b781feeae4cf3357bea Author: Richard Fuchs Committer: Richard Fuchs Date: 2021-01-25T08:37:26-05:00 tmrec: fix typos in docs --- Modified

Re: [sr-dev] [kamailio/kamailio] Fix in parsing IPv6 address:port (#2592)

2021-01-04 Thread Richard Fuchs
Merged #2592 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2592#event-4165505278___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] Fix in parsing IPv6 address:port (#2592)

2021-01-04 Thread Richard Fuchs
LGTM, thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2592#issuecomment-754045349___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] rtpengine: query rtt per call leg (#2576)

2020-12-07 Thread Richard Fuchs
Merged #2576 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2576#event-4079619670___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] rtpengine: add CRC32 hash algo (#2558)

2020-11-25 Thread Richard Fuchs
Merged #2558 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2558#event-4039137200___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] rtpengine: add CRC32 hash algo (#2558)

2020-11-25 Thread Richard Fuchs
@rfuchs commented on this pull request. > @@ -2028,14 +2028,17 @@ modparam("rtpengine", "control_cmd_tos", 144) Default value is 0, legacy algorithm. - The values not falling into the range 0-1 are ignored. +

[sr-dev] git:master:134c6b4b: rtpengine: fix wrong codec action strings being used

2020-10-26 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 134c6b4b63f8fee3b94e3caed956b080477022d4 URL: https://github.com/kamailio/kamailio/commit/134c6b4b63f8fee3b94e3caed956b080477022d4 Author: Richard Fuchs Committer: Richard Fuchs Date: 2020-10-26T14:19:09-04:00 rtpengine: fix wrong codec action strings

[sr-dev] git:master:4de33ea9: rtpengine: update README for 8bf1935c

2020-10-22 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 4de33ea963b40a5150f34fac8f63d04c5992515e URL: https://github.com/kamailio/kamailio/commit/4de33ea963b40a5150f34fac8f63d04c5992515e Author: Richard Fuchs Committer: Richard Fuchs Date: 2020-10-22T11:40:47-04:00 rtpengine: update README for 8bf1935c

Re: [sr-dev] git:master:8bf1935c: rtpengine: support new codec flags

2020-10-22 Thread Richard Fuchs
, at 20:05, Richard Fuchs wrote: Module: kamailio Branch: master Commit: 8bf1935c4e9cb0081784dbd8bd951148b8865381 URL: https://github.com/kamailio/kamailio/commit/8bf1935c4e9cb0081784dbd8bd951148b8865381 Author: Richard Fuchs Committer: Richard Fuchs Date: 2020-10-21T14:05:20-04:00 rtpengine

[sr-dev] git:master:8bf1935c: rtpengine: support new codec flags

2020-10-21 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 8bf1935c4e9cb0081784dbd8bd951148b8865381 URL: https://github.com/kamailio/kamailio/commit/8bf1935c4e9cb0081784dbd8bd951148b8865381 Author: Richard Fuchs Committer: Richard Fuchs Date: 2020-10-21T14:05:20-04:00 rtpengine: support new codec flags Adds

[sr-dev] HTTP/WS support for rtpengine

2020-10-05 Thread Richard Fuchs
Hi gang, As of today, rtpengine adds support for HTTP and WebSocket interfaces (as well as HTTPS and WSS). Currently supported operations are accessing the CLI commands provided by the `rtpengine-ctl` CLI tool, and accessing the "NG" control protocol. These are both 1-to-1 mappings on top of

Re: [sr-dev] [kamailio/kamailio] db_redis: Failed to allocate memory for match pattern (#2441)

2020-08-25 Thread Richard Fuchs
This can be closed then? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2441#issuecomment-680149853___ Kamailio (SER) - Development

Re: [sr-dev] [kamailio/kamailio] db_redis: Failed to allocate memory for match pattern (#2441)

2020-08-24 Thread Richard Fuchs
First of all, if you have two modules both using the same Redis DB, you should make them use different DB numbers. And then, since Redis is key-value only and doesn't have a DB schema, you need to specify the schema for each DB you want to use through the `keys` modparam to db_redis. Have you

[sr-dev] git:5.2:f2a987a8: db_redis: fix unfiltered table deletion

2020-07-16 Thread Richard Fuchs
Module: kamailio Branch: 5.2 Commit: f2a987a8c4aacb1538f44b890f922d495ef103f6 URL: https://github.com/kamailio/kamailio/commit/f2a987a8c4aacb1538f44b890f922d495ef103f6 Author: Richard Fuchs Committer: Richard Fuchs Date: 2020-07-16T11:26:39-04:00 db_redis: fix unfiltered table deletion

[sr-dev] git:5.3:3bc06fdb: db_redis: fix unfiltered table deletion

2020-07-16 Thread Richard Fuchs
Module: kamailio Branch: 5.3 Commit: 3bc06fdb87d86d3269f7774f52b8040be1c1f76c URL: https://github.com/kamailio/kamailio/commit/3bc06fdb87d86d3269f7774f52b8040be1c1f76c Author: Richard Fuchs Committer: Richard Fuchs Date: 2020-07-16T11:26:20-04:00 db_redis: fix unfiltered table deletion

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)

2020-07-14 Thread Richard Fuchs
@rdboisvert I would propose cbc4d1eaea61f3b2d1012823d633fd2d0d85ab70 to fix this. It should allow for full table deletion while also fixing our use case. Could you confirm that this also works for you? -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)

2020-07-08 Thread Richard Fuchs
Yes, but did it actually break the delete operation, or was it just a performance optimisation? In either case I can probably come up with an alternative patch that doesn't break the set indexes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)

2020-07-08 Thread Richard Fuchs
@rdboisvert it should already do this. Which part was not working for you? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)

2020-07-07 Thread Richard Fuchs
@miconda it happens on every delete. Our "table definitions" use Redis sets to simulate non-unique database indexes. For example if we have a key `entry:foobar` that is a hash and includes a key "test = blah" (so, `HMSET entry:foobar test blah`) and we use the "test" key as a non-unique index,

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)

2020-07-07 Thread Richard Fuchs
Hello @rdboisvert and @henningw We bumped into this commit on our deployments because it was causing some issues. In particular it makes the Redis SETs that we use a pseudo-indexes being left over in the Redis DB after a delete operation. The reason is that even for deletes that can be done

Re: [sr-dev] [kamailio/kamailio] TOS field not overtaken by RTPengine (#2303)

2020-04-29 Thread Richard Fuchs
Closed #2303. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2303#event-3284320577___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] TOS field not overtaken by RTPengine (#2303)

2020-04-29 Thread Richard Fuchs
If you want or need the kind of TOS passthrough you're talking about, feel free to open a feature request over at https://github.com/sipwise/rtpengine -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] TOS field not overtaken by RTPengine (#2303)

2020-04-28 Thread Richard Fuchs
If you set TOS=123 in the first offer, then setting TOS=-1 in a subsequent offer would leave 123 in place, while omitting TOS= would revert the TOS back to the global default (e.g. taken from the config file). -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [sr-dev] [kamailio/kamailio] TOS field not overtaken by RTPengine (#2303)

2020-04-27 Thread Richard Fuchs
Rtpengine always sets the TOS for outgoing packets. The value of -1 means to leave the underlying default (i.e. the global value) unchanged. It doesn't mean to use the same TOS value as was set for received packets. -- You are receiving this because you are subscribed to this thread. Reply to

[sr-dev] git:master:498d7649: rtpengine: add `flags` field for every command

2020-04-14 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 498d7649339edfc07f40fe3e37e66376b2817d6c URL: https://github.com/kamailio/kamailio/commit/498d7649339edfc07f40fe3e37e66376b2817d6c Author: Richard Fuchs Committer: Richard Fuchs Date: 2020-04-14T13:15:21-04:00 rtpengine: add `flags` field for every

[sr-dev] git:master:6ab14314: rtpengine: add support for new T.38 options

2020-03-25 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 6ab1431464f97e856812e0f69d77bc96e3dd8f57 URL: https://github.com/kamailio/kamailio/commit/6ab1431464f97e856812e0f69d77bc96e3dd8f57 Author: Richard Fuchs Committer: Richard Fuchs Date: 2020-03-25T09:00:40-04:00 rtpengine: add support for new T.38 options

[sr-dev] git:master:de5b28f8: rtpengine: document new T.38 options

2020-03-25 Thread Richard Fuchs
Module: kamailio Branch: master Commit: de5b28f89aadfbbf70f023bce7a6fcdd55bfd044 URL: https://github.com/kamailio/kamailio/commit/de5b28f89aadfbbf70f023bce7a6fcdd55bfd044 Author: Richard Fuchs Committer: Richard Fuchs Date: 2020-03-25T09:56:56-04:00 rtpengine: document new T.38 options

[sr-dev] git:master:ad3ae013: rtpengine: update/fix via-branch=next ID generation

2020-01-28 Thread Richard Fuchs
Module: kamailio Branch: master Commit: ad3ae0133f321e357cf09f65f2067ed10d9c64a2 URL: https://github.com/kamailio/kamailio/commit/ad3ae0133f321e357cf09f65f2067ed10d9c64a2 Author: Richard Fuchs Committer: Richard Fuchs Date: 2020-01-28T10:40:45-05:00 rtpengine: update/fix via-branch=next ID

[sr-dev] git:master:384c2ab8: db_redis: fix printf type mismatch on size_t

2019-11-24 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 384c2ab866cc9f6b6c1a6a90be032531b65cb394 URL: https://github.com/kamailio/kamailio/commit/384c2ab866cc9f6b6c1a6a90be032531b65cb394 Author: Richard Fuchs Committer: Richard Fuchs Date: 2019-11-24T08:16:37-05:00 db_redis: fix printf type mismatch

[sr-dev] git:master:febdb877: rtpengine: document play_dtmf() command

2019-11-22 Thread Richard Fuchs
Module: kamailio Branch: master Commit: febdb8778f5ef338864f52e441a4311c0b2c04da URL: https://github.com/kamailio/kamailio/commit/febdb8778f5ef338864f52e441a4311c0b2c04da Author: Richard Fuchs Committer: Richard Fuchs Date: 2019-11-22T09:37:28-05:00 rtpengine: document play_dtmf() command

[sr-dev] git:master:120a71be: rtpengine: add play_dtmf() command

2019-11-22 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 120a71bec0ee7a07f5f39262a038977f27bc7073 URL: https://github.com/kamailio/kamailio/commit/120a71bec0ee7a07f5f39262a038977f27bc7073 Author: Richard Fuchs Committer: Richard Fuchs Date: 2019-11-22T09:37:02-05:00 rtpengine: add play_dtmf() command

[sr-dev] git:master:9da53bae: db_redis: performance improvements and fixes

2019-11-22 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 9da53baeadb0403de86d14fa7be826780382e315 URL: https://github.com/kamailio/kamailio/commit/9da53baeadb0403de86d14fa7be826780382e315 Author: Richard Fuchs Committer: Richard Fuchs Date: 2019-11-22T08:35:49-05:00 db_redis: performance improvements

Re: [sr-dev] rtpengine play DTMF from SIP INFO

2019-11-22 Thread Richard Fuchs
On 20/11/2019 06.08, Giuseppe Pandolfi wrote: Hi, I'm using kamailio (v. 5.2.1) and rtpengine (v. mr8.0.1.1) to test transcoding rtp. All works. From rtpengine documentation I see that ther is possibility to play DTMF tone from SIP INFO message using "play DTMF" ng control protocol message but

Re: [sr-dev] [kamailio/kamailio] modules/rtpengine: set_rtpengine_set fix (#2040)

2019-08-26 Thread Richard Fuchs
LGTM, no objections -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2040#issuecomment-524966592___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] Extend rtpengine hashing algorithms (#1986)

2019-06-19 Thread Richard Fuchs
@miconda looks good to me, no objections -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1986#issuecomment-503540415___ Kamailio (SER) -

  1   2   >