[sr-dev] Re: [kamailio/kamailio] core: Add TCP_USER_TIMEOUT socket option on listening socket. (PR #3528)

2023-11-13 Thread schoberw via sr-dev
Anything I need to do? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3528#issuecomment-1808224517 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] tcp_send_timeout not used on reused socket (Issue #3443)

2023-11-13 Thread schoberw via sr-dev
The patch is a really small change. So it should be easy to add. I would aprreciate to find it in the stable branch to avoic private builds all the time. I understand, that my task is done so far. -- Reply to this email directly or view it on GitHub:

[sr-dev] Re: [kamailio/kamailio] tcp_send_timeout not used on reused socket (Issue #3443)

2023-11-13 Thread schoberw via sr-dev
Closed #3443 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3443#event-10941705624 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] core: Add TCP_USER_TIMEOUT socket option on listening socket. (PR #3528)

2023-11-08 Thread schoberw via sr-dev
Is there a reason why it didn't make it into 5.7.2? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3528#issuecomment-1801322464 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] tcp_send_timeout not used on reused socket (Issue #3443)

2023-11-08 Thread schoberw via sr-dev
What is missing and why it doesnt go into upstream? Why it was not added to 5.7.2? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3443#issuecomment-1801319989 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] core: Add TCP_USER_TIMEOUT socket option on listening socket. (PR #3528)

2023-07-31 Thread schoberw
@schoberw pushed 1 commit. fd04de376cbd854e270d8c86ccf9a3a517bf967e core: Add TCP_USER_TIMEOUT socket option on listening socket. -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3528/files/73d1e0112e4868c0821e63caf346e9c154a2ff77..fd04de376cbd854e270d8c86ccf9a3a517bf967e You

[sr-dev] [kamailio/kamailio] core: Add TCP_USER_TIMEOUT socket option on listening socket. (PR #3528)

2023-07-31 Thread schoberw
Use tcp_send_timeout config option also on listening socket to timeout outbound messages sent on passive inbound connections. Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified,

[sr-dev] Re: [kamailio/kamailio] tcp_send_timeout not used on reused socket (Issue #3443)

2023-07-27 Thread schoberw
Erratum: It **is** inherited - I had oberwritten the TCP_USER_TIMEOUT in handle_new_connect() with a missing TICKS_TO_S() - so it was a too high value (ticks instead of seconds). Tried again in tcp_init() on the listening socket: ```diff --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@

[sr-dev] Re: [kamailio/kamailio] tcp_send_timeout not used on reused socket (Issue #3443)

2023-07-27 Thread schoberw
I made working patch on the current master branch: ```diff --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -4324,10 +4324,25 @@ static inline int handle_new_connect(struct socket_info *si) struct tcp_connection *tcpconn; socklen_t su_len; int new_sock; + int

[sr-dev] [kamailio/kamailio] tcp_send_timeout not used on reused socket (Issue #3443)

2023-05-09 Thread schoberw
### Description Having clients connected via TCP doing only passive connections in the kamailio server it seems the tcp_send_timeout is not used on messages going out to the clients. While tcp_keepalive is doing well as long as there was not sent any packet to the client tcp_send_timout does

[sr-dev] Re: [kamailio/kamailio] Inactive video stream: can't find media IP in the message (Issue #3406)

2023-03-27 Thread schoberw
Thanks for point to the RFC, that's great for my ticket to Audiocodes :-) Still we do not have any possibilities on our side. Audiocodes e.g. has some options to fix broken things and move on. Am I right that the only possibility Kamailio offers is to do it with textops? Still very difficult

[sr-dev] [kamailio/kamailio] Inactive video stream: can't find media IP in the message (Issue #3406)

2023-03-27 Thread schoberw
### Description In some situations the other side UA must reply with an inactive media stream. E.g. if video was added but not supported by the other side. The UAS then must answer with an m=video 0 RTP/.. line. It seams that the video section must contain a c= line with an IP address for