Re: [sr-dev] [kamailio/kamailio] fix_nated_contact() and remove_hf malform packet (#977)

2017-02-07 Thread Daniel-Constantin Mierla
Closed #977. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/977#event-953386072___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] Change to Makefiles.def to support building on recent versions of Solaris (#963)

2017-02-07 Thread Daniel-Constantin Mierla
Closed #963. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/963#event-953384719___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] Change to Makefiles.def to support building on recent versions of Solaris (#963)

2017-02-07 Thread Daniel-Constantin Mierla
Committed to master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/963#issuecomment-278252127___ sr-dev mailing list

[sr-dev] git:master:19121e75: Makefile.defs: version set to 5.0.0-pre2

2017-02-07 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 19121e75c90784c1890e87a96e07bf32a31b2f0d URL: https://github.com/kamailio/kamailio/commit/19121e75c90784c1890e87a96e07bf32a31b2f0d Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:47590ddf: Makefile.defs: don't enforce yacc on solaris

2017-02-07 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 47590ddf1819a8df1f580ea1fb64bfdc712f6771 URL: https://github.com/kamailio/kamailio/commit/47590ddf1819a8df1f580ea1fb64bfdc712f6771 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] [kamailio/kamailio] pua_dialoginfo: Add flags to disable caller and/or callee PUBLISH when required (#979)

2017-02-07 Thread Phil Lavin
- Added 2 new flags, disable_caller_publish_flag and disable_callee_publish_flag - Wrapped each call to dialog_publish_multi to first check if the flag is set This is actually quite a strange usecase. It's useful when calls do not route internally on Kamailio but are always forced out through a

Re: [sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Victor Seva
linuxmaniac commented on this pull request. > @@ -3238,11 +3238,11 @@ int pv_get_msg_attrs(sip_msg_t *msg, pv_param_t > *param, pv_value_t *res) int pv_parse_env_name(pv_spec_p sp, str *in) { + char *csname; + if(in->s==NULL || in->len<=0) FTR, it works nicely ```

Re: [sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Camille Oudot
camilleoudot commented on this pull request. > @@ -3238,11 +3238,11 @@ int pv_get_msg_attrs(sip_msg_t *msg, pv_param_t > *param, pv_value_t *res) int pv_parse_env_name(pv_spec_p sp, str *in) { + char *csname; + if(in->s==NULL || in->len<=0) I'll document it on the wiki

Re: [sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Victor Seva
linuxmaniac commented on this pull request. > @@ -3238,11 +3238,11 @@ int pv_get_msg_attrs(sip_msg_t *msg, pv_param_t > *param, pv_value_t *res) int pv_parse_env_name(pv_spec_p sp, str *in) { + char *csname; + if(in->s==NULL || in->len<=0) and where is the documentation

Re: [sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Camille Oudot
camilleoudot commented on this pull request. > @@ -3238,11 +3238,11 @@ int pv_get_msg_attrs(sip_msg_t *msg, pv_param_t > *param, pv_value_t *res) int pv_parse_env_name(pv_spec_p sp, str *in) { + char *csname; + if(in->s==NULL || in->len<=0) it does not look like any of the

Re: [sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Victor Seva
linuxmaniac commented on this pull request. > @@ -3238,11 +3238,11 @@ int pv_get_msg_attrs(sip_msg_t *msg, pv_param_t > *param, pv_value_t *res) int pv_parse_env_name(pv_spec_p sp, str *in) { + char *csname; + if(in->s==NULL || in->len<=0) I would do ``` if(sp==NULL || in ==

Re: [sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Camille Oudot
@camilleoudot pushed 1 commit. 04f5465 pv: $env() code style improvements -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

2017-02-07 Thread Victor Seva
> Why not use kamailio.service and kamailio.sysconfig from debian? > This is more easy to maintain packaging. because is what we have in master and from my point of view is better to be independient -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Camille Oudot
camilleoudot commented on this pull request. > @@ -3233,3 +3235,44 @@ int pv_get_msg_attrs(sip_msg_t *msg, pv_param_t > *param, pv_value_t *res) return pv_get_null(msg, param, res); } } + +int pv_parse_env_name(pv_spec_p sp, str *in) +{ + if(in->s==NULL

Re: [sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Camille Oudot
camilleoudot commented on this pull request. > + sp->pvp.pvn.u.dname = (void*)csname; + sp->pvp.pvn.type = PV_NAME_OTHER; + return 0; +} + +int pv_get_env(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + char *val; + char *csname = (char *)

Re: [sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Victor Seva
linuxmaniac commented on this pull request. > @@ -3233,3 +3235,44 @@ int pv_get_msg_attrs(sip_msg_t *msg, pv_param_t > *param, pv_value_t *res) return pv_get_null(msg, param, res); } } + +int pv_parse_env_name(pv_spec_p sp, str *in) +{ + if(in->s==NULL ||

Re: [sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Victor Seva
linuxmaniac commented on this pull request. > + sp->pvp.pvn.u.dname = (void*)csname; + sp->pvp.pvn.type = PV_NAME_OTHER; + return 0; +} + +int pv_get_env(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + char *val; + char *csname = (char *) param->pvn.u.dname;

[sr-dev] [kamailio/kamailio] pv: add the $env() PV class to read env vars (#978)

2017-02-07 Thread Camille Oudot
this allows kamailio to have read-only (for now) access to environment variables You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/978 -- Commit Summary -- * pv: add the $env() PV class to read env vars -- File Changes -- M

[sr-dev] [kamailio/kamailio] fix_nated_contact() and remove_hf malform packet (#977)

2017-02-07 Thread Jared Hull
### Description fix_nated_contact() and removing and appending a contact will malform the SIP packet. I read somewhere that all of the *_hf functions are applied only when the packet is sent out again. Perhaps things are working as intended and I am just asking too much of these functions.

[sr-dev] [kamailio/kamailio] kazoo: incomplete documentation (#976)

2017-02-07 Thread Ovidiu Sas
There are lots of module parameters that are not documented in the README file: "amqp_timmer_process_interval" "amqp_consumer_ack_timeout_micro" "amqp_consumer_ack_timeout_sec" "amqp_interprocess_timeout_micro" "amqp_interprocess_timeout_sec" "amqp_waitframe_timeout_micro"

Re: [sr-dev] [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)

2017-02-07 Thread lazedo
Closed #972. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/972#event-952311004___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)

2017-02-07 Thread lazedo
@ovidiusas thanks. fixed in master and 4.4 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/972#issuecomment-278044110___ sr-dev mailing

[sr-dev] [kamailio/kamailio] nsq: hardcoded values used for ranks in forked processes (#975)

2017-02-07 Thread Ovidiu Sas
The nsq module creates several processes for consumer workers. The ranks for all this process are incremented one by one, starting with value 1. Value 1 is defined as PROC_SIPINIT and has a special meaning for most of the regular modules. One side effect of this is that the registration records

[sr-dev] git:4.4:8a6c0e21: kazoo: set proper ranking for consumer workers

2017-02-07 Thread Luis Azedo
Module: kamailio Branch: 4.4 Commit: 8a6c0e21f52af0efa39a3585d53e2f97b2cb90cf URL: https://github.com/kamailio/kamailio/commit/8a6c0e21f52af0efa39a3585d53e2f97b2cb90cf Author: lazedo Committer: Luis Azedo Date: 2017-02-07T15:57:36Z kazoo: set

[sr-dev] git:master:744e8981: kazoo: set proper ranking for consumer workers

2017-02-07 Thread GitHub
Module: kamailio Branch: master Commit: 744e898189fa84b5aa3d19958b348f9b99d48b41 URL: https://github.com/kamailio/kamailio/commit/744e898189fa84b5aa3d19958b348f9b99d48b41 Author: lazedo Committer: GitHub Date: 2017-02-07T15:55:53Z kazoo: set

[sr-dev] [kamailio/kamailio] cdp: hardcoded values used for ranks in forked processes (#973)

2017-02-07 Thread Ovidiu Sas
The cdp module creates several processes for workers, receivers, acceptors ... All this processes have random ranks. It seems that the rank for all this processes has no special meaning and therefore the forking should be done using the PROC_NOCHLDINIT rank and not a random hardcoded one. --

[sr-dev] [kamailio/kamailio] kazoo: improper ampq consumer worker procs (#972)

2017-02-07 Thread Ovidiu Sas
During init, the kazoo module performs forking for "AMQP Consumer Worker". The ranks for all this process are incremented one by one, starting with value 1. Value 1 is defined as PROC_SIPINIT and has a special meaning for most of the regular modules. One side effect of this is that the

[sr-dev] git:master:a032d400: rtpengine: fix potential segfault when enabling a proxy

2017-02-07 Thread Richard Fuchs
Module: kamailio Branch: master Commit: a032d400a43698468bc3a2b6c3c9b25fe1b514c7 URL: https://github.com/kamailio/kamailio/commit/a032d400a43698468bc3a2b6c3c9b25fe1b514c7 Author: Richard Fuchs Committer: Richard Fuchs Date: 2017-02-07T09:14:25-05:00

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

2017-02-07 Thread lazedo
lazedo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#pullrequestreview-20515854___ sr-dev mailing

[sr-dev] git:4.4:a3210259: rtpengine: fix segfault when enabling a proxy

2017-02-07 Thread Richard Fuchs
Module: kamailio Branch: 4.4 Commit: a321025984d183f9c727fa4c9fcdc1e2e87010bf URL: https://github.com/kamailio/kamailio/commit/a321025984d183f9c727fa4c9fcdc1e2e87010bf Author: Richard Fuchs Committer: Richard Fuchs Date: 2017-02-07T08:55:52-05:00

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

2017-02-07 Thread sergey-safarov
@lazedo I will update master branch after this PR is merged. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#issuecomment-278005998___

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

2017-02-07 Thread lazedo
lazedo requested changes on this pull request. > + +%packagejson +Summary:json string handling and RPC modules for Kamailio. +Group: System Environment/Daemons +Requires: json-c, libevent, kamailio = %ver +BuildRequires: json-c-devel, libevent-devel + +%descriptionjson +json

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » amd64,jessie,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » i386,jessie,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » amd64,trusty,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » amd64,xenial,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » i386,xenial,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] tm: deep cloning of the request for fake environment (#971)

2017-02-07 Thread Victor Seva
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/971 -- Commit Summary -- * tm: deep cloning of the request for fake environment -- File Changes -- M src/modules/tm/t_append_branches.c (23) M src/modules/tm/t_reply.c (104)

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » i386,trusty,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » i386,wheezy,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » amd64,precise,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » amd64,squeeze,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » i386,squeeze,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » i386,precise,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to stable : kamailiodev-nightly-binaries » amd64,wheezy,slave #719

2017-02-07 Thread jenkins
See ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:2bab64fe: pkg/kamailio/deb: fix description

2017-02-07 Thread Victor Seva
Module: kamailio Branch: master Commit: 2bab64fec9bac8f2456a7784201db5fce7c8cf08 URL: https://github.com/kamailio/kamailio/commit/2bab64fec9bac8f2456a7784201db5fce7c8cf08 Author: Victor Seva Committer: Victor Seva Date: