Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: sync with multi contacts per message (#1054)

Are there other changes you'd like to make to this PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1054#issuecomment-291784434___

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: sync with multi contacts per message (#1054)

I am reviewing the patch currently but as for limiting to 60KB, I'm not sure that for this application it is necessary. It will be difficult to be 100% accurate, anyway, since you only have control over the body - therefore, the only option is to assume a sensible size for the rest of the

Re: [sr-dev] [kamailio/kamailio] Enabling DMQ cause high CPU usage (#822)

Fixed in 71a88212 - please re-open if the issue remains after testing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Enabling DMQ cause high CPU usage (#822)

Closed #822. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/822#event-1020940437___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] dmq: remove worker lock (#1046)

Thanks - this has now been incorporated into 71a88212 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1046#issuecomment-290175395___

Re: [sr-dev] [kamailio/kamailio] dmq: remove worker lock (#1046)

Closed #1046. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1046#event-1020936981___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] git:master:71a88212: dmq: add option for non-locking workers

Module: kamailio Branch: master Commit: 71a882122c2e6a9c61f25cb34bfd4fef75c65fe0 URL: https://github.com/kamailio/kamailio/commit/71a882122c2e6a9c61f25cb34bfd4fef75c65fe0 Author: Charles Chance <charles.cha...@sipcentric.com> Committer: Charles Chance <charles.cha...@sipcentric.com>

Re: [sr-dev] [kamailio/kamailio] Enabling DMQ cause high CPU usage (#822)

Yes, I would be happier implementing that way, since the lock method is better in most situations. If no-one has any objections or reasons not to, then I shall proceed on that basis and make the necessary changes this evening. -- You are receiving this because you are subscribed to this

Re: [sr-dev] [kamailio/kamailio] Enabling DMQ cause high CPU usage (#822)

Thanks, @tombeard - it works and appears safe. However, in my own (Centos) tests, CPU utilisation when workers are idle is noticeably higher than before. Increasing the sleep duration helps - so if it is implemented this way then it should be exposed as a mod param with a sensible default.

Re: [sr-dev] [kamailio/kamailio] Enabling DMQ cause high CPU usage (#822)

Ok, I'll refine and push for testing tomorrow. Thanks for the input @tombeard. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Enabling DMQ cause high CPU usage (#822)

@tombeard thanks - I guess not! Pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/822#issuecomment-289914479___ sr-dev

[sr-dev] git:master:666ebb63: dmq: attempt to re-initialize if node becomes detatched from cluster

Module: kamailio Branch: master Commit: 666ebb63aecf2254b8efeae261452fc75c6d3aed URL: https://github.com/kamailio/kamailio/commit/666ebb63aecf2254b8efeae261452fc75c6d3aed Author: Charles Chance <charles.cha...@sipcentric.com> Committer: Charles Chance <charles.cha...@sipcentric.com>

Re: [sr-dev] [kamailio/kamailio] Enabling DMQ cause high CPU usage (#822)

Revisiting this now after a busy few months. @miconda - is it better in your opinion to introduce new locking method completely, or only in the presence of a compile-time flag? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

[sr-dev] git:4.4:aa27479a: presence: delay aux_body_processing until after subscription has been updated

Module: kamailio Branch: 4.4 Commit: aa27479ad204b6826aea03d777af9401ffd26a11 URL: https://github.com/kamailio/kamailio/commit/aa27479ad204b6826aea03d777af9401ffd26a11 Author: Charles Chance <charles.cha...@sipcentric.com> Committer: Charles Chance <charles.cha...@sipcentric.com> D

Re: [sr-dev] [kamailio/kamailio] presence: delay aux_body_processing until after subscription has been updated (#917)

Hello again - given today's announcement of upcoming 4.4.5 release in the next couple of days, I would ask anyone with any issues to report it here, otherwise, I will backport tomorrow evening to ensure it is included in the release. -- You are receiving this because you are subscribed to

Re: [sr-dev] [kamailio/kamailio] presence: delay aux_body_processing until after subscription has been updated (#917)

Ok, I will wait another couple of weeks. We have it already in production since last week, so if no other issue reported by end of January I will assume it is safe to backport. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [sr-dev] [kamailio/kamailio] presence: delay aux_body_processing until after subscription has been updated (#917)

@miconda - is it OK to backport to 4.4? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/917#issuecomment-271850901___ sr-dev mailing list

Re: [sr-dev] [kamailio/kamailio] presence: delay aux_body_processing until after subscription has been updated (#917)

Thanks - can it be backported also? Charles On 9 January 2017 at 10:41, Charles Chance <notificati...@github.com> wrote: > Merged #917 <https://github.com/kamailio/kamailio/pull/917>. > > — > You are receiving this because you are subscribed to this thread. > Reply t

Re: [sr-dev] [kamailio/kamailio] presence: delay aux_body_processing until after subscription has been updated (#917)

Merged #917. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/917#event-915742731___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] git:master:b429f625: presence: delay aux_body_processing until after subscription has been updated

Module: kamailio Branch: master Commit: b429f625ba409cb668b00155996a5f4a4f1733d8 URL: https://github.com/kamailio/kamailio/commit/b429f625ba409cb668b00155996a5f4a4f1733d8 Author: Charles Chance <charles.cha...@sipcentric.com> Committer: Charles Chance <charles.cha...@sipcentric.com>

[sr-dev] [kamailio/kamailio] presence: delay aux_body_processing until after subscription has been updated (#917)

Fixes out-of-sequence version when subs_db_mode <> 3 and fast_notify is enabled. Version is incremented only when copy is updated in memory. Therefore, currently: On SUBSCRIBE, subscription is updated first, so NOTIFY body contains newly incremented version. But on PUBLISH,

Re: [sr-dev] [kamailio/kamailio] Enabling DMQ cause high CPU usage (#822)

Thanks, @miconda, will take a look. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/822#issuecomment-259144332___ sr-dev mailing list

Re: [sr-dev] [kamailio/kamailio] Enabling DMQ cause high CPU usage (#822)

Apologies, I have been away for a couple of weeks. DMQ does indeed use mutexes to trigger processing of a new task by its workers. Your log shows everything is as expected with DMQ - i.e. with no other traffic, a lock is acquired/released once every minute with each peer notification (node

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc has "location" table name hardcoded (#796)

Please try with b747d469e6c9d12be5e4541c41346b73f9bc1199, which introduces a new parameter "usrloc_domain". I will try to enhance further at a later date to allow for multiple domains. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

[sr-dev] git:master:b747d469: Add modparam to specify the usrloc domain to synchronize.

Module: kamailio Branch: master Commit: b747d469e6c9d12be5e4541c41346b73f9bc1199 URL: https://github.com/kamailio/kamailio/commit/b747d469e6c9d12be5e4541c41346b73f9bc1199 Author: Charles Chance <charles.cha...@sipcentric.com> Committer: Charles Chance <charles.cha...@sipcentric.com>

[sr-dev] git:master:af2f5007: Update documentation to include new usrloc_domain parameter.

Module: kamailio Branch: master Commit: af2f50071db80d22ebd790608ea409ed4cc36c04 URL: https://github.com/kamailio/kamailio/commit/af2f50071db80d22ebd790608ea409ed4cc36c04 Author: Charles Chance <charles.cha...@sipcentric.com> Committer: Charles Chance <charles.cha...@sipcentric.com>

[sr-dev] Presence notify - duplicate aux body processing?

Hi All, Whilst attempting to track down the source of an issue introduced at some point since 4.2.1, I came across the following and would appreciate a second opinion. In send_notify_request() function (/modules/presence/notify.c), the aux body processing function attached to the event is

Re: [sr-dev] Presence notify - duplicate aux body processing?

> *aux_body = subs->event->aux_body_processing(subs, notify_body);* > > > but you haven't detailed your issue, so i'm not sure how to help you. > > Best > > -- > *From:* sr-dev [sr-dev-boun...@lists.sip-router.org] on behalf of Charles > Cha

Re: [sr-dev] git:master:b6b7de88: presence_dialoginfo : aux_body should return xmldoc instead of char

lse start on the > correction, i was fooled by travis and misread the return type which lead > to crashing. > > Best > > -- > *From:* sr-dev [sr-dev-boun...@lists.sip-router.org] on behalf of Charles > Chance [charles.cha...@sipcentric.com] > *Sent:* T

Re: [sr-dev] git:master:b6b7de88: presence_dialoginfo : aux_body should return xmldoc instead of char

Hi Luis, It would be interesting to understand where the issue with document versioning was first introduced - it was working fine prior to 4.3 as far as I can tell. We noticed some weirdness with BLF after upgrading to 4.3.4 on some production machines and soon realised it was due to the

Re: [sr-dev] [SR-Users] Releasing Kamailio v4.3.2

Hi Daniel, Do you have a moment to comment on this related question: http://lists.sip-router.org/pipermail/sr-dev/2015-September/030663.html? Cheers, Charles On 10 Sep 2015 08:21, "Daniel-Constantin Mierla" wrote: > Hello, > > short note to remind that today kamailio v4.3.1

[sr-dev] git:4.3:24b347a5: dmq_usrloc: implement deleted contact replication

Module: kamailio Branch: 4.3 Commit: 24b347a5fca61d13a0765dbf1b3c8207caf3b45d URL: https://github.com/kamailio/kamailio/commit/24b347a5fca61d13a0765dbf1b3c8207caf3b45d Author: Charles Chance <charles.cha...@sipcentric.com> Committer: Charles Chance <charles.cha...@sipcentric.com> D

[sr-dev] git:4.3:3fc2d2ce: dmq_usrloc: check existence of usrloc domain before continuing.

Module: kamailio Branch: 4.3 Commit: 3fc2d2ceafa33153e9c046f192dc41baae14f3ec URL: https://github.com/kamailio/kamailio/commit/3fc2d2ceafa33153e9c046f192dc41baae14f3ec Author: Charles Chance <charles.cha...@sipcentric.com> Committer: Charles Chance <charles.cha...@sipcentric.com> D

Re: [sr-dev] [SR-Users] Releasing Kamailio v4.3.2

n? Being caught on > some other backports, it will take a while to read the whole thread and > figure out the details -- sometime looking at code is faster to decide is a > new feature or not. > > Cheers, > Daniel > > On 10/09/15 11:26, Charles Chance wrote: > > Hi Dani

Re: [sr-dev] [kamailio] dmq_usrloc replication and max_contacts (Kamailio v4.3.1) (#265)

This is now in 4.3. Cheers, Charles On 8 September 2015 at 10:38, Charles Chance <charles.cha...@sipcentric.com> wrote: > Hi, > > I'm happy to backport, but it depends whether others see this as a new > feature or a bug fix. > > Personally I believe it is essential for

Re: [sr-dev] [SR-Users] Releasing Kamailio v4.3.2

, > then all is ok to backport. To me it looks like making that dmq location > replication work, because removing a contact is part of the normal > registration processing, so personally I am fine backporting. > > Cheers, > Daniel > > On 10/09/15 12:49, Charles Chance wrote: &g

Re: [sr-dev] [kamailio] dmq_usrloc replication and max_contacts (Kamailio v4.3.1) (#265)

Hi, I'm happy to backport, but it depends whether others see this as a new feature or a bug fix. Personally I believe it is essential for the originally intended behaviour, but maybe someone else can comment? Cheers, Charles Charles Chance Managing Director t. 0121 285 4400 m. 07932 063 891

Re: [sr-dev] [kamailio] nathelper sending keep alives on nodes where contact replicated using dmq_usrloc (#310)

I missed this originally and although I've not looked closely at it yet, a quick alternative might be to use the nat_traversal module's keepalive mechanism instead, directly on the edge proxies. Works for us at least. --- Reply to this email directly or view it on GitHub:

[sr-dev] git:4.3:feaed398: dmq_usrloc: check existence of usrloc domain before continuing.

Module: kamailio Branch: 4.3 Commit: feaed39802a86b1701f3db4aff0e64bed9d1cd04 URL: https://github.com/kamailio/kamailio/commit/feaed39802a86b1701f3db4aff0e64bed9d1cd04 Author: Charles Chance <charles.cha...@sipcentric.com> Committer: Charles Chance <charles.cha...@sipcentric.com> D

[sr-dev] git:master:c7f94fd9: dmq_usrloc: check existence of usrloc domain before continuing.

Module: kamailio Branch: master Commit: c7f94fd94500270828fcc4cb3011c60c67a8936b URL: https://github.com/kamailio/kamailio/commit/c7f94fd94500270828fcc4cb3011c60c67a8936b Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-08

[sr-dev] git:master:7b357914: dmq_usrloc: fix indentation

Module: kamailio Branch: master Commit: 7b35791472620bee9f489b80f3528ce00ffbd688 URL: https://github.com/kamailio/kamailio/commit/7b35791472620bee9f489b80f3528ce00ffbd688 Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-08

[sr-dev] git:master:9c943031: dmq_usrloc: check existence of usrloc domain before continuing.

Module: kamailio Branch: master Commit: 9c943031f29889c21b25b49b5dd267f4b2460bae URL: https://github.com/kamailio/kamailio/commit/9c943031f29889c21b25b49b5dd267f4b2460bae Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-08

Re: [sr-dev] [kamailio] dmq_usrloc replication and max_contacts (Kamailio v4.3.1) (#265)

Just looking into this now but I am struggling to reproduce the issue - can you confirm you are still seeing it with the 0x04 flag on save() and that all instances are running the most up-to-date version (with delete replication)? --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] dmq_usrloc replication and max_contacts (Kamailio v4.3.1) (#265)

-- *Charles Chance* Managing Director t. 0121 285 4400m. 07932 063 891 -- *** We're rebranding! Learn more here http://www.sipcentric.com/2015/07/were-rebranding/ *** www.sipcentric.com Follow us on twitter @sipcentric http://twitter.com/sipcentric Sipcentric Ltd. Company registered

Re: [sr-dev] [kamailio] dmq_usrloc replication and max_contacts (Kamailio v4.3.1) (#265)

I'm happy to leave it open since the issue is still there if overwriting contacts (that is, passing 0x04 flag to registrar save function). --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] dmq_usrloc replication results in garbled AOR's on client nodes (#237)

Hi, It seems https://github.com/kamailio/kamailio/commit/99f7d67b20c011e78c277a44ea8cd4d6a820806f has fixed the issue and has been confirmed elsewhere. Please feel free to reopen if your tests show otherwise. Cheers, Charles --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] dmq_usrloc replication results in garbled AOR's on client nodes (#237)

Closed #237. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/237#event-357881520___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] Crash on start up synchronisation with dmq_usrloc (#244)

Fixed in https://github.com/kamailio/kamailio/commit/bc01d8d6c6abfc7912a27df3ac23bffd818758e9. Also backported to 4.3. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/244#issuecomment-122062804___

Re: [sr-dev] [kamailio] Crash on start up synchronisation with dmq_usrloc (#244)

Closed #244. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/244#event-357873600___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:4.3:5304da51: dmq_usrloc: don't destroy json doc before we're done with it.

Module: kamailio Branch: 4.3 Commit: 5304da51e32ba79dbe6bdd60d848c4d4f5afd9bd URL: https://github.com/kamailio/kamailio/commit/5304da51e32ba79dbe6bdd60d848c4d4f5afd9bd Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-07-16T20

[sr-dev] git:4.3:785ab99f: dmq_usrloc: use new version of serialized structure returned by usrloc (now includes received address)

Module: kamailio Branch: 4.3 Commit: 785ab99f18627f1173c9e1714551577c901f04ed URL: https://github.com/kamailio/kamailio/commit/785ab99f18627f1173c9e1714551577c901f04ed Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-07-16T20

Re: [sr-dev] [kamailio] Crash on start up synchronisation with dmq_usrloc (#244)

Hi Paul, I've just committed another fix (https://github.com/kamailio/kamailio/commit/bc01d8d6c6abfc7912a27df3ac23bffd818758e9) if you could test and confirm. Cheers, Charles --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] Crash on start up synchronisation with dmq_usrloc (#244)

Hi, Please test using latest master at https://github.com/kamailio/kamailio/commit/99f7d67b20c011e78c277a44ea8cd4d6a820806f and if it resolves the issue I will backport to 4.3. Cheers, Charles --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] dmq_usrloc replication results in garbled AOR's on client nodes (#237)

Hi, I'll have some time later today to look at it but it's unlikely to be a missing module. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/237#issuecomment-121196392___ sr-dev mailing list

Re: [sr-dev] [kamailio] dmq_usrloc replication results in garbled AOR's on client nodes (#237)

Hi, I have just committed the below patch - can you confirm the issue is resolved? https://github.com/kamailio/kamailio/commit/99f7d67b20c011e78c277a44ea8cd4d6a820806f Cheers, Charles --- Reply to this email directly or view it on GitHub:

[sr-dev] git:master:99f7d67b: dmq_usrloc: don't destroy json doc before we're done with it.

Module: kamailio Branch: master Commit: 99f7d67b20c011e78c277a44ea8cd4d6a820806f URL: https://github.com/kamailio/kamailio/commit/99f7d67b20c011e78c277a44ea8cd4d6a820806f Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-07

Re: [sr-dev] [kamailio] Add option to disable delete queries in usrloc module. (#165)

Hi, The timer to delete records only runs if modparam timer_interval is greater than 0, so the new parameter is not required in this case. Admittedly this is not documented, so the readme does need updating :) Cheers, Charles --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] Add option to disable delete queries in usrloc module. (#165)

According to the module code, you should also ensure timer_procs modparam is set to 0 (default): /* Register cache timer */ if(ul_timer_procs=0) { if (timer_interval 0) register_timer(ul_core_timer, 0, timer_interval); } else

[sr-dev] git:master:c55ec2ba: dmq: resolve multiple IPv4/IPv6 addresses for a single notification address

Module: kamailio Branch: master Commit: c55ec2ba2dcbcfda504339bfd8070b000c9bee52 URL: https://github.com/kamailio/kamailio/commit/c55ec2ba2dcbcfda504339bfd8070b000c9bee52 Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-04

[sr-dev] git:master:8ac3d00f: dmq: regenerate readme

Module: kamailio Branch: master Commit: 8ac3d00f64f9bcd011be3ce088010d9f6e18cd1f URL: https://github.com/kamailio/kamailio/commit/8ac3d00f64f9bcd011be3ce088010d9f6e18cd1f Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-04

[sr-dev] git:master:8e955bad: dmq: check for duplicate nodes when multi_notify enabled

Module: kamailio Branch: master Commit: 8e955bad80bbc8d05ed71dca00f51dbad684f1ae URL: https://github.com/kamailio/kamailio/commit/8e955bad80bbc8d05ed71dca00f51dbad684f1ae Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-04

Re: [sr-dev] Proposed Change to DMQ Notification Address Resolution

directly. Did you have a reason for adding the parameter? I can either push directly to master, or if you'd prefer you can create a pull request (again, master, not 4.2). Cheers, Charles On 23 March 2015 at 15:59, Charles Chance charles.cha...@sipcentric.com wrote: Hi Bob, Thanks for your

Re: [sr-dev] Proposed Change to DMQ Notification Address Resolution

http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev -- *Charles Chance* Managing Director t. 0121 285 4400m. 07932 063 891 -- www.sipcentric.com Follow us on twitter @sipcentric http://twitter.com/sipcentric Sipcentric Ltd. Company registered in England Wales no. 7365592

Re: [sr-dev] [kamailio] kamailio doesn't provide number of registered users stat when usrloc in db_mode=3 (#113)

It is not a bug. From the docs: 3.20. db_mode (integer) ... 3 - DB-Only scheme. No memory cache is kept, all operations being directly performed with the database... snip ...The lack of memory caching also disable the statistics exports. On 19 Mar 2015 15:38, mading087

Re: [sr-dev] Proposed Change to DMQ Notification Address Resolution

Hello Bob, As previously stated, it is a needed improvement. My time is heavily consumed right now, so your patch will be gratefully received. My only comment would be that once connected to the cluster, notifications are sent to all nodes anyway, not just the one specified in the notification

[sr-dev] Registrar: check local path - backport?

Hi, Is it OK to backport the above ( https://github.com/kamailio/kamailio/commit/635f23b12eff2431ca9a14bb39f4204dc2a7227b) to 4.2? The patch preserves existing behaviour, having optional parameter to enable (default disabled). Cheers, Charles -- www.sipcentric.com Follow us on twitter

Re: [sr-dev] Registrar: check local path - backport?

modules like registrar. A new major release should be out in few months. Cheers, Daniel On 10/02/15 10:18, Charles Chance wrote: Hi, Is it OK to backport the above ( https://github.com/kamailio/kamailio/commit/635f23b12eff2431ca9a14bb39f4204dc2a7227b) to 4.2? The patch preserves

[sr-dev] git:master:ff114281: dmq: add branches when replicating to multiple nodes

Module: kamailio Branch: master Commit: ff114281fc2f523ed7bf87ea31448ce7327fdf93 URL: https://github.com/kamailio/kamailio/commit/ff114281fc2f523ed7bf87ea31448ce7327fdf93 Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-02

[sr-dev] git:4.2:5e07d01a: dmq: add branches when replicating to multiple nodes

Module: kamailio Branch: 4.2 Commit: 5e07d01aaae15d3441876d8ee154a53484d08682 URL: https://github.com/kamailio/kamailio/commit/5e07d01aaae15d3441876d8ee154a53484d08682 Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-02-06T12

Re: [sr-dev] Append branches in module

module at lookup() function to see how first location record is added as r-uri and the rest as branches. Cheers, Daniel On 04/02/15 13:29, Charles Chance wrote: Hi All, Can anyone confirm, is this safe? Primary use case is replication of REGISTER after local save(). diff --git

Re: [sr-dev] Append branches in module

-uri and then call append_branch()? Cheers, Daniel On 05/02/15 11:46, Charles Chance wrote: Hi Daniel, I believe this is expected, since we are simply replicating the original message to other (multiple, hence the additional branches) nodes so they have a copy. Should we in fact change

[sr-dev] Append branches in module

Hi All, Can anyone confirm, is this safe? Primary use case is replication of REGISTER after local save(). diff --git a/modules/dmq/dmq_funcs.c b/modules/dmq/dmq_funcs.c index b31deba..a3611e8 100644 --- a/modules/dmq/dmq_funcs.c +++ b/modules/dmq/dmq_funcs.c @@ -24,6 +24,7 @@ #include

[sr-dev] git:master:9876a9cd: dmq: fix indentation

Module: kamailio Branch: master Commit: 9876a9cd1fbb66bbce3f01f015a52bf331deee59 URL: https://github.com/kamailio/kamailio/commit/9876a9cd1fbb66bbce3f01f015a52bf331deee59 Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-02

Re: [sr-dev] git:master:10250429: dmq: do not parse From header again, since it was done already prior to cloning msg.

am not sure if this alone is solving the issue properly. Maybe the From was not parsed in the first place, before cloning... Cheers, Daniel On Fri, Jan 30, 2015 at 3:09 PM, Charles Chance charles.cha...@sipcentric.com wrote: Module: kamailio Branch: master Commit

[sr-dev] git:master:3ae78d88: Revert dmq: do not parse From header again, since it was done already prior to cloning msg.

Module: kamailio Branch: master Commit: 3ae78d88678a64fe59a925c8e3e257e046464c97 URL: https://github.com/kamailio/kamailio/commit/3ae78d88678a64fe59a925c8e3e257e046464c97 Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01

Re: [sr-dev] [kamailio] dmq: fix memory leak (#59)

Having investigated further, the code which calls parse_from_header() is new - introduced for the purpose of letting the callback function know about the sending node - and I had wrongly assumed we were already parsing the From header prior to cloning. So apologies - I would say this is OK to

[sr-dev] git:master:10250429: dmq: do not parse From header again, since it was done already prior to cloning msg.

Module: kamailio Branch: master Commit: 102504294f9edaaee9d4baea873d4ed9151b8fed URL: https://github.com/kamailio/kamailio/commit/102504294f9edaaee9d4baea873d4ed9151b8fed Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01

Re: [sr-dev] [kamailio] dmq: fix memory leak (#59)

Thanks for clarifying, Daniel. As the From header is parsed prior to cloning (and therefore included in the clone), it is pointless to parse it again and have to manually clean it up later - so this part of the code needs changing anyway. I have added a commit to master relating to the above -

Re: [sr-dev] [kamailio] dmq: fix memory leak (#59)

Have you observed a leak here? According to the documentation for sip_msg_shm_clone() [1]: org_msg is cloned along with most of its headers and lumps into one shm memory block (so that a shm_free() on the result will free everything). 1.

Re: [sr-dev] [kamailio] dmq: fix memory leak (#59)

The problem may be earlier in worker_loop(): 95 if (parse_from_header(current_job-msg) 0) { 96 LM_ERR(bad sip message or missing From hdr\n); 97 } else { 98

[sr-dev] git:4.2:120bf4a4: dmq: force to send replicated messages from configured server address - as reported on list by Victor Kustov

Module: kamailio Branch: 4.2 Commit: 120bf4a4f6854592bd910334d4d0bd97c9f94974 URL: https://github.com/kamailio/kamailio/commit/120bf4a4f6854592bd910334d4d0bd97c9f94974 Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01-09T15

[sr-dev] git:4.2:840d15e0: dmq: Don't delete the original notification_peer on timeout

Module: kamailio Branch: 4.2 Commit: 840d15e03523413282426135175e25761488bcac URL: https://github.com/kamailio/kamailio/commit/840d15e03523413282426135175e25761488bcac Author: Alex Hermann a...@speakup.nl Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01-09T15:56:51Z dmq

Re: [sr-dev] Registrar - check for local path

Yes, given that it is possible to do between branches of the same repo, I vote for it being preferred also. Thanks again, Charles On 9 Jan 2015 18:21, Daniel-Constantin Mierla mico...@gmail.com wrote: On 09/01/15 19:00, Charles Chance wrote: Hey Victor, On 9 January 2015 at 17:57, Victor

[sr-dev] [kamailio] registrar: check for local path on lookup (#23)

When performing a lookup, the Path (if present) is evaluated and if the first hop is local we skip it to avoid unnecessary looping. It is useful if multiple servers are sharing a common database, each saving contacts with their local address as the Path. You can merge this Pull Request by

[sr-dev] git:master:887167f8: Merge pull request #23 from kamailio/cchance/registrar

Module: kamailio Branch: master Commit: 887167f8e34286e0bb069ddcbdbb260331909eed URL: https://github.com/kamailio/kamailio/commit/887167f8e34286e0bb069ddcbdbb260331909eed Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01

[sr-dev] git:master:635f23b1: registrar: add optional check for local path during lookup()

Module: kamailio Branch: master Commit: 635f23b12eff2431ca9a14bb39f4204dc2a7227b URL: https://github.com/kamailio/kamailio/commit/635f23b12eff2431ca9a14bb39f4204dc2a7227b Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01

Re: [sr-dev] Registrar - check for local path

Hey Victor, On 9 January 2015 at 17:57, Victor Seva linuxman...@torreviejawireless.org wrote: On 01/09/2015 06:54 PM, Charles Chance wrote: Would anyone like to review the final changes, before I merge them into master? I usually use pull-request to get some feedback. Just my 2 cents

Re: [sr-dev] Registrar - check for local path

/commit/4ff2c48d66a3bce2c491b44d0f1b5e939e5508ff Thanks in advance, Charles On 15 December 2014 at 12:58, Charles Chance charles.cha...@sipcentric.com wrote: On 14 December 2014 at 21:40, Daniel-Constantin Mierla mico...@gmail.com wrote: Hello, looking at the patch, I see that the block

[sr-dev] git:master:d28fdbb8: htable: regenerated readme

Module: kamailio Branch: master Commit: d28fdbb810fff638a1e0acce2dc1e3e5377ead37 URL: https://github.com/kamailio/kamailio/commit/d28fdbb810fff638a1e0acce2dc1e3e5377ead37 Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01

[sr-dev] git:master:95a7d147: htable: update documentation to reiterate importance of loading DMQ module first if enable_dmq is set

Module: kamailio Branch: master Commit: 95a7d14716bdcc7c8fd27bcf8f2449e719a02eac URL: https://github.com/kamailio/kamailio/commit/95a7d14716bdcc7c8fd27bcf8f2449e719a02eac Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01

Re: [sr-dev] [kamailio] registrar: check for local path on lookup (#23)

Merged #23. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/23#event-216695228___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:4ff2c48d: registrar: update documentation to include path_check_local parameter

Module: kamailio Branch: master Commit: 4ff2c48d66a3bce2c491b44d0f1b5e939e5508ff URL: https://github.com/kamailio/kamailio/commit/4ff2c48d66a3bce2c491b44d0f1b5e939e5508ff Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01

[sr-dev] git:master:fe95e1ee: registrar: regenerated README

Module: kamailio Branch: master Commit: fe95e1ee9350cc64b6dd9739fffc4d8d19037db0 URL: https://github.com/kamailio/kamailio/commit/fe95e1ee9350cc64b6dd9739fffc4d8d19037db0 Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01

Re: [sr-dev] git:4.2:6a9133a1: dmq: reverted dmq to the state of v4.2.1

something wrong. Cheers, Daniel On 09/01/15 14:57, Charles Chance wrote: Hi Daniel, Can the following be reinstated in 4.2, since they don't cause any issues that I know of? https://github.com/kamailio/kamailio/commit/7b5f79f9f384bfe3c16c399184281ebe63bb7785 https://github.com/kamailio

[sr-dev] git:master:8d7b9db5: pua_dialoginfo: do not free dlginfo_cell too early

Module: kamailio Branch: master Commit: 8d7b9db5d3b290c9f180dac8610a61a7cee9d192 URL: https://github.com/kamailio/kamailio/commit/8d7b9db5d3b290c9f180dac8610a61a7cee9d192 Author: Charles Chance charles.cha...@sipcentric.com Committer: Charles Chance charles.cha...@sipcentric.com Date: 2015-01

Re: [sr-dev] git:4.2:6a9133a1: dmq: reverted dmq to the state of v4.2.1

/6a9133a119cd2556cdfc5260b5c3442fe2290584.diff Patch: https://github.com/kamailio/kamailio/commit/6a9133a119cd2556cdfc5260b5c3442fe2290584.patch ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev -- *Charles

Re: [sr-dev] Trunk: DMQ and hashtables - won't start and crashes

/15 09:38, Charles Chance wrote: Hey Olle, Anything in the log? Listening on udp: 192.168.40.15:5060 Aliases: WARNING: no fork mode 0(60369) INFO: cfgutils [cfgutils.c:891]: mod_init(): no hash_file given, disable hash functionality 0(60369) ERROR: dmq [dmq_funcs.c:35

Re: [sr-dev] Trunk: DMQ and hashtables - won't start and crashes

Hey Olle, Anything in the log? Are you loading dmq before htable? What are your values for dmq modparams? Does dmq_send_message() work in default route? Cheers, Charles On 8 Jan 2015 07:57, Olle E. Johansson o...@edvina.net wrote: Using trunk code, I can get DMQ to work by itself. I have

Re: [sr-dev] git:master:cc5f96f9: dmq: safety check for peer_list when calling the callbacks

or not to the reported issue. Best, Charles On 08/01/15 16:02, Charles Chance wrote: Hi Daniel, I was wondering, did you find some way in which this was causing the issue? Theoretically, if the module is loaded successfully then peer_list cannot be null... (dmq.c) static int mod_init(void

Re: [sr-dev] git:master:cc5f96f9: dmq: safety check for peer_list when calling the callbacks

://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev -- *Charles Chance* Managing Director t. 0121 285 4400m. 07932 063 891 -- www.sipcentric.com Follow us on twitter @sipcentric http://twitter.com/sipcentric Sipcentric Ltd. Company registered in England Wales no. 7365592. Registered

  1   2   >