Re: [sr-dev] [kamailio/kamailio] Keepalive module - prototype (#1045)

2017-04-04 Thread Dragos Oancea
squash the two commits into one :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1045#issuecomment-291465480___ sr-dev mailing list

[sr-dev] git:master:39ceb976: examples/scscf: minor fixes (logging)

2016-08-23 Thread Dragos Oancea
Module: kamailio Branch: master Commit: 39ceb9763132549f100de638f4c0b8806c0a9232 URL: https://github.com/kamailio/kamailio/commit/39ceb9763132549f100de638f4c0b8806c0a9232 Author: Dragos Oancea <dragos.oan...@athonet.com> Committer: Dragos Oancea <dragos.oan...@athonet.com> Date: 2016

Re: [sr-dev] [kamailio/kamailio] examples/scscf: minor fixes (logging) (#756)

2016-08-23 Thread Dragos Oancea
Thank you Carsten. I also wish to report that this manual page is missing from all docs versions apparently : http://www.kamailio.org/docs/modules/4.3.x/modules/ims_usrloc_scscf.html -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

[sr-dev] [kamailio/kamailio] examples/scscf: minor fixes (logging) (#756)

2016-08-23 Thread Dragos Oancea
The real return code of MAA/SAA is not shown in the logs in case of unknown error. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/756 -- Commit Summary -- * examples/scscf: minor fixes (logging) -- File Changes -- M

[sr-dev] git:master:df83103b: core: fix double free on clearing hdr

2016-08-22 Thread Dragos Oancea
Module: kamailio Branch: master Commit: df83103bb4756b0a3c3e42927396f78aa8210ec4 URL: https://github.com/kamailio/kamailio/commit/df83103bb4756b0a3c3e42927396f78aa8210ec4 Author: Dragos Oancea <dragos.oan...@athonet.com> Committer: Dragos Oancea <dragos.oan...@athonet.com> Date: 2016

[sr-dev] git:master:c1ea48cf: core: fix double free on clearing lump

2016-08-22 Thread Dragos Oancea
Module: kamailio Branch: master Commit: c1ea48cfe38e6c52c50e6f1d698254a789e988f1 URL: https://github.com/kamailio/kamailio/commit/c1ea48cfe38e6c52c50e6f1d698254a789e988f1 Author: Dragos Oancea <dragos.oan...@athonet.com> Committer: Dragos Oancea <dragos.oan...@athonet.com> Date: 2016

[sr-dev] git:master:dc6962fb: presence: fix multiple double free on shutdown caught with memlog=1

2016-08-22 Thread Dragos Oancea
Module: kamailio Branch: master Commit: dc6962fb7e02cf44a145e0bafa455873c73ebc2d URL: https://github.com/kamailio/kamailio/commit/dc6962fb7e02cf44a145e0bafa455873c73ebc2d Author: Dragos Oancea <dragos.oan...@athonet.com> Committer: Dragos Oancea <dragos.oan...@athonet.com> Date: 2016

[sr-dev] [kamailio/kamailio] presence: fix multiple double free on shutdown caught with memlog=1 (#754)

2016-08-19 Thread Dragos Oancea
These small changes fix the bug shown below and another potential one. kamailio[3062]: : [mem/q_malloc.c:453]: qm_free(): BUG: qm_free: freeing already freed pointer (0x7facf958dc08), called from presence: hash.c: delete_shtable(316), first free presence: hash.c: free_subs_list(349) -

[sr-dev] [kamailio/kamailio] core: fixed two double free() situations (#753)

2016-08-19 Thread Dragos Oancea
I ran into these while testing with SIPP and having memlog=1 : kamailio[21826]: : [mem/q_malloc.c:453]: qm_free(): BUG: qm_free: freeing already freed pointer (0x7f24869850f8), called from : parser/contact/parse_contact.c: free_contact(109), first free : parser/contact/parse_contact.c:

[sr-dev] git:master:d61ff2e4: core: fix some logging in tcp_read.c

2016-08-18 Thread Dragos Oancea
Module: kamailio Branch: master Commit: d61ff2e4cf49479a811019c2f01ace46344cacc2 URL: https://github.com/kamailio/kamailio/commit/d61ff2e4cf49479a811019c2f01ace46344cacc2 Author: Dragos Oancea <dragos.oan...@athonet.com> Committer: Dragos Oancea <dragos.oan...@athonet.com> Date: 2016

[sr-dev] [kamailio/kamailio] core: fix some logging in tcp_read.c (#749)

2016-08-17 Thread Dragos Oancea
This patch to emphasize that ip_addr2a() uses a static buffer and because of this lots of log lines in tcp_read.c print the same IP as src and dst . It can be confusing when debugging TCP connections. Practically LM_DBG or LOG print the same buffer twice in these cases. You can view, comment on,

[sr-dev] git:master:ee6b0607: ims_auth: print ck in readable form for debug reasons and init hbody to 0 to avoid printing gibberish in the log

2016-07-19 Thread Dragos Oancea
Module: kamailio Branch: master Commit: ee6b060701f5a05958fc1822ccf8b62920bb0124 URL: https://github.com/kamailio/kamailio/commit/ee6b060701f5a05958fc1822ccf8b62920bb0124 Author: Dragos Oancea <dragos.oan...@athonet.com> Committer: Dragos Oancea <dragos.oan...@athonet.com> Date: 2016

[sr-dev] [kamailio/kamailio] presence: fix potential double free in shutdown routine (#717)

2016-07-19 Thread Dragos Oancea
Attempt to fix this (crash at shutdown) : I observed some of these while working with daemontools (svc) . Program terminated with signal 6, Aborted. #0 0x7f43e6fd5125 in raise () from /lib/x86_64-linux-gnu/libc.so.6 (gdb) (gdb) (gdb) bt #0 0x7f43e6fd5125 in raise () from

[sr-dev] [kamailio/kamailio] ims_auth: print ck in readable form and init var to 0 to avoid printing gibberish in the log (#711)

2016-07-15 Thread Dragos Oancea
These changes help with debugging , for example I may need to grep for ck in the scscf log in my environment. Also, hbody prints gibberish when qop=auth . You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/711 -- Commit Summary -- *

[sr-dev] git:master:4396c5fb: cdp: fix occasional segfault on process exit

2016-07-15 Thread Dragos Oancea
Module: kamailio Branch: master Commit: 4396c5fbc85848c69b3318397a7ed8b67d76a05f URL: https://github.com/kamailio/kamailio/commit/4396c5fbc85848c69b3318397a7ed8b67d76a05f Author: Dragos Oancea <dragos.oan...@athonet.com> Committer: Dragos Oancea <dragos.oan...@athonet.com> Date: 2016

[sr-dev] [kamailio/kamailio] cdp: fix occasional segfault on process exit (#710)

2016-07-14 Thread Dragos Oancea
this may happen at kamailio shutdown : Program terminated with signal 11, Segmentation fault. #0 0x7fb66a73e591 in atomic_cmpxchg_int (var=0x0, old=0, new_v=1) at ../../mem/../atomic/atomic_x86.h:233 233 ATOMIC_FUNC_CMPXCHG(cmpxchg, "cmpxchgl %2, %1", int , int) (gdb) bt #0

Re: [sr-dev] Gm interface ipsec support

2016-06-29 Thread Dragos Oancea
There is work in progress on this . We have an ipsec module which handles points 1. and 2. We have a daemon that talks with the kamailio module which handles point 3 and is managing SAs via XFRM . Last point is a little bit harder without NAT, but possible, and likely we'll have that too.When

Re: [sr-dev] [kamailio/kamailio] Fix check_route_param() (#663)

2016-06-15 Thread Dragos Oancea
I am pretty sure it's a request route . It's true I call route[RTPPROXY] from a reply route too , but when I have the issue is always a request_route . It has to do with the number of params in Route , it seems the bug becomes visible only when there's only one param (;lr) and then

Re: [sr-dev] [kamailio/kamailio] Fix check_route_param() (#663)

2016-06-10 Thread Dragos Oancea
No and no . I am using it in my route[RTPPROXY] like this : if (is_request() && !isflagset(FLT_NAT)) { if(check_route_param("nat=yes")) { setflag(FLT_NAT); } } --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Fix check_route_param() (#663)

2016-06-09 Thread Dragos Oancea
I applied the patch , but I still have output like this : rr [loose.c:985]: check_route_param(): current params are (72) Let me know if I can help further. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Fix check_route_param() (#663)

2016-06-09 Thread Dragos Oancea
I added that logline . Sometimes it prints strange things like this: Jun 9 12:10:09 B1-RD-IMS-2 /opt/local/ims/sbin/kamailio[23328]: INFO: rr [loose.c:980]: check_route_param(): current params are (6f) Jun 9 12:10:09 B1-RD-IMS-2 /opt/local/ims/sbin/kamailio[23328]: DEBUG: rr [loose.c:986]:

[sr-dev] [kamailio/kamailio] Fix check_route_param() (#663)

2016-06-07 Thread Dragos Oancea
Given that there are multiple Route sets , each with one param , check_route_param() function fails to search the proper param.s string . The condition params.s[0]!=';' holds false and it stops the loop only when it encounters another ";" character which is not part of the Route header . Eg:

[sr-dev] git:master:e88ea402: ims_registrar_pcscf: fix getContactP() for is_registered_fallback2ip param - so that script function pcscf_is_registered() actually finds the contact .

2016-06-02 Thread Dragos Oancea
Module: kamailio Branch: master Commit: e88ea4022af341bb67e959c42d2096a42ae3796d URL: https://github.com/kamailio/kamailio/commit/e88ea4022af341bb67e959c42d2096a42ae3796d Author: Dragos Oancea <dragos.oan...@athonet.com> Committer: Dragos Oancea <dragos.oan...@athonet.com> Date: 2016

[sr-dev] [kamailio/kamailio] ims_registrar_pcscf: fix getContactP() for is_registered_fallback2ip param. (#649)

2016-05-31 Thread Dragos Oancea
With this change script function pcscf_is_registered() will actually find the contact (Volte) . Changes made to reflect the docs : http://www.kamailio.org/docs/modules/devel/modules/ims_registrar_pcscf.html#idp196032 You can view, comment on, or merge this pull request online at:

Re: [sr-dev] [kamailio] dialog module: dialog in 5 state is not removed (#545)

2016-03-15 Thread Dragos Oancea
Hi. Not sure if related but I experimented this with dialog_ng , the command dlg2.list was showing some dialogs in "Deleted" state after several hours after the actual dialogs finished. Dragos --- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [sr-dev] [kamailio] ims_dialog: fix double free (unref early dialog) (#508)

2016-03-14 Thread Dragos Oancea
Lots of bugs disappeared with the latest patches which are already in master, thank you Jason, thank you Daniel. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/508#issuecomment-196370642___ sr-dev

[sr-dev] git:master:644b8710: siputils: tel2sip(): fix 'off by one' when allocating memory

2016-03-10 Thread Dragos Oancea
Module: kamailio Branch: master Commit: 644b87109321d6a6724cc82336289d17814173f2 URL: https://github.com/kamailio/kamailio/commit/644b87109321d6a6724cc82336289d17814173f2 Author: Dragos Oancea <dragos.oan...@athonet.com> Committer: Dragos Oancea <dragos.oan...@athonet.com> Date: 2016

Re: [sr-dev] [kamailio] siputils: tel2sip(): fix 'off by one' when allocating memory (#534)

2016-03-07 Thread Dragos Oancea
I am using master. Your fix for tel2sip was in 7992a2b8d42bb7e8bcf1738cf042013ed126a47a , it's similar, but it's not the same thing. --- Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio] siputils: tel2sip(): fix 'off by one' when allocating memory (#534)

2016-03-07 Thread Dragos Oancea
While building the sip uri in tel2sip() we have: sip_uri.s = pkg_malloc(sip_uri.len) But later in pv_set_ruri(): val->rs.s[val->rs.len] = '\0'; It's overwriting the q_malloc control structures (a classic type of bug already). Kamailio will log a line like this before crashing: Mar 3 13:31:15

Re: [sr-dev] [kamailio] ims_usrloc_scscf: fix link_contact_to_impu() - was crashing with maxcontact_behaviour == 2 (#512)

2016-02-22 Thread Dragos Oancea
Hi Jason, Actually is more strange, and I do not exclude a diameter problem or an issue with my environment now. The P forwards the REGISTER to the I , I to the S , S sends back 401 back to the I , and then it arrives at the P , and then on UE. Then UE sends REGISTER again

Re: [sr-dev] [kamailio] ims_usrloc_scscf: fix link_contact_to_impu() - was crashing with maxcontact_behaviour == 2 (#512)

2016-02-22 Thread Dragos Oancea
Hi Jason, I had no crash so far with your patches. However, I observed some strange behaviour which I have not seen before applying the patches: 1. A timeout for a reply to REGISTER. A 200 OK reply is expected but nothing happens. This is with the P-cscf and it does not occur all the time. I

Re: [sr-dev] [kamailio] ims_usrloc_scscf: fix link_contact_to_impu() - was crashing with maxcontact_behaviour == 2 (#512)

2016-02-18 Thread Dragos Oancea
Thank you Jason, looks good so far. I compiled and ran the patches on a test machine. I will keep on using the machine these days and report back. --- Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio] ims_usrloc_scscf: fix link_contact_to_impu() - was crashing with maxcontact_behaviour == 2 (#512)

2016-02-18 Thread Dragos Oancea
Hi Jason, Sure, send me the patch , I will test it. Cheers, Dragos --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/512#issuecomment-185745995___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] [kamailio] ims_usrloc_scscf: fix link_contact_to_impu() - was crashing with maxcontact_behaviour == 2 (#512)

2016-02-16 Thread Dragos Oancea
link_contact_to_impu() does not behave as intended - it will return immediately because ptr==contact . This will lead to a crash when current contact is always different than the previous. To prevent this, I set ptr to 0 as it points to a chunk of freed memory anyway. Removed call to

Re: [sr-dev] [kamailio] ims_dialog: fix double free (unref early dialog) (#508)

2016-02-15 Thread Dragos Oancea
Hi Jason. Thanks for looking into it. Here is a log and the output of "bt full" : http://pastebin.com/PdXiZSV8 . Scenario : A call comes in, then the first INVITE is relayed somewhere, and there is no reply coming to it (there are retransmissions) , kamailio is generating a 503 , and then

[sr-dev] [kamailio] ims_dialog: fix double free (unref early dialog) (#508)

2016-02-12 Thread Dragos Oancea
Attempt fix for when an INVITE goes out and there is no 100 Trying reply to it , and then ims_dialog destroys the dialog twice via unref_dlg_unsafe() . You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/508 -- Commit Summary -- *

[sr-dev] [kamailio] ims_registrar_scscf: fix new_notification() so it does not crash (#506)

2016-02-10 Thread Dragos Oancea
fix mishandling of impus (array of ptr) - avoid crash You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/506 -- Commit Summary -- * ims_registrar_scscf: fix new_notification() so it does not crash (with 2 or more IMPU) -- File

[sr-dev] crash with 4.0.4 - st_delete_ucontact()

2014-02-10 Thread Dragos Oancea
Hello Everyone, Kamailio 4.0.4 crashes for us once a few weeks, apparently in the same point: #0  st_delete_ucontact (_c=0x3a746361746e6f43) at ucontact.c:358 #1  0x7f2c7a9b3836 in delete_ucontact (_r=0x7f2c37e1be40, _c=0x3a746361746e6f43) at urecord.c:509 #2  0x7f2c7a373d52 in

Re: [sr-dev] kamailio 4.0.3 crash

2013-11-22 Thread Dragos Oancea
on and nobody complained about performances. Cheers, Daniel On 11/21/13 7:39 PM, Dragos Oancea wrote: Hi Here is the output: gdb)  (gdb) frame 0 #0  qm_detach_free (qm=0x7fd96175e010, size=112) at mem/q_malloc.c:266 266in mem/q_malloc.c (gdb)  #0  qm_detach_free (qm=0x7fd96175e010, size=112) at mem

[sr-dev] kamailio 4.0.3 crash

2013-11-21 Thread Dragos Oancea
Hello We had this crash today with kamailio 4.0.3 . It ran stable for few weeks until this crash. GDB here: http://pastebin.com/rACV31z8 Regards, Dragos___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] kamailio 4.0.3 crash

2013-11-21 Thread Dragos Oancea
}} (gdb) p *((char*)frag + sizeof(struct qm_frag)) $8 = 1 '\001' Regards, Dragos On , Dragos Oancea droan...@yahoo.com wrote: Hi Here is the output: gdb)  (gdb) frame 0 #0  qm_detach_free (qm=0x7fd96175e010, size=112) at mem/q_malloc.c:266 266in mem/q_malloc.c (gdb)  #0  qm_detach_free (qm

Re: [sr-dev] kamailio 4.0.3 crash

2013-11-21 Thread Dragos Oancea
branch 4.0, because there were some other fixes from 4.0.3. With this occasion, you should set MEMDBG=1 in Makefile.defs before recompiling the new version to be able to catch easier the overwrites of memory. Cheers, Daniel On 11/21/13 6:36 PM, Dragos Oancea wrote: Hello We had

Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-21 Thread Dragos Oancea
Hi all, Just wanted to say that any addition to the memcached module or its documentation is very useful to us.  We use libmemcached-1.0.17 and as far as I know there is no CentOS RPM for it. Thank you, Charles! Regards, Dragos On Monday, October 21, 2013 3:24 PM, Charles Chance

Re: [sr-dev] memory leak in memcached module

2013-10-03 Thread Dragos Oancea
on a report by Dragos Oancea. The pkg usage logs are like: 0(24328) NOTICE: qm_status:    19010. N  address=0x7fb23683bc98 frag=0x7fb23683bc68 size=8 used=1  0(24328) NOTICE: qm_status:           alloc'd from memcached: ../../parser/../ut.h: pkg_str_dup(733)  0(24328) NOTICE: qm_status

Re: [sr-dev] git:master: memcached: fix crash during shutdown, make used memory manager configurable

2013-07-02 Thread Dragos Oancea
from Dragos Oancea, droancea at yahoo dot com * make memcache client library memory manager configurable, as default use   the one from the system as this is probably the most tested configuration   in the field * the internal memory manager should provide a better performance in this case

Re: [sr-dev] the new memcache module

2013-07-02 Thread Dragos Oancea
will be watching the logs for anything abnormal. Cheers, Dragos From: Henning Westerholt h...@kamailio.org To: Dragos Oancea droan...@yahoo.com Cc: sr-dev@lists.sip-router.org sr-dev@lists.sip-router.org; Charles Chance charles.cha...@sipcentric.com Sent

Re: [sr-dev] the new memcache module

2013-06-18 Thread Dragos Oancea
[0x4145e9] I use libmemcached version 1.0.17 . Let me know if I can help you debug this. Regards, Dragos From: Charles Chance charles.cha...@sipcentric.com To: Dragos Oancea droan...@yahoo.com Cc: sr-dev@lists.sip-router.org sr-dev@lists.sip

[sr-dev] the new memcache module

2013-06-17 Thread Dragos Oancea
It also dumps core at shutdown: http://pastebin.com/5uJJ3tp4 Regards, Dragos From: Henning Westerholt h...@kamailio.org To: sr-us...@lists.sip-router.org Cc: Charles Chance charles.cha...@sipcentric.com; Dragos Oancea droan...@yahoo.com Sent: Friday, June 14

Re: [sr-dev] segfault with t_suspend() / t_continue()

2013-04-05 Thread Dragos Oancea
Oancea droan...@yahoo.com; Kamailio (SER) - Development Mailing List sr-dev@lists.sip-router.org Sent: Friday, April 5, 2013 2:28 PM Subject: Re: [sr-dev] segfault with t_suspend() / t_continue() Hello, On 4/4/13 9:26 PM, Dragos Oancea wrote: Hi Daniel,  hi Guys, I did not stress test it, I

[sr-dev] segfault with t_suspend() / t_continue()

2013-04-04 Thread Dragos Oancea
Hello, I got the following coredump while doing some testing with t_suspend() and t_continue() on the first INVITE: (gdb) bt #0  qm_detach_free (qm=0x7fe2dae65000, size=16) at mem/q_malloc.c:269 #1  qm_malloc (qm=0x7fe2dae65000, size=16) at mem/q_malloc.c:386 #2  0x7fe2e5e6d541 in

Re: [sr-dev] segfault with t_suspend() / t_continue()

2013-04-04 Thread Dragos Oancea
Hi Daniel, Here is the output of `bt full`: http://pastebin.com/tnrWML3L Let me know if I can be of any assistance further. Regards, Dragos From: Daniel-Constantin Mierla mico...@gmail.com To: Dragos Oancea droan...@yahoo.com; Kamailio (SER) - Development

Re: [sr-dev] segfault with t_suspend() / t_continue()

2013-04-04 Thread Dragos Oancea
it.  Regards, Dragos From: Daniel-Constantin Mierla mico...@gmail.com To: Dragos Oancea droan...@yahoo.com; Kamailio (SER) - Development Mailing List sr-dev@lists.sip-router.org Sent: Thursday, April 4, 2013 8:53 PM Subject: Re: [sr-dev] segfault with t_suspend

Re: [sr-dev] segfault with t_suspend() / t_continue()

2013-04-04 Thread Dragos Oancea
() , but I am not sure the other side received the INVITE and answered. Dragos From: Jason Penton jason.pen...@gmail.com To: Dragos Oancea droan...@yahoo.com; Kamailio (SER) - Development Mailing List sr-dev@lists.sip-router.org Cc: mico...@gmail.com mico