Re: [sr-dev] [kamailio] pua_dialoginfo: fixed crash when loading dialogs from database on restart (#492)

2016-02-02 Thread Daniel-Constantin Mierla
Btw, contributions to documentation are also very welcome and much appreciated. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/492#issuecomment-178446990___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio] pua_dialoginfo: fixed crash when loading dialogs from database on restart (#492)

2016-02-02 Thread Phil Lavin
Thanks, Daniel. All understood :) --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/492#issuecomment-178445057___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/l

Re: [sr-dev] [kamailio] pua_dialoginfo: fixed crash when loading dialogs from database on restart (#492)

2016-02-02 Thread Daniel-Constantin Mierla
Thank you for the report of the issue and accompanied patch to fix it. A slightly different patch was pushed, to avoid compile and sanity checks warnings that the variable was set but not used, respectively dlginfo. The changes to the documentation are not valid, the names there refer to the au

Re: [sr-dev] [kamailio] pua_dialoginfo: fixed crash when loading dialogs from database on restart (#492)

2016-02-02 Thread Daniel-Constantin Mierla
Closed #492. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/492#event-535468479___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio] pua_dialoginfo: fixed crash when loading dialogs from database on restart (#492)

2016-01-28 Thread Phil Lavin
I will backport this to 4.3 if/when you're happy with it --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/492#issuecomment-176268420___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-route

[sr-dev] [kamailio] pua_dialoginfo: fixed crash when loading dialogs from database on restart (#492)

2016-01-28 Thread Phil Lavin
- SHM pointer is freed when it is required later by dialog callbacks. Remove the free_dlginfo_cell() call. This is causing crashing after the BYE, when a call is ongoing during a Kamailio restart The free is actually done by the callback function `dlg_api.register_dlgcb()` when it is register